• src/sbbs3/msg_id.c

    From rswindell to CVS commit on Tuesday, July 14, 2020 23:03:43
    src/sbbs3 msg_id.c 1.14 1.15
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32061

    Modified Files:
    msg_id.c
    Log Message:
    According to August Abolins (2:221/1.58):
    "Other systems produce [FTN MSG-IDs for NetMail messages) quite nicely: HotdogEd, BBBS, Mageia, Platinum
    Express, GED+LNX, and OpenXP. I took it for granted that SBBS would be
    in the same league. It makes it super easy to link up a netmail
    conversation or generate a graphical-tree when a msgid exists.

    I was spoiled into thinking that msgid was ubiquitous in netmail as well."

    Reviewing FTS-9, I see no restriction to only echomail, so sure, why not: add_msg_ids() now adds FTN Message-IDs to outbound NetMail messages too (not just FTN echomail). No configuration or SBBSecho change needed.

  • From Rob Swindell to Git commit to main/sbbs/master on Saturday, January 16, 2021 18:49:46
    https://gitlab.synchro.net/main/sbbs/-/commit/fca309193fcd80d6c8a663ad
    Modified Files:
    src/sbbs3/msg_id.c
    Log Message:
    Don't include message number in origaddr portion of FTN NetMail MSGIDs

    Some old/unsupported FidoNet software (NetMgr? Squish?) reportedly parse addresses from MSGID control/kludge lines in NetMail messages to determine the source and/or destination address. This is clearly a bad idea for a lot of reasons, but to improve compatibility, let's not include the message number (or an '@') in the origaddr field for NetMail messages. This does slightly increase the chance of a duplicate MSGID being accidentally generated if the "mail" base is renumbered. No change for EchoMail MSGIDs (where dupe detection and threading still benefit from the additional entropy).
    For Watchman.
  • From Rob Swindell (on Windows) to Git commit to main/sbbs/master on Saturday, April 01, 2023 21:06:44
    https://gitlab.synchro.net/main/sbbs/-/commit/f35340ec517c8594433b6bcc
    Modified Files:
    src/sbbs3/msg_id.c
    Log Message:
    Pass a buffer to smb_faddrtoa(), not thread-safe otherwise

    smb_faddrtoa() uses a static local buffer if passed NULL and we shouldn't be doing that from multi-threaded callers.
  • From Rob Swindell (on Windows) to Git commit to main/sbbs/master on Sunday, May 07, 2023 23:22:44
    https://gitlab.synchro.net/main/sbbs/-/commit/7b8c48463346a8e8d58ee86f
    Modified Files:
    src/sbbs3/msg_id.c
    Log Message:
    Bounds-check subnum in add_msg_ids()

    Avoids crash when adding a msg to a non-sub-board msgbase.
  • From Rob Swindell (on Debian Linux) to Git commit to main/sbbs/master on Thursday, March 07, 2024 00:06:57
    https://gitlab.synchro.net/main/sbbs/-/commit/a38ce25db9df20b4852a8c58
    Modified Files:
    src/sbbs3/msg_id.c
    Log Message:
    Include just date in the program-ID (as before) the switch for build->Git date