1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/pack_qwk.cpp

    From Rob Swindell to Git commit to sbbs/master on Saturday, October 10, 2020 15:04:14
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/2bc1d73f7c7e147b909c4694
    Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Fix NDX file creation when votes are included in QWK packets

    When both Indexes (NDX files) and vote messages are included in a QWK packet (an unexpected, but valid combination), the "Record number" stored in NDX files for subs with votes would be incorrect as it did not increment when a vote message (with no body text) was added to the messages.dat file.

    Reported by user that was trying to use MultiMail to read a QWK packet that included both votes and indexes and "IgnoreNDX: No" in their .mmailrc file.
  • From Mortifis@EPHRAM to Rob Swindell on Monday, October 12, 2020 13:26:44
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/2bc1d73f7c7e147b909c4694 Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Fix NDX file creation when votes are included in QWK packets

    When both Indexes (NDX files) and vote messages are included in a QWK packet (an unexpected, but valid combination), the "Record number" stored in NDX files for subs with votes would be incorrect as it did not increment when a vote message (with no body text) was added to the messages.dat file.

    Reported by user that was trying to use MultiMail to read a QWK packet that included both votes and indexes and "IgnoreNDX: No" in their .mmailrc file.

    Would a Sept 29th build be affected by this behaviour? I run 2 boards (one 'public'[alleycat] one 'private'[ephram]. On ephram (realm of dispair) I use a runemaster web ui variant (which does not support voting) and there are missing posts or posts not being displayed, or is this a multimail specific thing?


    Mortifis

    ---
    ■ Synchronet ■ The Realm of Dispair telnet ephram.synchro.net 2323 ssh 2222 web 82
  • From Digital Man to Mortifis on Monday, October 12, 2020 13:08:13
    Re: Re: src/sbbs3/pack_qwk.cpp
    By: Mortifis to Rob Swindell on Mon Oct 12 2020 01:26 pm

    https://gitlab.synchro.net/sbbs/sbbs/-/commit/2bc1d73f7c7e147b909c4694 Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Fix NDX file creation when votes are included in QWK packets

    When both Indexes (NDX files) and vote messages are included in a QWK packet (an unexpected, but valid combination), the "Record number" stored in NDX files for subs with votes would be incorrect as it did not increment when a vote message (with no body text) was added to the messages.dat file.

    Reported by user that was trying to use MultiMail to read a QWK packet that included both votes and indexes and "IgnoreNDX: No" in their .mmailrc file.

    Would a Sept 29th build be affected by this behaviour? I run 2 boards (one 'public'[alleycat] one 'private'[ephram]. On ephram (realm of dispair) I use a runemaster web ui variant (which does not support voting) and there are missing posts or posts not being displayed, or is this a multimail specific thing?

    It's a QWK offline reader specific thing.

    digital man

    Sling Blade quote #23:
    Karl: I reckon I'm gonna have to get used to looking at pretty people.
    Norco, CA WX: 95.4°F, 23.0% humidity, 2 mph WSW wind, 0.00 inches rain/24hrs
  • From Rob Swindell to Git commit to main/sbbs/master on Sunday, December 27, 2020 00:10:34
    https://gitlab.synchro.net/main/sbbs/-/commit/20ec6bfe5aec294b341b9c31
    Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Fix the messages per second statistic displayed to user

    .. when packing a QWK packet (on Win32, was always reported 0 messages per second).
  • From Rob Swindell to Git commit to main/sbbs/master on Sunday, December 27, 2020 00:10:34
    https://gitlab.synchro.net/main/sbbs/-/commit/bbe7f4e2638d77f6bc9bc0a3
    Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Display/log nicer original QWK packet message size in bytes

    Print the Mbyte estimate.
  • From Rob Swindell to Git commit to main/sbbs/master on Friday, April 16, 2021 12:22:40
    https://gitlab.synchro.net/main/sbbs/-/commit/314cd52922b9102f2d4aec41
    Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Fix QWK/BLT-* copy issue (regression since v3.18)

    Reported by Daryl Stout (TBOLT)
  • From Rob Swindell to Git commit to main/sbbs/master on Tuesday, June 08, 2021 22:39:27
    https://gitlab.synchro.net/main/sbbs/-/commit/2245523d4834732d80af5921
    Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Better error handling in QWK packet creation

    If libarchive creates a 0-byte file or no file at all, then fall-through to the "temp file command-line" (if there is at least one Compressible File Type configured).

    If libarchive fails, there will still be a (hopefully helpful) error message logged, but at least the QWK packet may still get created.
  • From Rob Swindell (on Debian Linux) to Git commit to main/sbbs/master on Tuesday, March 21, 2023 11:20:13
    https://gitlab.synchro.net/main/sbbs/-/commit/2c953d3eb700588b101461f4
    Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Fix FILE (stream) pointer leak in error condition

    Fixes CID 451020
  • From Deuc╨╡ to Git commit to main/sbbs/master on Wednesday, February 07, 2024 13:07:34
    https://gitlab.synchro.net/main/sbbs/-/commit/398502c10f0608c702418317
    Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Another time_t warning... thanks OpenBSD!
  • From Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Saturday, March 16, 2024 20:11:36
    https://gitlab.synchro.net/main/sbbs/-/commit/478d85d20f6b70d1bb054362
    Modified Files:
    src/sbbs3/pack_qwk.cpp
    Log Message:
    Add "MSGID" to QWK DOOR.ID file

    This is a "newer" QWK control message supported by Synchronet (for like 20 years now), so it's been missing from the DOOR.ID file all this time and no
    one noticed. <shrug>