Synchronet CVS Commit Log

This is a log of the 500 most recent changes in the Synchronet CVS repository.
  1. rswindell
    Sun Jul 15 2018 10:42 pm PDT

    Modified Files:
    src/sbbs3/js_msgbase.c 1.220 1.221 diff

    Log Message:
    Rename this private_t.status to private_t.smb_result, to avoid confusion
    with smb_t.status.
  2. rswindell
    Sun Jul 15 2018 12:53 am PDT

    Modified Files:
    src/sbbs3/filelist.c 1.19 1.20 diff

    Log Message:
    Brace-style update of this ancient source file.
  3. deuce
    Fri Jul 13 2018 11:07 am PDT

    Modified Files:
    exec/ircbots/ham/ham.js 1.32 1.33 diff

    Log Message:
    Add 10min/hr/day change stats.
  4. deuce
    Fri Jul 13 2018 12:43 am PDT

    Modified Files:
    exec/ircbots/ham/ham.js 1.31 1.32 diff

    Log Message:
    Add bands command for real-time conditions from bandconditions.com
  5. rswindell
    Sun Jul 08 2018 06:36 pm PDT

    Modified Files:
    exec/binkit.js 2.5 2.6 diff

    Log Message:
    Fix the "too much recursion" error when running from JSexec, need a different
    log prefix solution.
  6. rswindell
    Sun Jul 08 2018 04:55 pm PDT

    Modified Files:
    exec/load/binkp.js 1.108 1.109 diff

    Log Message:
    Fix potential infinite loop in send_chunks(), some versions of Socket.send()
    can return false on error, which is >= 0, so this will just add 0 to the
    length and keep on looping forever in that case.
  7. deuce
    Sun Jul 08 2018 04:44 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.220 1.221 diff

    Log Message:
    Update documentation to match the behaviour... send() returns undefined,
    not null on failure.
  8. deuce
    Sun Jul 08 2018 04:33 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.219 1.220 diff

    Log Message:
    Fix js_send() to conform to documentation.
    Also, is that some line ending weirdness?  *shrug*
  9. rswindell
    Sun Jul 08 2018 03:38 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.127 1.128 diff

    Log Message:
    Added support for referencing a message on the command-line with the
    'l' (list messages), 'x' (dump index), 'r' (read msgs), and 'v' (view msgs)
    commands by "days old", by specifying a negative number (in days).
    (e.g. "smbutil r-30" would read messages posted within the past 30 days).
    This was added to test the smb_getmsgidx_by_time() function, but has some
    value otherwise I suppose.
  10. rswindell
    Sun Jul 08 2018 03:10 pm PDT

    Modified Files:
    exec/load/binkp.js 1.107 1.108 diff

    Log Message:
    Fix what appears to be a few potential infinite loops where
    recvFrame() is being called in a loop and only breaking on specific
    conditions or if recvFrame returned undefined. Problem is, on timeout,
    recvFrame returns null (and when using === comparision, undefined !== null).
    Also added more debug output around sends where I suspect there might be
    another potential infinite loop.
  11. rswindell
    Sun Jul 08 2018 02:50 pm PDT

    Modified Files:
    exec/load/binkp.js 1.106 1.107 diff

    Log Message:
    More log output around connecting to a node.
    I suspect that connect() may be blocking and causing Al's reported issue
    (A BinkIT poll never returns from the script and goes into some kind of
    infinite busy loop).
  12. rswindell
    Sun Jul 08 2018 02:48 pm PDT

    Modified Files:
    exec/binkit.js 2.4 2.5 diff

    Log Message:
    More log output when connecting to an outbound node and when an inbound
    file already exists.
    Also, insure all log messages are prefixed with "BinkIT:".
  13. rswindell
    Sat Jul 07 2018 09:02 pm PDT

    Modified Files:
    src/smblib/smblib.c 1.177 1.178 diff

    Log Message:
    smb_lockmsghdr() - if the 'locked' smb instance property is already set,
    don't try to (re)lock it, just return SMB_SUCCESS.
    
    I honestly don't recall why I made this change, but it makes sense, so I'm
    committing it finally.
  14. rswindell
    Sat Jul 07 2018 08:51 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.197 1.198 diff

    Log Message:
    smb_getmsgidx_by_time() can now return positive integers on success.
  15. rswindell
    Sat Jul 07 2018 08:50 pm PDT

    Modified Files:
    src/smblib/smblib.c 1.176 1.177 diff
    src/smblib/smblib.h 1.85 1.86 diff

    Log Message:
    Re-write of smb_getmsgidx_by_time() - using a proper binary search
    algorithm now. Also, now returns the index offset of the matched index
    (if found), negative error value otherwise.
    
    I was testing something and noticed that the old smb_getmsgidx_by_time()
    implementation could sometimes return the index of a message posted before
    the requested time. That was fixed by re-writing the binary search logic.
    
    Also, I found it useful in my testing to have this function return the
    offset of the matching index (in addition to the index record itself), so
    checks of the return value need to compare >= SMB_SUCCESS, not just ==
    or != SMB_SUCCESS.
  16. rswindell
    Sat Jul 07 2018 12:52 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.96 1.97 diff

    Log Message:
    For SSH and RLogin 'logins', use the mastchuser() function rather than
    userdatdupe() to match the passed login-id (username):
    *  This allows more permissive username matching, e.g. if your user name
       is "Analog Kid", you could login with "analogkid", "analog.kid" or
       "analog_kid", which is handy when passing a user name on the command
       line (e.g. to an ssh client) for example.
    *  This is the same function used for Telnet logins via exec/login.js
  17. rswindell
    Sat Jul 07 2018 12:30 am PDT

    Modified Files:
    src/sbbs3/text_defaults.c 1.43 1.44 diff

    Log Message:
    Added @-codes to the SubGroupOrAll and DirLisstOrAll prompts (mnemonics)
    so that the current sub/group and dir/lib short name is displayed as
    part of the prompt.
  18. rswindell
    Sat Jul 07 2018 12:29 am PDT

    Modified Files:
    ctrl/text.dat 1.83 1.84 diff

    Log Message:
    Added @-codes to the SubGroupOrAll and DirLisstOrAll prompts (mnemonics)
    so that the current sub/group and dir/lib short name is displayed as
    part of the prompt.
  19. rswindell
    Sat Jul 07 2018 12:22 am PDT

    Modified Files:
    src/sbbs3/getkey.cpp 1.46 1.47 diff

    Log Message:
    mnemonic strings (those with tilde's to indicate the command-keys), now support
    @-codes within them. Previously, only if the entire mnemonic string was
    comprised of an @-code would it be expanded, now any @-codes within will expand
    as well.
  20. rswindell
    Fri Jul 06 2018 11:14 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.78 1.79 diff

    Log Message:
    Restore the 'U' command back to "User Edit" and commented-out the 
    experimental 'U' (View Unread-Only toggle) command. The 'U' command from
    the e-mail menu (e.g. email_sec.js) works better than the toggle approach and
    is probably all that is needed.
    Also, the user number lookup in the User Edit bit is better at finding the
    proper user account (e.g. for received netmail).
  21. rswindell
    Tue Jul 03 2018 10:42 pm PDT

    Modified Files:
    exec/dyndns.js 1.14 1.15 diff

    Log Message:
    Add support for a [dyndns] section in ctrl/modopts.ini for the following
    settings (keys): mx, ip, ip6
    
    This allows you to specify a long string (e.g. address) here without
    exceeding the 63 char external program command-line limit.
  22. rswindell
    Tue Jul 03 2018 04:52 pm PDT

    Modified Files:
    exec/dyndns.js 1.13 1.14 diff

    Log Message:
    Don't log 'null' if Socket.readline() returns null.
  23. rswindell
    Tue Jul 03 2018 03:58 pm PDT

    Modified Files:
    exec/dyndns.js 1.12 1.13 diff

    Log Message:
    Added '-ip6' option to specify your (optional) IPv6 address on the
    command-line.
  24. rswindell
    Sun Jul 01 2018 08:05 pm PDT

    Modified Files:
    ctrl/ircd.conf 1.12 1.13 diff

    Log Message:
    Added exmaple C/N lines for connecting to cvs.synchro.net too.
  25. rswindell
    Sun Jul 01 2018 02:40 am PDT

    Modified Files:
    src/sbbs3/con_hi.cpp 1.25 1.26 diff
    src/sbbs3/con_out.cpp 1.84 1.85 diff

    Log Message:
    So Nelgin noticed that in novice (non-expert) menu mode, the A/S/D cmds
    from the Chat menu would immediately clear the screen and redisplay the
    menu after displaying the change in the node's state. This was due to the
    enhancement in rev 1.77 of con_out.cpp whereby we no longer increment
    lncntr if the first lines displayed after a key-press are blank (who
    cares if blank lines scroll off the screen?). That's fine and all, but the
    auto-pause check in outchar(FF) would only auto-pause if the line-counter
    was greater than *one* (has been this way since forever). So with the
    enhancement in 1.77, a single non-blank line displayed after a key-press
    was now not enough to trigger the auto-pause ([Hit a Key] prompt).
    So I've changed the line-counter trigger value to greater than *zero*,
    which means we could have some new excessive auto-pauses, but other places
    where auto-pause wasn't working, should again.
    
    One new excessive auto-pause was after the system password was entered at
    the SY: prompt, so that fix is included in this commit.
  26. rswindell
    Sat Jun 30 2018 12:41 pm PDT

    Modified Files:
    web/root/msgs/msgs.ssjs 1.43 1.44 diff

    Log Message:
    Why was this truncating displayed message subjects to 50 chars? No one will
    ever know. Make the max subject length 70 (like Synchronet).
  27. rswindell
    Fri Jun 29 2018 07:51 pm PDT

    Modified Files:
    src/sbbs3/baja.c 1.49 1.50 diff

    Log Message:
    If the BAJAINCLUDE environment variable is set (new!), use that path as the
    default location to find !include'd baja (*.inc) files. If you use the '-I'
    option, it will override the environment variable setting. For Nelgin.
  28. rswindell
    Fri Jun 29 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.719 1.720 diff

    Log Message:
    Fix problem with socket-I/O external programs executed while the client
    using SSH: the output from the program (file transfer driver, door game)
    would reach the SSH client, but input from the client (or user) would not
    reach the external program:
    passthru_output_thread() - responsible for SSH input from the client/user
    to be sent to a "raw" pass-through socket used by the external program,
    had a reversed logic bug added around rev 1.686.
    Problem was introduced as part of the cryptlib update/SSH overhaul of 
    early 2018. Thanks to Thumper @ THEWASTE for the bug report!
  29. rswindell
    Thu Jun 28 2018 03:07 pm PDT

    Modified Files:
    ctrl/sbbsecho.ini 1.2 1.3 diff

    Log Message:
    Added list of known domains (including "othernets" provided by Tony Langdon).
    We should try to keep this list current to assist new sysops, so feedback is
    welcome.
    Also read/saved using EchoCfg, so it added all the supported keys with default
    values.
    Updated the default Inbound directory
     (from /binkd/inbound to ../fido/nonsecure)
    Updated the default Outbound directory
     (from /binkd/outbound to ../fido/outbound)
  30. nightfox
    Mon Jun 25 2018 09:50 pm PDT

    Modified Files:
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js 1.13 1.14 diff

    Log Message:
    Update for the feature of not showing the latest message date & time in the sub-board lists.
  31. nightfox
    Mon Jun 25 2018 09:35 pm PDT

    Modified Files:
    xtrn/DDAreaChoosers/DDFileAreaChooser.js 1.11 1.12 diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.cfg 1.3 1.4 diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js 1.12 1.13 diff
    xtrn/DDAreaChoosers/readme.txt 1.2 1.3 diff
    xtrn/DDAreaChoosers/revision_history.txt 1.2 1.3 diff

    Log Message:
    Version 1.17: For the message area chooser, added a new configuration file option, showDatesInSubBoardList, that specifies whether or not to show the date & time of the latest message in the sub-boards.
  32. rswindell
    Mon Jun 25 2018 02:14 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.38 1.39 diff

    Log Message:
    Disable the FTN NetMail source address selection (chooser) by default -
    the sysop must now enable this feature in SCFG->Networks->FidoNet.
    Also, widen the FidoNet configuration menu in SCFG, display more FTN
    addresses and the default origin line (part of it, at least) in the menu.
  33. rswindell
    Mon Jun 25 2018 02:13 pm PDT

    Modified Files:
    src/sbbs3/sbbsdefs.h 1.220 1.221 diff
    src/sbbs3/fido.cpp 1.60 1.61 diff

    Log Message:
    Disable the FTN NetMail source address selection (chooser) by default -
    the sysop must now enable this feature in SCFG->Networks->FidoNet.
  34. rswindell
    Mon Jun 25 2018 01:28 pm PDT

    Modified Files:
    exec/postmsg.js 1.2 1.3 diff

    Log Message:
    Clarify that 'mail' is a supported msgbase code.
  35. nightfox
    Mon Jun 25 2018 12:41 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.121 1.122 diff
    xtrn/DDMsgReader/readme.txt 1.17 1.18 diff

    Log Message:
    Version 1.17 beta 62: Made another fix to avoid the "Unknown destination" error when forwarding a message to a QWK-style address (such as "sysop@DIGDIST")
  36. nightfox
    Sun Jun 24 2018 10:05 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.120 1.121 diff
    xtrn/DDMsgReader/readme.txt 1.16 1.17 diff

    Log Message:
    Version 1.17 beta 61: Fixed a bug where it would report an "unknown destination" error when trying to forward a message to a FTN-style email address.
  37. rswindell
    Thu Jun 21 2018 01:24 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgxtrn.c 1.58 1.59 diff

    Log Message:
    Fixed typo (causing line-wrap) in online help.
  38. rswindell
    Thu Jun 21 2018 01:23 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.234 1.235 diff

    Log Message:
    Add clarification to the "No startup directory" error, that this is only
    for DOS programs (part of the USE_DOSEMU patch).
  39. rswindell
    Thu Jun 21 2018 01:22 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgchat.c 1.22 1.23 diff

    Log Message:
    Allow external chat pagers to have their "native" and "use shell" execution
    flags set manually in SCFG.
  40. rswindell
    Thu Jun 21 2018 01:22 pm PDT

    Modified Files:
    src/sbbs3/chat.cpp 1.76 1.77 diff

    Log Message:
    Allow external chat pagers to have their "native" and "use shell" execution
    flags set manually in SCFG.
  41. rswindell
    Tue Jun 19 2018 12:01 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.85 3.86 diff

    Log Message:
    When importing packets, don't export previously-rescanned messages
    (messages which contain the RESCANNED control line) to downlinks.
    
    Also renamed pkt_to_pkt() to write_to_pkts().
  42. rswindell
    Sun Jun 17 2018 06:28 pm PDT

    Modified Files:
    src/sbbs3/download.cpp 1.51 1.52 diff
    src/sbbs3/main.cpp 1.718 1.719 diff

    Log Message:
    Resolved some valgrind reported issues (likely, harmless):
    "Conditional jump or move depends on uninitialised value(s)"
    Thanks, Nelgin.
  43. rswindell
    Sun Jun 17 2018 12:26 pm PDT

    Modified Files:
    exec/load/fido.js 1.32 1.33 diff

    Log Message:
    Fix bug in parse_flo_file_path():
    If there's no zone in the specified path, the default_zone is used and that zone
    is a decimal number, not a hexadecimal string, so running parseInt(...,16)
    on it errorneously generates an incorrect outbound/FLO dir.
    This should fix the problem reported by Al @ TRMB.
  44. rswindell
    Mon Jun 11 2018 10:19 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.40 1.41 diff

    Log Message:
    Fix TLS/SSL failure/error: "creating SSL context"
    If the ctrl/ssl.cert file did not exist, the various TLS/SSL services would
    fail to create it and (sometimes) log the "creating SSL context" error.
    This problem was introduced with rev 1.30 (Mar-9) and the fix/patch
    provided by Deuce via irc. Thanks to Psi-Jack for the bug report.
  45. rswindell
    Mon Jun 11 2018 01:00 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.672 1.673 diff

    Log Message:
    Added log output for a couple of instances where get_ssl_cert() could
    (previuosly) silently fail - in the sendmail_negotiate() and pop3_thread().
    If get_ssl_cert() can return -1 withOUT setting the estr argument to a
    non-NULL value, then we could still have silent failures (TBD).
  46. rswindell
    Sun Jun 10 2018 02:47 am PDT

    Modified Files:
    text/menu/e-mail.asc 1.2 1.3 diff

    Log Message:
    New menu to correspond with new email_sec.js module (loaded by updated Baja cmd
    shells: default, wwiv, wildcat, pcboard).
    - Added (U)n-read messages only command.
    - Renamed (U)pload file to (A)ttach file.
  47. rswindell
    Sun Jun 10 2018 02:09 am PDT

    Modified Files:
    exec/default.src 1.20 1.21 diff
    exec/pcboard.src 1.9 1.10 diff
    exec/wildcat.src 1.12 1.13 diff
    exec/wwiv.src 1.5 1.6 diff
    exec/email_sec.js NONE 1.1 diff

    Added Files:
    	email_sec.js 
    Log Message:
    Replaced the Baja "E-mail Section" code block that was copy/pasted into several
    shells with a new single/unified JS module (email_sec.js):
    - New (U)n-read mail read command ('A' is now for sending file attachments)
    - I didn't update to the renegade shell since it has a custom menu file
    - This module will work with older Synchronet builds, without netmail file
      attachments
    - The old Baja code still works, however... less Baja = rounder Earth
  48. rswindell
    Sun Jun 10 2018 02:00 am PDT

    Modified Files:
    src/sbbs3/getmail.c 1.16 1.17 diff

    Log Message:
    Code cleanup in delfattach().
  49. rswindell
    Sun Jun 10 2018 01:57 am PDT

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.23 1.24 diff

    Log Message:
    Log an error if putmsgptrs() fails (e.g. out of disk space?).
  50. rswindell
    Sun Jun 10 2018 01:56 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.196 1.197 diff

    Log Message:
    putmsgptrs() will now return FALSE if iniWriteFile() returns FALSE
    (out of disk space?).
  51. rswindell
    Sun Jun 10 2018 01:54 am PDT

    Modified Files:
    src/sbbs3/js_msg_area.c 1.69 1.70 diff

    Log Message:
    Add (finally) fido_netmail_settings and inet_netmail_settings (bit-field)
    properties to msg_area object. See NMAIL_* in sbbsdefs.js for the bit values.
  52. rswindell
    Sun Jun 10 2018 01:53 am PDT

    Modified Files:
    src/sbbs3/data.cpp 1.30 1.31 diff
    src/sbbs3/js_bbs.cpp 1.163 1.164 diff
    src/sbbs3/readmail.cpp 1.77 1.78 diff
    src/sbbs3/sbbs.h 1.480 1.481 diff

    Log Message:
    JS bbs object changes:
    - finduser() method no longer prints "Unknown user" upon failure (the calling
      script can do this if/when it wants).
    - read_mail() method now accepts an optional 3rd argumnet (loadmail_mode)
      which may be used to load *only* un-read mail (for example), see LM_* in
      sbbsdefs.js
    
    Pass the lm_mode as a 4th argument to any readmail mod (if one is installed) -
    this correlates with the LM_* mode flag values (0 is normal/usual).
    
    File attachments can also be in a file/####.out directory (e.g. outbound
    Internet email attachments), so try deleting from there too when deleting
    mail with attachments.
  53. rswindell
    Sun Jun 10 2018 01:45 am PDT

    Modified Files:
    src/sbbs3/email.cpp 1.67 1.68 diff

    Log Message:
    Insure the WM_EMAIL mode flag is set when calling writemsg() from email()
    - similar to what we do in netmail() with the WM_NETMAIL flag.
    If you call writemsg() without WM_EMAIL set, it tries to use the subnum as an
    index into the sub-board array and will crash.
  54. rswindell
    Sun Jun 10 2018 01:39 am PDT

    Modified Files:
    src/sbbs3/textgen.c 1.10 1.11 diff

    Log Message:
    text.js now ends in "this;" allowing cool load usage like this:
    var text = load({}, 'text.js');
  55. rswindell
    Sun Jun 10 2018 01:37 am PDT

    Added Files:
    exec/load/userprops.js NONE 1.1 diff

    Log Message:
    New load/library module to make read/writing to user "properties"
    (stored in data/user/*.ini) easy.
  56. rswindell
    Sun Jun 10 2018 01:35 am PDT

    Modified Files:
    exec/load/text.js 1.22 1.23 diff

    Log Message:
    Added new OriginFidoAddr item.
    text.js now ends in "this;" allowing cool load usage like this:
    var text = load({}, 'text.js');
  57. rswindell
    Sun Jun 10 2018 01:34 am PDT

    Modified Files:
    exec/load/sbbsdefs.js 1.77 1.78 diff

    Log Message:
    Added the missing MM_* (msg_area.settings) flag definitions.
    Added loadmail mode (LM_*) definitions for new bbs.read_mail() argument
    (optional).
  58. rswindell
    Fri Jun 08 2018 05:38 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.76 1.77 diff

    Log Message:
    A little beautification of the unread msg only toggle output.
  59. rswindell
    Fri Jun 08 2018 05:24 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.75 1.76 diff

    Log Message:
    getmail() can only check the presence of an attribute flag currently
    (not the absense), so we need to call it twice to find out if there are
    any unread messages for the user.
  60. rswindell
    Fri Jun 08 2018 02:59 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.74 1.75 diff

    Log Message:
    Experimental feature: 'U' command toggles un-read mail visibility.
    Change the 'Edit Author's user account' command to '!' (for now).
  61. rswindell
    Wed Jun 06 2018 07:35 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.104 1.105 diff

    Log Message:
    Updated the JSDOC description of a few User properties.
  62. rswindell
    Wed Jun 06 2018 07:21 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.103 1.104 diff

    Log Message:
    Improve JS User class/object reads across a local network by leaving the
    user.dat file open (for read operations only). Writing still opens and
    closes the user.dat for each property/field modification.
  63. rswindell
    Wed Jun 06 2018 04:07 pm PDT

    Added Files:
    exec/load/birthdays.js NONE 1.1 diff

    Log Message:
     Library to return a list of users with a specified birthday or birthmonth
  64. rswindell
    Wed Jun 06 2018 02:44 pm PDT

    Modified Files:
    exec/load/birthdate.js 1.3 1.4 diff

    Log Message:
     Fix typos in comments, add Id rcs keyword
  65. rswindell
    Wed Jun 06 2018 02:40 pm PDT

    Modified Files:
    exec/load/birthdate.js 1.2 1.3 diff

    Log Message:
     Fix previous change (__defineGetter__)
  66. rswindell
    Tue Jun 05 2018 11:25 pm PDT

    Modified Files:
    exec/fseditor.js 1.88 1.89 diff

    Log Message:
    Use the js.on_exit() method of restoring the bbs.sys_status and
    console.ctrlkey_passthru values. This allows these critical session
    settings to be restored even if/when fseditor.js crashes/abends
    (e.g. exits unexpectedly due to unhandled JS exception).
  67. rswindell
    Mon Jun 04 2018 05:01 pm PDT

    Modified Files:
    ctrl/text.dat 1.82 1.83 diff

    Log Message:
    Added OriginFidoAddr text item.
  68. rswindell
    Mon Jun 04 2018 04:55 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.33 3.34 diff

    Log Message:
    Moved all the BSO/BinkP settings to the end of the Global Settings menu and
    made their display conditional on mailer-type being set to FLO/BSO.
    Added a help menu to the BinkP Settings menu (under Linked Nodes).
  69. rswindell
    Mon Jun 04 2018 03:02 pm PDT

    Modified Files:
    src/xpdev/sockwrap.h 1.54 1.55 diff

    Log Message:
    Added IPPORT_BINKP (TCP port number) definition.
  70. rswindell
    Mon Jun 04 2018 02:52 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.22 3.23 diff

    Log Message:
    Increment SBBSecho version to 3.05:
    more control over SBBS-initiated netmail source/origin addresses.
  71. rswindell
    Mon Jun 04 2018 02:50 pm PDT

    Modified Files:
    src/sbbs3/fido.cpp 1.59 1.60 diff
    src/sbbs3/text.h 1.31 1.32 diff
    src/sbbs3/text_defaults.c 1.42 1.43 diff

    Log Message:
    When the system has multiple configured FidoNet addressess (AKAs), let the
    user choose which address to use as the source address when composing a netmail
    message (the default being the most appropriate for the dest zone/net). This
    change only works with SBBSecho v3.05 or later.
    Some other incremental and safety improvements to sbbs_t::netmail() too.
    FTN netmail file attachments needs some more work however (the "FA:" subject
    prefix trick) - just remove it?
  72. rswindell
    Mon Jun 04 2018 01:56 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.84 3.85 diff

    Log Message:
    Another improvement to create_netmail():
    If the SMB header contains a source FTN address, use that as the origin address
    of the netmail and do not look-up a local AKA match for the destination address.
    Also, fix what appears to have been a (currently harmless) bug in
    smsg_to_echostat_msg(): the msg.from_net.addr is not an ASCIIZ string when
    net.type == NET_FIDO. Currently, source FTN addresses aren't set in echomail
    message headers, where the echostats come from. Could just remove
    these 2 lines.
  73. rswindell
    Mon Jun 04 2018 12:07 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.83 3.84 diff

    Log Message:
    Address RMH's issue:
    When the local system has multiple AKAs for the same zone and we are picking a
    origin/source address suitable for the destination address, pick the AKA that
    matches both the zone and net of the destination address first (if there is
    such a local AKA). It's the same logic used in sbbs_t::netmail() to display
    the originating address, so the AKA picking logic now matches what is shown
    to the netmail author and what SBBSecho will actually use.
  74. rswindell
    Tue May 22 2018 09:16 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.82 3.83 diff

    Log Message:
    Add a ^ARESCANNED w:x/y.z control line to exported messages during a rescan
    (apparently this is a pseudo-standard supported by fastecho and other
    "old-school" tossers) - per mark lewis' request.
  75. rswindell
    Tue May 22 2018 03:34 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.81 3.82 diff

    Log Message:
    When exporting msgs that came from an FTN (e.g. during a rescan), don't convert
    existing tear/origin lines and don't add a new origin line.
  76. rswindell
    Tue May 15 2018 03:41 pm PDT

    Modified Files:
    src/sbbs3/js_msgbase.c 1.219 1.220 diff

    Log Message:
    Fix get_msg_header() problem reported by Bill McGarrity:
    "expand fields" could be misinterpretted (e.g. as 'false') if less than 3
    args were passed to the function. Apparently you can NOT assume that argv[argc]
    is undefined and would fail a JSVAL_IS_BOOLEAN test. In the reported problem,
    MsgBase.get_msg_header() was being called with 2 arguments (from newslink.js)
    and the if(JSVAL_IS_BOOLEAN(argv[n])) test, when n was 2, would eval to true
    and then argv[n] evalulated as false, which would cause a message with no
    message ID to not have one dynamically created, which would then cause the
    message to fail to post to an NNTP server due to malformed Message-ID (a
    missing message "id" property would end up being included in the newsgropu
    article header as "Message-ID: undefined").
    
    get_msg_index() had a similar potential issue, also fixed.
  77. rswindell
    Mon May 14 2018 04:37 pm PDT

    Modified Files:
    exec/newslink.js 1.109 1.110 diff

    Log Message:
    If msgbase.get_msg_header() returns a header with no (undefined) message-ID
    header field, print/log an error and continue on (don't attempt to send to
    NNTP server). This won't solve Bill McGarrity's problem, but it might
    provide a clue (?).
  78. rswindell
    Mon May 14 2018 02:32 pm PDT

    Modified Files:
    exec/binkit.js 2.3 2.4 diff

    Log Message:
    Ignore sub-directories (e.g. *.pnt) of the outbound directory/ies in
    add_outbound_files(). The outbound/*.pnt sub-dirs are handled at a higher
    level.
  79. rswindell
    Thu May 10 2018 12:06 pm PDT

    Added Files:
    exec/msgutil.js NONE 1.1 diff

    Log Message:
    A simple message base test script right now, but ultimately could (should)
    grow into something that could be used in lieu of smbutil for at least
    some message base admin functions. Committing in its current form for
    Bill McGarrity to use to help diagnose a Message-ID issue (w/newslink.js)
  80. rswindell
    Wed May 09 2018 11:48 am PDT

    Modified Files:
    exec/newslink.js 1.108 1.109 diff

    Log Message:
    Created a new function (save_ptr) to elminate some redundant code.
    Removed support for the long-deprecated .snl import/export pointer files
    (uses the long-supported .ini file now only, [NewsLink] section).
    Added more debug output (enabled with the -d switch) when skipping
    (not exporting) any locally posted messages to help debug Bill McGarrity's
    reported problem.
  81. nightfox
    Tue May 08 2018 10:09 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.119 1.120 diff

    Log Message:
    Minor fix
  82. nightfox
    Tue May 08 2018 09:12 pm PDT

    Modified Files:
    xtrn/DDMsgReader/readme.txt 1.15 1.16 diff

    Log Message:
    Updated the version number (1.17 beta 60)
  83. nightfox
    Tue May 08 2018 09:12 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.118 1.119 diff

    Log Message:
    Version 1.17 beta 60:  When a non-sysop is reading anonymous posts, the  "from" name is now shown as "Anonymous".
  84. rswindell
    Thu May 03 2018 06:32 pm PDT

    Modified Files:
    exec/binkit.js 2.2 2.3 diff

    Log Message:
    Resolve exception/abend when files with no extension/suffix are placed 
    in the outbound directory:
     TypeError: file_getext(file) is undefined
  85. rswindell
    Wed May 02 2018 02:47 pm PDT

    Modified Files:
    exec/load/lockfile.js 1.9 1.10 diff

    Log Message:
    Removed the now-deprecated (never-functioning) 'e' flag from File.open()
    calls.
  86. deuce
    Mon Apr 30 2018 11:00 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.667 1.668 diff

    Log Message:
    Break the loop when failed is set to true.
    Also, use a stack pointer if the passed failed pointer is NULL.
  87. rswindell
    Mon Apr 30 2018 06:17 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.80 3.81 diff

    Log Message:
    If a bundle file cannot be unpacked after 48-hours, if the file is 0-bytes in
    length, just delete it (don't rename to *.?_?).
  88. rswindell
    Mon Apr 30 2018 04:02 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.126 1.127 diff

    Log Message:
    maint(): don't truncate the .sid and .hash files to 0-bytes before writing their
    new contents,
    Instead truncate to the new length after writing the new contents. This should
    make the files more tolerant of "out of disk space" situations and reduce
    the risk of lost data (0-byte files) due to low/no free disk space.
  89. rswindell
    Mon Apr 30 2018 03:54 pm PDT

    Modified Files:
    src/sbbs3/mail.cpp 1.32 1.33 diff

    Log Message:
    delmail(): don't truncate the .sid file to 0-bytes before writing the contents,
    instead truncate to the new length after writing the contents. This should
    make mail.sid files more tolerant of "out of disk space" situations and reduce
    the risk of lost data (0-byte mail.sid files) due to low/no free disk space.
  90. rswindell
    Mon Apr 30 2018 02:58 pm PDT

    Modified Files:
    src/xpdev/ini_file.c 1.162 1.163 diff

    Log Message:
    iniWriteFile(): don't truncate the file to 0-bytes before writing the contents,
    instead truncate to the new length after writing the contents. This should
    make .ini files more tolerate of "out of disk space" situations and reduce
    the risk of lost data (0-byte .ini files) due to low/no disk space.
  91. rswindell
    Sun Apr 29 2018 11:05 pm PDT

    Modified Files:
    src/sbbs3/fixsmb.c 1.45 1.46 diff

    Log Message:
    Bug fix: if the msgbase.lock file existed, it would cause the msgbase open (and
    thus fixsmb) to fail, but just before exiting, fixsmb would delete the .lock
    file (whoops). The msgbase.lock file means something else is rebuilding this
    base (e.g. smbutil) and thus we can't just go deleting the .lock file, unless
    we (fixmsb) was the one that created it.
  92. rswindell
    Tue Apr 24 2018 12:56 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.717 1.718 diff
    src/sbbs3/ftpsrvr.c 1.471 1.472 diff
    src/sbbs3/websrvr.c 1.666 1.667 diff

    Log Message:
    Make the strings passed to startup->errormsg() more consistent (a 4-char
    left-justified server prefix), e.g. "term" now added for terminal server
    errors.
  93. rswindell
    Tue Apr 24 2018 12:02 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.95 1.96 diff

    Log Message:
    Make the "UNKNOWN USER" log messages more consistent:
    - Using NOTCICE (not INFO) log level.
    - Move the protocol name after Node X and remove the colon.
  94. deuce
    Mon Apr 23 2018 09:26 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.233 1.234 diff

    Log Message:
    Fix FreeBSD build, broken by revision 1.230
  95. nightfox
    Mon Apr 23 2018 09:26 pm PDT

    Modified Files:
    xtrn/SlyVote/SlyVote.js 1.55 1.56 diff
    xtrn/SlyVote/readme.txt 1.14 1.15 diff

    Log Message:
    Version 0.37 Beta: When submitting a vote, the thread_id field is now set to the message/poll's message ID, not message number.
  96. nightfox
    Mon Apr 23 2018 09:18 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.117 1.118 diff
    xtrn/DDMsgReader/readme.txt 1.14 1.15 diff

    Log Message:
    Version 1.17 beta 59: When submitting a vote, the thread_id field is now set to the message/poll's message ID, not the message number.
  97. rswindell
    Mon Apr 23 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.716 1.717 diff

    Log Message:
    Added protocol (e.g. Telnet, Rlogin, or SSH) to more log messages
    (e.g. warnings and errors).
    Also, stripped trailing white-space from many lines (editor setting).
  98. rswindell
    Mon Apr 23 2018 07:12 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.715 1.716 diff

    Log Message:
    Fix yet another race condition that could cause:
    Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1) ... 
    from output_thread
    Don't set ssh_mode=true until the ssh_session has been created successfully.
    
    Also added some more debug output with regards to Cryptlib session number.
  99. rswindell
    Mon Apr 23 2018 06:43 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.714 1.715 diff

    Log Message:
    Fix more race conditions which cause Terminal Server SSH ERROR 'Bad argument,
    parameter 1' (-1) ... from output_thread
  100. rswindell
    Fri Apr 20 2018 01:18 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.713 1.714 diff

    Log Message:
    Fix race-condition causing SSH errors:
    Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1)
     ... from output_thread
    
    The bbs_thread() sets the global/server sbbs ssh_mode to false and ssh_session
    to 0 (the "parameter 1" value used in the cryptlib function calls in
    output_thread) but was doing this without owning the ssh_mutex, so the
    output_thread had a race condition where it would check ssh_mode=true and
    then use grab the ssh_mutex and use ssh_session in a few cryptlib function
    calls. The fix for the bbs_thread() to grab the ssh_mutex before setting
    ssh_mode to false and ssh_session to 0 and have the output_thread() re-check
    the ssh_mode after grabbing the ssh_mutex and not call any cryptlib
    functions if ssh_mode was set to false while waiting for the mutex.
    
    The cause would have been more obvious if the various cryptlib error/log
    messages contained the cryptlib session ID value (which was 0 in this case).
  101. nightfox
    Thu Apr 19 2018 10:36 am PDT

    Modified Files:
    text/avatars/DIGDIST.startrek.bin 1.1 1.2 diff

    Log Message:
    Used some brigher colors in some of the avatars.  This collection is still a work in progress..
  102. rswindell
    Wed Apr 18 2018 10:47 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.39 1.40 diff

    Log Message:
    Lower the log level of "BADDATA" cryptlib errors (-32) from ERROR to
    WARNING.
    Also fixed a couple of typos in strings.
  103. deuce
    Tue Apr 17 2018 11:51 pm PDT

    Modified Files:
    src/syncterm/menu.c 1.60 1.61 diff
    src/syncterm/term.c 1.337 1.338 diff
    src/syncterm/uifcinit.c 1.38 1.39 diff

    Log Message:
    Now that save/restorescreen() do font stuff too, we can just go ahead and
    switch to CP437 before any uifc stuff and everythings going to be happy.
  104. rswindell
    Tue Apr 17 2018 11:46 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.712 1.713 diff

    Log Message:
    Some log output updates, mainly adding errno string-representation where
    missing, but also now logging when renaming (or failing to rename) bad
    received .REP packet files.
  105. deuce
    Tue Apr 17 2018 11:44 pm PDT

    Modified Files:
    src/conio/ciolib.c 1.171 1.172 diff
    src/conio/ciolib.h 1.99 1.100 diff

    Log Message:
    Have save/restorescreen() save and restore the flags and fonts as well.
  106. rswindell
    Tue Apr 17 2018 11:43 pm PDT

    Modified Files:
    src/sbbs3/un_rep.cpp 1.64 1.65 diff

    Log Message:
    Don't treat qwk_import_msg() failures (e.g. duplicate messages) as
    packet errors, no need to save such REP packets as .bad files.
  107. deuce
    Tue Apr 17 2018 11:33 pm PDT

    Modified Files:
    src/conio/bitmap_con.c 1.136 1.137 diff

    Log Message:
    Handle default fonts when setting vmem.
  108. deuce
    Tue Apr 17 2018 11:33 pm PDT

    Modified Files:
    src/conio/cterm.c 1.241 1.242 diff

    Log Message:
    Copy the current font one into the CTerm altfont array during cterm_init()
    
    This should fix the issue with non-CP437 fonts reported by Kirkman.
  109. rswindell
    Tue Apr 17 2018 11:06 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.671 1.672 diff

    Log Message:
    Use the msg.idx.number as the message number in smb_getmsghdr() failure
    error messages (in the POP3 server) as the msg.hdr.number is zeroed by 
    smb_getmsghdr() and potentially invalid when returning an error.
  110. rswindell
    Tue Apr 17 2018 11:00 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.670 1.671 diff

    Log Message:
    Use a different source for the message number in smb_getmsghdr() failure
    error log message as the header is zeroed in this function and thus the
    message number previously read from the index, lost (zeroed) and useless.
  111. deuce
    Tue Apr 17 2018 08:54 pm PDT

    Modified Files:
    src/syncterm/bbslist.c 1.212 1.213 diff

    Log Message:
    Pass a bar pointer to screen mode list to allow showing below end of first
    screen of rows.
  112. deuce
    Tue Apr 17 2018 07:35 pm PDT

    Modified Files:
    exec/imapservice.js 1.66 1.67 diff

    Log Message:
    is_connected is not a method.
  113. rswindell
    Tue Apr 17 2018 06:41 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.232 1.233 diff

    Log Message:
    Experimental enhancement: enable WWIV color (Ctrl-C) code expansion in
    *nix-builds (for stdio WWIV doors).
  114. rswindell
    Tue Apr 17 2018 03:57 pm PDT

    Modified Files:
    src/sbbs3/xtrn_sec.cpp 1.84 1.85 diff

    Log Message:
    Extend USE_DOSEMU patch to drop file creation for non-native doors:
    Use drive mappings (e.g. D:, F:, G:, H:) rathe than absolute paths to node_dir,
    ctrl_dir, data_dir, and exec_dir in drop files.
    Also: fixed what appears to have been a copy/paste error in the node_dir
    and ctrl_dir mapping to Win32-shortnames for non-native doors on Windows.
  115. rswindell
    Tue Apr 17 2018 02:45 pm PDT

    Modified Files:
    exec/tickit.js 1.43 1.44 diff

    Log Message:
    Simplified the rename_or_move() function:
    - Don't use the deprecated 'e' file open mode
    - Use the global file_copy() method rather than roll-your-own
  116. rswindell
    Mon Apr 16 2018 09:32 pm PDT

    Modified Files:
    src/sbbs3/email.cpp 1.66 1.67 diff

    Log Message:
    Display the (previously unused) EmailFilesNotAllowed text.dat entry if a file
    attachment is attempted but unsupported.
  117. rswindell
    Mon Apr 16 2018 09:30 pm PDT

    Modified Files:
    src/sbbs3/fido.cpp 1.58 1.59 diff

    Log Message:
    Overhaul sbbs_t::netmail() for FidoNet netmail:
    - writes outbound netmail to SMB rather than FTS-1 Stored Messages (*.msg)
      this means you must have SBBSecho v2.30 or later in order to export FTN
      netmail (for file attachments, you'll need SBBSecho v3.04 rev 3.78 or later)
    - removed support for the now deprecated "default address" feature
      (nowadays, people are much more likely to gate FidoNet over Internet rather
      than the reverse!)
    
    The QWK-to-NetMail function still needs a similar overhaul.
  118. rswindell
    Mon Apr 16 2018 09:14 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.79 3.80 diff

    Log Message:
    write_flofile(): if the 'infile' path contains a drive letter prefix
    (e.g. "C:"), skip it on *nix and if the path contains backslashes, convert
    to forward-slashes (for all OSes). This resolves an issue of sending a
    netmail file-attachment that was created on a Windows/MS-DOS type system
    and then scanned/exported on a *nix system. The FTN "stored message"
    convention is to have the full path of the attached file in the message
    subject.
    
    Hopefully nobody wants to use outbound directory names beginning with "x:"
    on *nix. :-)
  119. rswindell
    Mon Apr 16 2018 07:56 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.78 3.79 diff

    Log Message:
    Bug-fix: when exporting FTN netmail from SMB "mail" base, if the netmail
    included an "old-style" (not MIME-encoded) file attachment (where the file path
    is in the subject and the FILEATTACH aux-attribute flag is set), the
    corresponding netmail attribute flag would not be set in the stored msg (*.msg)
    file. Also simplified the create_netmail() function prototype/usage, removing
    the "file_attached" argument (use the hdr.auxattr instead).
  120. rswindell
    Mon Apr 16 2018 03:48 pm PDT

    Modified Files:
    3rdp/win32.release/cryptlib/bin/cl32.dll 1.6 1.7 diff

    Log Message:
    This is a clean rebuild of 3.4.4 with all our patches and there are several
    bytes different, so committing out of an abundance of caution. No "known"
    changes however.
  121. rswindell
    Mon Apr 16 2018 03:39 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.711 1.712 diff

    Log Message:
    Fix typo in previous commit.
  122. rswindell
    Mon Apr 16 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.710 1.711 diff
    src/sbbs3/un_rep.cpp 1.63 1.64 diff

    Log Message:
    2 unrelated changes:
    1: Wrap SSH cryptDestroySession() calls in a wrapper that tracks the number of
        open sessions and logs errors upon failure (and remaining session count).
        This is how I found the SSH session leak in sbbs_t::hangup().
        Also found multiple cals to SSH_END() which were invalid (no session to
        destroy) and removed them.
    2: If errors are detected when unpacking a REP packet, save the .rep file
        (in data/file/<filename.rep>.<timestamp>.bad) for later inspection.
        Also added some VOTING.DAT debug output (to be removed later).
        Trying to the get to the bottom of the
        "smb_addvote thread_back field missing" errors.
  123. rswindell
    Sun Apr 15 2018 06:32 pm PDT

    Modified Files:
    src/sbbs3/logon.cpp 1.65 1.66 diff

    Log Message:
    If the HappyBirthday text.dat line is blank, don't try to display it nor 
    pause and CLS after.
  124. echicken
    Sat Apr 14 2018 10:27 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.28 1.29 diff

    Log Message:
    @DigitalMan | It'd be nice if home/end keys moved to first/last avatars in a collection when viewing a collection
  125. echicken
    Sat Apr 14 2018 10:21 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.27 1.28 diff

    Log Message:
    @DigitalMan | JavaScript  s:\sbbs\exec\avatar_chooser.js line 775: TypeError: state.opt_out_item is null
    
    uh, this oughta do away with that, I guess
  126. echicken
    Sat Apr 14 2018 10:10 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.26 1.27 diff

    Log Message:
    Fix display bug (collection/highlight desync), but I should probably 
    revisit some of this.
  127. echicken
    Sat Apr 14 2018 10:00 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.25 1.26 diff

    Log Message:
    Scroll up one more line when on row zero to reveal the collection title.
    (Not the best fix, but it'll do for now.)
  128. rswindell
    Fri Apr 13 2018 04:59 pm PDT

    Modified Files:
    src/sbbs3/logfile.cpp 1.60 1.61 diff

    Log Message:
    errormsg() logs the "useron", when applicable, even for timed events (e.g.
    REP unpacking).
  129. rswindell
    Thu Apr 12 2018 10:25 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.709 1.710 diff

    Log Message:
    Apparent fix for SSH cryptlib session leak (leading to eventual
    'Resource/space exhausted' errors in TLS and SSH:
    The wrong ssh_session is being passed to cryptDestroySession() in
    sbbs_t::hangup() (introduced in rev 1.615), this call to cryptDestorySession()
    fails (returns -1, bad param) thus leaving the actual
    ssh_session never destroyed (leaked).
  130. rswindell
    Thu Apr 12 2018 03:11 pm PDT

    Modified Files:
    exec/load/sbbslist_lib.js 1.14 1.15 diff

    Log Message:
    Increase maximum service address (e.g. host name) length from 28 chars to 35
    chars for Bill McGarrity @ tequilamockingbirdonline.net :-)
    Doesn't seem to break anything (except backwards compatibility with SBL
    v3).
  131. rswindell
    Sun Apr 08 2018 07:59 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.470 1.471 diff

    Log Message:
    Bug-fix: The GCES macro already prints and *frees* the error string, so
    you can't print and free it again after calling that macro.
  132. rswindell
    Sun Apr 08 2018 07:49 pm PDT

    Modified Files:
    exec/binkit.js 2.1 2.2 diff

    Log Message:
    Remove 'e' from File.open() modes, but place a reminder comment to revisit.
    Added destination address of outbound file in "Attempting callout" log msg.
  133. rswindell
    Sat Apr 07 2018 12:21 am PDT

    Modified Files:
    src/xpdev/xpprintf.c 1.61 1.62 diff

    Log Message:
    Resolve GCC warnings:
    cast from pointer to integer of different size
  134. rswindell
    Sat Apr 07 2018 12:18 am PDT

    Modified Files:
    src/sbbs3/pack_rep.cpp 1.47 1.48 diff

    Log Message:
    Resolved GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
  135. rswindell
    Sat Apr 07 2018 12:17 am PDT

    Modified Files:
    src/sbbs3/mime.c 1.10 1.11 diff

    Log Message:
    Resolved GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
  136. rswindell
    Sat Apr 07 2018 12:15 am PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.231 1.232 diff

    Log Message:
    Removed an apparent debug-output (to stderr) line (output the path to
    emusetup.bat).
    It was generating an (easy to fix) GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
    But the line was not needed, so just removed it.
  137. rswindell
    Fri Apr 06 2018 11:01 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.669 1.670 diff

    Log Message:
    Resolve gcc version 5.4.0 warning: 
    format not a string literal and no format arguments [-Wformat-security]
  138. rswindell
    Fri Apr 06 2018 10:55 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.77 3.78 diff

    Log Message:
    Attempt to address GCC v7 warnings raised by Nelgin:
    warning: format not a string literal and no format arguments [-Wformat-security]
  139. rswindell
    Fri Apr 06 2018 10:51 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.668 1.669 diff

    Log Message:
    Attempt to address GCC v7 warnings raised by Nelgin:
    warning: format not a string literal and no format arguments [-Wformat-security]
       sockprintf(sock,sess,(char*)resp);
       sockprintf(socket,session,sys_error);
  140. rswindell
    Fri Apr 06 2018 12:08 am PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.230 1.231 diff

    Log Message:
    Fix build for USE_DOSEMU option (which I don't use).
  141. rswindell
    Thu Apr 05 2018 08:02 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.76 3.77 diff

    Log Message:
    Use GCC-assisted printf-style format/arg checking to find and fix instances
    of lprintf() misuse.
  142. rswindell
    Thu Apr 05 2018 07:49 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.229 1.230 diff

    Log Message:
    Resolve a couple GCC warnings:
    unused variable 'p'
    comparison between signed and unsigned integer expressions
  143. rswindell
    Thu Apr 05 2018 07:47 pm PDT

    Modified Files:
    src/sbbs3/js_global.c 1.373 1.374 diff

    Log Message:
    Resolve GCC warning: cast from pointer to integer of different size
     in expansion of macro 'JS_ARGS_OFFSET':
    unsigned long is the same size as a pointer (rather than unsigned int)
    on the supported target platforms/tool-chains.
  144. rswindell
    Thu Apr 05 2018 07:42 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.479 1.480 diff
    src/sbbs3/js_cryptcon.c 1.19 1.20 diff
    src/sbbs3/main.cpp 1.708 1.709 diff
    src/sbbs3/pack_rep.cpp 1.46 1.47 diff
    src/sbbs3/readtext.c 1.4 1.5 diff
    src/sbbs3/un_qwk.cpp 1.52 1.53 diff
    src/sbbs3/jsexec.c 1.198 1.199 diff

    Log Message:
    Use GCC-printf-style format/arg checking to find and fix problems with
    ::lprintf() usage.
  145. rswindell
    Thu Apr 05 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.665 1.666 diff

    Log Message:
    Enabled GCC-assisted printf-style format/arg checking for lprintf() and
    fix the resulting warnings.
  146. rswindell
    Thu Apr 05 2018 07:18 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.321 1.322 diff

    Log Message:
    Enabled GCC-assisted printf-style format/arg checking for lprintf() and
    fix the resulting warnings.
  147. rswindell
    Thu Apr 05 2018 07:11 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.h 1.84 1.85 diff
    src/sbbs3/mailsrvr.c 1.667 1.668 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for sockprintf()
    and resolve the resulting warnings.
  148. rswindell
    Thu Apr 05 2018 06:58 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.666 1.667 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for lprintf() and
    resolve the resulting warnings.
  149. rswindell
    Thu Apr 05 2018 06:35 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.469 1.470 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for lprintf, sockprintf
    and send_mlsx().
    Fix numerous printf-style argument bugs, many in the TLS and MLSx support.
  150. rswindell
    Thu Apr 05 2018 06:05 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.468 1.469 diff

    Log Message:
    Fix get_ssl_cert() failure log message (wrong number of arguments).
    Put "TLS" in the failure log messages rather than repeating "FTP".
  151. rswindell
    Thu Apr 05 2018 06:02 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.665 1.666 diff

    Log Message:
    Fix get_ssl_cert() failure log message (wrong number of arguments).
    Was this pasted from somewhere else?
  152. rswindell
    Thu Apr 05 2018 05:49 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.75 3.76 diff

    Log Message:
    Log an error if ftouch() fails to create the outbound sem file.
  153. rswindell
    Thu Apr 05 2018 05:21 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.478 1.479 diff
    src/sbbs3/login.cpp 1.26 1.27 diff

    Log Message:
    Address GCC warning: ISO C++ forbids converting a string constant to 'char*'
  154. rswindell
    Thu Apr 05 2018 05:14 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.664 1.665 diff

    Log Message:
    Fix a couple of issues with external mail processors:
    - Since rev 1.556, mailproc_to_match[] would only ever contain one mail
      processor (index) value, even if the RCPT TO address matched multiple
      mail processor "To" keys in mailproc.ini, so only the first-matching
      mail processor (with a "To" key) would be executed for the msg.
    - mailproc_match, meaning the destination was a non-passthrough
      external mail processor, in which case the destination (RCPT TO) address
      may *not* match a valid local user account, would be set for *passthru*
      mail processors potentially resulting in the following error (and an
      undelivered mail message): !SMTP can't deliver mail to user #0
      only set mailproc_match to a valid mail proc index if the recipient matches a
      non-passthru mail processor.
  155. rswindell
    Thu Apr 05 2018 03:26 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.467 1.468 diff

    Log Message:
    The real apparent fix for the free() assertion: use free_crypt_attrstr() instead
  156. rswindell
    Thu Apr 05 2018 02:49 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.466 1.467 diff

    Log Message:
    Initialize estr to NULL in start_tls(), likely cause of free() assert in
    Windows debug build.
  157. rswindell
    Thu Apr 05 2018 03:28 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.74 3.75 diff

    Log Message:
    Some status string (e.g. "Loading user names...") were being sent to stderr
    instead of stdout.
  158. rswindell
    Wed Apr 04 2018 07:22 pm PDT

    Modified Files:
    exec/showmsghdr.js 1.3 1.4 diff
    exec/showmsgavatar.js 1.1 1.2 diff
    exec/showfileavatar.js 1.2 1.3 diff
    exec/logon.js 1.32 1.33 diff

    Log Message:
    Don't "clear the background attribute" by setting the attributes to 0
    (black on black) as this can inadvertently "hide" text for ANSI users
    (e.g. poll comments, when reading a poll message). Set to 7 (lightgray)
    instead.
  159. rswindell
    Wed Apr 04 2018 12:13 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.195 1.196 diff

    Log Message:
    Don't log "(null)" for the user name in filter_ip() when the user name is
    not known/available (e.g. certain types of SSH login failures).
  160. rswindell
    Wed Apr 04 2018 12:11 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.320 1.321 diff
    src/sbbs3/ftpsrvr.c 1.465 1.466 diff
    src/sbbs3/websrvr.c 1.664 1.665 diff
    src/sbbs3/mailsrvr.c 1.663 1.664 diff

    Log Message:
    Log the number of failed login attempts which triggered the IP filter.
  161. rswindell
    Wed Apr 04 2018 12:10 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.477 1.478 diff
    src/sbbs3/login.cpp 1.25 1.26 diff
    src/sbbs3/main.cpp 1.707 1.708 diff

    Log Message:
    sbbs_t::badlogin() now accepts 3 more (optional) arguments which allow us
    to use this function in bbs_thread() for SSH failed login attempts and thus
    enable the perm-IP-filtering (LoginAttemptFilterThreshold) functionality.
    Right now, it's only a "bad login" if the "Getting channel type" doesn't
    return "session", but we could (and likely will) use it for more SSH login
    failure modes which indicate a likely hack-attempt.
  162. rswindell
    Tue Apr 03 2018 06:52 pm PDT

    Modified Files:
    exec/tickit.js 1.42 1.43 diff

    Log Message:
    Change the -replace option to -force-replace since the old "tick" program
    had a "replace" option that did something differnet (enabled parsing of the
    REPLACES verb) - don't want to confuse sysops now. :-)
  163. rswindell
    Mon Apr 02 2018 04:45 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.706 1.707 diff

    Log Message:
    Create yet-another GCES macro (GCESSTR) to log the output_thread instance
    description string ('node') in SSH-related log messages (e.g. errors) from the
    output_thread: No more "Node 0" log entries from here.
  164. rswindell
    Mon Apr 02 2018 04:22 pm PDT

    Modified Files:
    src/sbbs3/js_file.c 1.171 1.172 diff

    Log Message:
    Updated JS warning when using old/deprecated file open mode 'e':
        "Deprecated file open mode: 'e'"
    If this is your script generating this warning, either remove the 'e' from
    the File open() mode string (it had no effect anyway) or change to 'x' to
    get the real/working exclusive-open functionality (added in v3.17).
  165. rswindell
    Mon Apr 02 2018 03:52 pm PDT

    Modified Files:
    src/sbbs3/ctrl/CodeInputFormUnit.dfm 1.5 1.6 diff

    Log Message:
    Sort the items in the combobox when prompting for an internal code
    (e.g. for a QNET hub or timed event).
  166. rswindell
    Mon Apr 02 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/js_file.c 1.170 1.171 diff

    Log Message:
    The 'e' (exclusive-open) mode flag (introduced in v3.12) never worked. It was
    simply ignored when converted to the underlying open mode passed to sopen().
    Deprecate this flag and log a warning when it is detected as used in a script:
    Deprecated open flag used: 'e'
    Added 'x' (exclsuive-open) mode flag which:
    1. was tested to work as intended
    2. is consistent with the C11 standard for fopen() mode flags
    3. won't cause existing scripts to suddenly break
  167. rswindell
    Mon Apr 02 2018 01:32 pm PDT

    Modified Files:
    exec/tickit.js 1.41 1.42 diff

    Log Message:
    Experimental feature for bgdjr: when '-replace' argument is passed on the
    command-line, treat all .TIC files as they have have a "REPLACES" clause.
  168. deuce
    Mon Apr 02 2018 01:29 am PDT

    Modified Files:
    exec/load/http.js 1.41 1.42 diff

    Log Message:
    When sending a request and the socket is still open, close it.
    This prevents leaving all sockets open until the script exits.  It would
    be better to reuse the existing socket when it's already connected to the
    right place, but this is easier for now.
  169. rswindell
    Sun Apr 01 2018 01:48 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.705 1.706 diff

    Log Message:
    Added function names to SSH error messages so we can better tell where
    these errors are coming from.
  170. rswindell
    Sun Apr 01 2018 01:46 pm PDT

    Modified Files:
    exec/load/fidocfg.js 1.32 1.33 diff
    exec/load/fido.js 1.31 1.32 diff
    exec/load/fido_syscfg.js 1.17 1.18 diff

    Log Message:
    Added CVS Id tag.
  171. echicken
    Sun Apr 01 2018 10:25 am PDT

    Modified Files:
    xtrn/ansiview/ansiview.js 1.24 1.25 diff
    xtrn/ansiview/readme.txt 1.6 1.7 diff

    Log Message:
    Two optional settings can be added to the root section of settings.ini:
    header = /path/to/some.ans
    header_rows = number of lines occupied by the header graphic
    The normal ansiview 'window' will be pushed down by header_rows lines,
    and the header graphic will be displayed above it.
  172. rswindell
    Sun Apr 01 2018 12:51 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.94 1.95 diff

    Log Message:
    If the SSH or RLogin-supplied username is in the name.can, don't start the
    new user signup process with that name (just fall-through to a normal login
    prompt).
  173. rswindell
    Sun Apr 01 2018 12:22 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.662 1.663 diff

    Log Message:
    Added a debug-level log msg ever 100 lines of received SMTP message text.
  174. rswindell
    Sat Mar 31 2018 11:55 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.16 1.17 diff

    Log Message:
    Fix bug in previous commit (use of Object.keys) which caused the default
    domain/zone-map configuration to be used - always.
  175. rswindell
    Sat Mar 31 2018 09:24 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.15 1.16 diff

    Log Message:
    Fix the default domain ('fidonet', zones 1-6) feature when there are no
    domains configured in sbbsecho.ini
    ('domains' is always undefined at this point, <shrug>).
  176. rswindell
    Sat Mar 31 2018 08:54 pm PDT

    Modified Files:
    exec/binkit.js 2.0 2.1 diff

    Log Message:
    Fix error line 792: TypeError: file_getext(dir) is undefined
    when outbound directory (dir) was "../some/path".
  177. rswindell
    Sat Mar 31 2018 08:42 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.32 3.33 diff

    Log Message:
    When creating a new linked node, set binkp_allowPlainText to true
    (Argus and Mystic's BinkP mailers don't support encryption).
  178. rswindell
    Sat Mar 31 2018 08:38 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.31 3.32 diff

    Log Message:
    Help text fix-ups.
  179. rswindell
    Sat Mar 31 2018 08:37 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.73 3.74 diff

    Log Message:
    Bug-fix: The Auto-Add-Subs feature would not create the area file (areas.bbs)
    if it didn't already exist.
  180. rswindell
    Sat Mar 31 2018 07:21 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.14 1.15 diff

    Log Message:
    Fixed some typos.
    Added node address to some authentication failure warnings.
  181. rswindell
    Sat Mar 31 2018 02:43 am PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.30 3.31 diff

    Log Message:
    Resolved GCC warning about implicit type (int).
  182. rswindell
    Sat Mar 31 2018 02:41 am PDT

    Modified Files:
    src/sbbs3/pktdump.c 1.10 1.11 diff

    Log Message:
    Use new struct fidoaddr (5D address).
  183. rswindell
    Sat Mar 31 2018 02:40 am PDT

    Modified Files:
    src/sbbs3/fidodefs.h 1.19 1.20 diff

    Log Message:
    Added FIDO_DOMAIN_LEN (8), PRODDATA_LEN (4), updated comments, etc.
    Created struct fidoaddr (5D address), though it's only used (so far)
    in pktdump.c - doesn't really need to be packed.
  184. rswindell
    Sat Mar 31 2018 02:38 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.21 3.22 diff
    src/sbbs3/sbbsecho.c 3.72 3.73 diff
    src/sbbs3/rechocfg.c 3.29 3.30 diff
    src/sbbs3/echocfg.c 3.29 3.30 diff

    Log Message:
    SBBSecho/EchoCfg v3.04 - uses the newly merged sbbsecho/binkit/ftn_domains.ini
    If you're not using BinkIT (you're using some other FidoNet mailer), you can
    safely ignore all the settings/options.
    A lot of the online help for the new settings/menus needs to be written
    still and the wiki now needs a lot of update to reflect the changes.
    The "title" of this program was changed, again, from "SBBSecho Config" to
    "[Synchronet] FidoNet Config" since it configures more than just SBBSecho
    now.
  185. rswindell
    Sat Mar 31 2018 02:34 am PDT

    Modified Files:
    exec/update.js 1.5 1.6 diff

    Log Message:
    Run 'binkit upgrade' if binkit.ini and sbbsecho.ini exists
    (the upgrade renames binkit.ini and ftn_domains.ini to *.old).
  186. rswindell
    Sat Mar 31 2018 02:33 am PDT

    Modified Files:
    exec/binkit.js NONE 2.0 diff

          Tag: 2.0
    	binkit.js 
    Log Message:
    Merged binkit.ini and ftn_domains.ini into sbbsecho.ini (BinkIT 2.0).
    Use "jsexec binkit upgrade" to upgrade your existing .ini files if you're
    already running BinkIT 1.x.
    echocfg v3.04 may now be used to set all the BinkIT settings and domains
    (in sbbsecho.ini).
  187. rswindell
    Sat Mar 31 2018 02:31 am PDT

    Modified Files:
    exec/load/fidocfg.js 1.31 1.32 diff
    exec/load/fido_syscfg.js 1.13 1.14 diff

    Log Message:
    Merged binkit.ini and ftn_domains.ini into sbbsecho.ini (for BinkIT 2.0)
    (note: some of the key names were changed), run "jsexec binkit upgrade"
    to upgrade your existing .ini's (if you have them).
    Removed support for sbbsecho.cfg.
  188. rswindell
    Sat Mar 31 2018 02:16 am PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.37 1.38 diff

    Log Message:
    Finished removing (now unused) PostLink-networking stuff.
  189. rswindell
    Sat Mar 31 2018 01:40 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.704 1.705 diff

    Log Message:
    Check the terminate_output_thread flag after acquiring the ssh_muex.
  190. deuce
    Sat Mar 31 2018 01:14 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.703 1.704 diff

    Log Message:
    Tabs are stupid.
  191. echicken
    Fri Mar 30 2018 10:41 pm PDT
    exec/load websocket-proxy.js 1.1 NONE
    Update of /cvsroot/sbbs/exec/load
    In directory cvs:/tmp/cvs-serv11750/load
    
    Removed Files:
    	websocket-proxy.js 
    Log Message:
    These are no longer needed and will only cause confusion alongside other websocket scripts.
  192. echicken
    Fri Mar 30 2018 10:41 pm PDT

    Removed Files:
    exec/NONE websocket-rlogin-service.js 1.5 diff

    Log Message:
    These are no longer needed and will only cause confusion alongside other websocket scripts.
  193. rswindell
    Fri Mar 30 2018 09:03 am PDT

    Modified Files:
    src/xpdev/ini_file.c 1.161 1.162 diff

    Log Message:
    Fix bcc32 build error: Expression syntax in function iniSetIntList
  194. rswindell
    Fri Mar 30 2018 01:35 am PDT

    Modified Files:
    src/xpdev/ini_file.c 1.160 1.161 diff
    src/xpdev/ini_file.h 1.54 1.55 diff

    Log Message:
    Added functions for reading/parsing/writing lists of integers in .ini files
    (e.g. "Zones=1,2,3,4,5,6").
  195. rswindell
    Fri Mar 30 2018 01:33 am PDT

    Modified Files:
    src/xpdev/link_list.h 1.27 1.28 diff

    Log Message:
    Fixed typo in comment.
  196. deuce
    Thu Mar 29 2018 06:02 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.464 1.465 diff

    Log Message:
    Fix infinite loop with TLS FTP control session.
  197. deuce
    Tue Mar 27 2018 07:47 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.319 1.320 diff

    Log Message:
    Fix potential crypt handle leak for TLS services.  Destroy the session
    if the thread returns before js_initcx() is called.
  198. deuce
    Tue Mar 27 2018 07:36 pm PDT

    Modified Files:
    exec/letsyncrypt.js 1.32 1.33 diff

    Log Message:
    Don't try ten times to delete files that don't exist.
  199. deuce
    Tue Mar 27 2018 06:45 pm PDT

    Modified Files:
    exec/imapservice.js 1.65 1.66 diff

    Log Message:
    Check if the socket is connected or not in the wait loop.
  200. deuce
    Mon Mar 26 2018 10:16 pm PDT

    Modified Files:
    exec/binkit.js 1.77 1.78 diff

    Log Message:
    Some binkp software (Taurus) doesn't send an M_NUL VER at all.
    Reported by bgdjr.
  201. rswindell
    Mon Mar 26 2018 06:08 pm PDT

    Modified Files:
    src/sbbs3/qwk.cpp 1.81 1.82 diff

    Log Message:
    Don't log an error when a QWK-posted vote message is a dupe (just silently
    discard).
    Also, trim trailing white-spaces.
  202. rswindell
    Mon Mar 26 2018 06:06 pm PDT

    Modified Files:
    src/conio/sdl_con.c 1.261 1.262 diff

    Log Message:
    Fix GCC warning:
    sdl_con.c: In function ΓÇÿsdl_mouse_threadΓÇÖ:
    sdl_con.c:1424:1: warning: no return statement in function returning non-void
  203. nightfox
    Mon Mar 26 2018 12:55 pm PDT

    Modified Files:
    exec/load/DDLightbarMenu.js 1.24 1.25 diff

    Log Message:
    Bug fix in the SetBorderChars method: Missing an index ([i]) into an array
  204. deuce
    Sun Mar 25 2018 10:17 pm PDT

    Modified Files:
    exec/binkit.js 1.76 1.77 diff

    Log Message:
    Check the Mystic version reported by the remote to see if we need to work
    around a broken CRAM-MD5 implementation.  For now, retrains the double-test
    for Mystic/1.12A39 until we see what version number the fixed builds have.
    
    If the major version is less than one, returns true.
    
    If the major version is greater than one, returns false.
    
    If the minor version is less than 12, returns true.
    
    If the minor version is greater than 12, returns false.
    
    If there is no character after the minor versions, returns false.
    (ie: 1.12 is newer than 1.12A39 and is assumed to be fixed)
    
    If the character after the minor version is not an 'A', returns false.
    (ie: 1.12B1 and 1.12.1 are newer than 1.12A39 and assumed fixed)
    
    If the number after the 'A' is less than or equal to 39, returns true.
    
    In all other cases, returns false.
    
    This prevents lowering security by having two allowed CRAM-MD5 responses
    for some remote software versions.  Hopefully the fixed build will have
    version 1.12A40 and we'll be able to remove the last version that does that.
  205. deuce
    Sun Mar 25 2018 09:40 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.702 1.703 diff

    Log Message:
    Since much more than the number of bytes we're reading can be sent on a
    channel we ignore/close, we would get a separate warning for each chunk of
    data on that channel until we read past the close.  Instead, if we're closing
    a channel, we note the channel ID, and simply discard the information
    immediately on the most recently closed channel.
    
    A remote could still cause a bunch of log output by multiplexing two or more
    writes to invalid channels, but nobody seems to do that, so this should be
    good for now.
  206. rswindell
    Sun Mar 25 2018 09:30 pm PDT

    Modified Files:
    src/sbbs3/chksmb.c 1.61 1.62 diff

    Log Message:
    Resolve msvc warnings (and confirm that cvs commits are making it into
    syncprog and the commit log again).
  207. deuce
    Sat Mar 24 2018 09:27 pm PDT

    Modified Files:
    src/conio/cterm.c 1.240 1.241 diff

    Log Message:
    Fix a large number of errors involving re-using an in-use index variable as
    a temp variable.  Mostly impacting the setting of video flags.
  208. rswindell
    Sat Mar 24 2018 09:14 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.193 1.194 diff

    Log Message:
    putmsgptrs():
    Fix-up the user/####.subs ini style (only one blank line between sections).
    Also, don't re-write the .subs file if nothing has changed.
  209. rswindell
    Sat Mar 24 2018 08:48 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.192 1.193 diff

    Log Message:
    Address GCC warning: "/*" within comment
  210. rswindell
    Sat Mar 24 2018 08:47 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.191 1.192 diff

    Log Message:
    Changed user' message pointer/last-read/scan-config storage to a new file
    (data/user/*.subs - in familar .ini syntax)
    indexed by the sub-board internal rather than the old flat binary file using
    the troublesome "pointer index" (ptridx) as an offset. The old files
    (data/user/ptrs/*.ixb) will still be read in when the new file doesn't exist,
    for upgrading users automatically to the new method of pointer storage.
    This should resolve long-standing issues around users' new-scan pointers and
    configurations getting corrupted when the sysop inserts/remove sub-boards.
    However, if you change a sub-board's internal code, that invalidates the users'
    pointers and scan configurations - so that may need to be addrsesed via SCFG.
    The subs' ptridx values are still be used for storing QWKnet hub pointers, for
    now, but that too will soon be addressed with a new file format for those ptrs
    too.
  211. deuce
    Sat Mar 24 2018 02:09 pm PDT

    Modified Files:
    exec/load/binkp.js 1.105 1.106 diff

    Log Message:
    Store the remote software version in the BinkP object, don't do special
    stuff in binkp.js, only the protocol.  BinkIT now does the Mystic check.
  212. deuce
    Sat Mar 24 2018 02:09 pm PDT

    Modified Files:
    exec/binkit.js 1.74 1.75 diff

    Log Message:
    Store the remote software version in the BinkP object, don't do special
    stuff in binkp.js, only the protocol.  BinkIT now does the Mystic check.
  213. deuce
    Sat Mar 24 2018 02:01 pm PDT

    Modified Files:
    exec/load/binkp.js 1.104 1.105 diff

    Log Message:
    Add comment in binkp about why we detect Mystic as well.
  214. deuce
    Sat Mar 24 2018 02:00 pm PDT

    Modified Files:
    exec/binkit.js 1.73 1.74 diff

    Log Message:
    Add comment regarding Mystic password workaround.
  215. deuce
    Sat Mar 24 2018 01:57 pm PDT

    Modified Files:
    exec/load/binkp.js 1.103 1.104 diff

    Log Message:
    Attept to work around Mystic CRAM+CRYPT issue.
  216. deuce
    Sat Mar 24 2018 01:57 pm PDT

    Modified Files:
    exec/binkit.js 1.72 1.73 diff

    Log Message:
    Attept to work around Mystic CRAM+CRYPT issue.
  217. rswindell
    Sat Mar 24 2018 01:53 am PDT

    Modified Files:
    src/sbbs3/text_defaults.c 1.41 1.42 diff

    Log Message:
    The SubLstHdr and SubLstFmt lines display the number of posts per sub-board,
    increase post-count width supported from 4 to 5 digits (beautifully).
  218. rswindell
    Sat Mar 24 2018 01:52 am PDT

    Modified Files:
    ctrl/text.dat 1.81 1.82 diff

    Log Message:
    The SubLstHdr and SubLstFmt lines display the number of posts per sub-board,
    increase post-count width supported from 4 to 5 digits (beautifully).
  219. rswindell
    Fri Mar 23 2018 11:49 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.36 1.37 diff
    src/sbbs3/scfg/scfgsub.c 1.45 1.46 diff

    Log Message:
    Removed PostLink/PCRelay configuration stuff - nobody has used this
    networking technology for 20 years. :-(
  220. rswindell
    Fri Mar 23 2018 05:02 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.660 1.661 diff

    Log Message:
    More detailed log output when posting a message via SMTP (successfully
    or not).
  221. rswindell
    Fri Mar 23 2018 04:57 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.700 1.701 diff

    Log Message:
    Log a generic "SSH session establishment failed" message (with NOTICE
    severity) whenever there is an SSH session establishment failure, because
    some of the SSH failure errors are DEBUG level severity and won't be visible
    with "Normal" (informational) log output filtering. This resolves the issue
    of seing "SSH connection accepted from <ip-address> port <port>" messages
    with no follow-up messages as to what happened to that connection.
  222. rswindell
    Fri Mar 23 2018 04:27 pm PDT

    Modified Files:
    exec/load/binkp.js 1.102 1.103 diff

    Log Message:
    Raise the log-level severity (from DEBUG to NOTICE) when sending any M_ERR
    messages. There's a lot of places in this script where we just send a
    (somewhat explanatory) M_ERR string, but don't log anything locally unless
    debug-level logging is enabled, now we'll at least log those messages with
    a bit higher severity.
  223. rswindell
    Fri Mar 23 2018 01:12 am PDT

    Modified Files:
    exec/binkit.js 1.71 1.72 diff

    Log Message:
    Don't allow the CRAM-MD5 challenge length to be overridden (always use
    the binkp.js default, 32-hexchars/16-bytes). Even IRex v2.31 requires a
    16-byte challenge, so experiment is over.
    Log more details when a CRAM-MD5 authentication response doesn't match
    (e.g. to make case-mismatch or other cause of authentication failures
    potentially more obvious - still debugging the Mystic inbound CRAM-MD5
    auth failure and this might help).
  224. rswindell
    Thu Mar 22 2018 07:12 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.190 1.191 diff

    Log Message:
    Fix weird compile error triggered by *some* revisions of msvc which dont'
    like a str_list_t declared in line (but the char* is fine?!).
  225. rswindell
    Thu Mar 22 2018 06:30 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.199 1.200 diff

    Log Message:
    Fix the log msg repeat count (off by one).
    Remember the last forced timed event setting.
  226. rswindell
    Thu Mar 22 2018 06:19 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.463 1.464 diff
    src/sbbs3/mailsrvr.c 1.659 1.660 diff
    src/sbbs3/main.cpp 1.699 1.700 diff
    src/sbbs3/services.c 1.318 1.319 diff
    src/sbbs3/websrvr.c 1.663 1.664 diff

    Log Message:
    Clean-up the log output around server shutdown/recycle:
    - lower log level (raise severity) of "Waiting for ..." msgs from Debug to Info
    - log a message when done waiting (for clients, threads, etc.)
    - only one #### log line per termination event
  227. rswindell
    Thu Mar 22 2018 05:09 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.8 1.9 diff

    Log Message:
    Log the UNIX socket name (filename) the status thread is listening on
    (default is ctrl/status.sock).
  228. rswindell
    Thu Mar 22 2018 04:32 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.7 1.8 diff

    Log Message:
    Fix more typos.
  229. rswindell
    Thu Mar 22 2018 04:29 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.6 1.7 diff

    Log Message:
    Fixed typo in status thread error message string ("stat" not "ftp").
  230. rswindell
    Thu Mar 22 2018 04:03 pm PDT

    Modified Files:
    exec/load/hexdump_lib.js 1.2 1.3 diff

    Log Message:
    Make hexdump_lib.js more lib-like and change the functions (methods) to
    return arrays rather than calling printf() directly. Also, make the ASCII
    portion of the output optional (but enabled by default).
  231. rswindell
    Thu Mar 22 2018 04:03 pm PDT

    Modified Files:
    exec/hexdump.js 1.1 1.2 diff

    Log Message:
    Make hexdump_lib.js more lib-like and change the functions (methods) to
    return arrays rather than calling printf() directly. Also, make the ASCII
    portion of the output optional (but enabled by default).
  232. rswindell
    Thu Mar 22 2018 02:20 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.317 1.318 diff

    Log Message:
    Bug-fix: JS service calls to random() would return the same sequence on
    Windows, every time. For example, this resulted in the same BinkP CRAM-MD5
    challenge being sent for every mailer session. Fixed by calling sbbs_srand
    in the service's thread, not (just once) in the accept thread.
  233. deuce
    Thu Mar 22 2018 12:31 am PDT

    Modified Files:
    exec/binkit.js 1.70 1.71 diff

    Log Message:
    We can't take a lockfile that doesn't exist.
  234. deuce
    Thu Mar 22 2018 12:22 am PDT

    Modified Files:
    exec/binkit.js 1.69 1.70 diff

    Log Message:
    Only add the SCFG outbound root if it's not in the FTNDomains config already.
    This shouldn't cause any functional changes since it's the outbound dirs that
    matter, and they already can't have duplicates.
  235. deuce
    Thu Mar 22 2018 12:06 am PDT

    Modified Files:
    exec/binkit.js 1.68 1.69 diff

    Log Message:
    I don't know how objects are "true", or "false", so don't risk it.
  236. rswindell
    Wed Mar 21 2018 08:24 pm PDT

    Modified Files:
    exec/binkit.js 1.67 1.68 diff

    Log Message:
    More elaborate fix for missing outbound directories (don't create them),
    just don't "run outbound" for those nodes.
  237. rswindell
    Wed Mar 21 2018 07:58 pm PDT

    Modified Files:
    exec/binkit.js 1.66 1.67 diff

    Log Message:
    <@Deuce> If there's no outbound dir, it should just skip the node.
  238. rswindell
    Wed Mar 21 2018 07:53 pm PDT

    Modified Files:
    exec/binkit.js 1.65 1.66 diff

    Log Message:
    Fix errors when outbound directory does not exist (create it):
      Locking c:\binkd\outbound\00da02bc.bsy
      Error 2 creating c:\binkd\outbound\00da02bc.bsy
      Failed to set date in the future fdate (-1) != future (1687417603)
    Also, added some debug dump of "outbound_roots" which appears to contain
    duplicates, at least when the ftn_domains.ini file is not in use:
     Outbound roots: ["c:\\binkd\\outbound","c:\\binkd\\outbound"]
  239. rswindell
    Wed Mar 21 2018 06:19 pm PDT

    Modified Files:
    text/sbbslist.hlp 1.1 1.2 diff

    Log Message:
    Finally a first pass at an sbbslist online help file.
    I got distracted by trying to wiki-syntax and then markdown and finally
    uust used asc/ctrl-a format. Sorry took so long.
  240. deuce
    Wed Mar 21 2018 12:18 pm PDT

    Modified Files:
    exec/fseditor.js 1.87 1.88 diff

    Log Message:
    Update the help text to list all keys.
  241. deuce
    Wed Mar 21 2018 12:02 pm PDT

    Modified Files:
    docs/fseditor.txt 1.13 1.14 diff

    Log Message:
    Update for all currently supported CTRL keys.
  242. deuce
    Wed Mar 21 2018 12:02 pm PDT

    Modified Files:
    exec/fseditor.js 1.86 1.87 diff

    Log Message:
    Add CTRL-\ as a synonym for CTRL-S to avoid collision with Xon.
    Missing synonym since 1.74 (over 8 years ago)
  243. deuce
    Wed Mar 21 2018 11:03 am PDT

    Modified Files:
    docs/fseditor.txt 1.12 1.13 diff

    Log Message:
    Update to match currently used control keys.
  244. deuce
    Wed Mar 21 2018 10:55 am PDT

    Modified Files:
    exec/fseditor.js 1.85 1.86 diff

    Log Message:
    Add CTRL-N to ctrlkey passthru and remove CTRL-O.
  245. deuce
    Wed Mar 21 2018 10:54 am PDT

    Modified Files:
    exec/fseditor.js 1.84 1.85 diff

    Log Message:
    Remove CTRL-N to "select none" (deselect all) in quote mode since DigitalMan
    decided that CTRL-N should be page-down.  This should fix page down in quote
    mode which has been broken since 1.83 three months ago (with a mention in the
    log that the commit broke fseditor.js)
  246. deuce
    Wed Mar 21 2018 10:41 am PDT

    Modified Files:
    src/sbbs3/js_console.cpp 1.115 1.116 diff

    Log Message:
    Document the cterm_version property to unbreak jsdocs.
  247. deuce
    Wed Mar 21 2018 10:04 am PDT

    Modified Files:
    exec/newuser_signup.js 1.45 1.46 diff

    Log Message:
    Apply patch from Psi-Jack in 2014:
    
    This patch fixes the user object process by ordering specific parts in a way
    that fixes the following problems:
    
    Post-delayed realname and handle caused realname and handle not to be set to
    the user object. Moved copy_user_template_to_user to after bbs.login just
    before the bbs.user_sync() solved that.
              
    Choosing not to use the randomly generated password would fail on every
    situation. Reordering user.security.password to be underneath user.number
    solved this problem.
  248. rswindell
    Tue Mar 20 2018 07:28 pm PDT

    Modified Files:
    exec/sbbslist.js 1.38 1.39 diff

    Log Message:
    Cosmetic improvements to "browse" mode, mainly around editing a BBS entry.
    Also clear the screen and display "Returning to <bbs name>" when exiting.
  249. rswindell
    Tue Mar 20 2018 06:36 pm PDT

    Modified Files:
    exec/sbbslist.js 1.37 1.38 diff

    Log Message:
    Allow up to 20 networks per entry, but only export 10 (the old SBL limit)
    in the legacy section of msgbase-exported entries.
  250. rswindell
    Tue Mar 20 2018 05:01 pm PDT

    Modified Files:
    exec/nntpservice.js 1.116 1.117 diff

    Log Message:
    Don't log a "!TIMEOUT waiting for request" message if the client in fact
    only disconnected.
  251. rswindell
    Tue Mar 20 2018 04:41 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.198 1.199 diff

    Log Message:
    Fix a long-standing bug with the log windows: when the log length would
    reach the configured "max size", newly added log lines would not use the
    configured color/font for the msg's log-level (they'd all use the default
    color/font).
  252. rswindell
    Mon Mar 19 2018 08:47 pm PDT

    Modified Files:
    exec/load/binkp.js 1.101 1.102 diff

    Log Message:
    Fix line 1196: ReferenceError: reset_eob is not defined
  253. rswindell
    Mon Mar 19 2018 08:41 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.197 1.198 diff

    Log Message:
    Track log messages that are repeated within the same LogTimer tick
    (interval) and display them on a single line with an " [x#]" suffix
    which identifies the number of times the message was repeated during that
    interval.
    Also created a common log_msg() function and eliminated a lot of copy/pasta
    in the various *_log_msg() functions.
  254. rswindell
    Mon Mar 19 2018 08:39 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.dfm 1.84 1.85 diff

    Log Message:
    Increase the LogTimer interval from 250ms to 500ms, this allows us to
    collate more (repeated/duplicate) log messages into a single line of the
    visible log.
  255. rswindell
    Mon Mar 19 2018 08:36 pm PDT

    Modified Files:
    src/sbbs3/ntsvcs.c 1.47 1.48 diff
    src/sbbs3/ntsvcs.h 1.6 1.7 diff

    Log Message:
    Add a "repeated" log_msg_t member which tracks repeated log messages.
  256. nightfox
    Mon Mar 19 2018 06:55 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.115 1.116 diff
    xtrn/DDMsgReader/readme.txt 1.12 1.13 diff

    Log Message:
    Version 1.17 beta 57: Made a fix for voting input - It wasn't accepting Q to quit out of voting (a blank input worked though).
  257. nightfox
    Mon Mar 19 2018 06:54 pm PDT

    Modified Files:
    xtrn/SlyVote/SlyVote.js 1.53 1.54 diff
    xtrn/SlyVote/readme.txt 1.12 1.13 diff

    Log Message:
    Version 0.35 beta: Made a fix for non-lightbar voting input - It wasn't accepting Q to quit out of voting (a blank input worked though).
  258. deuce
    Mon Mar 19 2018 05:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.698 1.699 diff

    Log Message:
    Some four spaces to tab conversion at the beginnings of lines.
  259. deuce
    Mon Mar 19 2018 05:10 pm PDT

    Modified Files:
    exec/load/binkp.js 1.100 1.101 diff

    Log Message:
    Inspired by revision 1.36, only reset senteob when we add a file.  Appears
    to work around Radius hang.  Also, in v2 mode, when we're close()ing, try
    to send two M_EOB to help work around weird/broken remotes.
  260. ree
    Mon Mar 19 2018 04:56 pm PDT

    Modified Files:
    exec/websocketservice.js 1.10 1.11 diff

    Log Message:
    Slightly less sucky frame handling
  261. deuce
    Mon Mar 19 2018 04:39 pm PDT

    Modified Files:
    exec/binkit.js 1.64 1.65 diff

    Log Message:
    flush() the lockfile after writing program name.
  262. deuce
    Mon Mar 19 2018 04:01 pm PDT

    Modified Files:
    exec/load/binkp.js 1.99 1.100 diff

    Log Message:
    On a recv() of zero bytes, check if the socket is still connected.
  263. deuce
    Mon Mar 19 2018 02:53 pm PDT

    Modified Files:
    exec/binkit.js 1.63 1.64 diff

    Log Message:
    Make semaphores[] a global and unconditionally touch them at the end of
    the script.
  264. deuce
    Mon Mar 19 2018 02:45 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.218 1.219 diff

    Log Message:
    If select() returns an error, return it rather than forcing the return value
    to zero.
  265. rswindell
    Mon Mar 19 2018 11:49 am PDT

    Modified Files:
    exec/load/binkp.js 1.98 1.99 diff

    Log Message:
    More log details with regards to timeouts and successful authentication.
  266. deuce
    Mon Mar 19 2018 11:41 am PDT

    Modified Files:
    exec/binkit.js 1.62 1.63 diff

    Log Message:
    Ensure semaphores isn't undefined since we're passing it around everywhere
    now.
  267. deuce
    Mon Mar 19 2018 11:12 am PDT

    Modified Files:
    exec/load/binkp.js 1.97 1.98 diff

    Log Message:
    Only use reset_eob() to reset eob counts.  Don't reset the EOB counts except
    for in file transfer related times.
  268. deuce
    Mon Mar 19 2018 11:05 am PDT

    Modified Files:
    exec/load/binkp.js 1.96 1.97 diff

    Log Message:
    Don't send a second M_EOB until we get an M_EOB from the remote.
  269. deuce
    Mon Mar 19 2018 10:55 am PDT

    Modified Files:
    exec/load/binkp.js 1.95 1.96 diff

    Log Message:
    Add comment (pending testing), and fix bug in last commit.
  270. deuce
    Mon Mar 19 2018 10:49 am PDT

    Modified Files:
    exec/load/binkp.js 1.94 1.95 diff

    Log Message:
    For v1.1 connections, send two EOBs before raising the timeout.  It seems that
    Radius/4.010/21.01.2005,13:56(Final-Release)/Win32 will not send an M_EOB
    until it receives two from the remote.
  271. deuce
    Mon Mar 19 2018 10:47 am PDT

    Modified Files:
    exec/load/binkp.js 1.93 1.94 diff

    Log Message:
    No need to send M_EOB while receiving a file, it'll settle out at the end.
  272. deuce
    Mon Mar 19 2018 09:36 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.658 1.659 diff
    src/sbbs3/mailsrvr.h 1.83 1.84 diff
    src/sbbs3/mxlookup.c 1.28 1.29 diff

    Log Message:
    Attempt to fix an apparently crypt object leak in the mail server by having
    mail_close_socket() also destroy the session, and take pointers to set the
    socket to INVALID_SOCKET, and the session to -1.
  273. deuce
    Sun Mar 18 2018 11:59 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.217 1.218 diff
    src/sbbs3/js_socket.h 1.5 1.6 diff

    Log Message:
    Make peek(), nread, data_waiting, and poll() usable for TLS sockets by recv()ing
    a single byte into a special buffer.  Note that peek() and nread will never
    return/indicate more than a single byte, so scripts which rely on these may
    be inefficient with TLS (websocket stuff appears to use nread heavily).
  274. deuce
    Sun Mar 18 2018 11:56 pm PDT

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.85 1.86 diff

    Log Message:
    More whitespace stuff.
  275. deuce
    Sun Mar 18 2018 11:06 pm PDT

    Modified Files:
    exec/load/binkp.js 1.92 1.93 diff

    Log Message:
    Pass the timeout argument to the data recv() call
  276. deuce
    Sun Mar 18 2018 04:19 pm PDT

    Modified Files:
    exec/imapservice.js 1.64 1.65 diff

    Log Message:
    cfgile -> cfgfile
  277. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/templates/default/ftelnet.inc 1.3 1.4 diff
    web/templates/default/ftelnet_external.inc 1.4 1.5 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  278. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/root/members/externals.ssjs 1.7 1.8 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  279. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/root/ftelnet.ssjs 1.5 1.6 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  280. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/templates/nightshade/ftelnet_external.inc 1.4 1.5 diff
    web/templates/nightshade/ftelnet.inc 1.3 1.4 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  281. ree
    Sun Mar 18 2018 01:28 pm PDT

    Modified Files:
    exec/load/ftelnethelper.js 1.6 1.7 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  282. ree
    Sun Mar 18 2018 01:28 pm PDT

    Modified Files:
    exec/websocketservice.js 1.9 1.10 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  283. rswindell
    Sun Mar 18 2018 12:32 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.189 1.190 diff

    Log Message:
    Fix Win32 link failure (e.g. unresolved getsockopt): when iniFile functions are
    used, that requires a socket lib too. util builds (that don't need the .ini
    file functions), they #define NO_SOCKET_SUPPORT, so exclude the user/####.ini
    support functions in that case too.
  284. deuce
    Sun Mar 18 2018 11:34 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.216 1.217 diff

    Log Message:
    Log which attribute couldn't be set.
  285. deuce
    Sun Mar 18 2018 09:57 am PDT

    Modified Files:
    exec/imapservice.js 1.63 1.64 diff

    Log Message:
    Only unlock/save the config if it's been opened.
    Fixes errors on sessions that do not authenticate before disconnecting.
  286. deuce
    Sat Mar 17 2018 09:42 pm PDT

    Modified Files:
    exec/load/binkp.js 1.91 1.92 diff

    Log Message:
    TLS is apparently causing issues, remove it since nobody else supports it
    anyway.
  287. rswindell
    Sat Mar 17 2018 08:48 pm PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.269 1.270 diff

    Log Message:
    Move all the remaining status_startup bits inside the #ifdef __unix__ block
    since it's not defined otherwise. Not sure if this ways intended to be
    included in Windows builds or not.
  288. rswindell
    Sat Mar 17 2018 05:00 pm PDT

    Modified Files:
    exec/binkit.js 1.61 1.62 diff

    Log Message:
    * When polling a node and receiving files, the semaphore files would not
      be touched - fixed (and debug-log output for each semfile touched).
    * When using the "install" command, the "BINKP" service won't be added to
      the services.ini file if a "BINKIT" or a "BINKP" service already exists.
  289. rswindell
    Sat Mar 17 2018 03:52 pm PDT

    Modified Files:
    exec/binkit.js 1.60 1.61 diff

    Log Message:
    Attempt to fix:
    Mar 17 14:15:56 trmb synchronet: srvc 0052 BINKP !JavaScript  /sbbs/exec/binkit
    .js line 862: TypeError: this.command is undefined
  290. deuce
    Sat Mar 17 2018 12:57 am PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.268 1.269 diff

    Log Message:
    Fix reported service for stat_*() callbacks.
  291. deuce
    Sat Mar 17 2018 12:51 am PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.5 1.6 diff

    Log Message:
    Fix up handling of disconnected sockets.
  292. deuce
    Sat Mar 17 2018 12:38 am PDT

    Modified Files:
    src/sbbs3/showstat.c 1.4 1.5 diff

    Log Message:
    Don't bother showing client_t info when a client disconnects... it's always
    NULL
  293. deuce
    Sat Mar 17 2018 12:35 am PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.4 1.5 diff

    Log Message:
    We must be much more clever with the client_t stuff in the lists...
    Always store the prot and user with the client_t to avoid even worse
    headaches.
    
    This makes the client update a bit trickier, but it seems to be good now.
  294. deuce
    Fri Mar 16 2018 11:45 pm PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.267 1.268 diff

    Log Message:
    Stat the status thread much later.
  295. deuce
    Fri Mar 16 2018 11:13 pm PDT

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.84 1.85 diff

    Log Message:
    Whitespace cleanup.
  296. deuce
    Fri Mar 16 2018 10:44 pm PDT

    Modified Files:
    install/GNUmakefile 1.73 1.74 diff

    Log Message:
    Install the new showstat utility.
  297. deuce
    Fri Mar 16 2018 10:43 pm PDT

    Modified Files:
    src/sbbs3/GNUmakefile 1.229 1.230 diff
    src/sbbs3/objects.mk 1.68 1.69 diff
    src/sbbs3/sbbscon.c 1.266 1.267 diff
    src/sbbs3/targets.mk 1.45 1.46 diff

    Log Message:
    Tie the new out of process thing into the build... not tested on Linux or
    Windows
  298. deuce
    Fri Mar 16 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/showstat.c 1.3 1.4 diff

    Log Message:
    Support authentication and the new SERVICE_STATUS
  299. deuce
    Fri Mar 16 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.3 1.4 diff
    src/sbbs3/sbbs_status.h 1.2 1.3 diff

    Log Message:
    Make the status thread a "proper" thread with a startup_t, callbacks, etc.
  300. deuce
    Fri Mar 16 2018 09:24 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.462 1.463 diff

    Log Message:
    That was likely supposed to be a semi-colon.
  301. deuce
    Fri Mar 16 2018 08:06 pm PDT

    Modified Files:
    src/sbbs3/showstat.c 1.2 1.3 diff

    Log Message:
    Fix buf declaration, add missing newline.
  302. deuce
    Fri Mar 16 2018 08:05 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.2 1.3 diff

    Log Message:
    client_on can be called with a NULL client, so we have to handle that too.
  303. deuce
    Fri Mar 16 2018 07:45 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.h 1.1 1.2 diff
    src/sbbs3/sbbs_status.c 1.1 1.2 diff
    src/sbbs3/showstat.c 1.1 1.2 diff

    Log Message:
    Fix handling of client_t char * fields.
  304. rswindell
    Fri Mar 16 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/atcodes.cpp 1.79 1.80 diff
    src/sbbs3/chat.cpp 1.75 1.76 diff
    src/sbbs3/echocfg.c 3.28 3.29 diff
    src/sbbs3/filedat.c 1.38 1.39 diff
    src/sbbs3/scfglib.h 1.22 1.23 diff
    src/sbbs3/scfglib2.c 1.45 1.46 diff
    src/sbbs3/services.c 1.316 1.317 diff
    src/sbbs3/xtrn_sec.cpp 1.83 1.84 diff

    Log Message:
    Address coverity-scan reported issues.
  305. rswindell
    Fri Mar 16 2018 07:21 pm PDT

    Modified Files:
    src/uifc/uifcx.c 1.33 1.34 diff

    Log Message:
    Address coverity-scan defect (unterminated string).
  306. deuce
    Fri Mar 16 2018 11:32 am PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.265 1.266 diff

    Log Message:
    Fix WTF indentation and braces.
  307. deuce
    Fri Mar 16 2018 10:50 am PDT

    Modified Files:
    exec/imapservice.js 1.62 1.63 diff

    Log Message:
    Support "binary" storage of Seen flags.  This greatly reduces the size of
    the data/users/000x.imap files when many messages have been seen.
  308. deuce
    Fri Mar 16 2018 09:13 am PDT

    Modified Files:
    exec/imapservice.js 1.61 1.62 diff

    Log Message:
    Typo in last commit?  Say it ain't so!
  309. deuce
    Fri Mar 16 2018 09:12 am PDT

    Modified Files:
    exec/imapservice.js 1.60 1.61 diff

    Log Message:
    Add -d and -r options to control debug and debugRX respectively... no need
    to spam the log unless you're working on the script itself.
  310. deuce
    Fri Mar 16 2018 09:08 am PDT

    Modified Files:
    exec/imapservice.js 1.59 1.60 diff

    Log Message:
    Ensure we can open the message base before including it in a LIST/LSUB
    response.
  311. deuce
    Fri Mar 16 2018 08:31 am PDT

    Modified Files:
    exec/imapservice.js 1.58 1.59 diff

    Log Message:
    Open the config file unbuffered to help with concurrency.
  312. deuce
    Fri Mar 16 2018 08:24 am PDT

    Modified Files:
    exec/imapservice.js 1.57 1.58 diff

    Log Message:
    Pass the index to operate on to apply_seen.
    Fixes issues with STATUS command.
  313. deuce
    Fri Mar 16 2018 08:04 am PDT

    Modified Files:
    exec/imapservice.js 1.56 1.57 diff

    Log Message:
    Pass the base to get_base_code() so that commands such as STATUS that don't
    have a selected base can use it.
  314. deuce
    Fri Mar 16 2018 08:01 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.215 1.216 diff

    Log Message:
    Update Socket.recvline() for new js_socket_recv() TLS semantics.
    Fixes recvline() returning an zero-length "line" on timeouts, which causes
    infinite loops and 100% CPU utilization with IMAPv4-TLS service (and likely
    any other service that uses recvline with a short timeout).
  315. rswindell
    Thu Mar 15 2018 11:06 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.697 1.698 diff

    Log Message:
    Adjusted log output:
    Added "Node # SSH" to a lot of SSH-related log messages.
    Lowered the severity of the SSH "attempt to use channel" msg from ERROR
    to WARNING.
    Removed "last:" from temp-ban message when there is no last-used username.
  316. rswindell
    Thu Mar 15 2018 10:30 pm PDT

    Modified Files:
    src/sbbs3/execfunc.cpp 1.41 1.42 diff

    Log Message:
    Save the last sent-to netmail address and re-use the address automatically
    when creating a new netmail message. Not exactly an "address book", but a
    convenience nonetheless.
  317. rswindell
    Thu Mar 15 2018 10:26 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.188 1.189 diff
    src/sbbs3/userdat.h 1.67 1.68 diff

    Log Message:
    Added some functions to read/write to the data/user/*.ini files.
    I'm calling these "user properties", but that might change.
  318. rswindell
    Thu Mar 15 2018 10:24 pm PDT

    Modified Files:
    src/xpdev/ini_file.c 1.159 1.160 diff
    src/xpdev/ini_file.h 1.53 1.54 diff

    Log Message:
    Added iniSetValue() which, like iniGetValue(), does not support string
    literals (e.g. won't detect and escape them automatically). If you set
    a key value with carriage-returns and line-feeds, those will end up in the
    .ini file as-is, so use with caution.
  319. deuce
    Thu Mar 15 2018 07:39 pm PDT

    Modified Files:
    exec/binkit.js 1.59 1.60 diff

    Log Message:
    Better log messages when locks fail and aren't old enough to take over.
  320. deuce
    Thu Mar 15 2018 07:30 pm PDT

    Modified Files:
    exec/load/binkp.js 1.90 1.91 diff

    Log Message:
    Fixes for v1.0 mode...
    1) Don't reset eob counts for sent or got.
    2) Ensure M_GET is never sent in v1.0 mode.
    3) Only send one M_EOB in v1.0 mode, even if we add to the list with M_GET
    
    This should cover all the bases, but FREQ may be non-conformant.
  321. deuce
    Thu Mar 15 2018 07:08 pm PDT

    Modified Files:
    exec/load/binkp.js 1.89 1.90 diff

    Log Message:
    Overhaul EOB handling... just count them, and reset both to zero on non-EOB
    in either direction.
    
    For v1.0, a single EOB in both directions terminates the session and for
    v1.1, two EOBs in both directions terminates.
    
    This should greatly simplify the overly complicated senteob/sentempty/goteob/
    gotempty logic and completely eliminate loops.  Biggest risk with this change
    is issues with v1.0 servers.
  322. deuce
    Thu Mar 15 2018 06:39 pm PDT

    Modified Files:
    exec/load/binkp.js 1.88 1.89 diff

    Log Message:
    Terminate string.
  323. deuce
    Thu Mar 15 2018 06:35 pm PDT

    Modified Files:
    exec/load/binkp.js 1.87 1.88 diff

    Log Message:
    Add some temporary debug logspam.
  324. rswindell
    Thu Mar 15 2018 04:56 pm PDT

    Modified Files:
    src/sbbs3/un_qwk.cpp 1.51 1.52 diff

    Log Message:
    Ignore (and delete) TOREADER.EXT (a QWKE additional metadata file) if it
    exists in a .QWK packet. Also, delete the other control/metadata files
    case-insensitively (just in case).
  325. deuce
    Thu Mar 15 2018 04:32 pm PDT

    Modified Files:
    exec/load/binkp.js 1.86 1.87 diff

    Log Message:
    Push an M_SKIP into the failed_sent_files() from the pending_ack array, not
    from the currently sending file, since the pending ack should always be there,
    but sending often won't be.  Also, log a warning when pending_ack isn't empty
    and we get an M_EOB.
  326. deuce
    Thu Mar 15 2018 03:39 pm PDT

    Modified Files:
    exec/load/binkp.js 1.85 1.86 diff

    Log Message:
    Add a new send_chunks() method which will deal with short send() calls.
    We can't rely on our send buffers being infinite anymore.
  327. deuce
    Thu Mar 15 2018 03:21 pm PDT

    Modified Files:
    exec/load/binkp.js 1.84 1.85 diff

    Log Message:
    Fix handling of timeouts vs. errors... they're not the same, so don't treat
    them that way.  Also, ensure there's a timeout on the second byte of the
    packet header since we toss out the first byte if the second byte times out
    (they should pretty much always be in the same packet, but why take the risk?)
  328. deuce
    Thu Mar 15 2018 03:07 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.214 1.215 diff

    Log Message:
    Add missing else in last commit.
  329. deuce
    Thu Mar 15 2018 03:06 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.213 1.214 diff

    Log Message:
    Have the return value of js_socket_recv() have something vaugely to do with
    the return value if recv() for non-TLS sockets.
  330. deuce
    Thu Mar 15 2018 02:56 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.212 1.213 diff

    Log Message:
    Fix ret/copied confusion in last commit.
  331. deuce
    Thu Mar 15 2018 02:42 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.696 1.697 diff

    Log Message:
    Fix unterminated string usage.
  332. deuce
    Thu Mar 15 2018 02:40 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.211 1.212 diff

    Log Message:
    Fix up js_recv_socket() some more... add explicit MSG_WAITALL support for
    TLS, use MSG_WAITALL for reading integers, add a time() based timeout,
    return as soon as any bytes are read (including zero), and generally
    behave more closely to how recv() itself behaves.
  333. deuce
    Thu Mar 15 2018 12:46 pm PDT

    Modified Files:
    exec/load/lightbar.js 1.34 1.35 diff

    Log Message:
    Fix typo in comment
  334. echicken
    Thu Mar 15 2018 12:22 pm PDT

    Modified Files:
    exec/load/http.js 1.40 1.41 diff

    Log Message:
    Ditch the 'self' stuff and give forEach a thisArg instead.
  335. echicken
    Thu Mar 15 2018 11:28 am PDT

    Modified Files:
    exec/load/http.js 1.39 1.40 diff

    Log Message:
    That 'this' was not the 'this' that your 'self' was looking for there then.
    May resolve the error reported by Bill McGarrity (this.extra_headers is
    undefined).
  336. deuce
    Thu Mar 15 2018 02:27 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.210 1.211 diff

    Log Message:
    The timeout to Socket.recv() is the *SECOND* argument, not a copy of the
    first one.
  337. deuce
    Thu Mar 15 2018 02:17 am PDT

    Modified Files:
    exec/load/binkp.js 1.83 1.84 diff

    Log Message:
    Don't use a separate OPT line for TLS, it seems to mess up
    Radius/4.010/21.01.2005,13:56(Final-Release)/Win32
  338. deuce
    Thu Mar 15 2018 01:59 am PDT

    Modified Files:
    exec/load/binkp.js 1.82 1.83 diff

    Log Message:
    Since we're supporting TLS now, use the sock.recv() timeout parameter instead
    of poll()ing for each byte.
  339. deuce
    Thu Mar 15 2018 01:52 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.209 1.210 diff

    Log Message:
    Re-enable recv timeouts for TLS sessions.  It was #ifdef'd out for some
    reason.
  340. deuce
    Thu Mar 15 2018 01:34 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.208 1.209 diff

    Log Message:
    Fix misuse of SSL_OPTIONS in last commit.
  341. deuce
    Thu Mar 15 2018 01:27 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.207 1.208 diff

    Log Message:
    For right now, don't verify server names in certificates.  This will need
    to be changed to something the individual clients can frob in the near
    future.
  342. deuce
    Thu Mar 15 2018 01:16 am PDT

    Modified Files:
    exec/load/binkp.js 1.81 1.82 diff

    Log Message:
    We need to send M_NUL "OPT TLS" before M_NUL "OPT CRYPT".
  343. deuce
    Thu Mar 15 2018 01:13 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.695 1.696 diff

    Log Message:
    We certainly can't re-use i for error return values when it's how many
    bytes have been sent!
  344. deuce
    Thu Mar 15 2018 12:58 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.694 1.695 diff

    Log Message:
    More hacks to work around a known bug in Cryptlib SSH...
    "Sometimes" the write timeout value is used for read timeouts.  Since we
    use a read timeout of zero, and a mutex, this can cause some serious delays
    in SSH processing.  As a workaround, we set the write timeout to zero.
    However, a flush failure has historically been fatal.
    
    So, we now change the write timeout to one second just before a flush, and
    have a flush timeout not be fatal anymore... we set it back to zero after
    the flush.
    
    The fiddling with the write timouts will be removed once the bug is fixed,
    but the flush timout not being fatal may stay forever... add some comments
    to remind us to remove the hack in the future.
  345. rswindell
    Thu Mar 15 2018 12:45 am PDT

    Modified Files:
    3rdp/win32.release/cryptlib/bin/cl32.dll 1.5 1.6 diff
    3rdp/win32.release/cryptlib/bin/cl32.lib 1.5 1.6 diff

    Log Message:
    Updated 3.4.4 with Deuce's latest patches.
  346. deuce
    Thu Mar 15 2018 12:28 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.693 1.694 diff

    Log Message:
    Connections without a "session" channel get treated as a dupe-free failed
    attempt.
  347. rswindell
    Thu Mar 15 2018 12:20 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.187 1.188 diff

    Log Message:
    When loginFailure() is called with a NULL username, always treat it as a
    "unique" login attempt (e.g. hack attempt).
  348. deuce
    Thu Mar 15 2018 12:05 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.692 1.693 diff

    Log Message:
    badlogin() can't be used for SSH sessions that are terminated early, this
    code merely introduced a 5 second delay in the Node 0 thread.
  349. deuce
    Wed Mar 14 2018 04:41 pm PDT

    Modified Files:
    exec/load/binkp.js 1.80 1.81 diff

    Log Message:
    Copy the comment about VER Internet Rex 2.29 Win32 (binkp/1.1) to where
    the challenge length is set and add a TODO comment there.
  350. deuce
    Wed Mar 14 2018 04:31 pm PDT

    Modified Files:
    exec/load/binkp.js 1.79 1.80 diff

    Log Message:
    Remove magical return type of auth callback.
  351. deuce
    Wed Mar 14 2018 04:30 pm PDT

    Modified Files:
    exec/binkit.js 1.58 1.59 diff

    Log Message:
    If there is at least one password mismatch, and there are zero password
    matches, send an M_ERR to the remote and leave the address list empty.
  352. deuce
    Wed Mar 14 2018 03:48 pm PDT

    Modified Files:
    exec/imapservice.js 1.55 1.56 diff

    Log Message:
    It seems many IMAP clients open multiple connections to the server, and
    expect the Seen flags to be coherent across them... support this by leaving
    the users IMAP status file open, and holding a lock on the first byte.
    
    We now need to flush changes to the status file more often, and we need
    to call file.flush() before unlocking.
  353. rswindell
    Wed Mar 14 2018 03:01 pm PDT

    Modified Files:
    exec/binkit.js 1.57 1.58 diff

    Log Message:
    Fix reserved logic of 'nomd5' option check:
    nomd5 means "plain-text passwords are okay" (AllowPlainPasswords=true)
  354. deuce
    Wed Mar 14 2018 11:23 am PDT

    Modified Files:
    exec/load/binkp.js 1.78 1.79 diff

    Log Message:
    Add TLS support to binkp.
    
    The *first* packet from the answering side *must* be an M_NUL "OPT TLS".
    If this is the case, the originating size responds with an M_NUL "OPT TLS".
    After this, the answering system performs a server TLS handshake, and the
    originating system performs a client TLS handshake.
    
    OPT CRYPT is not used in this case (ie: not crypt over TLS)
  355. rswindell
    Tue Mar 13 2018 11:04 pm PDT

    Modified Files:
    exec/postmsg.js 1.1 1.2 diff

    Log Message:
     Allow sub-code value of 'mail'
  356. rswindell
    Tue Mar 13 2018 10:55 pm PDT

    Modified Files:
    src/smblib/smbstr.c 1.28 1.29 diff

    Log Message:
    smb_netaddr_type() will now recognize an FTN-style address without a 
    "user@" prefix.
  357. rswindell
    Tue Mar 13 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.125 1.126 diff

    Log Message:
    Use smb_hfield_netaddr() to properly support FidoNet netmail via the 'n'
    (import netmail) command along with the '-n' option to set the recipient
    net address (and network type). Previously, only Internet or QWK netmail
    was supported.
  358. deuce
    Tue Mar 13 2018 10:39 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.691 1.692 diff

    Log Message:
    Actually, anything except failure to send credentials should count as a
    bad login.
  359. deuce
    Tue Mar 13 2018 10:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.690 1.691 diff

    Log Message:
    Toss invalid session connections into badlogin().
  360. deuce
    Tue Mar 13 2018 07:47 pm PDT

    Modified Files:
    exec/load/utf8_ascii.js 1.2 1.3 diff

    Log Message:
    Fix error in last commit.
  361. deuce
    Tue Mar 13 2018 07:25 pm PDT

    Modified Files:
    exec/imapservice.js 1.54 1.55 diff

    Log Message:
    Handle an uncommon error a bit better... maybe.
  362. deuce
    Tue Mar 13 2018 07:19 pm PDT

    Modified Files:
    web/templates/nightshade/footer.inc 1.1 1.2 diff
    web/templates/nightshade/main.inc 1.3 1.4 diff

    Log Message:
    Do the https:// thing to <img src="http://... stuff in nightshade too.
  363. deuce
    Tue Mar 13 2018 07:17 pm PDT

    Modified Files:
    web/templates/default/footer.inc 1.11 1.12 diff

    Log Message:
    Use the https:// link for the W3 image for that sweet green lock.
  364. rswindell
    Tue Mar 13 2018 03:13 pm PDT

    Modified Files:
    exec/binkit.js 1.56 1.57 diff

    Log Message:
    More detailed log output in inbound_auth_cb() to help debug why
    inbound Mystic sessions are failing (e.g. with Al@TRMB's BinkIt mailer).
  365. deuce
    Tue Mar 13 2018 10:29 am PDT

    Modified Files:
    exec/letsyncrypt.js 1.31 1.32 diff

    Log Message:
    ACMEv2 endpoint is now live.  See the wiki for how to automate TLS certificates
    with Synchronet.
  366. rswindell
    Mon Mar 12 2018 11:22 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.124 1.125 diff

    Log Message:
    Fix bug introduced in rev 1.119: When reading in the msgbase index
    (.sid file), don't divide the fread() results (it's already in number of
    records read). This could cause msgbase maintenance to not take place
    or corruption of a msg base.
  367. deuce
    Mon Mar 12 2018 11:16 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.206 1.207 diff

    Log Message:
    Don't log orderly shutdowns, even at debug level.  This is mostly because
    my jsexec includes debug output... and this is super-normal.
  368. deuce
    Mon Mar 12 2018 10:55 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.662 1.663 diff

    Log Message:
    Fix handling of cryptPushData() and cryptFlushData() success correctly.
    Also, change READTIMEOUT back to zero since that issue is fixed now.
  369. rswindell
    Mon Mar 12 2018 10:10 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.689 1.690 diff

    Log Message:
    Upper-case the timed event internal code and display it in more of the
    log messages.
  370. deuce
    Mon Mar 12 2018 07:00 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.38 1.39 diff

    Log Message:
    Make CRYPT_ERROR_NOSECURE a warning, not an error.  There appear to be
    SSLv3 (!) and even SSLv2(!!) clients still in the wild.  Sysops aren't
    expected to be able to fix other peoples ancient broken stuff.
  371. deuce
    Mon Mar 12 2018 06:58 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.688 1.689 diff

    Log Message:
    No matter the reason we don't get the channel type, still disconnect
    the SSH session.  Also, do an INFO level log entry to indicate what
    happened to your socket.
  372. deuce
    Mon Mar 12 2018 06:32 pm PDT

    Modified Files:
    3rdp/build/GNUmakefile 1.41 1.42 diff
    3rdp/build/cl-short-client-name.patch NONE 1.1 diff

    Added Files:
    	cl-short-client-name.patch 
    Log Message:
    Allow even shorter SSH client names... specifically, SSH-2.0-Go
  373. deuce
    Mon Mar 12 2018 06:23 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.687 1.688 diff

    Log Message:
    Set the TX channel before reading the primary channel type.  Also add
    missing "SSH" when logging channel use errors.
  374. deuce
    Mon Mar 12 2018 05:41 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.205 1.206 diff

    Log Message:
    Limit push size to 8k.  Fixes issue in the IMAP server where ver large
    sends would cause MAC errors.
  375. deuce
    Mon Mar 12 2018 12:22 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.657 1.658 diff

    Log Message:
    Pedanticaly, rsp may not be three characters long (yes, it always will),
    so support that.
  376. deuce
    Mon Mar 12 2018 12:20 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.656 1.657 diff

    Log Message:
    Fix issue where the last line of a multi-line response wasn't searched
    for a match... which caused a memory leak.
    
    Thanks scan-build!
  377. deuce
    Mon Mar 12 2018 12:11 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.655 1.656 diff

    Log Message:
    sendmail_open_socket() will close the passed socket if it's not INVALID_SOCKET
    So, we really should initialize sock to INVALID_SOCKET before calling it.
    
    This should fix the "random descriptors are closed" issue.
  378. deuce
    Mon Mar 12 2018 11:26 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.686 1.687 diff

    Log Message:
    Remove unused variables.
  379. deuce
    Mon Mar 12 2018 11:24 am PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.461 1.462 diff
    src/sbbs3/sbbs.h 1.475 1.476 diff
    src/sbbs3/websrvr.c 1.661 1.662 diff

    Log Message:
    More log fixes.
  380. deuce
    Mon Mar 12 2018 11:11 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.654 1.655 diff

    Log Message:
    Fix incorrect log messages.
  381. deuce
    Mon Mar 12 2018 11:07 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.685 1.686 diff

    Log Message:
    Now that we've fixed the zero timeout on rx issue, we can set the rx timeout
    to zero again.  Unfortunately, there appears to be a related bug where the
    TX timeout is sometimes used for RX... that's OK, we'll just set them both
    to zero.
    
    Also, deal with secondary channels (ie: forwarded ports).  For now, we just
    close these channels any time we get data on them.  In the future, we can
    do scp/sftp pretty easily now... though neither is likely to ever work with
    the sysop account due to the system password requirement.
    
    This change ABSOLUTELY REQUIRES an updated cryptlib.  Windows guys don't
    update until DigitalMan commits cl.lib or whatever it's called.
  382. deuce
    Mon Mar 12 2018 10:52 am PDT

    Modified Files:
    3rdp/build/GNUmakefile 1.40 1.41 diff
    3rdp/build/cl-select-fix.patch NONE 1.1 diff

    Added Files:
    	cl-select-fix.patch 
    Log Message:
    Add fix for ioWait() to guarantee at least one iteration through the select()
    loop even when the timeout is zero.
  383. rswindell
    Sun Mar 11 2018 08:21 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.315 1.316 diff

    Log Message:
    NNTPS/TLS looks funny. Let's go with a "<svc/prot> TLS" instead.
  384. rswindell
    Sun Mar 11 2018 05:21 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.460 1.461 diff
    src/sbbs3/js_socket.c 1.204 1.205 diff
    src/sbbs3/mailsrvr.c 1.653 1.654 diff
    src/sbbs3/services.c 1.314 1.315 diff
    src/sbbs3/websrvr.c 1.660 1.661 diff

    Log Message:
    Added "TLS" (or "/TLS") to the cryptlib-related log messages.
  385. rswindell
    Sun Mar 11 2018 02:30 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.684 1.685 diff
    src/sbbs3/sbbs.h 1.474 1.475 diff
    src/sbbs3/js_socket.c 1.203 1.204 diff

    Log Message:
    Created and used call_socket_open_callback() to track the sockets opened
    via JS Socket->xpms_accept().
    Also, use do_js_close() to eliminate some repeated code in js_socket.c.
  386. rswindell
    Sun Mar 11 2018 02:29 pm PDT

    Modified Files:
    src/sbbs3/inkey.cpp 1.54 1.55 diff

    Log Message:
    When using Ctrl-T to display time info (globally), if the time left has
    been reduced due to an upcoming event, say so here.
  387. rswindell
    Sun Mar 11 2018 02:28 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.652 1.653 diff

    Log Message:
    A little more debug-level log output around the saving of receiving
    msgs and SPAM database lookup.
  388. rswindell
    Sun Mar 11 2018 02:27 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.54 1.55 diff

    Log Message:
    Fix another memory leak found by scan-build (in an error condition).
  389. rswindell
    Sun Mar 11 2018 02:24 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.35 1.36 diff

    Log Message:
    Overhaul the "System FidoNet Addresses" configuration menu - mainly just
    to add CUT/COPY/PASTE support, but also some beautification and sensible
    updates.
  390. rswindell
    Sun Mar 11 2018 01:59 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.34 1.35 diff

    Log Message:
    Remove the deprecated "Default Outbound FidoNet NetMail Address"
    option.
  391. nightfox
    Sat Mar 10 2018 05:57 pm PST

    Modified Files:
    exec/filearea-lb.js 1.4 1.5 diff

    Log Message:
    Fixed a typo in one of the comments
  392. rswindell
    Sat Mar 10 2018 05:36 pm PST

    Modified Files:
    exec/load/binkp.js 1.77 1.78 diff

    Log Message:
    Log the peer mailer version report with a LOG_INFO level message.
  393. nightfox
    Sat Mar 10 2018 05:24 pm PST

    Modified Files:
    exec/filearea-lb.js 1.3 1.4 diff

    Log Message:
    Made use of cnflib.js to load file.cnf to get the viewable file types information.  This requires the latest cnflib.js (and cnfdefs.js) in the load directory.  Also, in the file listing, changed the info command from Enter to I.  This saves a little space on the help bar at the bottom, and I think it's more consistent with using letters for the other commands.  (I also wanted to be able to use the enter key for something else, which I might do as my own custom mod on my BBS, as I make it look & work more like my Baja file lister mod.)
  394. rswindell
    Sat Mar 10 2018 04:43 pm PST

    Added Files:
    exec/dumpcnfs.js NONE 1.1 diff

    Log Message:
    Example use of load/cnflib.js (and cnfdefs.js)
  395. rswindell
    Sat Mar 10 2018 04:42 pm PST

    Modified Files:
    exec/load/cnfdefs.js 1.5 1.6 diff

    Log Message:
    Renamed msg.msg_misc (bit-field) to msg.settings, for consistency.
  396. nightfox
    Sat Mar 10 2018 04:30 pm PST

    Modified Files:
    exec/filearea-lb.js 1.2 1.3 diff

    Log Message:
    The main function now updates bbs.node_action to NODE_LFIL to indicate that the user is listing files.  bbs.node_action is restored to the previous value upon exit of the main function.
    Also I forgot to mention in my last commit that I added an optional command-line argument to specify a file directory internal code so that this script can (optionally) start at the file list for a file directory rather than the file group chooser.  This allows a command shell to run this script for the 'List files in directory' command (with bbs.curdir_code as the first argument).
  397. rswindell
    Sat Mar 10 2018 01:40 pm PST

    Modified Files:
    exec/load/cnfdefs.js 1.4 1.5 diff
    exec/load/cnflib.js 1.12 1.13 diff

    Log Message:
    Added file.cnf support (Nightfox, you could use this for your filearea-lb
    module).
    Also fixed a couple of field names (to match the Sync-JS model) in the
    msgs.cnf representation (e.g. op_ars -> operator_ars).
  398. nightfox
    Sat Mar 10 2018 12:23 pm PST

    Modified Files:
    exec/filearea-lb.js 1.1 1.2 diff

    Log Message:
    Added a V command to the file directory list to allow viewing a file.  This is done by reading ctrl/file.cnf (based on the read_file_config function in src/sbbs3/scfglib2.c), matching the filename extension in the list, and if found, it runs the file view command using bbs.exec().
    
    If possible, it would be useful to add the ability for sysops to move and delete files from this file lister (as in the stock file lister), but I'm not sure how feasable that would be right now.
  399. rswindell
    Sat Mar 10 2018 12:14 pm PST

    Modified Files:
    exec/load/binkp.js 1.76 1.77 diff

    Log Message:
    Allow the default CRAM challenge length (16 bytes) to be overridden
    (e.g. for experimental purposes) via binkit.ini:
    cram_challenge_length = <length in bytes>
  400. rswindell
    Sat Mar 10 2018 12:13 pm PST

    Modified Files:
    exec/binkit.js 1.55 1.56 diff

    Log Message:
    Allow the default CRAM challenge length (16 bytes) to be overridden
    (e.g. for experimental purposes) via binkit.ini:
    cram_challenge_length = <length in bytes>
  401. deuce
    Sat Mar 10 2018 02:16 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.202 1.203 diff

    Log Message:
    Have do_CryptFlush() return a bool.
    Also some whitespace cleanup.
  402. deuce
    Sat Mar 10 2018 02:04 am PST

    Modified Files:
    src/sbbs3/ssl.c 1.37 1.38 diff

    Log Message:
    Lower CRYPT_ERROR_INTERNAL to NOTICE.  Not sure the sysop can do anything
    about these.
  403. deuce
    Sat Mar 10 2018 01:50 am PST

    Modified Files:
    src/conio/x_cio.c 1.48 1.49 diff

    Log Message:
    Don't start the mouse thread until after video init is successful.
    Prevents x11 mouse thread from running when ciolib falls back past it
    (ie: to curses mode)
  404. deuce
    Sat Mar 10 2018 01:20 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.651 1.652 diff

    Log Message:
    Mail server is guilty too.
  405. deuce
    Sat Mar 10 2018 01:17 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.201 1.202 diff

    Log Message:
    Not every crypt error is due to flushing data!
  406. deuce
    Sat Mar 10 2018 12:50 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.650 1.651 diff

    Log Message:
    Re-fix warnings, but be sane about it this time.
  407. deuce
    Sat Mar 10 2018 12:09 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.649 1.650 diff
    src/sbbs3/main.cpp 1.683 1.684 diff

    Log Message:
    Fix indentation.
  408. deuce
    Sat Mar 10 2018 12:00 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.648 1.649 diff
    src/sbbs3/main.cpp 1.682 1.683 diff

    Log Message:
    Open cryptlib.key read-only (also, be cooler)
  409. deuce
    Fri Mar 09 2018 11:32 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.36 1.37 diff

    Log Message:
    Make CRYPT_ERROR_NOTAVAIL LOG_INFO level.
  410. deuce
    Fri Mar 09 2018 11:27 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.647 1.648 diff

    Log Message:
    Oh yeah, that's WAY cooler.
  411. deuce
    Fri Mar 09 2018 11:17 pm PST

    Modified Files:
    src/sbbs3/smbutil.c 1.123 1.124 diff

    Log Message:
    Fix last Clang warning.
  412. deuce
    Fri Mar 09 2018 11:15 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.646 1.647 diff

    Log Message:
    Fix unaligned pointer access warnings from Clang.
  413. deuce
    Fri Mar 09 2018 11:02 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.459 1.460 diff
    src/sbbs3/js_socket.c 1.200 1.201 diff
    src/sbbs3/mailsrvr.c 1.645 1.646 diff
    src/sbbs3/main.cpp 1.681 1.682 diff
    src/sbbs3/services.c 1.313 1.314 diff
    src/sbbs3/smbutil.c 1.122 1.123 diff
    src/sbbs3/websrvr.c 1.659 1.660 diff

    Log Message:
    "If you alloc() in a DLL, thou shalt free() in the same DLL"
    -- Albert Einstein
  414. deuce
    Fri Mar 09 2018 10:42 pm PST

    Modified Files:
    src/xpdev/xpprintf.c 1.60 1.61 diff

    Log Message:
    Call va_end() on errors as well.
  415. deuce
    Fri Mar 09 2018 10:34 pm PST

    Modified Files:
    src/sbbs3/services.c 1.312 1.313 diff

    Log Message:
    Add missing NULL check.
  416. deuce
    Fri Mar 09 2018 10:30 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.680 1.681 diff

    Log Message:
    Add "SSH" to all the cryptlib SSH logging.
  417. deuce
    Fri Mar 09 2018 10:20 pm PST

    Modified Files:
    src/sbbs3/writemsg.cpp 1.121 1.122 diff

    Log Message:
    And another of the same warnings.
  418. rswindell
    Fri Mar 09 2018 10:20 pm PST

    Modified Files:
    src/sbbs3/useredit.cpp 1.49 1.50 diff

    Log Message:
    Address clang warning: comparison of unsigned expression < 0 is always false
    getstr() does not return < 0, ever (it returns 0 on abort).
    Added more abort-checks after calls to getstr().
  419. deuce
    Fri Mar 09 2018 10:19 pm PST

    Modified Files:
    src/sbbs3/writemsg.cpp 1.120 1.121 diff

    Log Message:
    Fix warning.
  420. deuce
    Fri Mar 09 2018 10:17 pm PST

    Modified Files:
    src/sbbs3/un_rep.cpp 1.62 1.63 diff

    Log Message:
    Fix warning.
  421. deuce
    Fri Mar 09 2018 10:16 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.679 1.680 diff

    Log Message:
    Fix warnings.
  422. deuce
    Fri Mar 09 2018 10:12 pm PST

    Modified Files:
    src/sbbs3/js_global.c 1.372 1.373 diff

    Log Message:
    Fix warnings.
  423. deuce
    Fri Mar 09 2018 10:11 pm PST

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.83 1.84 diff

    Log Message:
    Fix warnings.
  424. rswindell
    Fri Mar 09 2018 10:08 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.678 1.679 diff
    src/sbbs3/js_system.c 1.169 1.170 diff

    Log Message:
    Fix more memory leaks (in error conditions) discovered by clang scan-build.
  425. rswindell
    Fri Mar 09 2018 10:05 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.35 1.36 diff

    Log Message:
    Fix get_ssl_cert() initialization of the error string pointer.
  426. rswindell
    Fri Mar 09 2018 09:13 pm PST

    Modified Files:
    src/sbbs3/userdat.c 1.186 1.187 diff

    Log Message:
    Fix some suspicious typos found via clang warnings.
  427. deuce
    Fri Mar 09 2018 08:49 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.644 1.645 diff

    Log Message:
    Remove unused variable.
  428. deuce
    Fri Mar 09 2018 08:49 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.677 1.678 diff

    Log Message:
    Use new cryptlib log stuff for SSH.
  429. deuce
    Fri Mar 09 2018 08:47 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.34 1.35 diff

    Log Message:
    CRYPT_ENVELOPE_RESOURCE is debug-level as well.
  430. rswindell
    Fri Mar 09 2018 08:34 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.458 1.459 diff

    Log Message:
    Elminated the redundnat "XXX Server listening" log messages
    (the multisock stuff already logs this for each interface and port).
  431. rswindell
    Fri Mar 09 2018 08:29 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.676 1.677 diff

    Log Message:
    Elminated the redundnat "XXX Server listening" log messages
    (the multisock stuff already logs this for each interface and port).
  432. rswindell
    Fri Mar 09 2018 08:20 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.33 1.34 diff

    Log Message:
    #include xpprintf.h to resolve msvc warning:
    ssl.c(210): warning C4013: 'asprintf' undefined; assuming extern returning int
  433. rswindell
    Fri Mar 09 2018 08:04 pm PST

    Modified Files:
    src/xpdev/xpprintf.c 1.59 1.60 diff
    src/xpdev/xpprintf.h 1.15 1.16 diff

    Log Message:
    Constify the 'format' argument of asprintf() and vasprintf() to be
    compatible with the glibc/etc. declarations and use.
  434. deuce
    Fri Mar 09 2018 07:53 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.199 1.200 diff
    src/sbbs3/mailsrvr.c 1.643 1.644 diff
    src/sbbs3/services.c 1.311 1.312 diff
    src/sbbs3/ssl.c 1.32 1.33 diff
    src/sbbs3/websrvr.c 1.658 1.659 diff

    Log Message:
    Massive TLS logging overhaul... next up, SSH...
  435. nightfox
    Fri Mar 09 2018 07:20 pm PST

    Modified Files:
    xtrn/DDAreaChoosers/DDFileAreaChooser.js 1.10 1.11 diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js 1.11 1.12 diff
    xtrn/DDAreaChoosers/readme.txt 1.1 1.2 diff
    xtrn/DDAreaChoosers/revision_history.txt 1.1 1.2 diff

    Log Message:
    Version 1.16: Bug fix for off-by-one issue when there is a file group with no directories or a message group with no sub-boards
  436. rswindell
    Fri Mar 09 2018 07:20 pm PST

    Modified Files:
    src/sbbs3/scfg/scfgxfr2.c 1.53 1.54 diff
    src/sbbs3/scfg/scfgxtrn.c 1.57 1.58 diff

    Log Message:
    Resolve memory leaks found by clang scan-build (mostly, or all, in error
    conditions) - e.g. if a malloc or realloc failed, then some other allocated
    memory would be leaked.
  437. rswindell
    Fri Mar 09 2018 07:19 pm PST

    Modified Files:
    src/sbbs3/bat_xfer.cpp 1.37 1.38 diff
    src/sbbs3/getmail.c 1.15 1.16 diff
    src/sbbs3/js_bbs.cpp 1.162 1.163 diff
    src/sbbs3/js_global.c 1.371 1.372 diff
    src/sbbs3/js_msgbase.c 1.218 1.219 diff
    src/sbbs3/js_system.c 1.168 1.169 diff
    src/sbbs3/sbbs.h 1.473 1.474 diff
    src/sbbs3/sbbsecho.c 3.71 3.72 diff

    Log Message:
    Resolve memory leaks found by clang scan-build (mostly, or all, in error
    conditions) - e.g. if a malloc or realloc failed, then some other allocated
    memory would be leaked.
  438. rswindell
    Fri Mar 09 2018 06:19 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.675 1.676 diff

    Log Message:
    Resolve clang scan-build warning about JS write_raw() method potentially
    calling putcom() with a len value of 0 (which triggers an auto-string-length
    grab via strlen() which should be 0 - but.. meh).
  439. deuce
    Fri Mar 09 2018 06:04 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.457 1.458 diff

    Log Message:
    Don't socket recv() errors for TLS sessions.
  440. deuce
    Fri Mar 09 2018 05:57 pm PST

    Modified Files:
    src/sbbs3/websrvr.c 1.657 1.658 diff

    Log Message:
    Resolve (?) clang crash on FreeBSD-CURRENT (!)
  441. deuce
    Fri Mar 09 2018 05:53 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.456 1.457 diff
    src/sbbs3/js_socket.c 1.198 1.199 diff
    src/sbbs3/mailsrvr.c 1.642 1.643 diff
    src/sbbs3/services.c 1.310 1.311 diff
    src/sbbs3/ssl.c 1.31 1.32 diff
    src/sbbs3/ssl.h 1.12 1.13 diff
    src/sbbs3/websrvr.c 1.656 1.657 diff

    Log Message:
    More betterer crypt logging...
    Things return allocated pointers with errors in them now.
    FTP server updated, the rest to follow "soon".
  442. rswindell
    Fri Mar 09 2018 05:10 pm PST

    Modified Files:
    exec/load/binkp.js 1.75 1.76 diff

    Log Message:
    Inlcude more more version details in the log output (so I can stop having
    to ask sysops after they've already pasted log output into a help request).
    Also, include the sbbs version in the BinkP "VER" message excahanged with
    the BinkP peer.
  443. rswindell
    Fri Mar 09 2018 05:10 pm PST

    Modified Files:
    exec/binkit.js 1.54 1.55 diff

    Log Message:
    Inlcude more more version details in the log output (so I can stop having
    to ask sysops after they've already pasted log output into a help request).
    Also, include the sbbs version in the BinkP "VER" message excahanged with
    the BinkP peer.
  444. rswindell
    Fri Mar 09 2018 04:01 pm PST

    Modified Files:
    src/sbbs3/sbbs_ini.c 1.162 1.163 diff

    Log Message:
    Fix some potential NULL dereferences in sbbs_write_ini() (if 'bbs' arg was
    passsed as NULL) found by scan-build.
  445. rswindell
    Fri Mar 09 2018 03:54 pm PST

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.53 1.54 diff

    Log Message:
    Initialize some variables to quiet scan-build.
  446. rswindell
    Fri Mar 09 2018 03:41 pm PST

    Modified Files:
    src/sbbs3/userdat.c 1.185 1.186 diff

    Log Message:
    Don't use the node value if it's garbage (unset by getnodedat).
    Thanks scan-build!
  447. deuce
    Fri Mar 09 2018 02:02 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.455 1.456 diff

    Log Message:
    Use crypt_ll() in the FTP server.
  448. deuce
    Fri Mar 09 2018 01:50 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.30 1.31 diff
    src/sbbs3/ssl.h 1.11 1.12 diff

    Log Message:
    Add crypt_ll(int) function that returns "the" appropriate log level for
    a cryptlib error code.
  449. deuce
    Fri Mar 09 2018 01:42 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.454 1.455 diff
    src/sbbs3/ssl.c 1.29 1.30 diff
    src/sbbs3/ssl.h 1.10 1.11 diff

    Log Message:
    First pass at updating the cryptlib log messages... step one, the FTP server.
  450. deuce
    Fri Mar 09 2018 12:51 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.28 1.29 diff
    src/sbbs3/ssl.h 1.9 1.10 diff

    Log Message:
    These functions take a CRYPT_HANDLE, not just a CRYPT_SESSION.
  451. deuce
    Fri Mar 09 2018 12:28 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.27 1.28 diff
    src/sbbs3/ssl.h 1.8 1.9 diff

    Log Message:
    Export get_crypt_error_string()
  452. deuce
    Fri Mar 09 2018 12:25 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.26 1.27 diff

    Log Message:
    Copy error descriptions from cryptlib.h into get_error_string() so we should
    always get a string in cryptlib errors.  Places that don't get an error
    string should now since it should always be useful.
  453. deuce
    Fri Mar 09 2018 12:04 pm PST

    Modified Files:
    src/sbbs3/js_global.c 1.370 1.371 diff

    Log Message:
    sp = p, not 0.
    (fix last commit)
  454. deuce
    Fri Mar 09 2018 12:03 pm PST

    Modified Files:
    src/sbbs3/js_global.c 1.369 1.370 diff

    Log Message:
    Fix spectacularly bad bug in the cksum_calc() global method.
    Thanks scan-build!
  455. deuce
    Fri Mar 09 2018 11:48 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.197 1.198 diff

    Log Message:
    When close() is called on an external socket (for example, from a service),
    call shutdown(sock, SHUT_RDWR) to do the TCP close, but leave the socket
    descriptor valid for the caller to clean up.
  456. deuce
    Fri Mar 09 2018 10:25 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.196 1.197 diff

    Log Message:
    Fix build error.
  457. deuce
    Fri Mar 09 2018 12:56 am PST

    Modified Files:
    src/smblib/base64.c 1.28 1.29 diff

    Log Message:
    Use the same comparison order so as not to confuse port scan-build.
  458. deuce
    Thu Mar 08 2018 11:46 pm PST

    Modified Files:
    src/xpdev/link_list.c 1.60 1.61 diff

    Log Message:
    Allow passing LAST_NODE to listRemoveNodes() for people who don't know that
    listRemoveNode() exists.
  459. deuce
    Thu Mar 08 2018 11:03 pm PST

    Modified Files:
    src/xpdev/xpevent.c 1.15 1.16 diff

    Log Message:
    And the final unused assignment... care of... SCAN-BUILD! \o/
  460. deuce
    Thu Mar 08 2018 11:02 pm PST

    Modified Files:
    src/syncterm/term.c 1.336 1.337 diff

    Log Message:
    Remove more unneeded assigmnents.
    Thanks scan-build!
  461. deuce
    Thu Mar 08 2018 10:59 pm PST

    Modified Files:
    src/syncterm/syncterm.c 1.217 1.218 diff

    Log Message:
    Remove more unused assignments.
    Thanks scan-build!
  462. deuce
    Thu Mar 08 2018 10:57 pm PST

    Modified Files:
    src/conio/bitmap_con.c 1.135 1.136 diff

    Log Message:
    Removed unused variable that got zeroed extra hard.
    Thanks scan-build!
  463. deuce
    Thu Mar 08 2018 10:55 pm PST

    Modified Files:
    src/conio/cterm.c 1.239 1.240 diff

    Log Message:
    Fix various useless assignments.
    Thanks scan-build!
  464. rswindell
    Thu Mar 08 2018 10:55 pm PST

    Modified Files:
    CVSROOT/loginfo 1.31 1.32 diff

    Log Message:
    Send commit message to synchro.net instead of vert.synchro.net, work-around
    for vert's IRCd not accepting new clients lately.
  465. deuce
    Thu Mar 08 2018 10:53 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.158 1.159 diff

    Log Message:
    Remove bad second check.
  466. deuce
    Thu Mar 08 2018 10:52 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.157 1.158 diff

    Log Message:
    The idea was to NULL check *before* passing to iniGetSectionList().
    Derp.
    Thanks DigitalMan!
  467. deuce
    Thu Mar 08 2018 10:48 pm PST

    Modified Files:
    src/conio/curs_cio.c 1.39 1.40 diff

    Log Message:
    Fix setvideoflags() in curses.  Did nothing.
    Thanks scan-build!
  468. rswindell
    Thu Mar 08 2018 10:47 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.641 1.642 diff

    Log Message:
    Remove "(ftn_addr)" portion of "To name", if it exists, in SMTP-submitted
    FidoNet netmail messages.
    Fix problem reported by Rastus and Nelgin.
  469. deuce
    Thu Mar 08 2018 10:45 pm PST

    Modified Files:
    src/syncterm/syncterm.c 1.216 1.217 diff

    Log Message:
    We don't need to call getenv("HOME") twice in a row to be extra super-sure
    the value is there.
    Thanks scan-build!
  470. deuce
    Thu Mar 08 2018 10:44 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.156 1.157 diff

    Log Message:
    More paranoia.  Still hard to hit unless you hate yourself.
    Thanks scan-build!
  471. deuce
    Thu Mar 08 2018 10:35 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.155 1.156 diff

    Log Message:
    Protect against NULL dereference
    Found by scan-build.
  472. deuce
    Thu Mar 08 2018 10:28 pm PST

    Modified Files:
    src/conio/ciolib.c 1.170 1.171 diff

    Log Message:
    Fix impossible to hit bug.
    Found by scan-build.
  473. deuce
    Thu Mar 08 2018 10:20 pm PST

    Modified Files:
    src/conio/cterm.c 1.238 1.239 diff

    Log Message:
    Fix use of uninitialized value when more than 16 bits of colour channel
    information are specified in an xterm rgb: color definition.
    Found by scan-build.
  474. deuce
    Thu Mar 08 2018 10:13 pm PST

    Modified Files:
    src/conio/cterm.c 1.237 1.238 diff

    Log Message:
    Fix potential NULL dereference on illegal strings commands.
    Found by scan-build.
  475. deuce
    Thu Mar 08 2018 10:11 pm PST

    Modified Files:
    src/xpdev/str_list.c 1.48 1.49 diff

    Log Message:
    Fix bug in last commit.
  476. deuce
    Thu Mar 08 2018 10:05 pm PST

    Modified Files:
    src/xpdev/str_list.c 1.47 1.48 diff

    Log Message:
    Fix a pair of unlikely memory leaks on realloc() failure found by scan-build.
  477. deuce
    Thu Mar 08 2018 10:01 pm PST

    Modified Files:
    src/syncterm/fonts.c 1.28 1.29 diff

    Log Message:
    Fix memory leak when quitting (meh)
    Found by scan-build.
  478. deuce
    Thu Mar 08 2018 09:50 pm PST

    Modified Files:
    src/xpdev/xpbeep.c 1.96 1.97 diff

    Log Message:
    Fix memory leak found by scan-build.
  479. deuce
    Thu Mar 08 2018 09:34 pm PST

    Modified Files:
    src/conio/cterm.c 1.236 1.237 diff

    Log Message:
    "fix" "issue" found by scan-build.
    Not impressed yet.  :-)
  480. rswindell
    Thu Mar 08 2018 08:54 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.640 1.641 diff

    Log Message:
    Log the message number when failing to increment delivery attempt counter.
  481. rswindell
    Thu Mar 08 2018 08:53 pm PST

    Modified Files:
    src/smblib/smblib.c 1.175 1.176 diff

    Log Message:
    A couple of the smb last_error strings had "index" and "header"
    conflated. Added " file" as well.
  482. rswindell
    Thu Mar 08 2018 07:55 pm PST

    Modified Files:
    src/sbbs3/jsexec.c 1.197 1.198 diff

    Log Message:
    Output the name of the module that set the exit_code.
  483. rswindell
    Thu Mar 08 2018 07:54 pm PST

    Modified Files:
    src/sbbs3/smbutil.c 1.121 1.122 diff

    Log Message:
    Output a status line when a messages is imported/added to a msgbase.
  484. deuce
    Thu Mar 08 2018 07:18 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.195 1.196 diff

    Log Message:
    Fix that ole last commit.
  485. rswindell
    Thu Mar 08 2018 07:11 pm PST

    Modified Files:
    src/build/Common.gmake 1.106 1.107 diff

    Log Message:
    Define _GNU_SOURCE when targeting linux. This resolves a lot of warnings
    about undeclared functions (vasprintf and pthread_setname_np) when building
    sbbs3.
  486. rswindell
    Thu Mar 08 2018 06:40 pm PST

    Modified Files:
    src/xpdev/link_list.c 1.59 1.60 diff

    Log Message:
    Use the function pthread_mutex_initializer_np() in place of the macro
    (PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP) - when we defined _GNU_SOURCE,
    assigning that macro value to list->mutex triggers a GCC compiler error.
  487. rswindell
    Thu Mar 08 2018 06:23 pm PST

    Modified Files:
    src/xpdev/gen_defs.h 1.75 1.76 diff

    Log Message:
    Use the "long" printf specifier for file offset (off_t) when __LP64__
    is defined - resolves gcc warning in ftpsrvr.c.
  488. deuce
    Thu Mar 08 2018 05:34 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.194 1.195 diff

    Log Message:
    Actually implement the timeout specified in Socket.recv().
    This has apparently never been implemented for non-TLS sockets, but it
    is used by some.
  489. deuce
    Thu Mar 08 2018 05:02 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.453 1.454 diff

    Log Message:
    Fix up load access with MLSx
    Call FULLPATH() on local directories after changing
    Add cdir to MLSD in the bbs: mount
    Return full path in MLST
  490. deuce
    Thu Mar 08 2018 03:52 pm PST

    Modified Files:
    src/sbbs3/jsexec.c 1.196 1.197 diff

    Log Message:
    Interrupt syscalls on break_handler() signals.
  491. rswindell
    Thu Mar 08 2018 03:33 pm PST

    Modified Files:
    src/xpdev/xpprintf.c 1.58 1.59 diff

    Log Message:
    Don't redefine _GNU_SOURCE if it's already defined.
  492. deuce
    Thu Mar 08 2018 03:25 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.452 1.453 diff

    Log Message:
    Map date uploaded to the created fact.
  493. deuce
    Thu Mar 08 2018 02:05 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.451 1.452 diff

    Log Message:
    Add the unique fact to things that can have aliases in ftpalias.cfg
    (dirs and files).  Include the unique fact in aliases as well.  Clients can
    now tell that aliases are the same entry.
    
    For MLST <dir>, always return the full path of the dir instead of the
    specified or relative path.
    
    Likely some other minor fixes as well.
  494. deuce
    Thu Mar 08 2018 11:09 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.639 1.640 diff

    Log Message:
    We don't need any of this cleanup on TLS negotiation failure... in fact,
    free() the mailproc causes a double-free crash.
  495. deuce
    Thu Mar 08 2018 02:34 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.450 1.451 diff

    Log Message:
    Fix format of modify fact.
  496. deuce
    Thu Mar 08 2018 12:37 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.449 1.450 diff

    Log Message:
    Add support for ftpalias.cfg to parsepath().  Directory aliases now work
    like symlinks... note that they aren't shown as symlinks in the directory
    output, so it may be a bit of a surprise when relative paths are relative
    to the target rather than the alias.
  497. rswindell
    Thu Mar 08 2018 12:19 am PST

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.22 1.23 diff

    Log Message:
    Don't call the Progress callbacks when online != ON_REMOTE (e.g. running
    tasks in timed events).
  498. rswindell
    Thu Mar 08 2018 12:17 am PST

    Modified Files:
    src/sbbs3/pack_qwk.cpp 1.77 1.78 diff

    Log Message:
    Check the sbbs_t.online element rather than the cfg.node_num to filter
    excessive log output from packing-QWK events.
  499. rswindell
    Thu Mar 08 2018 12:05 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.448 1.449 diff

    Log Message:
    You need xpprintf.h for the vasprintf() prototype on Windows.
  500. deuce
    Wed Mar 07 2018 03:34 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.447 1.448 diff

    Log Message:
    Return an empty LIST or NLST listing if parsepath() fails.
AuthorCommitsLatest
rswindell262Sun Jul 15 2018 10:42 pm
deuce204Fri Jul 13 2018 11:07 am
nightfox18Mon Jun 25 2018 09:50 pm
echicken9Sat Apr 14 2018 10:27 pm
ree7Mon Mar 19 2018 04:56 pm

Dynamically generated in 5510 milliseconds