Synchronet CVS Commit Log

This is a log of the 2000 most recent changes in the Synchronet CVS repository.
  1. rswindell
    Wed Aug 15 2018 11:40 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgxfr2.c 1.54 1.55 diff

    Log Message:
    When importing file areas from a file (e.g. FILEGATE.ZXX), and the dir's
    "short name" (e.g. derived from the "AREA tag" from FILEGATE.ZXX) is the same
    as a pre-existing dir, just over-write that dir - don't create a new one.
  2. rswindell
    Wed Aug 15 2018 12:48 pm PDT

    Modified Files:
    src/sbbs3/con_out.cpp 1.86 1.87 diff

    Log Message:
    This is just something I noticed while looking into the change for the
    previous commit: don't clear the line counter or call pause() - which will
    do nothing - if the console abort flag is set.
  3. rswindell
    Wed Aug 15 2018 12:38 pm PDT

    Modified Files:
    src/sbbs3/putmsg.cpp 1.34 1.35 diff

    Log Message:
    This is a bit of a hack for Nelgin, who noticed that novice menu mode
    would not always auto-redisplay menu files when the user hits 'Q' (or 'N'
    or Ctrl-C) at auto-pause prompts:
    
    When displaying a "message" (e.g. file), if the console abort flag is set
    before a single line has been displayed, clear the abort flag. This most
    likely means a pause (hit a key) prompt was automatically displayed due to
    a clear screen code in the message/file and the user hit 'Q' or 'N' or
    Ctrl-C at the prompt. In this special case, don't treat that as an
    "abort message" command and keep displaying the message/file. 
    
    Once one or more lines in the message/file have been displayed, then the
    behavior is the same as before: a console abort (even as a result of an
    auto-pause prompt key) will stop the display of the current message/file.
  4. rswindell
    Tue Aug 14 2018 08:03 pm PDT

    Modified Files:
    exec/xtrn_sec.js 1.18 1.19 diff

    Log Message:
    Fix problem reported by Nelgin:
    In External programs after running Sycnrhonet BBS List you get
    "Returning to <BBS> - hit a key". If you presss Q you get a blank external
    menu menu rather than the full menu.
    The main problem was the line counter, so clearing after returning from
    executing an external program (unless the forced pause thing is on).
  5. rswindell
    Tue Aug 14 2018 07:53 pm PDT

    Modified Files:
    exec/nntpservice.js 1.124 1.125 diff

    Log Message:
    Count blank requests as "bogus commands".
    Throttle bogus command sending clients (one second per bogus command, accumulating).
  6. echicken
    Tue Aug 14 2018 08:24 am PDT

    Modified Files:
    exec/tickit.js 1.45 1.46 diff

    Log Message:
    seem like maybe addrs should be a array
  7. rswindell
    Tue Aug 14 2018 02:36 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.222 1.223 diff

    Log Message:
    Fix-up js_recvline() based on infinite error/log message report from Nelgin:
     term 0087 TLS ERROR 'Unexpected <Unknown type> (24) packet, expected application_data (23)' (-1) popping data
     message repeated 492 times: [ term 0087 TLS ERROR 'Unexpected <Unknown type> (24) packet, expected application_data (23)' (-1) popping data]
    
    When using TLS with a JS Socket object, if there was any kind of data error,
    the recvline() method would return a blank string rather than null/undefined.
    nntpservice.js just loops when it receives a blank string, so this caused an
    infinite loop (with disk-filling error log messages).
    
    First change: if no data has been received (i == 0) and there's any kind of 
    receive error or timeout or disconnection, just return null. And not undefined,
    but null (!) like in v3.15 (before the great JS engine update of 2000-mumble).
    Also, there appeared to be a JS_RESUMEREQUEST call missing in the TLS error
    return case - so that's another bug fixed.
    Commented on the magic return values for js_sock_read_check()
    and js_socket_recv().
    Simplified js_sock_read_check() return value a tad: let the caller decide if
    they want to do something special based on the value of 'i'.
    Added some comments to make this code more readable.
    
    We are now no longer treating the different error return values (0 and -1) from
    js_socket_recv() special in this function, but we dont' treat them special in
    any of the other calls in this file/object either, so that seems to be the
    norm.
  8. rswindell
    Tue Aug 14 2018 12:59 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.221 1.222 diff

    Log Message:
    The timeout parameter to js_socket_recv() is in seconds. I don't think
    Deuce really wanted to pass 1000 as a value here (use 1 instead). I don't
    know if this was an observable problem or not, but it certainly *looks*
    like a bug.
  9. deuce
    Thu Aug 09 2018 01:20 pm PDT

    Modified Files:
    exec/load/fido.js 1.33 1.34 diff

    Log Message:
    Have TickIT use the "closest" address in the From line.
    
    This may resolve Dumas Walker's issue with cross-domain TIC forwarding.
    This should really use the value from BinkpSourceAddress, but that would
    mean renaming that key and including it in the TicITCfg object, or
    creating a new SBBSEchoCfg object method or something, and I don't want
    to mess with the sbbsecho.ini format.
  10. deuce
    Thu Aug 09 2018 01:20 pm PDT

    Modified Files:
    exec/binkit.js 2.6 2.7 diff
    exec/tickit.js 1.44 1.45 diff

    Log Message:
    Have TickIT use the "closest" address in the From line.
    
    This may resolve Dumas Walker's issue with cross-domain TIC forwarding.
    This should really use the value from BinkpSourceAddress, but that would
    mean renaming that key and including it in the TicITCfg object, or
    creating a new SBBSEchoCfg object method or something, and I don't want
    to mess with the sbbsecho.ini format.
  11. deuce
    Thu Aug 09 2018 01:08 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.18 1.19 diff

    Log Message:
    Make ecfg a local variable, not a global one.
  12. deuce
    Thu Aug 09 2018 01:06 pm PDT

    Modified Files:
    exec/ircbots/weather/weather_commands.js 1.27 1.28 diff

    Log Message:
    Display the relative humidity as well.
  13. deuce
    Thu Aug 09 2018 01:05 pm PDT

    Modified Files:
    exec/ircbots/dis/dis.js 1.9 1.10 diff

    Log Message:
    Add null check.
  14. rswindell
    Wed Aug 08 2018 03:23 pm PDT

    Modified Files:
    src/smblib/smbtxt.c 1.33 1.34 diff

    Log Message:
    Additional fix to mime_getattachment() - terminate the filename at the
    first white-space character encountered.
  15. rswindell
    Wed Aug 08 2018 03:14 pm PDT

    Modified Files:
    src/smblib/smbtxt.c 1.32 1.33 diff

    Log Message:
    Fix potential buffer overrun in mime_getattachment() when the MIME
    'content-disposition' filename parameter is not terminated with a double-
    quote or semi-colon character.
  16. rswindell
    Tue Aug 07 2018 11:59 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.24 3.25 diff
    src/sbbs3/sbbsecho.c 3.91 3.92 diff
    src/sbbs3/rechocfg.c 3.31 3.32 diff
    src/sbbs3/echocfg.c 3.35 3.36 diff

    Log Message:
    Incremented version to 3.06
    Added version for Bill McGarrity: for each linked-node, a preferred
    local address (AKA) can be specified to be used as the source address
    when creating packets destined for that linked-node. If no local address
    is specified, the previous (best match) logic is used: find an AKA that
    has the same zone and net as the destination address, if none found, use
    the first address with the same zone.
  17. rswindell
    Mon Aug 06 2018 07:16 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.106 1.107 diff

    Log Message:
    If the user number is 0, don't open the user file (user.dat) - the read
    of the user record is going to fail anyway. *this* explains a lot of
    instances of the user.dat file being open concurrently, at least one per
    active thread with a JS context.
  18. rswindell
    Mon Aug 06 2018 05:49 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.105 1.106 diff

    Log Message:
    js_CreateUserObject(): if passed an internal user_t representation, the
    user data is thusly cached - set the 'cached' property member to TRUE. This
    prevents an unnecessary re-read of the user file and the leaving the user file
    (user.dat) open, at least for JS contexts that contain a "user" object. I don't
    think this explains the "too many open files" errors, but it explains at least
    *some* number of the user.dat open file descriptors.
  19. rswindell
    Thu Aug 02 2018 11:37 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.90 3.91 diff

    Log Message:
    Don't delete netmail file attachments: just because the netmail was exported
    to .msg file doesn't mean you should delete the file attachment! The .msg
    file will still be pointing to that file and it needs to be there.
    SBBSecho was silently failing to delete file attachments on my system, so
    I didn't see this problem. Oops. Anyway, this explains Al's problem with
    netmail attachments.
  20. rswindell
    Thu Aug 02 2018 11:27 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.726 1.727 diff

    Log Message:
    Fix conditions where event log messages could still be sent to the terminal
    server log output/window.
    Also added comment about an observed exception upon shutdown with regards to
    the node_threads_running counter (protected int) being accessed after
    destruction.
  21. rswindell
    Thu Aug 02 2018 11:25 pm PDT

    Modified Files:
    src/sbbs3/getmail.c 1.17 1.18 diff

    Log Message:
    delfattch() now returns FALSE if any of the file attachments could not be
    removed.
  22. rswindell
    Thu Aug 02 2018 11:24 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.486 1.487 diff

    Log Message:
    delfattch() returns BOOL now.
  23. rswindell
    Thu Aug 02 2018 11:18 pm PDT

    Modified Files:
    src/sbbs3/bulkmail.cpp 1.38 1.39 diff
    src/sbbs3/chat.cpp 1.77 1.78 diff
    src/sbbs3/con_hi.cpp 1.26 1.27 diff
    src/sbbs3/download.cpp 1.52 1.53 diff
    src/sbbs3/email.cpp 1.68 1.69 diff
    src/sbbs3/fido.cpp 1.61 1.62 diff
    src/sbbs3/listfile.cpp 1.63 1.64 diff
    src/sbbs3/netmail.cpp 1.50 1.51 diff
    src/sbbs3/newuser.cpp 1.72 1.73 diff
    src/sbbs3/postmsg.cpp 1.108 1.109 diff
    src/sbbs3/qwk.cpp 1.84 1.85 diff
    src/sbbs3/qwktomsg.cpp 1.66 1.67 diff
    src/sbbs3/readmail.cpp 1.79 1.80 diff
    src/sbbs3/readmsgs.cpp 1.104 1.105 diff
    src/sbbs3/scansubs.cpp 1.25 1.26 diff
    src/sbbs3/text_sec.cpp 1.15 1.16 diff
    src/sbbs3/tmp_xfer.cpp 1.48 1.49 diff
    src/sbbs3/un_rep.cpp 1.66 1.67 diff
    src/sbbs3/upload.cpp 1.60 1.61 diff
    src/sbbs3/useredit.cpp 1.50 1.51 diff
    src/sbbs3/writemsg.cpp 1.123 1.124 diff
    src/sbbs3/xtrn.cpp 1.237 1.238 diff

    Log Message:
    Removed a bunch of duplicate user aliases from log messages now that
    sbbs::lputs() will log the current user alias already, logline()->lputs() would
    create log messages with the user alias twice.
  24. rswindell
    Thu Aug 02 2018 10:48 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.89 3.90 diff

    Log Message:
    Log an error if one or more file attachments could not be deleted when
    attempted.
  25. rswindell
    Thu Aug 02 2018 10:47 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfg.c 1.96 1.97 diff

    Log Message:
    Fix gcc printf format warning.
  26. rswindell
    Wed Aug 01 2018 03:34 pm PDT

    Modified Files:
    exec/load/userprops.js 1.1 1.2 diff

    Log Message:
    Allow a default value to be passed to the get() method, fixes problem
    with email_sec.js:
    line 65: TypeError: addr_list.indexOf is not a function
  27. echicken
    Wed Aug 01 2018 02:57 pm PDT

    Modified Files:
    exec/nntpservice.js 1.123 1.124 diff

    Log Message:
    RFC3977-compliant handling of 2-digit year in NEWGROUPS.
    If yy <= current 2-digit year, yy is assumed to be from this century,
    else it is assumed to refer to the previous century.
  28. echicken
    Wed Aug 01 2018 02:15 pm PDT

    Modified Files:
    exec/nntpservice.js 1.122 1.123 diff

    Log Message:
    In the case of a two-digit year, run it through parseInt with radix 10.  On the off chance we look at a message area created from 2000-2009 this will help, I guess.
    Go back to putting month and day through parseInt, but specify radix 10.  In some *cough* older JS interpreters, parseInt likes to treat any string beginning with 0 as octal.
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt#Octal_interpretations_with_no_radix
  29. echicken
    Wed Aug 01 2018 01:57 pm PDT

    Modified Files:
    exec/nntpservice.js 1.121 1.122 diff

    Log Message:
    Removed check for js.global.file_cdate (unused, I think).
    Don't run month/day through parseInt.  On my system, parseInt('08') yields 0 while parseInt('8') yields 8.  Days/months < 10 end up being -1, which apparently doesn't bother the Date constructor.
  30. rswindell
    Tue Jul 31 2018 03:30 pm PDT

    Modified Files:
    src/sbbs3/gtkchat/objects.mk 1.1 1.2 diff

    Log Message:
    userdat.* now dependent on msgdate.*
  31. rswindell
    Mon Jul 30 2018 01:43 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.88 3.89 diff

    Log Message:
    Fix crash (segfault) reported in AreaFix handler for "-ALL", reported
    by Ragnarok@DOCKSUD.
  32. rswindell
    Mon Jul 30 2018 01:29 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.676 1.677 diff

    Log Message:
    Fix chk_email_addr() for strings which begin with a name, specifically for
    mail "To" and "From" header fields of the form: user name <user@addr> or
    "user name" <user@addr> - the email.can filtering would not work
  33. echicken
    Sun Jul 29 2018 04:10 pm PDT

    Modified Files:
    xtrn/ansiview/ansiview.js 1.25 1.26 diff

    Log Message:
    Handle extensionless files. Untested, totally fine I'm sure.
  34. rswindell
    Sun Jul 29 2018 01:21 am PDT

    Modified Files:
    src/sbbs3/getnode.cpp 1.48 1.49 diff

    Log Message:
    The trigger to print a CRLF before claling putmsg() from getnmsg() and
    getsmsg() is now based on the current console column (!=0), not the current
    node action.
  35. rswindell
    Sat Jul 28 2018 10:33 pm PDT

    Modified Files:
    src/sbbs3/execfunc.cpp 1.43 1.44 diff

    Log Message:
    Finish reversion of the rev 1.42 feature (save/reuse previous netmail addr)
  36. rswindell
    Sat Jul 28 2018 10:18 pm PDT

    Added Files:
    exec/privatemsg.js NONE 1.1 diff

    Log Message:
    A new module that can be used to replace the hard-coded private message
    hot key (Ctrl-P) handler.
    
    Currently, it behaves nearly identically to the hard-coded C++ function,
    but my plans are to intergrate the inter-BBS instant messaging functionality
    in here to make it easier to send and reply to instant messages.
    
    Install this module in SCFG->External Programs->Global Hot Key Events:
    Global Hot Key             Ctrl-P        
    Command Line               ?privatemsg.js
  37. rswindell
    Sat Jul 28 2018 10:01 pm PDT

    Modified Files:
    exec/email_sec.js 1.1 1.2 diff

    Log Message:
    Store a history (of 10) destination netmail addresses and pass them to
    console.getstr() so they can be recalled with the up/down arrow keys.
  38. rswindell
    Sat Jul 28 2018 09:57 pm PDT

    Modified Files:
    src/sbbs3/js_console.cpp 1.117 1.118 diff

    Log Message:
    Document (in jsdocs) the new history argument to console.getstr()
  39. rswindell
    Sat Jul 28 2018 09:53 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.485 1.486 diff
    src/sbbs3/getstr.cpp 1.31 1.32 diff
    src/sbbs3/js_console.cpp 1.116 1.117 diff

    Log Message:
    getstr() - both the C++ and JS (console method) versions, now accept an
    additional, optional, "history" argument - an array of strings that can
    be recalled/scrolled using the up/down arrow keys. Currently, I just plan
    to use this for netmail destination address recall, but it could be used
    other places easily enough.
  40. rswindell
    Sat Jul 28 2018 09:45 pm PDT

    Modified Files:
    exec/nntpservice.js 1.120 1.121 diff

    Log Message:
    More NEWGROUPS madness:
    If the "GMT" zone is not specified by the client, presume the date/time
    comparison values are in the server's local timezone. If the client and
    server are not in the same timezone, this could lead to confusing behavior.
  41. rswindell
    Sat Jul 28 2018 09:33 pm PDT

    Modified Files:
    src/sbbs3/inkey.cpp 1.55 1.56 diff

    Log Message:
    Change how the global hot key recursion control (hostkey_inside) works:
    from a counter, which allowed 2 depths of nesting (any 2 hot key handlers)
    to a bit-mask which disallows *any* hot key handler to be re-entrant, but
    you can enter any of the *other* hot key handlers from any *other* hot
    key handler.
    
    Previously, for example, you could hit Ctrl-P to enter the private message
    prompt and then Ctrl-P again to re-enter the private message prompt
    (recusively) - confusingly, requiring 2 'Q'uits to get back to whatever
    you were doing before you hit the first Ctrl-P. Been like this forever.
    Now, while in the Ctrl-P (private message) handler, hitting Ctrl-P again
    does nothing. But you can hit Ctrl-T, or Ctrl-K or any other global hot
    key and it'll work but those in turn will also disallow recursion of their
    own handlers.
  42. rswindell
    Sat Jul 28 2018 07:10 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.56 1.57 diff
    src/sbbs3/scfg/scfgsub.c 1.48 1.49 diff

    Log Message:
    Fixed bug introduced in rev 1.52 of scfgmsg.c: We're not displaying
    the data dir here, we're using it to delete the data files! This explains
    why sub data wasn't getting deleted when deleting a message group and
    answering "Yes" to the "Delete All Data in Group" dialog.
    Eliminated the "clearing ptrs" thing - not needed any more since the move
    from ptrs/*.ixb to user/*.subs files.
  43. rswindell
    Sat Jul 28 2018 07:05 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnode.c 1.33 1.34 diff

    Log Message:
    Cosmetic changes only (popups).
  44. rswindell
    Sat Jul 28 2018 07:05 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfg.c 1.95 1.96 diff

    Log Message:
    Cosmetic changes only (popups, mostly).
  45. rswindell
    Sat Jul 28 2018 06:10 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.55 1.56 diff
    src/sbbs3/scfg/scfgsub.c 1.47 1.48 diff

    Log Message:
    Improvements to importing message areas:
    - If an FTN Echo Tag is more than 25 chars, copy it to the newly created
      sub's "newsgroup" name
      (when exporting areas to echolists, use the newsgroup name for the FTN
      Area/Echo Tag field, if it's not blank)
    - Copied the duplicate internal code logic from the importing file areas
      code - it works a lot better
    
    With these changes I was able to successfully import 10247 areas from the
    usenet group listing he sent me (with 10258 areas listed). The areas that
    were over-written during import were due to the first 63 characters of the
    newsgroup names being duplicated - sorry, that's the best I can do.
  46. rswindell
    Sat Jul 28 2018 06:01 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfg.c 1.94 1.95 diff

    Log Message:
    More status pop-ups when exiting SCFG and saving changes.
  47. rswindell
    Sat Jul 28 2018 06:00 pm PDT

    Modified Files:
    src/uifc/uifc.h 1.92 1.93 diff

    Log Message:
    Increase the maximum number of menu options from 10,000 to 100,000 to
    accommodate configurations of more than 10,000 things (e.g. sub-boards)
    in a single menu (e.g. message group).
    This brings this value over the 16-bit thresholds (0x7ffff and 0xffff)
    where problems could happen if short's/int16's are used to capture the
    return value of uifc.list(), but that's unlikely happening anywhere. Still
    a good idea to make sure if you're using this library/headers.
  48. rswindell
    Sat Jul 28 2018 05:27 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.87 3.88 diff

    Log Message:
    When adding a new sub-board to the area file, if the sub has a "newsgroup"
    name specified, use that instead of the short name as the "Echo Tag"
    (Area Tag) value.
  49. rswindell
    Sat Jul 28 2018 05:26 pm PDT

    Modified Files:
    src/sbbs3/load_cfg.c 1.73 1.74 diff

    Log Message:
    Remove dots (.) from internal codes auto-generated from other strings.
  50. rswindell
    Sat Jul 28 2018 05:17 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfg.c 1.93 1.94 diff

    Log Message:
    Fix a couple of cosmetic things with the -import command.
  51. rswindell
    Sat Jul 28 2018 05:15 pm PDT

    Modified Files:
    src/sbbs3/js_msg_area.c 1.70 1.71 diff

    Log Message:
    Fix apparent typo in revision 1.69 by deuce
  52. rswindell
    Sat Jul 28 2018 03:27 pm PDT

    Modified Files:
    src/sbbs3/scfgsave.c 1.75 1.76 diff

    Log Message:
    When attempting to create message base during config-save, make sure the
    full path to the data dir is created first (note: md() calls mkpath()).
    write_msgs_cfg() will now return FALSE if any message bases couldn't be
    created, but nobody is checking the return value currently.
  53. rswindell
    Sat Jul 28 2018 03:04 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgsub.c 1.46 1.47 diff

    Log Message:
    Fix bug introduced in rev 1.41:
    If there were any sub-boards in the group of a newly created sub-board,
    the newly created sub-board would not have the "HDRMOD" misc flag set, so
    its data files would not be created when saving changes/exiting SCFG.
  54. rswindell
    Sat Jul 28 2018 01:13 pm PDT

    Modified Files:
    exec/nntpservice.js 1.119 1.120 diff

    Log Message:
    NEWGROUPS command, again:
    only list a newsgroup (sub-board) if all of these conditions are true:
    1. It has a .ini file that can be opened
    2. It has a "Created" value and it's later than (or equal to) the requested
       date/time
    3. The message base can be opened
  55. rswindell
    Sat Jul 28 2018 01:10 am PDT

    Modified Files:
    exec/nntpservice.js 1.118 1.119 diff

    Log Message:
    Simplify the NEWGROUPS response (msg area list) filtering:
    - Removed the file "ctime" check as it's not accurate - oh well
    - Removed the index record check - not a good idea (msg purging and all)
    - If the "Created" key in the msgbase.ini file doesn't exist, it's
      obviously not a new msg area! :-)
  56. rswindell
    Fri Jul 27 2018 07:32 pm PDT

    Modified Files:
    exec/nntpservice.js 1.117 1.118 diff

    Log Message:
    Experimental fix for NEWGROUPS command:
    - compares date with the "Created" key in the subs .ini file (if it has one)
    - compare date against the oldest message index record, if there is one
  57. rswindell
    Fri Jul 27 2018 04:39 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.169 1.170 diff

    Log Message:
    Fixed a couple of issues with the last commit.
    Make similar enhancements to the bbs.put_node_message() method:
    - if you message text is given, it is prompted for
    - if no node number is given, it is prompted for
    - if a node number value of -1 is specified, send message to all nodes
    - logs the activity
  58. rswindell
    Fri Jul 27 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.168 1.169 diff

    Log Message:
    bbs.put_telegram() enhancements (mostly copy/pasted from chat.cpp):
    - now creates a log entry that the user sent a telegram to somebody
    - if a destination user number is not specified, one is prompted for
    - the destination user number is compared against the current user's
      restrictions (e.g. F-restricted users can't telegram the sysop)
    - if a telegram message text is not specified, one is prompted for
    
    unrelated fix to bbs.list_msgs(): if a 'find' argument was passed, too many
    increments of argn in call to macro: JSVALUE_TO_MSTRING
  59. rswindell
    Fri Jul 27 2018 02:37 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.167 1.168 diff

    Log Message:
    Fix copy/paste errors in previous commit.
  60. rswindell
    Fri Jul 27 2018 02:32 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.166 1.167 diff

    Log Message:
    New JS 'bbs' properties:
    node_status - reflects the current node's 'status' value (see nodedefs.js)
    node_errors - current node's error counter
    node_useron - current node's logged-in user number (if applicable, else 0)
    node_connection - current node's connection rate or protocol
    node_misc - see nodedefs.js
    node_aux - see nodedefs.js
    node_extaux - see nodedefs.js
    
    This are read-only wrappers around the sbbs_t::thisnode property and have
    the same fundamental meaning as the properties of the same names in the
    system.node_list[] array.
    
    bbs.node_action is a little different as it is the authorative action value
    that should be sync'd with the node database (node.dab) and not necessarily
    the current value in the node database - it's also writeable.
  61. rswindell
    Fri Jul 27 2018 02:02 pm PDT

    Modified Files:
    exec/hatchit.js 1.3 1.4 diff

    Log Message:
    Fix bug reported by Al @ TRMB:
    
    From FTS-5006:
    "The CRC an eight digit hex number, preferably written in upper case"
    
    However hatchit was writing the CRC value in decimal notation.
  62. rswindell
    Thu Jul 26 2018 07:27 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.165 1.166 diff

    Log Message:
    Fix long-time JSDOC error: bbs.good_password() returns Boolean, not String.
  63. rswindell
    Thu Jul 26 2018 06:49 pm PDT

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.164 1.165 diff

    Log Message:
    Created 2 new bbs methods: select_node() and select_user().
    These are wrappers for the C++ function: sbbs::getnodetopage() and will
    be used by the privatemsg.js (Ctrl-P handler) and possibly other node/user
    interaction stuff in the future.
  64. rswindell
    Thu Jul 26 2018 06:23 pm PDT

    Modified Files:
    src/sbbs3/newuser.cpp 1.71 1.72 diff

    Log Message:
    Fixed GCC warning: format not a string literal and no format arguments
  65. rswindell
    Wed Jul 25 2018 11:24 pm PDT

    Modified Files:
    src/sbbs3/putnode.cpp 1.21 1.22 diff

    Log Message:
    putnodedat() - don't try to lock the node.dab file again (should be locked
    already with a call to getnodedat()).
    When using the MSVC2017 CRTL, a lock() of a region that was previously
    locked is a blocking call causing major slowness in the MSVC2017 build.
    This just reverses the 1-line commit from 16 years ago in rev 1.10 of this file.
  66. rswindell
    Wed Jul 25 2018 11:22 pm PDT

    Modified Files:
    src/sbbs3/getnode.cpp 1.47 1.48 diff

    Log Message:
    getnodedat() - don't try to unlock the node.dab file unless the read() fails.
    When using the MSVC2017 CRTL, an unlock() of a region that was not previously
    locked is a blocking call causing major slowness in the MSVC2017 build.
  67. rswindell
    Wed Jul 25 2018 11:21 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.203 1.204 diff

    Log Message:
    getuserdat() - if this function fails to open the user.dat file (e.g. it does
    not exist), set the user->number to 0 before returning as many callers of this
    function do not check the return value, just the value of user->number after
    it returns (ugh). This problem was discovered when running a fresh install,
    typing "1" at the Login prompt and immediately getting a "Time's Up" message
    and a disconnect - only happens when there's no data/user.dat file.
    
    getnodedat() - don't try to unlock the node.dab file unless the read() fails.
    When using the MSVC2017 CRTL, an unlock() of a region that was not previously
    locked is a blocking call causing major slowness in the MSVC2017 build.
    
    putmsgptrs() - cleans up obsolete sections in the data/user/*.subs files now.
    So if you go from say 10,000 sub-boards to 2,000, it won't have to load and
    search through the extra 8,000 invalid subs (once the file is re-written upon
    log-off). This requires an updated xpdev build (for iniAppendSectionWithKeys)
    
    fixmsgptrs() - if the msgbase index can't be opened or the last index record
    cannot be read (e.g. there isn't one), insure the msg-scan pointer value is
    set to 0 (not ~0).
  68. rswindell
    Wed Jul 25 2018 10:36 pm PDT

    Modified Files:
    src/xpdev/ini_file.c 1.163 1.164 diff
    src/xpdev/ini_file.h 1.55 1.56 diff

    Log Message:
    iniGetSection() no longer includes blank lines (if there are any in the
    section) in the returned stringlist.
    Created iniAppendSectionWithKeys(): similar to iniAppendSection, but a list
    of list of "key=[value]" strings (like those returned from iniGetSection())
    can be added at the same time.
  69. rswindell
    Wed Jul 25 2018 01:40 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.725 1.726 diff

    Log Message:
    More eprintf() to sbbs->lprintf() conversion.
  70. rswindell
    Wed Jul 25 2018 12:02 am PDT

    Modified Files:
    src/sbbs3/execfunc.cpp 1.42 1.43 diff

    Log Message:
    Revert the feature added in rev 1.42 of this file (save/re-use netmail
    destination addresses): this feature messed up the smeg@ address book
    Baja module.
    Use the email_sec.js module if you want this feature.
  71. rswindell
    Tue Jul 24 2018 11:28 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.724 1.725 diff

    Log Message:
    Strip control codes from strings logged with sbbs_t::lputs().
  72. rswindell
    Tue Jul 24 2018 11:23 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.723 1.724 diff

    Log Message:
    More useron number clearing after timed event segments.
  73. rswindell
    Tue Jul 24 2018 11:12 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.722 1.723 diff

    Log Message:
    Make sure the current user number is 0 when terminating the event thread
    or else we may end up with user names in log msgs that don't apply.
  74. rswindell
    Tue Jul 24 2018 11:07 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.236 1.237 diff

    Log Message:
    Another eprintf to lprintf change.
  75. rswindell
    Tue Jul 24 2018 09:20 pm PDT

    Modified Files:
    src/sbbs3/qwk.cpp 1.83 1.84 diff

    Log Message:
    Log an error if any files in the data/qnet/*.out directory could not be
    removed.
  76. rswindell
    Tue Jul 24 2018 09:20 pm PDT

    Modified Files:
    src/xpdev/dirwrap.c 1.100 1.101 diff
    src/xpdev/dirwrap.h 1.49 1.50 diff

    Log Message:
    delfiles() needs to return a signed value (long, not ulong) to indicate
    a faliure.
    delfiles() now returns a negative result upon any deletion errors.
  77. rswindell
    Tue Jul 24 2018 09:00 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.721 1.722 diff

    Log Message:
    More eprintf() to sbbs->lputs/lprintf() replacements.
  78. rswindell
    Tue Jul 24 2018 08:43 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.484 1.485 diff

    Log Message:
    Resolve warning: ISO C++ forbids converting a string constant to ΓÇÿchar*ΓÇÖ
  79. rswindell
    Tue Jul 24 2018 08:39 pm PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.97 1.98 diff
    src/sbbs3/con_out.cpp 1.85 1.86 diff
    src/sbbs3/data_ovl.cpp 1.26 1.27 diff
    src/sbbs3/logfile.cpp 1.61 1.62 diff
    src/sbbs3/logout.cpp 1.30 1.31 diff
    src/sbbs3/main.cpp 1.720 1.721 diff
    src/sbbs3/pack_qwk.cpp 1.79 1.80 diff
    src/sbbs3/sbbs.h 1.483 1.484 diff
    src/sbbs3/xtrn.cpp 1.235 1.236 diff
    src/sbbs3/xtrn_sec.cpp 1.85 1.86 diff

    Log Message:
    sbbs_t::lputs() now handles the adding of the log message prefixes
    ("Node X", user alias, etc.) - so removing a lot of the redundancies.
    Also, logging the current timed event code and other prefixes in the
    event thread log messages - something I've wanted for a while now.
    There might be some redundant "Node X" strings, so if you see some funny
    looking log message, please let me know.
  80. rswindell
    Tue Jul 24 2018 05:40 pm PDT

    Modified Files:
    src/sbbs3/atcodes.cpp 1.80 1.81 diff
    src/sbbs3/execmisc.cpp 1.55 1.56 diff
    src/sbbs3/getstr.cpp 1.30 1.31 diff
    src/sbbs3/listfile.cpp 1.62 1.63 diff
    src/sbbs3/pack_qwk.cpp 1.78 1.79 diff
    src/sbbs3/readmsgs.cpp 1.103 1.104 diff
    src/sbbs3/sbbs.h 1.482 1.483 diff
    src/sbbs3/str.cpp 1.79 1.80 diff
    src/sbbs3/writemsg.cpp 1.122 1.123 diff

    Log Message:
    Enable GCC printf-format checking for more printf-style functions and
    fix the resulting warnings.
  81. rswindell
    Tue Jul 24 2018 05:24 pm PDT

    Modified Files:
    src/sbbs3/un_rep.cpp 1.65 1.66 diff

    Log Message:
    A little better error reporting on bad .REP packets.
  82. rswindell
    Tue Jul 24 2018 04:55 pm PDT

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.25 1.26 diff

    Log Message:
    Even more details (number of subs) in the "read message ... pointers"
    debug log msg.
  83. rswindell
    Tue Jul 24 2018 04:37 am PDT

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.24 1.25 diff
    src/sbbs3/msgdate.c 1.6 1.7 diff
    src/sbbs3/userdat.c 1.202 1.203 diff

    Log Message:
    Reduce the amount of time to load msg ptrs/config from *.subs files even
    more (!) by removing the sections from the total file string list, once parsed.
    Fixed a couple of minor and unlikely off-by-one errors with message ptrs
    based on date/time.
  84. rswindell
    Tue Jul 24 2018 01:41 am PDT

    Modified Files:
    src/sbbs3/ntsvcs.c 1.48 1.49 diff
    src/sbbs3/sbbs_ini.c 1.163 1.164 diff
    src/sbbs3/sbbscon.c 1.270 1.271 diff
    src/sbbs3/startup.h 1.80 1.81 diff

    Log Message:
    Remove/deprecate trailing references to the "SYSOP_AVAILABLE" startup
    option - the sysop chat availability is now controlled via semaphore
    file (ctrl/sysavail.chat).
  85. rswindell
    Tue Jul 24 2018 01:39 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.201 1.202 diff

    Log Message:
    Small optimization here: don't read the last msg idx twice.
  86. rswindell
    Tue Jul 24 2018 01:38 am PDT

    Modified Files:
    ctrl/sbbs.ini 1.75 1.76 diff

    Log Message:
    Removed a trailing reference to the SYSOP_AVAILABLE option (controlled
    via BBS/terminal server startup option flags, now controlled via semfile).
  87. rswindell
    Tue Jul 24 2018 12:03 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.200 1.201 diff

    Log Message:
    Fix major faux pas in previous commit - whoops.
  88. rswindell
    Mon Jul 23 2018 11:39 pm PDT

    Modified Files:
    src/sbbs3/objects.mk 1.69 1.70 diff

    Log Message:
    userdat.* now requires msgdate.*
  89. rswindell
    Mon Jul 23 2018 11:39 pm PDT

    Modified Files:
    src/sbbs3/umonitor/objects.mk 1.3 1.4 diff

    Log Message:
    userdat.* now requires msgdate.*
  90. rswindell
    Mon Jul 23 2018 11:38 pm PDT

    Modified Files:
    src/sbbs3/uedit/objects.mk 1.3 1.4 diff

    Log Message:
    userdat.* now requires msgdate.*
  91. rswindell
    Mon Jul 23 2018 11:29 pm PDT

    Modified Files:
    src/sbbs3/scfg/objects.mk 1.16 1.17 diff
    src/sbbs3/scfg/scfg.vcxproj 1.5 1.6 diff

    Log Message:
    msgdate.* is now needed by userdat.*, for newmsgs() function.
  92. rswindell
    Mon Jul 23 2018 10:36 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.199 1.200 diff

    Log Message:
    Speed-up getmsgptrs() (reads users/data/*.subs files) by only parsing
    each section (sub-code) once. Should cut the search/parse algorithm by 66%
    (since there's 3 keys/values we're searching for, per sub).
  93. rswindell
    Mon Jul 23 2018 10:15 pm PDT

    Modified Files:
    src/smblib/smblib.c 1.179 1.180 diff
    src/smblib/smblib.h 1.86 1.87 diff

    Log Message:
    Singificantlly improve message scan pointer initialization (e.g. for new
    users) and adjusting scan ptrs by date or set to "Last msg" while online:
    - speed (on my system, reduced from 12 to < 2 seconds)
      This involved 2 enhancements: check msgbase index file timestamp (fast)
      before opening any files. When opening the msgbase, just open the index
      file (no other msgbase files) - required new smblib function: smb_open_index.
    - fixed off-by-one when setting by date (when setting the new-scan ptr to
      Jan-1-2018, you want that first message posted on/after Jan-1-2018 to be
      found as "new", not the first message posted *after* that date.
    - re-added the fixmsgptrs() call in putmsgptrs(), inadvertently removed
      in the .ixb -> .ini ptr storage update in rev 1.192 of userdat.c.
  94. rswindell
    Mon Jul 23 2018 10:15 pm PDT

    Modified Files:
    src/sbbs3/getmsg.cpp 1.73 1.74 diff
    src/sbbs3/msgdate.c 1.5 1.6 diff
    src/sbbs3/sbbs.h 1.481 1.482 diff
    src/sbbs3/scansubs.cpp 1.24 1.25 diff
    src/sbbs3/text_defaults.c 1.46 1.47 diff
    src/sbbs3/userdat.c 1.198 1.199 diff

    Log Message:
    Singificantlly improve message scan pointer initialization (e.g. for new
    users) and adjusting scan ptrs by date or set to "Last msg" while online:
    - speed (on my system, reduced from 12 to < 2 seconds)
      This involved 2 enhancements: check msgbase index file timestamp (fast)
      before opening any files. When opening the msgbase, just open the index
      file (no other msgbase files) - required new smblib function: smb_open_index.
    - fixed off-by-one when setting by date (when setting the new-scan ptr to
      Jan-1-2018, you want that first message posted on/after Jan-1-2018 to be
      found as "new", not the first message posted *after* that date.
    - re-added the fixmsgptrs() call in putmsgptrs(), inadvertently removed
      in the .ixb -> .ini ptr storage update in rev 1.192 of userdat.c.
  95. rswindell
    Mon Jul 23 2018 06:20 pm PDT
    src/xpdev truncsp.c 1.3 NONE
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv11037
    
    Removed Files:
    	truncsp.c 
    Log Message:
    This file was not used by anything (thankfully, truncsp is defined in genwrap).
  96. rswindell
    Mon Jul 23 2018 06:13 pm PDT

    Modified Files:
    src/xpdev/conwrap.c 1.14 1.15 diff
    src/xpdev/conwrap.h 1.5 1.6 diff
    src/xpdev/dat_file.c 1.7 1.8 diff
    src/xpdev/dat_file.h 1.3 1.4 diff
    src/xpdev/dirwrap.h 1.48 1.49 diff
    src/xpdev/eventwrap.h 1.3 1.4 diff
    src/xpdev/filewrap.c 1.45 1.46 diff
    src/xpdev/filewrap.h 1.36 1.37 diff
    src/xpdev/netwrap.c 1.6 1.7 diff
    src/xpdev/netwrap.h 1.4 1.5 diff
    src/xpdev/semfile.h 1.1 1.2 diff
    src/xpdev/semwrap.c 1.14 1.15 diff
    src/xpdev/semwrap.h 1.15 1.16 diff
    src/xpdev/threadwrap.c 1.35 1.36 diff
    src/xpdev/threadwrap.h 1.50 1.51 diff
    src/xpdev/wrapdll.h 1.6 1.7 diff
    src/xpdev/xpendian.h 1.5 1.6 diff
    src/xpdev/xpevent.c 1.16 1.17 diff
    src/xpdev/xpevent.h 1.5 1.6 diff
    src/xpdev/xpmap.c 1.7 1.8 diff
    src/xpdev/xpmap.h 1.4 1.5 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  97. rswindell
    Mon Jul 23 2018 06:13 pm PDT

    Modified Files:
    src/uifc/uifc.c 1.30 1.31 diff
    src/uifc/uifctest.c 1.7 1.8 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  98. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/smblib/crc16.c 1.7 1.8 diff
    src/smblib/crc16.h 1.6 1.7 diff
    src/smblib/crc32.c 1.11 1.12 diff
    src/smblib/crc32.h 1.16 1.17 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  99. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sexpots/sexpots.c 1.30 1.31 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  100. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/umonitor/chat.c 1.18 1.19 diff
    src/sbbs3/umonitor/chat.h 1.4 1.5 diff
    src/sbbs3/umonitor/spyon.c 1.14 1.15 diff
    src/sbbs3/umonitor/spyon.h 1.2 1.3 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  101. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgmdm.c 1.5 1.6 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  102. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/menuedit/menuedit.c 1.5 1.6 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  103. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/install/sbbsinst.c 1.98 1.99 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  104. rswindell
    Mon Jul 23 2018 06:12 pm PDT

    Modified Files:
    src/sbbs3/gtkuseredit/gtkuseredit.glade 1.18 1.19 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  105. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/execvxd/sbbsexec.cpp 1.2 1.3 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  106. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/dosxtrn/dosxtrn.c 1.23 1.24 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  107. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/ctrl/AboutBoxFormUnit.cpp 1.12 1.13 diff
    src/sbbs3/ctrl/AboutBoxFormUnit.dfm 1.19 1.20 diff
    src/sbbs3/ctrl/AboutBoxFormUnit.h 1.5 1.6 diff
    src/sbbs3/ctrl/ClientFormUnit.cpp 1.14 1.15 diff
    src/sbbs3/ctrl/ClientFormUnit.h 1.5 1.6 diff
    src/sbbs3/ctrl/CodeInputFormUnit.cpp 1.3 1.4 diff
    src/sbbs3/ctrl/CodeInputFormUnit.h 1.3 1.4 diff
    src/sbbs3/ctrl/CtrlPathDialogUnit.cpp 1.2 1.3 diff
    src/sbbs3/ctrl/CtrlPathDialogUnit.h 1.2 1.3 diff
    src/sbbs3/ctrl/EventsFormUnit.cpp 1.2 1.3 diff
    src/sbbs3/ctrl/EventsFormUnit.h 1.3 1.4 diff
    src/sbbs3/ctrl/FtpCfgDlgUnit.h 1.7 1.8 diff
    src/sbbs3/ctrl/FtpFormUnit.h 1.6 1.7 diff
    src/sbbs3/ctrl/LoginAttemptsFormUnit.cpp 1.6 1.7 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.h 1.21 1.22 diff
    src/sbbs3/ctrl/MailFormUnit.h 1.6 1.7 diff
    src/sbbs3/ctrl/NodeFormUnit.cpp 1.28 1.29 diff
    src/sbbs3/ctrl/NodeFormUnit.h 1.10 1.11 diff
    src/sbbs3/ctrl/PreviewFormUnit.cpp 1.4 1.5 diff
    src/sbbs3/ctrl/PreviewFormUnit.h 1.4 1.5 diff
    src/sbbs3/ctrl/PropertiesDlgUnit.h 1.19 1.20 diff
    src/sbbs3/ctrl/ServicesFormUnit.h 1.7 1.8 diff
    src/sbbs3/ctrl/SpyFormUnit.cpp 1.13 1.14 diff
    src/sbbs3/ctrl/SpyFormUnit.h 1.9 1.10 diff
    src/sbbs3/ctrl/StatsFormUnit.cpp 1.2 1.3 diff
    src/sbbs3/ctrl/StatsFormUnit.h 1.2 1.3 diff
    src/sbbs3/ctrl/StatsLogFormUnit.cpp 1.3 1.4 diff
    src/sbbs3/ctrl/StatsLogFormUnit.h 1.1.1.1 1.2 diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.h 1.17 1.18 diff
    src/sbbs3/ctrl/TelnetFormUnit.h 1.6 1.7 diff
    src/sbbs3/ctrl/TextFileEditUnit.cpp 1.5 1.6 diff
    src/sbbs3/ctrl/TextFileEditUnit.h 1.2 1.3 diff
    src/sbbs3/ctrl/WebFormUnit.h 1.5 1.6 diff
    src/sbbs3/ctrl/sbbsctrl.bpr 1.46 1.47 diff
    src/sbbs3/ctrl/sbbsctrl.cpp 1.20 1.21 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  108. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/chat/MainFormUnit.cpp 1.7 1.8 diff
    src/sbbs3/chat/MainFormUnit.h 1.2 1.3 diff
    src/sbbs3/chat/chat.cpp 1.3 1.4 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  109. rswindell
    Mon Jul 23 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/ars_defs.h 1.12 1.13 diff
    src/sbbs3/cmdshell.h 1.13 1.14 diff
    src/sbbs3/dat_rec.h 1.3 1.4 diff
    src/sbbs3/execmisc.cpp 1.54 1.55 diff
    src/sbbs3/fossdefs.h 1.2 1.3 diff
    src/sbbs3/getstats.c 1.3 1.4 diff
    src/sbbs3/ident.h 1.5 1.6 diff
    src/sbbs3/msdirent.c 1.2 1.3 diff
    src/sbbs3/msdirent.h 1.3 1.4 diff
    src/sbbs3/putnode.cpp 1.20 1.21 diff
    src/sbbs3/ringbuf.h 1.13 1.14 diff
    src/sbbs3/riodefs.h 1.1.1.1 1.2 diff
    src/sbbs3/sbbs4defs.h 1.5 1.6 diff
    src/sbbs3/sbbsdefs.h 1.221 1.222 diff
    src/sbbs3/sbbsexec.c 1.40 1.41 diff
    src/sbbs3/sexyz.h 1.12 1.13 diff
    src/sbbs3/telnet.h 1.16 1.17 diff
    src/sbbs3/text_defaults.c 1.45 1.46 diff
    src/sbbs3/text_sec.cpp 1.14 1.15 diff
    src/sbbs3/uartdefs.h 1.5 1.6 diff
    src/sbbs3/uucode.h 1.1 1.2 diff
    src/sbbs3/v4upgrade.c 1.15 1.16 diff
    src/sbbs3/vdd_func.h 1.9 1.10 diff
    src/sbbs3/viewfile.cpp 1.10 1.11 diff
    src/sbbs3/wordwrap.h 1.6 1.7 diff
    src/sbbs3/xmodem.h 1.23 1.24 diff
    src/sbbs3/yenc.h 1.1 1.2 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  110. rswindell
    Mon Jul 23 2018 06:10 pm PDT

    Modified Files:
    src/conio/ansi_cio.c 1.83 1.84 diff
    src/conio/ansi_cio.h 1.10 1.11 diff
    src/conio/curs_cio.c 1.40 1.41 diff
    src/conio/curs_cio.h 1.16 1.17 diff
    src/conio/curs_fix.h 1.2 1.3 diff
    src/conio/mouse.c 1.44 1.45 diff
    src/conio/vidmodes.h 1.28 1.29 diff
    src/conio/win32cio.c 1.107 1.108 diff
    src/conio/win32cio.h 1.14 1.15 diff
    src/conio/x_cio.c 1.49 1.50 diff
    src/conio/x_cio.h 1.24 1.25 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  111. rswindell
    Mon Jul 23 2018 06:10 pm PDT

    Modified Files:
    src/comio/comio.c 1.2 1.3 diff
    src/comio/comio.h 1.8 1.9 diff
    src/comio/comio_nix.c 1.12 1.13 diff
    src/comio/comio_win32.c 1.7 1.8 diff

    Log Message:
    The great Copyright year update and (mostly) removal of 2018:
    Most of the copyright years in the source code were misleading (the date of
    most recent publish was actually later) and all were unnecessary. I've been
    removing copyright years piecemeal, for a long time, but I decided it was time
    to just perform a bulk search and (mostly) replace. In some cases, I left
    old copyright years on files that either are not used (and soon to be removed)
    or obsolete and unlikely to ever be touched again (e.g. Win9x FOSSIL VXD). Some
    of the runtime binaries still contain copyright years and those were updated to
    2018.
  112. rswindell
    Mon Jul 23 2018 06:02 pm PDT

    Modified Files:
    docs/copyright.html 1.6 1.7 diff

    Log Message:
    The beginning of the big copyright year removal/update.
  113. rswindell
    Mon Jul 23 2018 04:07 pm PDT

    Modified Files:
    ctrl/text.dat 1.84 1.85 diff

    Log Message:
    Added a rounded/estimated file size (in parenthesis) to the FiFileSize
    output. Example:
    File size        : 7,128,414 (6.8M) bytes
  114. rswindell
    Mon Jul 23 2018 04:06 pm PDT

    Modified Files:
    src/sbbs3/text_defaults.c 1.44 1.45 diff

    Log Message:
    Added a rounded/estimated file size (in parenthesis) to the FiFileSize
    output. Example:
    File size        : 7,128,414 (6.8M) bytes
  115. rswindell
    Mon Jul 23 2018 04:05 pm PDT

    Modified Files:
    src/sbbs3/qwk.cpp 1.82 1.83 diff
    src/sbbs3/file.cpp 1.34 1.35 diff

    Log Message:
    Added a rounded/estimated file size (in parenthesis) to the FiFileSize
    output. Example:
    File size        : 7,128,414 (6.8M) bytes
  116. rswindell
    Mon Jul 23 2018 03:52 pm PDT

    Modified Files:
    src/xpdev/genwrap.c 1.108 1.109 diff
    src/xpdev/genwrap.h 1.113 1.114 diff

    Log Message:
    Add a precision argument to byte_estimate_to_str() so the caller can control
    the number of decimal places in the resulting string.
  117. rswindell
    Mon Jul 23 2018 03:41 pm PDT

    Modified Files:
    src/sbbs3/listfile.cpp 1.61 1.62 diff

    Log Message:
    Fix bug introduced in rev 1.60: when searching for a file and a single file
    matches the search spec, the 'D' batch-flagging command would invoke the
    downloadfile() method which confusingly, doesn't actually download (send)
    the file, but instead performs all the post-download functions needed. So
    the user would just see "<filename> sent." and possibly lose some credits
    without actually receiving the file.
  118. rswindell
    Thu Jul 19 2018 10:44 pm PDT

    Modified Files:
    src/xpdev/genwrap.c 1.107 1.108 diff
    src/xpdev/genwrap.h 1.112 1.113 diff

    Log Message:
    Fixed strcasestr() for Windows - oops.
    Created byte_estimate_to_str(), much like byte_count_to_str(), except the
    byte count is rounded to the nearest tera/giga/mega/kilo-byte
    (technically tebi/gibi/mebi/kibi-byte, but ugh, I'm old-sk00l!).
  119. rswindell
    Thu Jul 19 2018 07:50 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.675 1.676 diff

    Log Message:
    Remove redundant calls to remove_mgs_instransit() from sendmail_open_socket()
  120. rswindell
    Thu Jul 19 2018 06:38 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.h 1.86 1.87 diff

    Log Message:
    Fix the GCC format attribute thing to match the new sockprintf() prototype.
  121. rswindell
    Thu Jul 19 2018 06:34 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.674 1.675 diff
    src/sbbs3/mailsrvr.h 1.85 1.86 diff
    src/sbbs3/mime.c 1.11 1.12 diff
    src/sbbs3/mime.h 1.5 1.6 diff
    src/sbbs3/services.c 1.322 1.323 diff

    Log Message:
    Cosmetic/helpful improvements to the log output (a lot of search and replace).
    The "official" log line format is (as of right now at least):
    "[socket] [protocol] [user/host-ID] [! if error]message"
    Hopefully I can remember that when I add new log messages.
    
    Also setting the protocol to SMTPS, POP3S, SEND/TLS, when appropriate and
    passing it around to pretty much any function that can log a message.
    Added debug-level log output when the mail sever is sending message body text
    (every 100 lines).
  122. rswindell
    Thu Jul 19 2018 04:18 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.673 1.674 diff

    Log Message:
    Fix SMTP-sending mail bug when SMTP/TLS was successfully negotiated:
    The "max lines" parameter value passed to sockmsgtxt was using the cryptlib
    session number - this would truncate sent email bodies to some seemingly
    random number of lines. Introduced in rev 1.622.
    Also added a couple of helpful log lines to let the log-reader know if/when
    TLS was successfully negotiated for sendmail sessions.
  123. rswindell
    Thu Jul 19 2018 11:23 am PDT

    Modified Files:
    src/xpdev/genwrap.c 1.106 1.107 diff
    src/xpdev/genwrap.h 1.111 1.112 diff

    Log Message:
    Create a strcasestr() implementation for MSVC (Windows) builds.
  124. rswindell
    Wed Jul 18 2018 09:44 pm PDT

    Modified Files:
    src/sbbs3/dupefind.c 1.4 1.5 diff

    Log Message:
    Update the indent/brace style in this ancient source file.
  125. rswindell
    Wed Jul 18 2018 09:13 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.23 3.24 diff
    src/sbbs3/sbbsecho.c 3.86 3.87 diff
    src/sbbs3/rechocfg.c 3.30 3.31 diff
    src/sbbs3/echocfg.c 3.34 3.35 diff

    Log Message:
    Added a "MinFreeDiskSpace" setting to the root section of sbbsecho.ini
    (defaults to 10 megabytes, "10M").
    When SBBSecho starts up, if this minimum amount of free space is not
    available in any of the following directories, SBBSecho will display an
    error and immediately exit:
    - data directory (in SCFG)
    - logs directory (in SCFG)
    - netmail directory (in SCFG)
    - outbound directory (from sbbsecho.ini)
    - temp directory
    - each linked-node's outbox, if configured
    
    If the sysop runs out of disk space for some reason, at least SBBSecho
    won't contribute to the problem.
  126. rswindell
    Wed Jul 18 2018 03:42 pm PDT

    Modified Files:
    ctrl/sbbsecho.ini 1.4 1.5 diff

    Log Message:
    Added vkradio (zone 432) DNS suffix.
  127. rswindell
    Tue Jul 17 2018 09:50 pm PDT

    Modified Files:
    src/sbbs3/delfiles.c 1.9 1.10 diff

    Log Message:
    Update brace style in this ancient source file.
  128. rswindell
    Tue Jul 17 2018 09:12 pm PDT

    Modified Files:
    ctrl/sbbsecho.ini 1.3 1.4 diff

    Log Message:
    fsxNet now has a domain for DNS-based address look-ups.
  129. nightfox
    Tue Jul 17 2018 08:11 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.122 1.123 diff
    xtrn/DDMsgReader/readme.txt 1.18 1.19 diff

    Log Message:
    Version 1.17 beta 63: Just before showing the message list or changing to another message area from the reader interface, it now writes "Loading..." in case there are a very large number of messages or sub-boards.
  130. rswindell
    Mon Jul 16 2018 11:31 pm PDT

    Modified Files:
    src/smblib/smbadd.c 1.39 1.40 diff
    src/smblib/smballoc.c 1.12 1.13 diff
    src/smblib/smblib.c 1.178 1.179 diff

    Log Message:
    fread() and fwrite() do not set 'errno' to a meaningful value upon failure,
    so remove 'errno' value (and corresponding error strings) from generated
    /logged error messages. fseek(), read(), write(), open(), etc. do set errno
    to a meaningful value, so we still log errno/strerror() in those failure
    cases.
  131. rswindell
    Mon Jul 16 2018 10:42 pm PDT

    Modified Files:
    src/sbbs3/chksmb.c 1.62 1.63 diff

    Log Message:
    Replace the hard-coded beep/BEL characters in the "Hit any key to continue..."
    prompts with the conditional beep enabled only with the '-b' option
    (silent by default). Thanks to Nelgin.
  132. rswindell
    Sun Jul 15 2018 10:42 pm PDT

    Modified Files:
    src/sbbs3/js_msgbase.c 1.220 1.221 diff

    Log Message:
    Rename this private_t.status to private_t.smb_result, to avoid confusion
    with smb_t.status.
  133. rswindell
    Sun Jul 15 2018 12:53 am PDT

    Modified Files:
    src/sbbs3/filelist.c 1.19 1.20 diff

    Log Message:
    Brace-style update of this ancient source file.
  134. deuce
    Fri Jul 13 2018 11:07 am PDT

    Modified Files:
    exec/ircbots/ham/ham.js 1.32 1.33 diff

    Log Message:
    Add 10min/hr/day change stats.
  135. deuce
    Fri Jul 13 2018 12:43 am PDT

    Modified Files:
    exec/ircbots/ham/ham.js 1.31 1.32 diff

    Log Message:
    Add bands command for real-time conditions from bandconditions.com
  136. rswindell
    Sun Jul 08 2018 06:36 pm PDT

    Modified Files:
    exec/binkit.js 2.5 2.6 diff

    Log Message:
    Fix the "too much recursion" error when running from JSexec, need a different
    log prefix solution.
  137. rswindell
    Sun Jul 08 2018 04:55 pm PDT

    Modified Files:
    exec/load/binkp.js 1.108 1.109 diff

    Log Message:
    Fix potential infinite loop in send_chunks(), some versions of Socket.send()
    can return false on error, which is >= 0, so this will just add 0 to the
    length and keep on looping forever in that case.
  138. deuce
    Sun Jul 08 2018 04:44 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.220 1.221 diff

    Log Message:
    Update documentation to match the behaviour... send() returns undefined,
    not null on failure.
  139. deuce
    Sun Jul 08 2018 04:33 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.219 1.220 diff

    Log Message:
    Fix js_send() to conform to documentation.
    Also, is that some line ending weirdness?  *shrug*
  140. rswindell
    Sun Jul 08 2018 03:38 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.127 1.128 diff

    Log Message:
    Added support for referencing a message on the command-line with the
    'l' (list messages), 'x' (dump index), 'r' (read msgs), and 'v' (view msgs)
    commands by "days old", by specifying a negative number (in days).
    (e.g. "smbutil r-30" would read messages posted within the past 30 days).
    This was added to test the smb_getmsgidx_by_time() function, but has some
    value otherwise I suppose.
  141. rswindell
    Sun Jul 08 2018 03:10 pm PDT

    Modified Files:
    exec/load/binkp.js 1.107 1.108 diff

    Log Message:
    Fix what appears to be a few potential infinite loops where
    recvFrame() is being called in a loop and only breaking on specific
    conditions or if recvFrame returned undefined. Problem is, on timeout,
    recvFrame returns null (and when using === comparision, undefined !== null).
    Also added more debug output around sends where I suspect there might be
    another potential infinite loop.
  142. rswindell
    Sun Jul 08 2018 02:50 pm PDT

    Modified Files:
    exec/load/binkp.js 1.106 1.107 diff

    Log Message:
    More log output around connecting to a node.
    I suspect that connect() may be blocking and causing Al's reported issue
    (A BinkIT poll never returns from the script and goes into some kind of
    infinite busy loop).
  143. rswindell
    Sun Jul 08 2018 02:48 pm PDT

    Modified Files:
    exec/binkit.js 2.4 2.5 diff

    Log Message:
    More log output when connecting to an outbound node and when an inbound
    file already exists.
    Also, insure all log messages are prefixed with "BinkIT:".
  144. rswindell
    Sat Jul 07 2018 09:02 pm PDT

    Modified Files:
    src/smblib/smblib.c 1.177 1.178 diff

    Log Message:
    smb_lockmsghdr() - if the 'locked' smb instance property is already set,
    don't try to (re)lock it, just return SMB_SUCCESS.
    
    I honestly don't recall why I made this change, but it makes sense, so I'm
    committing it finally.
  145. rswindell
    Sat Jul 07 2018 08:51 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.197 1.198 diff

    Log Message:
    smb_getmsgidx_by_time() can now return positive integers on success.
  146. rswindell
    Sat Jul 07 2018 08:50 pm PDT

    Modified Files:
    src/smblib/smblib.c 1.176 1.177 diff
    src/smblib/smblib.h 1.85 1.86 diff

    Log Message:
    Re-write of smb_getmsgidx_by_time() - using a proper binary search
    algorithm now. Also, now returns the index offset of the matched index
    (if found), negative error value otherwise.
    
    I was testing something and noticed that the old smb_getmsgidx_by_time()
    implementation could sometimes return the index of a message posted before
    the requested time. That was fixed by re-writing the binary search logic.
    
    Also, I found it useful in my testing to have this function return the
    offset of the matching index (in addition to the index record itself), so
    checks of the return value need to compare >= SMB_SUCCESS, not just ==
    or != SMB_SUCCESS.
  147. rswindell
    Sat Jul 07 2018 12:52 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.96 1.97 diff

    Log Message:
    For SSH and RLogin 'logins', use the mastchuser() function rather than
    userdatdupe() to match the passed login-id (username):
    *  This allows more permissive username matching, e.g. if your user name
       is "Analog Kid", you could login with "analogkid", "analog.kid" or
       "analog_kid", which is handy when passing a user name on the command
       line (e.g. to an ssh client) for example.
    *  This is the same function used for Telnet logins via exec/login.js
  148. rswindell
    Sat Jul 07 2018 12:30 am PDT

    Modified Files:
    src/sbbs3/text_defaults.c 1.43 1.44 diff

    Log Message:
    Added @-codes to the SubGroupOrAll and DirLisstOrAll prompts (mnemonics)
    so that the current sub/group and dir/lib short name is displayed as
    part of the prompt.
  149. rswindell
    Sat Jul 07 2018 12:29 am PDT

    Modified Files:
    ctrl/text.dat 1.83 1.84 diff

    Log Message:
    Added @-codes to the SubGroupOrAll and DirLisstOrAll prompts (mnemonics)
    so that the current sub/group and dir/lib short name is displayed as
    part of the prompt.
  150. rswindell
    Sat Jul 07 2018 12:22 am PDT

    Modified Files:
    src/sbbs3/getkey.cpp 1.46 1.47 diff

    Log Message:
    mnemonic strings (those with tilde's to indicate the command-keys), now support
    @-codes within them. Previously, only if the entire mnemonic string was
    comprised of an @-code would it be expanded, now any @-codes within will expand
    as well.
  151. rswindell
    Fri Jul 06 2018 11:14 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.78 1.79 diff

    Log Message:
    Restore the 'U' command back to "User Edit" and commented-out the 
    experimental 'U' (View Unread-Only toggle) command. The 'U' command from
    the e-mail menu (e.g. email_sec.js) works better than the toggle approach and
    is probably all that is needed.
    Also, the user number lookup in the User Edit bit is better at finding the
    proper user account (e.g. for received netmail).
  152. rswindell
    Tue Jul 03 2018 10:42 pm PDT

    Modified Files:
    exec/dyndns.js 1.14 1.15 diff

    Log Message:
    Add support for a [dyndns] section in ctrl/modopts.ini for the following
    settings (keys): mx, ip, ip6
    
    This allows you to specify a long string (e.g. address) here without
    exceeding the 63 char external program command-line limit.
  153. rswindell
    Tue Jul 03 2018 04:52 pm PDT

    Modified Files:
    exec/dyndns.js 1.13 1.14 diff

    Log Message:
    Don't log 'null' if Socket.readline() returns null.
  154. rswindell
    Tue Jul 03 2018 03:58 pm PDT

    Modified Files:
    exec/dyndns.js 1.12 1.13 diff

    Log Message:
    Added '-ip6' option to specify your (optional) IPv6 address on the
    command-line.
  155. rswindell
    Sun Jul 01 2018 08:05 pm PDT

    Modified Files:
    ctrl/ircd.conf 1.12 1.13 diff

    Log Message:
    Added exmaple C/N lines for connecting to cvs.synchro.net too.
  156. rswindell
    Sun Jul 01 2018 02:40 am PDT

    Modified Files:
    src/sbbs3/con_hi.cpp 1.25 1.26 diff
    src/sbbs3/con_out.cpp 1.84 1.85 diff

    Log Message:
    So Nelgin noticed that in novice (non-expert) menu mode, the A/S/D cmds
    from the Chat menu would immediately clear the screen and redisplay the
    menu after displaying the change in the node's state. This was due to the
    enhancement in rev 1.77 of con_out.cpp whereby we no longer increment
    lncntr if the first lines displayed after a key-press are blank (who
    cares if blank lines scroll off the screen?). That's fine and all, but the
    auto-pause check in outchar(FF) would only auto-pause if the line-counter
    was greater than *one* (has been this way since forever). So with the
    enhancement in 1.77, a single non-blank line displayed after a key-press
    was now not enough to trigger the auto-pause ([Hit a Key] prompt).
    So I've changed the line-counter trigger value to greater than *zero*,
    which means we could have some new excessive auto-pauses, but other places
    where auto-pause wasn't working, should again.
    
    One new excessive auto-pause was after the system password was entered at
    the SY: prompt, so that fix is included in this commit.
  157. rswindell
    Sat Jun 30 2018 12:41 pm PDT

    Modified Files:
    web/root/msgs/msgs.ssjs 1.43 1.44 diff

    Log Message:
    Why was this truncating displayed message subjects to 50 chars? No one will
    ever know. Make the max subject length 70 (like Synchronet).
  158. rswindell
    Fri Jun 29 2018 07:51 pm PDT

    Modified Files:
    src/sbbs3/baja.c 1.49 1.50 diff

    Log Message:
    If the BAJAINCLUDE environment variable is set (new!), use that path as the
    default location to find !include'd baja (*.inc) files. If you use the '-I'
    option, it will override the environment variable setting. For Nelgin.
  159. rswindell
    Fri Jun 29 2018 06:11 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.719 1.720 diff

    Log Message:
    Fix problem with socket-I/O external programs executed while the client
    using SSH: the output from the program (file transfer driver, door game)
    would reach the SSH client, but input from the client (or user) would not
    reach the external program:
    passthru_output_thread() - responsible for SSH input from the client/user
    to be sent to a "raw" pass-through socket used by the external program,
    had a reversed logic bug added around rev 1.686.
    Problem was introduced as part of the cryptlib update/SSH overhaul of 
    early 2018. Thanks to Thumper @ THEWASTE for the bug report!
  160. rswindell
    Thu Jun 28 2018 03:07 pm PDT

    Modified Files:
    ctrl/sbbsecho.ini 1.2 1.3 diff

    Log Message:
    Added list of known domains (including "othernets" provided by Tony Langdon).
    We should try to keep this list current to assist new sysops, so feedback is
    welcome.
    Also read/saved using EchoCfg, so it added all the supported keys with default
    values.
    Updated the default Inbound directory
     (from /binkd/inbound to ../fido/nonsecure)
    Updated the default Outbound directory
     (from /binkd/outbound to ../fido/outbound)
  161. nightfox
    Mon Jun 25 2018 09:50 pm PDT

    Modified Files:
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js 1.13 1.14 diff

    Log Message:
    Update for the feature of not showing the latest message date & time in the sub-board lists.
  162. nightfox
    Mon Jun 25 2018 09:35 pm PDT

    Modified Files:
    xtrn/DDAreaChoosers/DDFileAreaChooser.js 1.11 1.12 diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.cfg 1.3 1.4 diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js 1.12 1.13 diff
    xtrn/DDAreaChoosers/readme.txt 1.2 1.3 diff
    xtrn/DDAreaChoosers/revision_history.txt 1.2 1.3 diff

    Log Message:
    Version 1.17: For the message area chooser, added a new configuration file option, showDatesInSubBoardList, that specifies whether or not to show the date & time of the latest message in the sub-boards.
  163. rswindell
    Mon Jun 25 2018 02:14 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.38 1.39 diff

    Log Message:
    Disable the FTN NetMail source address selection (chooser) by default -
    the sysop must now enable this feature in SCFG->Networks->FidoNet.
    Also, widen the FidoNet configuration menu in SCFG, display more FTN
    addresses and the default origin line (part of it, at least) in the menu.
  164. rswindell
    Mon Jun 25 2018 02:13 pm PDT

    Modified Files:
    src/sbbs3/sbbsdefs.h 1.220 1.221 diff
    src/sbbs3/fido.cpp 1.60 1.61 diff

    Log Message:
    Disable the FTN NetMail source address selection (chooser) by default -
    the sysop must now enable this feature in SCFG->Networks->FidoNet.
  165. rswindell
    Mon Jun 25 2018 01:28 pm PDT

    Modified Files:
    exec/postmsg.js 1.2 1.3 diff

    Log Message:
    Clarify that 'mail' is a supported msgbase code.
  166. nightfox
    Mon Jun 25 2018 12:41 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.121 1.122 diff
    xtrn/DDMsgReader/readme.txt 1.17 1.18 diff

    Log Message:
    Version 1.17 beta 62: Made another fix to avoid the "Unknown destination" error when forwarding a message to a QWK-style address (such as "sysop@DIGDIST")
  167. nightfox
    Sun Jun 24 2018 10:05 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.120 1.121 diff
    xtrn/DDMsgReader/readme.txt 1.16 1.17 diff

    Log Message:
    Version 1.17 beta 61: Fixed a bug where it would report an "unknown destination" error when trying to forward a message to a FTN-style email address.
  168. rswindell
    Thu Jun 21 2018 01:24 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgxtrn.c 1.58 1.59 diff

    Log Message:
    Fixed typo (causing line-wrap) in online help.
  169. rswindell
    Thu Jun 21 2018 01:23 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.234 1.235 diff

    Log Message:
    Add clarification to the "No startup directory" error, that this is only
    for DOS programs (part of the USE_DOSEMU patch).
  170. rswindell
    Thu Jun 21 2018 01:22 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgchat.c 1.22 1.23 diff

    Log Message:
    Allow external chat pagers to have their "native" and "use shell" execution
    flags set manually in SCFG.
  171. rswindell
    Thu Jun 21 2018 01:22 pm PDT

    Modified Files:
    src/sbbs3/chat.cpp 1.76 1.77 diff

    Log Message:
    Allow external chat pagers to have their "native" and "use shell" execution
    flags set manually in SCFG.
  172. rswindell
    Tue Jun 19 2018 12:01 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.85 3.86 diff

    Log Message:
    When importing packets, don't export previously-rescanned messages
    (messages which contain the RESCANNED control line) to downlinks.
    
    Also renamed pkt_to_pkt() to write_to_pkts().
  173. rswindell
    Sun Jun 17 2018 06:28 pm PDT

    Modified Files:
    src/sbbs3/download.cpp 1.51 1.52 diff
    src/sbbs3/main.cpp 1.718 1.719 diff

    Log Message:
    Resolved some valgrind reported issues (likely, harmless):
    "Conditional jump or move depends on uninitialised value(s)"
    Thanks, Nelgin.
  174. rswindell
    Sun Jun 17 2018 12:26 pm PDT

    Modified Files:
    exec/load/fido.js 1.32 1.33 diff

    Log Message:
    Fix bug in parse_flo_file_path():
    If there's no zone in the specified path, the default_zone is used and that zone
    is a decimal number, not a hexadecimal string, so running parseInt(...,16)
    on it errorneously generates an incorrect outbound/FLO dir.
    This should fix the problem reported by Al @ TRMB.
  175. rswindell
    Mon Jun 11 2018 10:19 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.40 1.41 diff

    Log Message:
    Fix TLS/SSL failure/error: "creating SSL context"
    If the ctrl/ssl.cert file did not exist, the various TLS/SSL services would
    fail to create it and (sometimes) log the "creating SSL context" error.
    This problem was introduced with rev 1.30 (Mar-9) and the fix/patch
    provided by Deuce via irc. Thanks to Psi-Jack for the bug report.
  176. rswindell
    Mon Jun 11 2018 01:00 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.672 1.673 diff

    Log Message:
    Added log output for a couple of instances where get_ssl_cert() could
    (previuosly) silently fail - in the sendmail_negotiate() and pop3_thread().
    If get_ssl_cert() can return -1 withOUT setting the estr argument to a
    non-NULL value, then we could still have silent failures (TBD).
  177. rswindell
    Sun Jun 10 2018 02:47 am PDT

    Modified Files:
    text/menu/e-mail.asc 1.2 1.3 diff

    Log Message:
    New menu to correspond with new email_sec.js module (loaded by updated Baja cmd
    shells: default, wwiv, wildcat, pcboard).
    - Added (U)n-read messages only command.
    - Renamed (U)pload file to (A)ttach file.
  178. rswindell
    Sun Jun 10 2018 02:09 am PDT

    Modified Files:
    exec/default.src 1.20 1.21 diff
    exec/pcboard.src 1.9 1.10 diff
    exec/wildcat.src 1.12 1.13 diff
    exec/wwiv.src 1.5 1.6 diff
    exec/email_sec.js NONE 1.1 diff

    Added Files:
    	email_sec.js 
    Log Message:
    Replaced the Baja "E-mail Section" code block that was copy/pasted into several
    shells with a new single/unified JS module (email_sec.js):
    - New (U)n-read mail read command ('A' is now for sending file attachments)
    - I didn't update to the renegade shell since it has a custom menu file
    - This module will work with older Synchronet builds, without netmail file
      attachments
    - The old Baja code still works, however... less Baja = rounder Earth
  179. rswindell
    Sun Jun 10 2018 02:00 am PDT

    Modified Files:
    src/sbbs3/getmail.c 1.16 1.17 diff

    Log Message:
    Code cleanup in delfattach().
  180. rswindell
    Sun Jun 10 2018 01:57 am PDT

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.23 1.24 diff

    Log Message:
    Log an error if putmsgptrs() fails (e.g. out of disk space?).
  181. rswindell
    Sun Jun 10 2018 01:56 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.196 1.197 diff

    Log Message:
    putmsgptrs() will now return FALSE if iniWriteFile() returns FALSE
    (out of disk space?).
  182. rswindell
    Sun Jun 10 2018 01:54 am PDT

    Modified Files:
    src/sbbs3/js_msg_area.c 1.69 1.70 diff

    Log Message:
    Add (finally) fido_netmail_settings and inet_netmail_settings (bit-field)
    properties to msg_area object. See NMAIL_* in sbbsdefs.js for the bit values.
  183. rswindell
    Sun Jun 10 2018 01:53 am PDT

    Modified Files:
    src/sbbs3/data.cpp 1.30 1.31 diff
    src/sbbs3/js_bbs.cpp 1.163 1.164 diff
    src/sbbs3/readmail.cpp 1.77 1.78 diff
    src/sbbs3/sbbs.h 1.480 1.481 diff

    Log Message:
    JS bbs object changes:
    - finduser() method no longer prints "Unknown user" upon failure (the calling
      script can do this if/when it wants).
    - read_mail() method now accepts an optional 3rd argumnet (loadmail_mode)
      which may be used to load *only* un-read mail (for example), see LM_* in
      sbbsdefs.js
    
    Pass the lm_mode as a 4th argument to any readmail mod (if one is installed) -
    this correlates with the LM_* mode flag values (0 is normal/usual).
    
    File attachments can also be in a file/####.out directory (e.g. outbound
    Internet email attachments), so try deleting from there too when deleting
    mail with attachments.
  184. rswindell
    Sun Jun 10 2018 01:45 am PDT

    Modified Files:
    src/sbbs3/email.cpp 1.67 1.68 diff

    Log Message:
    Insure the WM_EMAIL mode flag is set when calling writemsg() from email()
    - similar to what we do in netmail() with the WM_NETMAIL flag.
    If you call writemsg() without WM_EMAIL set, it tries to use the subnum as an
    index into the sub-board array and will crash.
  185. rswindell
    Sun Jun 10 2018 01:39 am PDT

    Modified Files:
    src/sbbs3/textgen.c 1.10 1.11 diff

    Log Message:
    text.js now ends in "this;" allowing cool load usage like this:
    var text = load({}, 'text.js');
  186. rswindell
    Sun Jun 10 2018 01:37 am PDT

    Added Files:
    exec/load/userprops.js NONE 1.1 diff

    Log Message:
    New load/library module to make read/writing to user "properties"
    (stored in data/user/*.ini) easy.
  187. rswindell
    Sun Jun 10 2018 01:35 am PDT

    Modified Files:
    exec/load/text.js 1.22 1.23 diff

    Log Message:
    Added new OriginFidoAddr item.
    text.js now ends in "this;" allowing cool load usage like this:
    var text = load({}, 'text.js');
  188. rswindell
    Sun Jun 10 2018 01:34 am PDT

    Modified Files:
    exec/load/sbbsdefs.js 1.77 1.78 diff

    Log Message:
    Added the missing MM_* (msg_area.settings) flag definitions.
    Added loadmail mode (LM_*) definitions for new bbs.read_mail() argument
    (optional).
  189. rswindell
    Fri Jun 08 2018 05:38 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.76 1.77 diff

    Log Message:
    A little beautification of the unread msg only toggle output.
  190. rswindell
    Fri Jun 08 2018 05:24 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.75 1.76 diff

    Log Message:
    getmail() can only check the presence of an attribute flag currently
    (not the absense), so we need to call it twice to find out if there are
    any unread messages for the user.
  191. rswindell
    Fri Jun 08 2018 02:59 pm PDT

    Modified Files:
    src/sbbs3/readmail.cpp 1.74 1.75 diff

    Log Message:
    Experimental feature: 'U' command toggles un-read mail visibility.
    Change the 'Edit Author's user account' command to '!' (for now).
  192. rswindell
    Wed Jun 06 2018 07:35 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.104 1.105 diff

    Log Message:
    Updated the JSDOC description of a few User properties.
  193. rswindell
    Wed Jun 06 2018 07:21 pm PDT

    Modified Files:
    src/sbbs3/js_user.c 1.103 1.104 diff

    Log Message:
    Improve JS User class/object reads across a local network by leaving the
    user.dat file open (for read operations only). Writing still opens and
    closes the user.dat for each property/field modification.
  194. rswindell
    Wed Jun 06 2018 04:07 pm PDT

    Added Files:
    exec/load/birthdays.js NONE 1.1 diff

    Log Message:
     Library to return a list of users with a specified birthday or birthmonth
  195. rswindell
    Wed Jun 06 2018 02:44 pm PDT

    Modified Files:
    exec/load/birthdate.js 1.3 1.4 diff

    Log Message:
     Fix typos in comments, add Id rcs keyword
  196. rswindell
    Wed Jun 06 2018 02:40 pm PDT

    Modified Files:
    exec/load/birthdate.js 1.2 1.3 diff

    Log Message:
     Fix previous change (__defineGetter__)
  197. rswindell
    Tue Jun 05 2018 11:25 pm PDT

    Modified Files:
    exec/fseditor.js 1.88 1.89 diff

    Log Message:
    Use the js.on_exit() method of restoring the bbs.sys_status and
    console.ctrlkey_passthru values. This allows these critical session
    settings to be restored even if/when fseditor.js crashes/abends
    (e.g. exits unexpectedly due to unhandled JS exception).
  198. rswindell
    Mon Jun 04 2018 05:01 pm PDT

    Modified Files:
    ctrl/text.dat 1.82 1.83 diff

    Log Message:
    Added OriginFidoAddr text item.
  199. rswindell
    Mon Jun 04 2018 04:55 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.33 3.34 diff

    Log Message:
    Moved all the BSO/BinkP settings to the end of the Global Settings menu and
    made their display conditional on mailer-type being set to FLO/BSO.
    Added a help menu to the BinkP Settings menu (under Linked Nodes).
  200. rswindell
    Mon Jun 04 2018 03:02 pm PDT

    Modified Files:
    src/xpdev/sockwrap.h 1.54 1.55 diff

    Log Message:
    Added IPPORT_BINKP (TCP port number) definition.
  201. rswindell
    Mon Jun 04 2018 02:52 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.22 3.23 diff

    Log Message:
    Increment SBBSecho version to 3.05:
    more control over SBBS-initiated netmail source/origin addresses.
  202. rswindell
    Mon Jun 04 2018 02:50 pm PDT

    Modified Files:
    src/sbbs3/fido.cpp 1.59 1.60 diff
    src/sbbs3/text.h 1.31 1.32 diff
    src/sbbs3/text_defaults.c 1.42 1.43 diff

    Log Message:
    When the system has multiple configured FidoNet addressess (AKAs), let the
    user choose which address to use as the source address when composing a netmail
    message (the default being the most appropriate for the dest zone/net). This
    change only works with SBBSecho v3.05 or later.
    Some other incremental and safety improvements to sbbs_t::netmail() too.
    FTN netmail file attachments needs some more work however (the "FA:" subject
    prefix trick) - just remove it?
  203. rswindell
    Mon Jun 04 2018 01:56 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.84 3.85 diff

    Log Message:
    Another improvement to create_netmail():
    If the SMB header contains a source FTN address, use that as the origin address
    of the netmail and do not look-up a local AKA match for the destination address.
    Also, fix what appears to have been a (currently harmless) bug in
    smsg_to_echostat_msg(): the msg.from_net.addr is not an ASCIIZ string when
    net.type == NET_FIDO. Currently, source FTN addresses aren't set in echomail
    message headers, where the echostats come from. Could just remove
    these 2 lines.
  204. rswindell
    Mon Jun 04 2018 12:07 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.83 3.84 diff

    Log Message:
    Address RMH's issue:
    When the local system has multiple AKAs for the same zone and we are picking a
    origin/source address suitable for the destination address, pick the AKA that
    matches both the zone and net of the destination address first (if there is
    such a local AKA). It's the same logic used in sbbs_t::netmail() to display
    the originating address, so the AKA picking logic now matches what is shown
    to the netmail author and what SBBSecho will actually use.
  205. rswindell
    Tue May 22 2018 09:16 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.82 3.83 diff

    Log Message:
    Add a ^ARESCANNED w:x/y.z control line to exported messages during a rescan
    (apparently this is a pseudo-standard supported by fastecho and other
    "old-school" tossers) - per mark lewis' request.
  206. rswindell
    Tue May 22 2018 03:34 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.81 3.82 diff

    Log Message:
    When exporting msgs that came from an FTN (e.g. during a rescan), don't convert
    existing tear/origin lines and don't add a new origin line.
  207. rswindell
    Tue May 15 2018 03:41 pm PDT

    Modified Files:
    src/sbbs3/js_msgbase.c 1.219 1.220 diff

    Log Message:
    Fix get_msg_header() problem reported by Bill McGarrity:
    "expand fields" could be misinterpretted (e.g. as 'false') if less than 3
    args were passed to the function. Apparently you can NOT assume that argv[argc]
    is undefined and would fail a JSVAL_IS_BOOLEAN test. In the reported problem,
    MsgBase.get_msg_header() was being called with 2 arguments (from newslink.js)
    and the if(JSVAL_IS_BOOLEAN(argv[n])) test, when n was 2, would eval to true
    and then argv[n] evalulated as false, which would cause a message with no
    message ID to not have one dynamically created, which would then cause the
    message to fail to post to an NNTP server due to malformed Message-ID (a
    missing message "id" property would end up being included in the newsgropu
    article header as "Message-ID: undefined").
    
    get_msg_index() had a similar potential issue, also fixed.
  208. rswindell
    Mon May 14 2018 04:37 pm PDT

    Modified Files:
    exec/newslink.js 1.109 1.110 diff

    Log Message:
    If msgbase.get_msg_header() returns a header with no (undefined) message-ID
    header field, print/log an error and continue on (don't attempt to send to
    NNTP server). This won't solve Bill McGarrity's problem, but it might
    provide a clue (?).
  209. rswindell
    Mon May 14 2018 02:32 pm PDT

    Modified Files:
    exec/binkit.js 2.3 2.4 diff

    Log Message:
    Ignore sub-directories (e.g. *.pnt) of the outbound directory/ies in
    add_outbound_files(). The outbound/*.pnt sub-dirs are handled at a higher
    level.
  210. rswindell
    Thu May 10 2018 12:06 pm PDT

    Added Files:
    exec/msgutil.js NONE 1.1 diff

    Log Message:
    A simple message base test script right now, but ultimately could (should)
    grow into something that could be used in lieu of smbutil for at least
    some message base admin functions. Committing in its current form for
    Bill McGarrity to use to help diagnose a Message-ID issue (w/newslink.js)
  211. rswindell
    Wed May 09 2018 11:48 am PDT

    Modified Files:
    exec/newslink.js 1.108 1.109 diff

    Log Message:
    Created a new function (save_ptr) to elminate some redundant code.
    Removed support for the long-deprecated .snl import/export pointer files
    (uses the long-supported .ini file now only, [NewsLink] section).
    Added more debug output (enabled with the -d switch) when skipping
    (not exporting) any locally posted messages to help debug Bill McGarrity's
    reported problem.
  212. nightfox
    Tue May 08 2018 10:09 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.119 1.120 diff

    Log Message:
    Minor fix
  213. nightfox
    Tue May 08 2018 09:12 pm PDT

    Modified Files:
    xtrn/DDMsgReader/readme.txt 1.15 1.16 diff

    Log Message:
    Updated the version number (1.17 beta 60)
  214. nightfox
    Tue May 08 2018 09:12 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.118 1.119 diff

    Log Message:
    Version 1.17 beta 60:  When a non-sysop is reading anonymous posts, the  "from" name is now shown as "Anonymous".
  215. rswindell
    Thu May 03 2018 06:32 pm PDT

    Modified Files:
    exec/binkit.js 2.2 2.3 diff

    Log Message:
    Resolve exception/abend when files with no extension/suffix are placed 
    in the outbound directory:
     TypeError: file_getext(file) is undefined
  216. rswindell
    Wed May 02 2018 02:47 pm PDT

    Modified Files:
    exec/load/lockfile.js 1.9 1.10 diff

    Log Message:
    Removed the now-deprecated (never-functioning) 'e' flag from File.open()
    calls.
  217. deuce
    Mon Apr 30 2018 11:00 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.667 1.668 diff

    Log Message:
    Break the loop when failed is set to true.
    Also, use a stack pointer if the passed failed pointer is NULL.
  218. rswindell
    Mon Apr 30 2018 06:17 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.80 3.81 diff

    Log Message:
    If a bundle file cannot be unpacked after 48-hours, if the file is 0-bytes in
    length, just delete it (don't rename to *.?_?).
  219. rswindell
    Mon Apr 30 2018 04:02 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.126 1.127 diff

    Log Message:
    maint(): don't truncate the .sid and .hash files to 0-bytes before writing their
    new contents,
    Instead truncate to the new length after writing the new contents. This should
    make the files more tolerant of "out of disk space" situations and reduce
    the risk of lost data (0-byte files) due to low/no free disk space.
  220. rswindell
    Mon Apr 30 2018 03:54 pm PDT

    Modified Files:
    src/sbbs3/mail.cpp 1.32 1.33 diff

    Log Message:
    delmail(): don't truncate the .sid file to 0-bytes before writing the contents,
    instead truncate to the new length after writing the contents. This should
    make mail.sid files more tolerant of "out of disk space" situations and reduce
    the risk of lost data (0-byte mail.sid files) due to low/no free disk space.
  221. rswindell
    Mon Apr 30 2018 02:58 pm PDT

    Modified Files:
    src/xpdev/ini_file.c 1.162 1.163 diff

    Log Message:
    iniWriteFile(): don't truncate the file to 0-bytes before writing the contents,
    instead truncate to the new length after writing the contents. This should
    make .ini files more tolerate of "out of disk space" situations and reduce
    the risk of lost data (0-byte .ini files) due to low/no disk space.
  222. rswindell
    Sun Apr 29 2018 11:05 pm PDT

    Modified Files:
    src/sbbs3/fixsmb.c 1.45 1.46 diff

    Log Message:
    Bug fix: if the msgbase.lock file existed, it would cause the msgbase open (and
    thus fixsmb) to fail, but just before exiting, fixsmb would delete the .lock
    file (whoops). The msgbase.lock file means something else is rebuilding this
    base (e.g. smbutil) and thus we can't just go deleting the .lock file, unless
    we (fixmsb) was the one that created it.
  223. rswindell
    Tue Apr 24 2018 12:56 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.717 1.718 diff
    src/sbbs3/ftpsrvr.c 1.471 1.472 diff
    src/sbbs3/websrvr.c 1.666 1.667 diff

    Log Message:
    Make the strings passed to startup->errormsg() more consistent (a 4-char
    left-justified server prefix), e.g. "term" now added for terminal server
    errors.
  224. rswindell
    Tue Apr 24 2018 12:02 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.95 1.96 diff

    Log Message:
    Make the "UNKNOWN USER" log messages more consistent:
    - Using NOTCICE (not INFO) log level.
    - Move the protocol name after Node X and remove the colon.
  225. deuce
    Mon Apr 23 2018 09:26 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.233 1.234 diff

    Log Message:
    Fix FreeBSD build, broken by revision 1.230
  226. nightfox
    Mon Apr 23 2018 09:26 pm PDT

    Modified Files:
    xtrn/SlyVote/SlyVote.js 1.55 1.56 diff
    xtrn/SlyVote/readme.txt 1.14 1.15 diff

    Log Message:
    Version 0.37 Beta: When submitting a vote, the thread_id field is now set to the message/poll's message ID, not message number.
  227. nightfox
    Mon Apr 23 2018 09:18 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.117 1.118 diff
    xtrn/DDMsgReader/readme.txt 1.14 1.15 diff

    Log Message:
    Version 1.17 beta 59: When submitting a vote, the thread_id field is now set to the message/poll's message ID, not the message number.
  228. rswindell
    Mon Apr 23 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.716 1.717 diff

    Log Message:
    Added protocol (e.g. Telnet, Rlogin, or SSH) to more log messages
    (e.g. warnings and errors).
    Also, stripped trailing white-space from many lines (editor setting).
  229. rswindell
    Mon Apr 23 2018 07:12 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.715 1.716 diff

    Log Message:
    Fix yet another race condition that could cause:
    Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1) ... 
    from output_thread
    Don't set ssh_mode=true until the ssh_session has been created successfully.
    
    Also added some more debug output with regards to Cryptlib session number.
  230. rswindell
    Mon Apr 23 2018 06:43 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.714 1.715 diff

    Log Message:
    Fix more race conditions which cause Terminal Server SSH ERROR 'Bad argument,
    parameter 1' (-1) ... from output_thread
  231. rswindell
    Fri Apr 20 2018 01:18 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.713 1.714 diff

    Log Message:
    Fix race-condition causing SSH errors:
    Terminal Server SSH ERROR 'Bad argument, parameter 1' (-1)
     ... from output_thread
    
    The bbs_thread() sets the global/server sbbs ssh_mode to false and ssh_session
    to 0 (the "parameter 1" value used in the cryptlib function calls in
    output_thread) but was doing this without owning the ssh_mutex, so the
    output_thread had a race condition where it would check ssh_mode=true and
    then use grab the ssh_mutex and use ssh_session in a few cryptlib function
    calls. The fix for the bbs_thread() to grab the ssh_mutex before setting
    ssh_mode to false and ssh_session to 0 and have the output_thread() re-check
    the ssh_mode after grabbing the ssh_mutex and not call any cryptlib
    functions if ssh_mode was set to false while waiting for the mutex.
    
    The cause would have been more obvious if the various cryptlib error/log
    messages contained the cryptlib session ID value (which was 0 in this case).
  232. nightfox
    Thu Apr 19 2018 10:36 am PDT

    Modified Files:
    text/avatars/DIGDIST.startrek.bin 1.1 1.2 diff

    Log Message:
    Used some brigher colors in some of the avatars.  This collection is still a work in progress..
  233. rswindell
    Wed Apr 18 2018 10:47 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.39 1.40 diff

    Log Message:
    Lower the log level of "BADDATA" cryptlib errors (-32) from ERROR to
    WARNING.
    Also fixed a couple of typos in strings.
  234. deuce
    Tue Apr 17 2018 11:51 pm PDT

    Modified Files:
    src/syncterm/menu.c 1.60 1.61 diff
    src/syncterm/term.c 1.337 1.338 diff
    src/syncterm/uifcinit.c 1.38 1.39 diff

    Log Message:
    Now that save/restorescreen() do font stuff too, we can just go ahead and
    switch to CP437 before any uifc stuff and everythings going to be happy.
  235. rswindell
    Tue Apr 17 2018 11:46 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.712 1.713 diff

    Log Message:
    Some log output updates, mainly adding errno string-representation where
    missing, but also now logging when renaming (or failing to rename) bad
    received .REP packet files.
  236. deuce
    Tue Apr 17 2018 11:44 pm PDT

    Modified Files:
    src/conio/ciolib.c 1.171 1.172 diff
    src/conio/ciolib.h 1.99 1.100 diff

    Log Message:
    Have save/restorescreen() save and restore the flags and fonts as well.
  237. rswindell
    Tue Apr 17 2018 11:43 pm PDT

    Modified Files:
    src/sbbs3/un_rep.cpp 1.64 1.65 diff

    Log Message:
    Don't treat qwk_import_msg() failures (e.g. duplicate messages) as
    packet errors, no need to save such REP packets as .bad files.
  238. deuce
    Tue Apr 17 2018 11:33 pm PDT

    Modified Files:
    src/conio/bitmap_con.c 1.136 1.137 diff

    Log Message:
    Handle default fonts when setting vmem.
  239. deuce
    Tue Apr 17 2018 11:33 pm PDT

    Modified Files:
    src/conio/cterm.c 1.241 1.242 diff

    Log Message:
    Copy the current font one into the CTerm altfont array during cterm_init()
    
    This should fix the issue with non-CP437 fonts reported by Kirkman.
  240. rswindell
    Tue Apr 17 2018 11:06 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.671 1.672 diff

    Log Message:
    Use the msg.idx.number as the message number in smb_getmsghdr() failure
    error messages (in the POP3 server) as the msg.hdr.number is zeroed by 
    smb_getmsghdr() and potentially invalid when returning an error.
  241. rswindell
    Tue Apr 17 2018 11:00 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.670 1.671 diff

    Log Message:
    Use a different source for the message number in smb_getmsghdr() failure
    error log message as the header is zeroed in this function and thus the
    message number previously read from the index, lost (zeroed) and useless.
  242. deuce
    Tue Apr 17 2018 08:54 pm PDT

    Modified Files:
    src/syncterm/bbslist.c 1.212 1.213 diff

    Log Message:
    Pass a bar pointer to screen mode list to allow showing below end of first
    screen of rows.
  243. deuce
    Tue Apr 17 2018 07:35 pm PDT

    Modified Files:
    exec/imapservice.js 1.66 1.67 diff

    Log Message:
    is_connected is not a method.
  244. rswindell
    Tue Apr 17 2018 06:41 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.232 1.233 diff

    Log Message:
    Experimental enhancement: enable WWIV color (Ctrl-C) code expansion in
    *nix-builds (for stdio WWIV doors).
  245. rswindell
    Tue Apr 17 2018 03:57 pm PDT

    Modified Files:
    src/sbbs3/xtrn_sec.cpp 1.84 1.85 diff

    Log Message:
    Extend USE_DOSEMU patch to drop file creation for non-native doors:
    Use drive mappings (e.g. D:, F:, G:, H:) rathe than absolute paths to node_dir,
    ctrl_dir, data_dir, and exec_dir in drop files.
    Also: fixed what appears to have been a copy/paste error in the node_dir
    and ctrl_dir mapping to Win32-shortnames for non-native doors on Windows.
  246. rswindell
    Tue Apr 17 2018 02:45 pm PDT

    Modified Files:
    exec/tickit.js 1.43 1.44 diff

    Log Message:
    Simplified the rename_or_move() function:
    - Don't use the deprecated 'e' file open mode
    - Use the global file_copy() method rather than roll-your-own
  247. rswindell
    Mon Apr 16 2018 09:32 pm PDT

    Modified Files:
    src/sbbs3/email.cpp 1.66 1.67 diff

    Log Message:
    Display the (previously unused) EmailFilesNotAllowed text.dat entry if a file
    attachment is attempted but unsupported.
  248. rswindell
    Mon Apr 16 2018 09:30 pm PDT

    Modified Files:
    src/sbbs3/fido.cpp 1.58 1.59 diff

    Log Message:
    Overhaul sbbs_t::netmail() for FidoNet netmail:
    - writes outbound netmail to SMB rather than FTS-1 Stored Messages (*.msg)
      this means you must have SBBSecho v2.30 or later in order to export FTN
      netmail (for file attachments, you'll need SBBSecho v3.04 rev 3.78 or later)
    - removed support for the now deprecated "default address" feature
      (nowadays, people are much more likely to gate FidoNet over Internet rather
      than the reverse!)
    
    The QWK-to-NetMail function still needs a similar overhaul.
  249. rswindell
    Mon Apr 16 2018 09:14 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.79 3.80 diff

    Log Message:
    write_flofile(): if the 'infile' path contains a drive letter prefix
    (e.g. "C:"), skip it on *nix and if the path contains backslashes, convert
    to forward-slashes (for all OSes). This resolves an issue of sending a
    netmail file-attachment that was created on a Windows/MS-DOS type system
    and then scanned/exported on a *nix system. The FTN "stored message"
    convention is to have the full path of the attached file in the message
    subject.
    
    Hopefully nobody wants to use outbound directory names beginning with "x:"
    on *nix. :-)
  250. rswindell
    Mon Apr 16 2018 07:56 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.78 3.79 diff

    Log Message:
    Bug-fix: when exporting FTN netmail from SMB "mail" base, if the netmail
    included an "old-style" (not MIME-encoded) file attachment (where the file path
    is in the subject and the FILEATTACH aux-attribute flag is set), the
    corresponding netmail attribute flag would not be set in the stored msg (*.msg)
    file. Also simplified the create_netmail() function prototype/usage, removing
    the "file_attached" argument (use the hdr.auxattr instead).
  251. rswindell
    Mon Apr 16 2018 03:48 pm PDT

    Modified Files:
    3rdp/win32.release/cryptlib/bin/cl32.dll 1.6 1.7 diff

    Log Message:
    This is a clean rebuild of 3.4.4 with all our patches and there are several
    bytes different, so committing out of an abundance of caution. No "known"
    changes however.
  252. rswindell
    Mon Apr 16 2018 03:39 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.711 1.712 diff

    Log Message:
    Fix typo in previous commit.
  253. rswindell
    Mon Apr 16 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.710 1.711 diff
    src/sbbs3/un_rep.cpp 1.63 1.64 diff

    Log Message:
    2 unrelated changes:
    1: Wrap SSH cryptDestroySession() calls in a wrapper that tracks the number of
        open sessions and logs errors upon failure (and remaining session count).
        This is how I found the SSH session leak in sbbs_t::hangup().
        Also found multiple cals to SSH_END() which were invalid (no session to
        destroy) and removed them.
    2: If errors are detected when unpacking a REP packet, save the .rep file
        (in data/file/<filename.rep>.<timestamp>.bad) for later inspection.
        Also added some VOTING.DAT debug output (to be removed later).
        Trying to the get to the bottom of the
        "smb_addvote thread_back field missing" errors.
  254. rswindell
    Sun Apr 15 2018 06:32 pm PDT

    Modified Files:
    src/sbbs3/logon.cpp 1.65 1.66 diff

    Log Message:
    If the HappyBirthday text.dat line is blank, don't try to display it nor 
    pause and CLS after.
  255. echicken
    Sat Apr 14 2018 10:27 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.28 1.29 diff

    Log Message:
    @DigitalMan | It'd be nice if home/end keys moved to first/last avatars in a collection when viewing a collection
  256. echicken
    Sat Apr 14 2018 10:21 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.27 1.28 diff

    Log Message:
    @DigitalMan | JavaScript  s:\sbbs\exec\avatar_chooser.js line 775: TypeError: state.opt_out_item is null
    
    uh, this oughta do away with that, I guess
  257. echicken
    Sat Apr 14 2018 10:10 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.26 1.27 diff

    Log Message:
    Fix display bug (collection/highlight desync), but I should probably 
    revisit some of this.
  258. echicken
    Sat Apr 14 2018 10:00 pm PDT

    Modified Files:
    exec/avatar_chooser.js 1.25 1.26 diff

    Log Message:
    Scroll up one more line when on row zero to reveal the collection title.
    (Not the best fix, but it'll do for now.)
  259. rswindell
    Fri Apr 13 2018 04:59 pm PDT

    Modified Files:
    src/sbbs3/logfile.cpp 1.60 1.61 diff

    Log Message:
    errormsg() logs the "useron", when applicable, even for timed events (e.g.
    REP unpacking).
  260. rswindell
    Thu Apr 12 2018 10:25 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.709 1.710 diff

    Log Message:
    Apparent fix for SSH cryptlib session leak (leading to eventual
    'Resource/space exhausted' errors in TLS and SSH:
    The wrong ssh_session is being passed to cryptDestroySession() in
    sbbs_t::hangup() (introduced in rev 1.615), this call to cryptDestorySession()
    fails (returns -1, bad param) thus leaving the actual
    ssh_session never destroyed (leaked).
  261. rswindell
    Thu Apr 12 2018 03:11 pm PDT

    Modified Files:
    exec/load/sbbslist_lib.js 1.14 1.15 diff

    Log Message:
    Increase maximum service address (e.g. host name) length from 28 chars to 35
    chars for Bill McGarrity @ tequilamockingbirdonline.net :-)
    Doesn't seem to break anything (except backwards compatibility with SBL
    v3).
  262. rswindell
    Sun Apr 08 2018 07:59 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.470 1.471 diff

    Log Message:
    Bug-fix: The GCES macro already prints and *frees* the error string, so
    you can't print and free it again after calling that macro.
  263. rswindell
    Sun Apr 08 2018 07:49 pm PDT

    Modified Files:
    exec/binkit.js 2.1 2.2 diff

    Log Message:
    Remove 'e' from File.open() modes, but place a reminder comment to revisit.
    Added destination address of outbound file in "Attempting callout" log msg.
  264. rswindell
    Sat Apr 07 2018 12:21 am PDT

    Modified Files:
    src/xpdev/xpprintf.c 1.61 1.62 diff

    Log Message:
    Resolve GCC warnings:
    cast from pointer to integer of different size
  265. rswindell
    Sat Apr 07 2018 12:18 am PDT

    Modified Files:
    src/sbbs3/pack_rep.cpp 1.47 1.48 diff

    Log Message:
    Resolved GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
  266. rswindell
    Sat Apr 07 2018 12:17 am PDT

    Modified Files:
    src/sbbs3/mime.c 1.10 1.11 diff

    Log Message:
    Resolved GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
  267. rswindell
    Sat Apr 07 2018 12:15 am PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.231 1.232 diff

    Log Message:
    Removed an apparent debug-output (to stderr) line (output the path to
    emusetup.bat).
    It was generating an (easy to fix) GCC 5.4.0 warning:
    format not a string literal and no format arguments [-Wformat-security]
    But the line was not needed, so just removed it.
  268. rswindell
    Fri Apr 06 2018 11:01 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.669 1.670 diff

    Log Message:
    Resolve gcc version 5.4.0 warning: 
    format not a string literal and no format arguments [-Wformat-security]
  269. rswindell
    Fri Apr 06 2018 10:55 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.77 3.78 diff

    Log Message:
    Attempt to address GCC v7 warnings raised by Nelgin:
    warning: format not a string literal and no format arguments [-Wformat-security]
  270. rswindell
    Fri Apr 06 2018 10:51 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.668 1.669 diff

    Log Message:
    Attempt to address GCC v7 warnings raised by Nelgin:
    warning: format not a string literal and no format arguments [-Wformat-security]
       sockprintf(sock,sess,(char*)resp);
       sockprintf(socket,session,sys_error);
  271. rswindell
    Fri Apr 06 2018 12:08 am PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.230 1.231 diff

    Log Message:
    Fix build for USE_DOSEMU option (which I don't use).
  272. rswindell
    Thu Apr 05 2018 08:02 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.76 3.77 diff

    Log Message:
    Use GCC-assisted printf-style format/arg checking to find and fix instances
    of lprintf() misuse.
  273. rswindell
    Thu Apr 05 2018 07:49 pm PDT

    Modified Files:
    src/sbbs3/xtrn.cpp 1.229 1.230 diff

    Log Message:
    Resolve a couple GCC warnings:
    unused variable 'p'
    comparison between signed and unsigned integer expressions
  274. rswindell
    Thu Apr 05 2018 07:47 pm PDT

    Modified Files:
    src/sbbs3/js_global.c 1.373 1.374 diff

    Log Message:
    Resolve GCC warning: cast from pointer to integer of different size
     in expansion of macro 'JS_ARGS_OFFSET':
    unsigned long is the same size as a pointer (rather than unsigned int)
    on the supported target platforms/tool-chains.
  275. rswindell
    Thu Apr 05 2018 07:42 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.479 1.480 diff
    src/sbbs3/js_cryptcon.c 1.19 1.20 diff
    src/sbbs3/main.cpp 1.708 1.709 diff
    src/sbbs3/pack_rep.cpp 1.46 1.47 diff
    src/sbbs3/readtext.c 1.4 1.5 diff
    src/sbbs3/un_qwk.cpp 1.52 1.53 diff
    src/sbbs3/jsexec.c 1.198 1.199 diff

    Log Message:
    Use GCC-printf-style format/arg checking to find and fix problems with
    ::lprintf() usage.
  276. rswindell
    Thu Apr 05 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.665 1.666 diff

    Log Message:
    Enabled GCC-assisted printf-style format/arg checking for lprintf() and
    fix the resulting warnings.
  277. rswindell
    Thu Apr 05 2018 07:18 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.321 1.322 diff

    Log Message:
    Enabled GCC-assisted printf-style format/arg checking for lprintf() and
    fix the resulting warnings.
  278. rswindell
    Thu Apr 05 2018 07:11 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.h 1.84 1.85 diff
    src/sbbs3/mailsrvr.c 1.667 1.668 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for sockprintf()
    and resolve the resulting warnings.
  279. rswindell
    Thu Apr 05 2018 06:58 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.666 1.667 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for lprintf() and
    resolve the resulting warnings.
  280. rswindell
    Thu Apr 05 2018 06:35 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.469 1.470 diff

    Log Message:
    Enable GCC-assisted printf-style format/arg checking for lprintf, sockprintf
    and send_mlsx().
    Fix numerous printf-style argument bugs, many in the TLS and MLSx support.
  281. rswindell
    Thu Apr 05 2018 06:05 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.468 1.469 diff

    Log Message:
    Fix get_ssl_cert() failure log message (wrong number of arguments).
    Put "TLS" in the failure log messages rather than repeating "FTP".
  282. rswindell
    Thu Apr 05 2018 06:02 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.665 1.666 diff

    Log Message:
    Fix get_ssl_cert() failure log message (wrong number of arguments).
    Was this pasted from somewhere else?
  283. rswindell
    Thu Apr 05 2018 05:49 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.75 3.76 diff

    Log Message:
    Log an error if ftouch() fails to create the outbound sem file.
  284. rswindell
    Thu Apr 05 2018 05:21 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.478 1.479 diff
    src/sbbs3/login.cpp 1.26 1.27 diff

    Log Message:
    Address GCC warning: ISO C++ forbids converting a string constant to 'char*'
  285. rswindell
    Thu Apr 05 2018 05:14 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.664 1.665 diff

    Log Message:
    Fix a couple of issues with external mail processors:
    - Since rev 1.556, mailproc_to_match[] would only ever contain one mail
      processor (index) value, even if the RCPT TO address matched multiple
      mail processor "To" keys in mailproc.ini, so only the first-matching
      mail processor (with a "To" key) would be executed for the msg.
    - mailproc_match, meaning the destination was a non-passthrough
      external mail processor, in which case the destination (RCPT TO) address
      may *not* match a valid local user account, would be set for *passthru*
      mail processors potentially resulting in the following error (and an
      undelivered mail message): !SMTP can't deliver mail to user #0
      only set mailproc_match to a valid mail proc index if the recipient matches a
      non-passthru mail processor.
  286. rswindell
    Thu Apr 05 2018 03:26 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.467 1.468 diff

    Log Message:
    The real apparent fix for the free() assertion: use free_crypt_attrstr() instead
  287. rswindell
    Thu Apr 05 2018 02:49 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.466 1.467 diff

    Log Message:
    Initialize estr to NULL in start_tls(), likely cause of free() assert in
    Windows debug build.
  288. rswindell
    Thu Apr 05 2018 03:28 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.74 3.75 diff

    Log Message:
    Some status string (e.g. "Loading user names...") were being sent to stderr
    instead of stdout.
  289. rswindell
    Wed Apr 04 2018 07:22 pm PDT

    Modified Files:
    exec/showmsghdr.js 1.3 1.4 diff
    exec/showmsgavatar.js 1.1 1.2 diff
    exec/showfileavatar.js 1.2 1.3 diff
    exec/logon.js 1.32 1.33 diff

    Log Message:
    Don't "clear the background attribute" by setting the attributes to 0
    (black on black) as this can inadvertently "hide" text for ANSI users
    (e.g. poll comments, when reading a poll message). Set to 7 (lightgray)
    instead.
  290. rswindell
    Wed Apr 04 2018 12:13 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.195 1.196 diff

    Log Message:
    Don't log "(null)" for the user name in filter_ip() when the user name is
    not known/available (e.g. certain types of SSH login failures).
  291. rswindell
    Wed Apr 04 2018 12:11 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.320 1.321 diff
    src/sbbs3/ftpsrvr.c 1.465 1.466 diff
    src/sbbs3/websrvr.c 1.664 1.665 diff
    src/sbbs3/mailsrvr.c 1.663 1.664 diff

    Log Message:
    Log the number of failed login attempts which triggered the IP filter.
  292. rswindell
    Wed Apr 04 2018 12:10 pm PDT

    Modified Files:
    src/sbbs3/sbbs.h 1.477 1.478 diff
    src/sbbs3/login.cpp 1.25 1.26 diff
    src/sbbs3/main.cpp 1.707 1.708 diff

    Log Message:
    sbbs_t::badlogin() now accepts 3 more (optional) arguments which allow us
    to use this function in bbs_thread() for SSH failed login attempts and thus
    enable the perm-IP-filtering (LoginAttemptFilterThreshold) functionality.
    Right now, it's only a "bad login" if the "Getting channel type" doesn't
    return "session", but we could (and likely will) use it for more SSH login
    failure modes which indicate a likely hack-attempt.
  293. rswindell
    Tue Apr 03 2018 06:52 pm PDT

    Modified Files:
    exec/tickit.js 1.42 1.43 diff

    Log Message:
    Change the -replace option to -force-replace since the old "tick" program
    had a "replace" option that did something differnet (enabled parsing of the
    REPLACES verb) - don't want to confuse sysops now. :-)
  294. rswindell
    Mon Apr 02 2018 04:45 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.706 1.707 diff

    Log Message:
    Create yet-another GCES macro (GCESSTR) to log the output_thread instance
    description string ('node') in SSH-related log messages (e.g. errors) from the
    output_thread: No more "Node 0" log entries from here.
  295. rswindell
    Mon Apr 02 2018 04:22 pm PDT

    Modified Files:
    src/sbbs3/js_file.c 1.171 1.172 diff

    Log Message:
    Updated JS warning when using old/deprecated file open mode 'e':
        "Deprecated file open mode: 'e'"
    If this is your script generating this warning, either remove the 'e' from
    the File open() mode string (it had no effect anyway) or change to 'x' to
    get the real/working exclusive-open functionality (added in v3.17).
  296. rswindell
    Mon Apr 02 2018 03:52 pm PDT

    Modified Files:
    src/sbbs3/ctrl/CodeInputFormUnit.dfm 1.5 1.6 diff

    Log Message:
    Sort the items in the combobox when prompting for an internal code
    (e.g. for a QNET hub or timed event).
  297. rswindell
    Mon Apr 02 2018 03:37 pm PDT

    Modified Files:
    src/sbbs3/js_file.c 1.170 1.171 diff

    Log Message:
    The 'e' (exclusive-open) mode flag (introduced in v3.12) never worked. It was
    simply ignored when converted to the underlying open mode passed to sopen().
    Deprecate this flag and log a warning when it is detected as used in a script:
    Deprecated open flag used: 'e'
    Added 'x' (exclsuive-open) mode flag which:
    1. was tested to work as intended
    2. is consistent with the C11 standard for fopen() mode flags
    3. won't cause existing scripts to suddenly break
  298. rswindell
    Mon Apr 02 2018 01:32 pm PDT

    Modified Files:
    exec/tickit.js 1.41 1.42 diff

    Log Message:
    Experimental feature for bgdjr: when '-replace' argument is passed on the
    command-line, treat all .TIC files as they have have a "REPLACES" clause.
  299. deuce
    Mon Apr 02 2018 01:29 am PDT

    Modified Files:
    exec/load/http.js 1.41 1.42 diff

    Log Message:
    When sending a request and the socket is still open, close it.
    This prevents leaving all sockets open until the script exits.  It would
    be better to reuse the existing socket when it's already connected to the
    right place, but this is easier for now.
  300. rswindell
    Sun Apr 01 2018 01:48 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.705 1.706 diff

    Log Message:
    Added function names to SSH error messages so we can better tell where
    these errors are coming from.
  301. rswindell
    Sun Apr 01 2018 01:46 pm PDT

    Modified Files:
    exec/load/fidocfg.js 1.32 1.33 diff
    exec/load/fido.js 1.31 1.32 diff
    exec/load/fido_syscfg.js 1.17 1.18 diff

    Log Message:
    Added CVS Id tag.
  302. echicken
    Sun Apr 01 2018 10:25 am PDT

    Modified Files:
    xtrn/ansiview/ansiview.js 1.24 1.25 diff
    xtrn/ansiview/readme.txt 1.6 1.7 diff

    Log Message:
    Two optional settings can be added to the root section of settings.ini:
    header = /path/to/some.ans
    header_rows = number of lines occupied by the header graphic
    The normal ansiview 'window' will be pushed down by header_rows lines,
    and the header graphic will be displayed above it.
  303. rswindell
    Sun Apr 01 2018 12:51 am PDT

    Modified Files:
    src/sbbs3/answer.cpp 1.94 1.95 diff

    Log Message:
    If the SSH or RLogin-supplied username is in the name.can, don't start the
    new user signup process with that name (just fall-through to a normal login
    prompt).
  304. rswindell
    Sun Apr 01 2018 12:22 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.662 1.663 diff

    Log Message:
    Added a debug-level log msg ever 100 lines of received SMTP message text.
  305. rswindell
    Sat Mar 31 2018 11:55 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.16 1.17 diff

    Log Message:
    Fix bug in previous commit (use of Object.keys) which caused the default
    domain/zone-map configuration to be used - always.
  306. rswindell
    Sat Mar 31 2018 09:24 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.15 1.16 diff

    Log Message:
    Fix the default domain ('fidonet', zones 1-6) feature when there are no
    domains configured in sbbsecho.ini
    ('domains' is always undefined at this point, <shrug>).
  307. rswindell
    Sat Mar 31 2018 08:54 pm PDT

    Modified Files:
    exec/binkit.js 2.0 2.1 diff

    Log Message:
    Fix error line 792: TypeError: file_getext(dir) is undefined
    when outbound directory (dir) was "../some/path".
  308. rswindell
    Sat Mar 31 2018 08:42 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.32 3.33 diff

    Log Message:
    When creating a new linked node, set binkp_allowPlainText to true
    (Argus and Mystic's BinkP mailers don't support encryption).
  309. rswindell
    Sat Mar 31 2018 08:38 pm PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.31 3.32 diff

    Log Message:
    Help text fix-ups.
  310. rswindell
    Sat Mar 31 2018 08:37 pm PDT

    Modified Files:
    src/sbbs3/sbbsecho.c 3.73 3.74 diff

    Log Message:
    Bug-fix: The Auto-Add-Subs feature would not create the area file (areas.bbs)
    if it didn't already exist.
  311. rswindell
    Sat Mar 31 2018 07:21 pm PDT

    Modified Files:
    exec/load/fido_syscfg.js 1.14 1.15 diff

    Log Message:
    Fixed some typos.
    Added node address to some authentication failure warnings.
  312. rswindell
    Sat Mar 31 2018 02:43 am PDT

    Modified Files:
    src/sbbs3/echocfg.c 3.30 3.31 diff

    Log Message:
    Resolved GCC warning about implicit type (int).
  313. rswindell
    Sat Mar 31 2018 02:41 am PDT

    Modified Files:
    src/sbbs3/pktdump.c 1.10 1.11 diff

    Log Message:
    Use new struct fidoaddr (5D address).
  314. rswindell
    Sat Mar 31 2018 02:40 am PDT

    Modified Files:
    src/sbbs3/fidodefs.h 1.19 1.20 diff

    Log Message:
    Added FIDO_DOMAIN_LEN (8), PRODDATA_LEN (4), updated comments, etc.
    Created struct fidoaddr (5D address), though it's only used (so far)
    in pktdump.c - doesn't really need to be packed.
  315. rswindell
    Sat Mar 31 2018 02:38 am PDT

    Modified Files:
    src/sbbs3/sbbsecho.h 3.21 3.22 diff
    src/sbbs3/sbbsecho.c 3.72 3.73 diff
    src/sbbs3/rechocfg.c 3.29 3.30 diff
    src/sbbs3/echocfg.c 3.29 3.30 diff

    Log Message:
    SBBSecho/EchoCfg v3.04 - uses the newly merged sbbsecho/binkit/ftn_domains.ini
    If you're not using BinkIT (you're using some other FidoNet mailer), you can
    safely ignore all the settings/options.
    A lot of the online help for the new settings/menus needs to be written
    still and the wiki now needs a lot of update to reflect the changes.
    The "title" of this program was changed, again, from "SBBSecho Config" to
    "[Synchronet] FidoNet Config" since it configures more than just SBBSecho
    now.
  316. rswindell
    Sat Mar 31 2018 02:34 am PDT

    Modified Files:
    exec/update.js 1.5 1.6 diff

    Log Message:
    Run 'binkit upgrade' if binkit.ini and sbbsecho.ini exists
    (the upgrade renames binkit.ini and ftn_domains.ini to *.old).
  317. rswindell
    Sat Mar 31 2018 02:33 am PDT

    Modified Files:
    exec/binkit.js NONE 2.0 diff

          Tag: 2.0
    	binkit.js 
    Log Message:
    Merged binkit.ini and ftn_domains.ini into sbbsecho.ini (BinkIT 2.0).
    Use "jsexec binkit upgrade" to upgrade your existing .ini files if you're
    already running BinkIT 1.x.
    echocfg v3.04 may now be used to set all the BinkIT settings and domains
    (in sbbsecho.ini).
  318. rswindell
    Sat Mar 31 2018 02:31 am PDT

    Modified Files:
    exec/load/fidocfg.js 1.31 1.32 diff
    exec/load/fido_syscfg.js 1.13 1.14 diff

    Log Message:
    Merged binkit.ini and ftn_domains.ini into sbbsecho.ini (for BinkIT 2.0)
    (note: some of the key names were changed), run "jsexec binkit upgrade"
    to upgrade your existing .ini's (if you have them).
    Removed support for sbbsecho.cfg.
  319. rswindell
    Sat Mar 31 2018 02:16 am PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.37 1.38 diff

    Log Message:
    Finished removing (now unused) PostLink-networking stuff.
  320. rswindell
    Sat Mar 31 2018 01:40 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.704 1.705 diff

    Log Message:
    Check the terminate_output_thread flag after acquiring the ssh_muex.
  321. deuce
    Sat Mar 31 2018 01:14 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.703 1.704 diff

    Log Message:
    Tabs are stupid.
  322. echicken
    Fri Mar 30 2018 10:41 pm PDT
    exec/load websocket-proxy.js 1.1 NONE
    Update of /cvsroot/sbbs/exec/load
    In directory cvs:/tmp/cvs-serv11750/load
    
    Removed Files:
    	websocket-proxy.js 
    Log Message:
    These are no longer needed and will only cause confusion alongside other websocket scripts.
  323. echicken
    Fri Mar 30 2018 10:41 pm PDT

    Removed Files:
    exec/NONE websocket-rlogin-service.js 1.5 diff

    Log Message:
    These are no longer needed and will only cause confusion alongside other websocket scripts.
  324. rswindell
    Fri Mar 30 2018 09:03 am PDT

    Modified Files:
    src/xpdev/ini_file.c 1.161 1.162 diff

    Log Message:
    Fix bcc32 build error: Expression syntax in function iniSetIntList
  325. rswindell
    Fri Mar 30 2018 01:35 am PDT

    Modified Files:
    src/xpdev/ini_file.c 1.160 1.161 diff
    src/xpdev/ini_file.h 1.54 1.55 diff

    Log Message:
    Added functions for reading/parsing/writing lists of integers in .ini files
    (e.g. "Zones=1,2,3,4,5,6").
  326. rswindell
    Fri Mar 30 2018 01:33 am PDT

    Modified Files:
    src/xpdev/link_list.h 1.27 1.28 diff

    Log Message:
    Fixed typo in comment.
  327. deuce
    Thu Mar 29 2018 06:02 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.464 1.465 diff

    Log Message:
    Fix infinite loop with TLS FTP control session.
  328. deuce
    Tue Mar 27 2018 07:47 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.319 1.320 diff

    Log Message:
    Fix potential crypt handle leak for TLS services.  Destroy the session
    if the thread returns before js_initcx() is called.
  329. deuce
    Tue Mar 27 2018 07:36 pm PDT

    Modified Files:
    exec/letsyncrypt.js 1.32 1.33 diff

    Log Message:
    Don't try ten times to delete files that don't exist.
  330. deuce
    Tue Mar 27 2018 06:45 pm PDT

    Modified Files:
    exec/imapservice.js 1.65 1.66 diff

    Log Message:
    Check if the socket is connected or not in the wait loop.
  331. deuce
    Mon Mar 26 2018 10:16 pm PDT

    Modified Files:
    exec/binkit.js 1.77 1.78 diff

    Log Message:
    Some binkp software (Taurus) doesn't send an M_NUL VER at all.
    Reported by bgdjr.
  332. rswindell
    Mon Mar 26 2018 06:08 pm PDT

    Modified Files:
    src/sbbs3/qwk.cpp 1.81 1.82 diff

    Log Message:
    Don't log an error when a QWK-posted vote message is a dupe (just silently
    discard).
    Also, trim trailing white-spaces.
  333. rswindell
    Mon Mar 26 2018 06:06 pm PDT

    Modified Files:
    src/conio/sdl_con.c 1.261 1.262 diff

    Log Message:
    Fix GCC warning:
    sdl_con.c: In function ΓÇÿsdl_mouse_threadΓÇÖ:
    sdl_con.c:1424:1: warning: no return statement in function returning non-void
  334. nightfox
    Mon Mar 26 2018 12:55 pm PDT

    Modified Files:
    exec/load/DDLightbarMenu.js 1.24 1.25 diff

    Log Message:
    Bug fix in the SetBorderChars method: Missing an index ([i]) into an array
  335. deuce
    Sun Mar 25 2018 10:17 pm PDT

    Modified Files:
    exec/binkit.js 1.76 1.77 diff

    Log Message:
    Check the Mystic version reported by the remote to see if we need to work
    around a broken CRAM-MD5 implementation.  For now, retrains the double-test
    for Mystic/1.12A39 until we see what version number the fixed builds have.
    
    If the major version is less than one, returns true.
    
    If the major version is greater than one, returns false.
    
    If the minor version is less than 12, returns true.
    
    If the minor version is greater than 12, returns false.
    
    If there is no character after the minor versions, returns false.
    (ie: 1.12 is newer than 1.12A39 and is assumed to be fixed)
    
    If the character after the minor version is not an 'A', returns false.
    (ie: 1.12B1 and 1.12.1 are newer than 1.12A39 and assumed fixed)
    
    If the number after the 'A' is less than or equal to 39, returns true.
    
    In all other cases, returns false.
    
    This prevents lowering security by having two allowed CRAM-MD5 responses
    for some remote software versions.  Hopefully the fixed build will have
    version 1.12A40 and we'll be able to remove the last version that does that.
  336. deuce
    Sun Mar 25 2018 09:40 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.702 1.703 diff

    Log Message:
    Since much more than the number of bytes we're reading can be sent on a
    channel we ignore/close, we would get a separate warning for each chunk of
    data on that channel until we read past the close.  Instead, if we're closing
    a channel, we note the channel ID, and simply discard the information
    immediately on the most recently closed channel.
    
    A remote could still cause a bunch of log output by multiplexing two or more
    writes to invalid channels, but nobody seems to do that, so this should be
    good for now.
  337. rswindell
    Sun Mar 25 2018 09:30 pm PDT

    Modified Files:
    src/sbbs3/chksmb.c 1.61 1.62 diff

    Log Message:
    Resolve msvc warnings (and confirm that cvs commits are making it into
    syncprog and the commit log again).
  338. deuce
    Sat Mar 24 2018 09:27 pm PDT

    Modified Files:
    src/conio/cterm.c 1.240 1.241 diff

    Log Message:
    Fix a large number of errors involving re-using an in-use index variable as
    a temp variable.  Mostly impacting the setting of video flags.
  339. rswindell
    Sat Mar 24 2018 09:14 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.193 1.194 diff

    Log Message:
    putmsgptrs():
    Fix-up the user/####.subs ini style (only one blank line between sections).
    Also, don't re-write the .subs file if nothing has changed.
  340. rswindell
    Sat Mar 24 2018 08:48 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.192 1.193 diff

    Log Message:
    Address GCC warning: "/*" within comment
  341. rswindell
    Sat Mar 24 2018 08:47 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.191 1.192 diff

    Log Message:
    Changed user' message pointer/last-read/scan-config storage to a new file
    (data/user/*.subs - in familar .ini syntax)
    indexed by the sub-board internal rather than the old flat binary file using
    the troublesome "pointer index" (ptridx) as an offset. The old files
    (data/user/ptrs/*.ixb) will still be read in when the new file doesn't exist,
    for upgrading users automatically to the new method of pointer storage.
    This should resolve long-standing issues around users' new-scan pointers and
    configurations getting corrupted when the sysop inserts/remove sub-boards.
    However, if you change a sub-board's internal code, that invalidates the users'
    pointers and scan configurations - so that may need to be addrsesed via SCFG.
    The subs' ptridx values are still be used for storing QWKnet hub pointers, for
    now, but that too will soon be addressed with a new file format for those ptrs
    too.
  342. deuce
    Sat Mar 24 2018 02:09 pm PDT

    Modified Files:
    exec/load/binkp.js 1.105 1.106 diff

    Log Message:
    Store the remote software version in the BinkP object, don't do special
    stuff in binkp.js, only the protocol.  BinkIT now does the Mystic check.
  343. deuce
    Sat Mar 24 2018 02:09 pm PDT

    Modified Files:
    exec/binkit.js 1.74 1.75 diff

    Log Message:
    Store the remote software version in the BinkP object, don't do special
    stuff in binkp.js, only the protocol.  BinkIT now does the Mystic check.
  344. deuce
    Sat Mar 24 2018 02:01 pm PDT

    Modified Files:
    exec/load/binkp.js 1.104 1.105 diff

    Log Message:
    Add comment in binkp about why we detect Mystic as well.
  345. deuce
    Sat Mar 24 2018 02:00 pm PDT

    Modified Files:
    exec/binkit.js 1.73 1.74 diff

    Log Message:
    Add comment regarding Mystic password workaround.
  346. deuce
    Sat Mar 24 2018 01:57 pm PDT

    Modified Files:
    exec/load/binkp.js 1.103 1.104 diff

    Log Message:
    Attept to work around Mystic CRAM+CRYPT issue.
  347. deuce
    Sat Mar 24 2018 01:57 pm PDT

    Modified Files:
    exec/binkit.js 1.72 1.73 diff

    Log Message:
    Attept to work around Mystic CRAM+CRYPT issue.
  348. rswindell
    Sat Mar 24 2018 01:53 am PDT

    Modified Files:
    src/sbbs3/text_defaults.c 1.41 1.42 diff

    Log Message:
    The SubLstHdr and SubLstFmt lines display the number of posts per sub-board,
    increase post-count width supported from 4 to 5 digits (beautifully).
  349. rswindell
    Sat Mar 24 2018 01:52 am PDT

    Modified Files:
    ctrl/text.dat 1.81 1.82 diff

    Log Message:
    The SubLstHdr and SubLstFmt lines display the number of posts per sub-board,
    increase post-count width supported from 4 to 5 digits (beautifully).
  350. rswindell
    Fri Mar 23 2018 11:49 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.36 1.37 diff
    src/sbbs3/scfg/scfgsub.c 1.45 1.46 diff

    Log Message:
    Removed PostLink/PCRelay configuration stuff - nobody has used this
    networking technology for 20 years. :-(
  351. rswindell
    Fri Mar 23 2018 05:02 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.660 1.661 diff

    Log Message:
    More detailed log output when posting a message via SMTP (successfully
    or not).
  352. rswindell
    Fri Mar 23 2018 04:57 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.700 1.701 diff

    Log Message:
    Log a generic "SSH session establishment failed" message (with NOTICE
    severity) whenever there is an SSH session establishment failure, because
    some of the SSH failure errors are DEBUG level severity and won't be visible
    with "Normal" (informational) log output filtering. This resolves the issue
    of seing "SSH connection accepted from <ip-address> port <port>" messages
    with no follow-up messages as to what happened to that connection.
  353. rswindell
    Fri Mar 23 2018 04:27 pm PDT

    Modified Files:
    exec/load/binkp.js 1.102 1.103 diff

    Log Message:
    Raise the log-level severity (from DEBUG to NOTICE) when sending any M_ERR
    messages. There's a lot of places in this script where we just send a
    (somewhat explanatory) M_ERR string, but don't log anything locally unless
    debug-level logging is enabled, now we'll at least log those messages with
    a bit higher severity.
  354. rswindell
    Fri Mar 23 2018 01:12 am PDT

    Modified Files:
    exec/binkit.js 1.71 1.72 diff

    Log Message:
    Don't allow the CRAM-MD5 challenge length to be overridden (always use
    the binkp.js default, 32-hexchars/16-bytes). Even IRex v2.31 requires a
    16-byte challenge, so experiment is over.
    Log more details when a CRAM-MD5 authentication response doesn't match
    (e.g. to make case-mismatch or other cause of authentication failures
    potentially more obvious - still debugging the Mystic inbound CRAM-MD5
    auth failure and this might help).
  355. rswindell
    Thu Mar 22 2018 07:12 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.190 1.191 diff

    Log Message:
    Fix weird compile error triggered by *some* revisions of msvc which dont'
    like a str_list_t declared in line (but the char* is fine?!).
  356. rswindell
    Thu Mar 22 2018 06:30 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.199 1.200 diff

    Log Message:
    Fix the log msg repeat count (off by one).
    Remember the last forced timed event setting.
  357. rswindell
    Thu Mar 22 2018 06:19 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.463 1.464 diff
    src/sbbs3/mailsrvr.c 1.659 1.660 diff
    src/sbbs3/main.cpp 1.699 1.700 diff
    src/sbbs3/services.c 1.318 1.319 diff
    src/sbbs3/websrvr.c 1.663 1.664 diff

    Log Message:
    Clean-up the log output around server shutdown/recycle:
    - lower log level (raise severity) of "Waiting for ..." msgs from Debug to Info
    - log a message when done waiting (for clients, threads, etc.)
    - only one #### log line per termination event
  358. rswindell
    Thu Mar 22 2018 05:09 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.8 1.9 diff

    Log Message:
    Log the UNIX socket name (filename) the status thread is listening on
    (default is ctrl/status.sock).
  359. rswindell
    Thu Mar 22 2018 04:32 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.7 1.8 diff

    Log Message:
    Fix more typos.
  360. rswindell
    Thu Mar 22 2018 04:29 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.6 1.7 diff

    Log Message:
    Fixed typo in status thread error message string ("stat" not "ftp").
  361. rswindell
    Thu Mar 22 2018 04:03 pm PDT

    Modified Files:
    exec/load/hexdump_lib.js 1.2 1.3 diff

    Log Message:
    Make hexdump_lib.js more lib-like and change the functions (methods) to
    return arrays rather than calling printf() directly. Also, make the ASCII
    portion of the output optional (but enabled by default).
  362. rswindell
    Thu Mar 22 2018 04:03 pm PDT

    Modified Files:
    exec/hexdump.js 1.1 1.2 diff

    Log Message:
    Make hexdump_lib.js more lib-like and change the functions (methods) to
    return arrays rather than calling printf() directly. Also, make the ASCII
    portion of the output optional (but enabled by default).
  363. rswindell
    Thu Mar 22 2018 02:20 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.317 1.318 diff

    Log Message:
    Bug-fix: JS service calls to random() would return the same sequence on
    Windows, every time. For example, this resulted in the same BinkP CRAM-MD5
    challenge being sent for every mailer session. Fixed by calling sbbs_srand
    in the service's thread, not (just once) in the accept thread.
  364. deuce
    Thu Mar 22 2018 12:31 am PDT

    Modified Files:
    exec/binkit.js 1.70 1.71 diff

    Log Message:
    We can't take a lockfile that doesn't exist.
  365. deuce
    Thu Mar 22 2018 12:22 am PDT

    Modified Files:
    exec/binkit.js 1.69 1.70 diff

    Log Message:
    Only add the SCFG outbound root if it's not in the FTNDomains config already.
    This shouldn't cause any functional changes since it's the outbound dirs that
    matter, and they already can't have duplicates.
  366. deuce
    Thu Mar 22 2018 12:06 am PDT

    Modified Files:
    exec/binkit.js 1.68 1.69 diff

    Log Message:
    I don't know how objects are "true", or "false", so don't risk it.
  367. rswindell
    Wed Mar 21 2018 08:24 pm PDT

    Modified Files:
    exec/binkit.js 1.67 1.68 diff

    Log Message:
    More elaborate fix for missing outbound directories (don't create them),
    just don't "run outbound" for those nodes.
  368. rswindell
    Wed Mar 21 2018 07:58 pm PDT

    Modified Files:
    exec/binkit.js 1.66 1.67 diff

    Log Message:
    <@Deuce> If there's no outbound dir, it should just skip the node.
  369. rswindell
    Wed Mar 21 2018 07:53 pm PDT

    Modified Files:
    exec/binkit.js 1.65 1.66 diff

    Log Message:
    Fix errors when outbound directory does not exist (create it):
      Locking c:\binkd\outbound\00da02bc.bsy
      Error 2 creating c:\binkd\outbound\00da02bc.bsy
      Failed to set date in the future fdate (-1) != future (1687417603)
    Also, added some debug dump of "outbound_roots" which appears to contain
    duplicates, at least when the ftn_domains.ini file is not in use:
     Outbound roots: ["c:\\binkd\\outbound","c:\\binkd\\outbound"]
  370. rswindell
    Wed Mar 21 2018 06:19 pm PDT

    Modified Files:
    text/sbbslist.hlp 1.1 1.2 diff

    Log Message:
    Finally a first pass at an sbbslist online help file.
    I got distracted by trying to wiki-syntax and then markdown and finally
    uust used asc/ctrl-a format. Sorry took so long.
  371. deuce
    Wed Mar 21 2018 12:18 pm PDT

    Modified Files:
    exec/fseditor.js 1.87 1.88 diff

    Log Message:
    Update the help text to list all keys.
  372. deuce
    Wed Mar 21 2018 12:02 pm PDT

    Modified Files:
    docs/fseditor.txt 1.13 1.14 diff

    Log Message:
    Update for all currently supported CTRL keys.
  373. deuce
    Wed Mar 21 2018 12:02 pm PDT

    Modified Files:
    exec/fseditor.js 1.86 1.87 diff

    Log Message:
    Add CTRL-\ as a synonym for CTRL-S to avoid collision with Xon.
    Missing synonym since 1.74 (over 8 years ago)
  374. deuce
    Wed Mar 21 2018 11:03 am PDT

    Modified Files:
    docs/fseditor.txt 1.12 1.13 diff

    Log Message:
    Update to match currently used control keys.
  375. deuce
    Wed Mar 21 2018 10:55 am PDT

    Modified Files:
    exec/fseditor.js 1.85 1.86 diff

    Log Message:
    Add CTRL-N to ctrlkey passthru and remove CTRL-O.
  376. deuce
    Wed Mar 21 2018 10:54 am PDT

    Modified Files:
    exec/fseditor.js 1.84 1.85 diff

    Log Message:
    Remove CTRL-N to "select none" (deselect all) in quote mode since DigitalMan
    decided that CTRL-N should be page-down.  This should fix page down in quote
    mode which has been broken since 1.83 three months ago (with a mention in the
    log that the commit broke fseditor.js)
  377. deuce
    Wed Mar 21 2018 10:41 am PDT

    Modified Files:
    src/sbbs3/js_console.cpp 1.115 1.116 diff

    Log Message:
    Document the cterm_version property to unbreak jsdocs.
  378. deuce
    Wed Mar 21 2018 10:04 am PDT

    Modified Files:
    exec/newuser_signup.js 1.45 1.46 diff

    Log Message:
    Apply patch from Psi-Jack in 2014:
    
    This patch fixes the user object process by ordering specific parts in a way
    that fixes the following problems:
    
    Post-delayed realname and handle caused realname and handle not to be set to
    the user object. Moved copy_user_template_to_user to after bbs.login just
    before the bbs.user_sync() solved that.
              
    Choosing not to use the randomly generated password would fail on every
    situation. Reordering user.security.password to be underneath user.number
    solved this problem.
  379. rswindell
    Tue Mar 20 2018 07:28 pm PDT

    Modified Files:
    exec/sbbslist.js 1.38 1.39 diff

    Log Message:
    Cosmetic improvements to "browse" mode, mainly around editing a BBS entry.
    Also clear the screen and display "Returning to <bbs name>" when exiting.
  380. rswindell
    Tue Mar 20 2018 06:36 pm PDT

    Modified Files:
    exec/sbbslist.js 1.37 1.38 diff

    Log Message:
    Allow up to 20 networks per entry, but only export 10 (the old SBL limit)
    in the legacy section of msgbase-exported entries.
  381. rswindell
    Tue Mar 20 2018 05:01 pm PDT

    Modified Files:
    exec/nntpservice.js 1.116 1.117 diff

    Log Message:
    Don't log a "!TIMEOUT waiting for request" message if the client in fact
    only disconnected.
  382. rswindell
    Tue Mar 20 2018 04:41 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.198 1.199 diff

    Log Message:
    Fix a long-standing bug with the log windows: when the log length would
    reach the configured "max size", newly added log lines would not use the
    configured color/font for the msg's log-level (they'd all use the default
    color/font).
  383. rswindell
    Mon Mar 19 2018 08:47 pm PDT

    Modified Files:
    exec/load/binkp.js 1.101 1.102 diff

    Log Message:
    Fix line 1196: ReferenceError: reset_eob is not defined
  384. rswindell
    Mon Mar 19 2018 08:41 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.197 1.198 diff

    Log Message:
    Track log messages that are repeated within the same LogTimer tick
    (interval) and display them on a single line with an " [x#]" suffix
    which identifies the number of times the message was repeated during that
    interval.
    Also created a common log_msg() function and eliminated a lot of copy/pasta
    in the various *_log_msg() functions.
  385. rswindell
    Mon Mar 19 2018 08:39 pm PDT

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.dfm 1.84 1.85 diff

    Log Message:
    Increase the LogTimer interval from 250ms to 500ms, this allows us to
    collate more (repeated/duplicate) log messages into a single line of the
    visible log.
  386. rswindell
    Mon Mar 19 2018 08:36 pm PDT

    Modified Files:
    src/sbbs3/ntsvcs.c 1.47 1.48 diff
    src/sbbs3/ntsvcs.h 1.6 1.7 diff

    Log Message:
    Add a "repeated" log_msg_t member which tracks repeated log messages.
  387. nightfox
    Mon Mar 19 2018 06:55 pm PDT

    Modified Files:
    xtrn/DDMsgReader/DDMsgReader.js 1.115 1.116 diff
    xtrn/DDMsgReader/readme.txt 1.12 1.13 diff

    Log Message:
    Version 1.17 beta 57: Made a fix for voting input - It wasn't accepting Q to quit out of voting (a blank input worked though).
  388. nightfox
    Mon Mar 19 2018 06:54 pm PDT

    Modified Files:
    xtrn/SlyVote/SlyVote.js 1.53 1.54 diff
    xtrn/SlyVote/readme.txt 1.12 1.13 diff

    Log Message:
    Version 0.35 beta: Made a fix for non-lightbar voting input - It wasn't accepting Q to quit out of voting (a blank input worked though).
  389. deuce
    Mon Mar 19 2018 05:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.698 1.699 diff

    Log Message:
    Some four spaces to tab conversion at the beginnings of lines.
  390. deuce
    Mon Mar 19 2018 05:10 pm PDT

    Modified Files:
    exec/load/binkp.js 1.100 1.101 diff

    Log Message:
    Inspired by revision 1.36, only reset senteob when we add a file.  Appears
    to work around Radius hang.  Also, in v2 mode, when we're close()ing, try
    to send two M_EOB to help work around weird/broken remotes.
  391. ree
    Mon Mar 19 2018 04:56 pm PDT

    Modified Files:
    exec/websocketservice.js 1.10 1.11 diff

    Log Message:
    Slightly less sucky frame handling
  392. deuce
    Mon Mar 19 2018 04:39 pm PDT

    Modified Files:
    exec/binkit.js 1.64 1.65 diff

    Log Message:
    flush() the lockfile after writing program name.
  393. deuce
    Mon Mar 19 2018 04:01 pm PDT

    Modified Files:
    exec/load/binkp.js 1.99 1.100 diff

    Log Message:
    On a recv() of zero bytes, check if the socket is still connected.
  394. deuce
    Mon Mar 19 2018 02:53 pm PDT

    Modified Files:
    exec/binkit.js 1.63 1.64 diff

    Log Message:
    Make semaphores[] a global and unconditionally touch them at the end of
    the script.
  395. deuce
    Mon Mar 19 2018 02:45 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.218 1.219 diff

    Log Message:
    If select() returns an error, return it rather than forcing the return value
    to zero.
  396. rswindell
    Mon Mar 19 2018 11:49 am PDT

    Modified Files:
    exec/load/binkp.js 1.98 1.99 diff

    Log Message:
    More log details with regards to timeouts and successful authentication.
  397. deuce
    Mon Mar 19 2018 11:41 am PDT

    Modified Files:
    exec/binkit.js 1.62 1.63 diff

    Log Message:
    Ensure semaphores isn't undefined since we're passing it around everywhere
    now.
  398. deuce
    Mon Mar 19 2018 11:12 am PDT

    Modified Files:
    exec/load/binkp.js 1.97 1.98 diff

    Log Message:
    Only use reset_eob() to reset eob counts.  Don't reset the EOB counts except
    for in file transfer related times.
  399. deuce
    Mon Mar 19 2018 11:05 am PDT

    Modified Files:
    exec/load/binkp.js 1.96 1.97 diff

    Log Message:
    Don't send a second M_EOB until we get an M_EOB from the remote.
  400. deuce
    Mon Mar 19 2018 10:55 am PDT

    Modified Files:
    exec/load/binkp.js 1.95 1.96 diff

    Log Message:
    Add comment (pending testing), and fix bug in last commit.
  401. deuce
    Mon Mar 19 2018 10:49 am PDT

    Modified Files:
    exec/load/binkp.js 1.94 1.95 diff

    Log Message:
    For v1.1 connections, send two EOBs before raising the timeout.  It seems that
    Radius/4.010/21.01.2005,13:56(Final-Release)/Win32 will not send an M_EOB
    until it receives two from the remote.
  402. deuce
    Mon Mar 19 2018 10:47 am PDT

    Modified Files:
    exec/load/binkp.js 1.93 1.94 diff

    Log Message:
    No need to send M_EOB while receiving a file, it'll settle out at the end.
  403. deuce
    Mon Mar 19 2018 09:36 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.658 1.659 diff
    src/sbbs3/mailsrvr.h 1.83 1.84 diff
    src/sbbs3/mxlookup.c 1.28 1.29 diff

    Log Message:
    Attempt to fix an apparently crypt object leak in the mail server by having
    mail_close_socket() also destroy the session, and take pointers to set the
    socket to INVALID_SOCKET, and the session to -1.
  404. deuce
    Sun Mar 18 2018 11:59 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.217 1.218 diff
    src/sbbs3/js_socket.h 1.5 1.6 diff

    Log Message:
    Make peek(), nread, data_waiting, and poll() usable for TLS sockets by recv()ing
    a single byte into a special buffer.  Note that peek() and nread will never
    return/indicate more than a single byte, so scripts which rely on these may
    be inefficient with TLS (websocket stuff appears to use nread heavily).
  405. deuce
    Sun Mar 18 2018 11:56 pm PDT

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.85 1.86 diff

    Log Message:
    More whitespace stuff.
  406. deuce
    Sun Mar 18 2018 11:06 pm PDT

    Modified Files:
    exec/load/binkp.js 1.92 1.93 diff

    Log Message:
    Pass the timeout argument to the data recv() call
  407. deuce
    Sun Mar 18 2018 04:19 pm PDT

    Modified Files:
    exec/imapservice.js 1.64 1.65 diff

    Log Message:
    cfgile -> cfgfile
  408. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/templates/default/ftelnet.inc 1.3 1.4 diff
    web/templates/default/ftelnet_external.inc 1.4 1.5 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  409. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/root/members/externals.ssjs 1.7 1.8 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  410. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/root/ftelnet.ssjs 1.5 1.6 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  411. ree
    Sun Mar 18 2018 01:30 pm PDT

    Modified Files:
    web/templates/nightshade/ftelnet_external.inc 1.4 1.5 diff
    web/templates/nightshade/ftelnet.inc 1.3 1.4 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  412. ree
    Sun Mar 18 2018 01:28 pm PDT

    Modified Files:
    exec/load/ftelnethelper.js 1.6 1.7 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  413. ree
    Sun Mar 18 2018 01:28 pm PDT

    Modified Files:
    exec/websocketservice.js 1.9 1.10 diff

    Log Message:
    Add WSS support.  Handle both Telnet and RLogin via single services.ini entry
  414. rswindell
    Sun Mar 18 2018 12:32 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.189 1.190 diff

    Log Message:
    Fix Win32 link failure (e.g. unresolved getsockopt): when iniFile functions are
    used, that requires a socket lib too. util builds (that don't need the .ini
    file functions), they #define NO_SOCKET_SUPPORT, so exclude the user/####.ini
    support functions in that case too.
  415. deuce
    Sun Mar 18 2018 11:34 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.216 1.217 diff

    Log Message:
    Log which attribute couldn't be set.
  416. deuce
    Sun Mar 18 2018 09:57 am PDT

    Modified Files:
    exec/imapservice.js 1.63 1.64 diff

    Log Message:
    Only unlock/save the config if it's been opened.
    Fixes errors on sessions that do not authenticate before disconnecting.
  417. deuce
    Sat Mar 17 2018 09:42 pm PDT

    Modified Files:
    exec/load/binkp.js 1.91 1.92 diff

    Log Message:
    TLS is apparently causing issues, remove it since nobody else supports it
    anyway.
  418. rswindell
    Sat Mar 17 2018 08:48 pm PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.269 1.270 diff

    Log Message:
    Move all the remaining status_startup bits inside the #ifdef __unix__ block
    since it's not defined otherwise. Not sure if this ways intended to be
    included in Windows builds or not.
  419. rswindell
    Sat Mar 17 2018 05:00 pm PDT

    Modified Files:
    exec/binkit.js 1.61 1.62 diff

    Log Message:
    * When polling a node and receiving files, the semaphore files would not
      be touched - fixed (and debug-log output for each semfile touched).
    * When using the "install" command, the "BINKP" service won't be added to
      the services.ini file if a "BINKIT" or a "BINKP" service already exists.
  420. rswindell
    Sat Mar 17 2018 03:52 pm PDT

    Modified Files:
    exec/binkit.js 1.60 1.61 diff

    Log Message:
    Attempt to fix:
    Mar 17 14:15:56 trmb synchronet: srvc 0052 BINKP !JavaScript  /sbbs/exec/binkit
    .js line 862: TypeError: this.command is undefined
  421. deuce
    Sat Mar 17 2018 12:57 am PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.268 1.269 diff

    Log Message:
    Fix reported service for stat_*() callbacks.
  422. deuce
    Sat Mar 17 2018 12:51 am PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.5 1.6 diff

    Log Message:
    Fix up handling of disconnected sockets.
  423. deuce
    Sat Mar 17 2018 12:38 am PDT

    Modified Files:
    src/sbbs3/showstat.c 1.4 1.5 diff

    Log Message:
    Don't bother showing client_t info when a client disconnects... it's always
    NULL
  424. deuce
    Sat Mar 17 2018 12:35 am PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.4 1.5 diff

    Log Message:
    We must be much more clever with the client_t stuff in the lists...
    Always store the prot and user with the client_t to avoid even worse
    headaches.
    
    This makes the client update a bit trickier, but it seems to be good now.
  425. deuce
    Fri Mar 16 2018 11:45 pm PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.267 1.268 diff

    Log Message:
    Stat the status thread much later.
  426. deuce
    Fri Mar 16 2018 11:13 pm PDT

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.84 1.85 diff

    Log Message:
    Whitespace cleanup.
  427. deuce
    Fri Mar 16 2018 10:44 pm PDT

    Modified Files:
    install/GNUmakefile 1.73 1.74 diff

    Log Message:
    Install the new showstat utility.
  428. deuce
    Fri Mar 16 2018 10:43 pm PDT

    Modified Files:
    src/sbbs3/GNUmakefile 1.229 1.230 diff
    src/sbbs3/objects.mk 1.68 1.69 diff
    src/sbbs3/sbbscon.c 1.266 1.267 diff
    src/sbbs3/targets.mk 1.45 1.46 diff

    Log Message:
    Tie the new out of process thing into the build... not tested on Linux or
    Windows
  429. deuce
    Fri Mar 16 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/showstat.c 1.3 1.4 diff

    Log Message:
    Support authentication and the new SERVICE_STATUS
  430. deuce
    Fri Mar 16 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.3 1.4 diff
    src/sbbs3/sbbs_status.h 1.2 1.3 diff

    Log Message:
    Make the status thread a "proper" thread with a startup_t, callbacks, etc.
  431. deuce
    Fri Mar 16 2018 09:24 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.462 1.463 diff

    Log Message:
    That was likely supposed to be a semi-colon.
  432. deuce
    Fri Mar 16 2018 08:06 pm PDT

    Modified Files:
    src/sbbs3/showstat.c 1.2 1.3 diff

    Log Message:
    Fix buf declaration, add missing newline.
  433. deuce
    Fri Mar 16 2018 08:05 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.c 1.2 1.3 diff

    Log Message:
    client_on can be called with a NULL client, so we have to handle that too.
  434. deuce
    Fri Mar 16 2018 07:45 pm PDT

    Modified Files:
    src/sbbs3/sbbs_status.h 1.1 1.2 diff
    src/sbbs3/sbbs_status.c 1.1 1.2 diff
    src/sbbs3/showstat.c 1.1 1.2 diff

    Log Message:
    Fix handling of client_t char * fields.
  435. rswindell
    Fri Mar 16 2018 07:23 pm PDT

    Modified Files:
    src/sbbs3/atcodes.cpp 1.79 1.80 diff
    src/sbbs3/chat.cpp 1.75 1.76 diff
    src/sbbs3/echocfg.c 3.28 3.29 diff
    src/sbbs3/filedat.c 1.38 1.39 diff
    src/sbbs3/scfglib.h 1.22 1.23 diff
    src/sbbs3/scfglib2.c 1.45 1.46 diff
    src/sbbs3/services.c 1.316 1.317 diff
    src/sbbs3/xtrn_sec.cpp 1.83 1.84 diff

    Log Message:
    Address coverity-scan reported issues.
  436. rswindell
    Fri Mar 16 2018 07:21 pm PDT

    Modified Files:
    src/uifc/uifcx.c 1.33 1.34 diff

    Log Message:
    Address coverity-scan defect (unterminated string).
  437. deuce
    Fri Mar 16 2018 11:32 am PDT

    Modified Files:
    src/sbbs3/sbbscon.c 1.265 1.266 diff

    Log Message:
    Fix WTF indentation and braces.
  438. deuce
    Fri Mar 16 2018 10:50 am PDT

    Modified Files:
    exec/imapservice.js 1.62 1.63 diff

    Log Message:
    Support "binary" storage of Seen flags.  This greatly reduces the size of
    the data/users/000x.imap files when many messages have been seen.
  439. deuce
    Fri Mar 16 2018 09:13 am PDT

    Modified Files:
    exec/imapservice.js 1.61 1.62 diff

    Log Message:
    Typo in last commit?  Say it ain't so!
  440. deuce
    Fri Mar 16 2018 09:12 am PDT

    Modified Files:
    exec/imapservice.js 1.60 1.61 diff

    Log Message:
    Add -d and -r options to control debug and debugRX respectively... no need
    to spam the log unless you're working on the script itself.
  441. deuce
    Fri Mar 16 2018 09:08 am PDT

    Modified Files:
    exec/imapservice.js 1.59 1.60 diff

    Log Message:
    Ensure we can open the message base before including it in a LIST/LSUB
    response.
  442. deuce
    Fri Mar 16 2018 08:31 am PDT

    Modified Files:
    exec/imapservice.js 1.58 1.59 diff

    Log Message:
    Open the config file unbuffered to help with concurrency.
  443. deuce
    Fri Mar 16 2018 08:24 am PDT

    Modified Files:
    exec/imapservice.js 1.57 1.58 diff

    Log Message:
    Pass the index to operate on to apply_seen.
    Fixes issues with STATUS command.
  444. deuce
    Fri Mar 16 2018 08:04 am PDT

    Modified Files:
    exec/imapservice.js 1.56 1.57 diff

    Log Message:
    Pass the base to get_base_code() so that commands such as STATUS that don't
    have a selected base can use it.
  445. deuce
    Fri Mar 16 2018 08:01 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.215 1.216 diff

    Log Message:
    Update Socket.recvline() for new js_socket_recv() TLS semantics.
    Fixes recvline() returning an zero-length "line" on timeouts, which causes
    infinite loops and 100% CPU utilization with IMAPv4-TLS service (and likely
    any other service that uses recvline with a short timeout).
  446. rswindell
    Thu Mar 15 2018 11:06 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.697 1.698 diff

    Log Message:
    Adjusted log output:
    Added "Node # SSH" to a lot of SSH-related log messages.
    Lowered the severity of the SSH "attempt to use channel" msg from ERROR
    to WARNING.
    Removed "last:" from temp-ban message when there is no last-used username.
  447. rswindell
    Thu Mar 15 2018 10:30 pm PDT

    Modified Files:
    src/sbbs3/execfunc.cpp 1.41 1.42 diff

    Log Message:
    Save the last sent-to netmail address and re-use the address automatically
    when creating a new netmail message. Not exactly an "address book", but a
    convenience nonetheless.
  448. rswindell
    Thu Mar 15 2018 10:26 pm PDT

    Modified Files:
    src/sbbs3/userdat.c 1.188 1.189 diff
    src/sbbs3/userdat.h 1.67 1.68 diff

    Log Message:
    Added some functions to read/write to the data/user/*.ini files.
    I'm calling these "user properties", but that might change.
  449. rswindell
    Thu Mar 15 2018 10:24 pm PDT

    Modified Files:
    src/xpdev/ini_file.c 1.159 1.160 diff
    src/xpdev/ini_file.h 1.53 1.54 diff

    Log Message:
    Added iniSetValue() which, like iniGetValue(), does not support string
    literals (e.g. won't detect and escape them automatically). If you set
    a key value with carriage-returns and line-feeds, those will end up in the
    .ini file as-is, so use with caution.
  450. deuce
    Thu Mar 15 2018 07:39 pm PDT

    Modified Files:
    exec/binkit.js 1.59 1.60 diff

    Log Message:
    Better log messages when locks fail and aren't old enough to take over.
  451. deuce
    Thu Mar 15 2018 07:30 pm PDT

    Modified Files:
    exec/load/binkp.js 1.90 1.91 diff

    Log Message:
    Fixes for v1.0 mode...
    1) Don't reset eob counts for sent or got.
    2) Ensure M_GET is never sent in v1.0 mode.
    3) Only send one M_EOB in v1.0 mode, even if we add to the list with M_GET
    
    This should cover all the bases, but FREQ may be non-conformant.
  452. deuce
    Thu Mar 15 2018 07:08 pm PDT

    Modified Files:
    exec/load/binkp.js 1.89 1.90 diff

    Log Message:
    Overhaul EOB handling... just count them, and reset both to zero on non-EOB
    in either direction.
    
    For v1.0, a single EOB in both directions terminates the session and for
    v1.1, two EOBs in both directions terminates.
    
    This should greatly simplify the overly complicated senteob/sentempty/goteob/
    gotempty logic and completely eliminate loops.  Biggest risk with this change
    is issues with v1.0 servers.
  453. deuce
    Thu Mar 15 2018 06:39 pm PDT

    Modified Files:
    exec/load/binkp.js 1.88 1.89 diff

    Log Message:
    Terminate string.
  454. deuce
    Thu Mar 15 2018 06:35 pm PDT

    Modified Files:
    exec/load/binkp.js 1.87 1.88 diff

    Log Message:
    Add some temporary debug logspam.
  455. rswindell
    Thu Mar 15 2018 04:56 pm PDT

    Modified Files:
    src/sbbs3/un_qwk.cpp 1.51 1.52 diff

    Log Message:
    Ignore (and delete) TOREADER.EXT (a QWKE additional metadata file) if it
    exists in a .QWK packet. Also, delete the other control/metadata files
    case-insensitively (just in case).
  456. deuce
    Thu Mar 15 2018 04:32 pm PDT

    Modified Files:
    exec/load/binkp.js 1.86 1.87 diff

    Log Message:
    Push an M_SKIP into the failed_sent_files() from the pending_ack array, not
    from the currently sending file, since the pending ack should always be there,
    but sending often won't be.  Also, log a warning when pending_ack isn't empty
    and we get an M_EOB.
  457. deuce
    Thu Mar 15 2018 03:39 pm PDT

    Modified Files:
    exec/load/binkp.js 1.85 1.86 diff

    Log Message:
    Add a new send_chunks() method which will deal with short send() calls.
    We can't rely on our send buffers being infinite anymore.
  458. deuce
    Thu Mar 15 2018 03:21 pm PDT

    Modified Files:
    exec/load/binkp.js 1.84 1.85 diff

    Log Message:
    Fix handling of timeouts vs. errors... they're not the same, so don't treat
    them that way.  Also, ensure there's a timeout on the second byte of the
    packet header since we toss out the first byte if the second byte times out
    (they should pretty much always be in the same packet, but why take the risk?)
  459. deuce
    Thu Mar 15 2018 03:07 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.214 1.215 diff

    Log Message:
    Add missing else in last commit.
  460. deuce
    Thu Mar 15 2018 03:06 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.213 1.214 diff

    Log Message:
    Have the return value of js_socket_recv() have something vaugely to do with
    the return value if recv() for non-TLS sockets.
  461. deuce
    Thu Mar 15 2018 02:56 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.212 1.213 diff

    Log Message:
    Fix ret/copied confusion in last commit.
  462. deuce
    Thu Mar 15 2018 02:42 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.696 1.697 diff

    Log Message:
    Fix unterminated string usage.
  463. deuce
    Thu Mar 15 2018 02:40 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.211 1.212 diff

    Log Message:
    Fix up js_recv_socket() some more... add explicit MSG_WAITALL support for
    TLS, use MSG_WAITALL for reading integers, add a time() based timeout,
    return as soon as any bytes are read (including zero), and generally
    behave more closely to how recv() itself behaves.
  464. deuce
    Thu Mar 15 2018 12:46 pm PDT

    Modified Files:
    exec/load/lightbar.js 1.34 1.35 diff

    Log Message:
    Fix typo in comment
  465. echicken
    Thu Mar 15 2018 12:22 pm PDT

    Modified Files:
    exec/load/http.js 1.40 1.41 diff

    Log Message:
    Ditch the 'self' stuff and give forEach a thisArg instead.
  466. echicken
    Thu Mar 15 2018 11:28 am PDT

    Modified Files:
    exec/load/http.js 1.39 1.40 diff

    Log Message:
    That 'this' was not the 'this' that your 'self' was looking for there then.
    May resolve the error reported by Bill McGarrity (this.extra_headers is
    undefined).
  467. deuce
    Thu Mar 15 2018 02:27 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.210 1.211 diff

    Log Message:
    The timeout to Socket.recv() is the *SECOND* argument, not a copy of the
    first one.
  468. deuce
    Thu Mar 15 2018 02:17 am PDT

    Modified Files:
    exec/load/binkp.js 1.83 1.84 diff

    Log Message:
    Don't use a separate OPT line for TLS, it seems to mess up
    Radius/4.010/21.01.2005,13:56(Final-Release)/Win32
  469. deuce
    Thu Mar 15 2018 01:59 am PDT

    Modified Files:
    exec/load/binkp.js 1.82 1.83 diff

    Log Message:
    Since we're supporting TLS now, use the sock.recv() timeout parameter instead
    of poll()ing for each byte.
  470. deuce
    Thu Mar 15 2018 01:52 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.209 1.210 diff

    Log Message:
    Re-enable recv timeouts for TLS sessions.  It was #ifdef'd out for some
    reason.
  471. deuce
    Thu Mar 15 2018 01:34 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.208 1.209 diff

    Log Message:
    Fix misuse of SSL_OPTIONS in last commit.
  472. deuce
    Thu Mar 15 2018 01:27 am PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.207 1.208 diff

    Log Message:
    For right now, don't verify server names in certificates.  This will need
    to be changed to something the individual clients can frob in the near
    future.
  473. deuce
    Thu Mar 15 2018 01:16 am PDT

    Modified Files:
    exec/load/binkp.js 1.81 1.82 diff

    Log Message:
    We need to send M_NUL "OPT TLS" before M_NUL "OPT CRYPT".
  474. deuce
    Thu Mar 15 2018 01:13 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.695 1.696 diff

    Log Message:
    We certainly can't re-use i for error return values when it's how many
    bytes have been sent!
  475. deuce
    Thu Mar 15 2018 12:58 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.694 1.695 diff

    Log Message:
    More hacks to work around a known bug in Cryptlib SSH...
    "Sometimes" the write timeout value is used for read timeouts.  Since we
    use a read timeout of zero, and a mutex, this can cause some serious delays
    in SSH processing.  As a workaround, we set the write timeout to zero.
    However, a flush failure has historically been fatal.
    
    So, we now change the write timeout to one second just before a flush, and
    have a flush timeout not be fatal anymore... we set it back to zero after
    the flush.
    
    The fiddling with the write timouts will be removed once the bug is fixed,
    but the flush timout not being fatal may stay forever... add some comments
    to remind us to remove the hack in the future.
  476. rswindell
    Thu Mar 15 2018 12:45 am PDT

    Modified Files:
    3rdp/win32.release/cryptlib/bin/cl32.dll 1.5 1.6 diff
    3rdp/win32.release/cryptlib/bin/cl32.lib 1.5 1.6 diff

    Log Message:
    Updated 3.4.4 with Deuce's latest patches.
  477. deuce
    Thu Mar 15 2018 12:28 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.693 1.694 diff

    Log Message:
    Connections without a "session" channel get treated as a dupe-free failed
    attempt.
  478. rswindell
    Thu Mar 15 2018 12:20 am PDT

    Modified Files:
    src/sbbs3/userdat.c 1.187 1.188 diff

    Log Message:
    When loginFailure() is called with a NULL username, always treat it as a
    "unique" login attempt (e.g. hack attempt).
  479. deuce
    Thu Mar 15 2018 12:05 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.692 1.693 diff

    Log Message:
    badlogin() can't be used for SSH sessions that are terminated early, this
    code merely introduced a 5 second delay in the Node 0 thread.
  480. deuce
    Wed Mar 14 2018 04:41 pm PDT

    Modified Files:
    exec/load/binkp.js 1.80 1.81 diff

    Log Message:
    Copy the comment about VER Internet Rex 2.29 Win32 (binkp/1.1) to where
    the challenge length is set and add a TODO comment there.
  481. deuce
    Wed Mar 14 2018 04:31 pm PDT

    Modified Files:
    exec/load/binkp.js 1.79 1.80 diff

    Log Message:
    Remove magical return type of auth callback.
  482. deuce
    Wed Mar 14 2018 04:30 pm PDT

    Modified Files:
    exec/binkit.js 1.58 1.59 diff

    Log Message:
    If there is at least one password mismatch, and there are zero password
    matches, send an M_ERR to the remote and leave the address list empty.
  483. deuce
    Wed Mar 14 2018 03:48 pm PDT

    Modified Files:
    exec/imapservice.js 1.55 1.56 diff

    Log Message:
    It seems many IMAP clients open multiple connections to the server, and
    expect the Seen flags to be coherent across them... support this by leaving
    the users IMAP status file open, and holding a lock on the first byte.
    
    We now need to flush changes to the status file more often, and we need
    to call file.flush() before unlocking.
  484. rswindell
    Wed Mar 14 2018 03:01 pm PDT

    Modified Files:
    exec/binkit.js 1.57 1.58 diff

    Log Message:
    Fix reserved logic of 'nomd5' option check:
    nomd5 means "plain-text passwords are okay" (AllowPlainPasswords=true)
  485. deuce
    Wed Mar 14 2018 11:23 am PDT

    Modified Files:
    exec/load/binkp.js 1.78 1.79 diff

    Log Message:
    Add TLS support to binkp.
    
    The *first* packet from the answering side *must* be an M_NUL "OPT TLS".
    If this is the case, the originating size responds with an M_NUL "OPT TLS".
    After this, the answering system performs a server TLS handshake, and the
    originating system performs a client TLS handshake.
    
    OPT CRYPT is not used in this case (ie: not crypt over TLS)
  486. rswindell
    Tue Mar 13 2018 11:04 pm PDT

    Modified Files:
    exec/postmsg.js 1.1 1.2 diff

    Log Message:
     Allow sub-code value of 'mail'
  487. rswindell
    Tue Mar 13 2018 10:55 pm PDT

    Modified Files:
    src/smblib/smbstr.c 1.28 1.29 diff

    Log Message:
    smb_netaddr_type() will now recognize an FTN-style address without a 
    "user@" prefix.
  488. rswindell
    Tue Mar 13 2018 10:41 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.125 1.126 diff

    Log Message:
    Use smb_hfield_netaddr() to properly support FidoNet netmail via the 'n'
    (import netmail) command along with the '-n' option to set the recipient
    net address (and network type). Previously, only Internet or QWK netmail
    was supported.
  489. deuce
    Tue Mar 13 2018 10:39 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.691 1.692 diff

    Log Message:
    Actually, anything except failure to send credentials should count as a
    bad login.
  490. deuce
    Tue Mar 13 2018 10:37 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.690 1.691 diff

    Log Message:
    Toss invalid session connections into badlogin().
  491. deuce
    Tue Mar 13 2018 07:47 pm PDT

    Modified Files:
    exec/load/utf8_ascii.js 1.2 1.3 diff

    Log Message:
    Fix error in last commit.
  492. deuce
    Tue Mar 13 2018 07:25 pm PDT

    Modified Files:
    exec/imapservice.js 1.54 1.55 diff

    Log Message:
    Handle an uncommon error a bit better... maybe.
  493. deuce
    Tue Mar 13 2018 07:19 pm PDT

    Modified Files:
    web/templates/nightshade/footer.inc 1.1 1.2 diff
    web/templates/nightshade/main.inc 1.3 1.4 diff

    Log Message:
    Do the https:// thing to <img src="http://... stuff in nightshade too.
  494. deuce
    Tue Mar 13 2018 07:17 pm PDT

    Modified Files:
    web/templates/default/footer.inc 1.11 1.12 diff

    Log Message:
    Use the https:// link for the W3 image for that sweet green lock.
  495. rswindell
    Tue Mar 13 2018 03:13 pm PDT

    Modified Files:
    exec/binkit.js 1.56 1.57 diff

    Log Message:
    More detailed log output in inbound_auth_cb() to help debug why
    inbound Mystic sessions are failing (e.g. with Al@TRMB's BinkIt mailer).
  496. deuce
    Tue Mar 13 2018 10:29 am PDT

    Modified Files:
    exec/letsyncrypt.js 1.31 1.32 diff

    Log Message:
    ACMEv2 endpoint is now live.  See the wiki for how to automate TLS certificates
    with Synchronet.
  497. rswindell
    Mon Mar 12 2018 11:22 pm PDT

    Modified Files:
    src/sbbs3/smbutil.c 1.124 1.125 diff

    Log Message:
    Fix bug introduced in rev 1.119: When reading in the msgbase index
    (.sid file), don't divide the fread() results (it's already in number of
    records read). This could cause msgbase maintenance to not take place
    or corruption of a msg base.
  498. deuce
    Mon Mar 12 2018 11:16 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.206 1.207 diff

    Log Message:
    Don't log orderly shutdowns, even at debug level.  This is mostly because
    my jsexec includes debug output... and this is super-normal.
  499. deuce
    Mon Mar 12 2018 10:55 pm PDT

    Modified Files:
    src/sbbs3/websrvr.c 1.662 1.663 diff

    Log Message:
    Fix handling of cryptPushData() and cryptFlushData() success correctly.
    Also, change READTIMEOUT back to zero since that issue is fixed now.
  500. rswindell
    Mon Mar 12 2018 10:10 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.689 1.690 diff

    Log Message:
    Upper-case the timed event internal code and display it in more of the
    log messages.
  501. deuce
    Mon Mar 12 2018 07:00 pm PDT

    Modified Files:
    src/sbbs3/ssl.c 1.38 1.39 diff

    Log Message:
    Make CRYPT_ERROR_NOSECURE a warning, not an error.  There appear to be
    SSLv3 (!) and even SSLv2(!!) clients still in the wild.  Sysops aren't
    expected to be able to fix other peoples ancient broken stuff.
  502. deuce
    Mon Mar 12 2018 06:58 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.688 1.689 diff

    Log Message:
    No matter the reason we don't get the channel type, still disconnect
    the SSH session.  Also, do an INFO level log entry to indicate what
    happened to your socket.
  503. deuce
    Mon Mar 12 2018 06:32 pm PDT

    Modified Files:
    3rdp/build/GNUmakefile 1.41 1.42 diff
    3rdp/build/cl-short-client-name.patch NONE 1.1 diff

    Added Files:
    	cl-short-client-name.patch 
    Log Message:
    Allow even shorter SSH client names... specifically, SSH-2.0-Go
  504. deuce
    Mon Mar 12 2018 06:23 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.687 1.688 diff

    Log Message:
    Set the TX channel before reading the primary channel type.  Also add
    missing "SSH" when logging channel use errors.
  505. deuce
    Mon Mar 12 2018 05:41 pm PDT

    Modified Files:
    src/sbbs3/js_socket.c 1.205 1.206 diff

    Log Message:
    Limit push size to 8k.  Fixes issue in the IMAP server where ver large
    sends would cause MAC errors.
  506. deuce
    Mon Mar 12 2018 12:22 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.657 1.658 diff

    Log Message:
    Pedanticaly, rsp may not be three characters long (yes, it always will),
    so support that.
  507. deuce
    Mon Mar 12 2018 12:20 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.656 1.657 diff

    Log Message:
    Fix issue where the last line of a multi-line response wasn't searched
    for a match... which caused a memory leak.
    
    Thanks scan-build!
  508. deuce
    Mon Mar 12 2018 12:11 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.655 1.656 diff

    Log Message:
    sendmail_open_socket() will close the passed socket if it's not INVALID_SOCKET
    So, we really should initialize sock to INVALID_SOCKET before calling it.
    
    This should fix the "random descriptors are closed" issue.
  509. deuce
    Mon Mar 12 2018 11:26 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.686 1.687 diff

    Log Message:
    Remove unused variables.
  510. deuce
    Mon Mar 12 2018 11:24 am PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.461 1.462 diff
    src/sbbs3/sbbs.h 1.475 1.476 diff
    src/sbbs3/websrvr.c 1.661 1.662 diff

    Log Message:
    More log fixes.
  511. deuce
    Mon Mar 12 2018 11:11 am PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.654 1.655 diff

    Log Message:
    Fix incorrect log messages.
  512. deuce
    Mon Mar 12 2018 11:07 am PDT

    Modified Files:
    src/sbbs3/main.cpp 1.685 1.686 diff

    Log Message:
    Now that we've fixed the zero timeout on rx issue, we can set the rx timeout
    to zero again.  Unfortunately, there appears to be a related bug where the
    TX timeout is sometimes used for RX... that's OK, we'll just set them both
    to zero.
    
    Also, deal with secondary channels (ie: forwarded ports).  For now, we just
    close these channels any time we get data on them.  In the future, we can
    do scp/sftp pretty easily now... though neither is likely to ever work with
    the sysop account due to the system password requirement.
    
    This change ABSOLUTELY REQUIRES an updated cryptlib.  Windows guys don't
    update until DigitalMan commits cl.lib or whatever it's called.
  513. deuce
    Mon Mar 12 2018 10:52 am PDT

    Modified Files:
    3rdp/build/GNUmakefile 1.40 1.41 diff
    3rdp/build/cl-select-fix.patch NONE 1.1 diff

    Added Files:
    	cl-select-fix.patch 
    Log Message:
    Add fix for ioWait() to guarantee at least one iteration through the select()
    loop even when the timeout is zero.
  514. rswindell
    Sun Mar 11 2018 08:21 pm PDT

    Modified Files:
    src/sbbs3/services.c 1.315 1.316 diff

    Log Message:
    NNTPS/TLS looks funny. Let's go with a "<svc/prot> TLS" instead.
  515. rswindell
    Sun Mar 11 2018 05:21 pm PDT

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.460 1.461 diff
    src/sbbs3/js_socket.c 1.204 1.205 diff
    src/sbbs3/mailsrvr.c 1.653 1.654 diff
    src/sbbs3/services.c 1.314 1.315 diff
    src/sbbs3/websrvr.c 1.660 1.661 diff

    Log Message:
    Added "TLS" (or "/TLS") to the cryptlib-related log messages.
  516. rswindell
    Sun Mar 11 2018 02:30 pm PDT

    Modified Files:
    src/sbbs3/main.cpp 1.684 1.685 diff
    src/sbbs3/sbbs.h 1.474 1.475 diff
    src/sbbs3/js_socket.c 1.203 1.204 diff

    Log Message:
    Created and used call_socket_open_callback() to track the sockets opened
    via JS Socket->xpms_accept().
    Also, use do_js_close() to eliminate some repeated code in js_socket.c.
  517. rswindell
    Sun Mar 11 2018 02:29 pm PDT

    Modified Files:
    src/sbbs3/inkey.cpp 1.54 1.55 diff

    Log Message:
    When using Ctrl-T to display time info (globally), if the time left has
    been reduced due to an upcoming event, say so here.
  518. rswindell
    Sun Mar 11 2018 02:28 pm PDT

    Modified Files:
    src/sbbs3/mailsrvr.c 1.652 1.653 diff

    Log Message:
    A little more debug-level log output around the saving of receiving
    msgs and SPAM database lookup.
  519. rswindell
    Sun Mar 11 2018 02:27 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.54 1.55 diff

    Log Message:
    Fix another memory leak found by scan-build (in an error condition).
  520. rswindell
    Sun Mar 11 2018 02:24 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.35 1.36 diff

    Log Message:
    Overhaul the "System FidoNet Addresses" configuration menu - mainly just
    to add CUT/COPY/PASTE support, but also some beautification and sensible
    updates.
  521. rswindell
    Sun Mar 11 2018 01:59 pm PDT

    Modified Files:
    src/sbbs3/scfg/scfgnet.c 1.34 1.35 diff

    Log Message:
    Remove the deprecated "Default Outbound FidoNet NetMail Address"
    option.
  522. nightfox
    Sat Mar 10 2018 05:57 pm PST

    Modified Files:
    exec/filearea-lb.js 1.4 1.5 diff

    Log Message:
    Fixed a typo in one of the comments
  523. rswindell
    Sat Mar 10 2018 05:36 pm PST

    Modified Files:
    exec/load/binkp.js 1.77 1.78 diff

    Log Message:
    Log the peer mailer version report with a LOG_INFO level message.
  524. nightfox
    Sat Mar 10 2018 05:24 pm PST

    Modified Files:
    exec/filearea-lb.js 1.3 1.4 diff

    Log Message:
    Made use of cnflib.js to load file.cnf to get the viewable file types information.  This requires the latest cnflib.js (and cnfdefs.js) in the load directory.  Also, in the file listing, changed the info command from Enter to I.  This saves a little space on the help bar at the bottom, and I think it's more consistent with using letters for the other commands.  (I also wanted to be able to use the enter key for something else, which I might do as my own custom mod on my BBS, as I make it look & work more like my Baja file lister mod.)
  525. rswindell
    Sat Mar 10 2018 04:43 pm PST

    Added Files:
    exec/dumpcnfs.js NONE 1.1 diff

    Log Message:
    Example use of load/cnflib.js (and cnfdefs.js)
  526. rswindell
    Sat Mar 10 2018 04:42 pm PST

    Modified Files:
    exec/load/cnfdefs.js 1.5 1.6 diff

    Log Message:
    Renamed msg.msg_misc (bit-field) to msg.settings, for consistency.
  527. nightfox
    Sat Mar 10 2018 04:30 pm PST

    Modified Files:
    exec/filearea-lb.js 1.2 1.3 diff

    Log Message:
    The main function now updates bbs.node_action to NODE_LFIL to indicate that the user is listing files.  bbs.node_action is restored to the previous value upon exit of the main function.
    Also I forgot to mention in my last commit that I added an optional command-line argument to specify a file directory internal code so that this script can (optionally) start at the file list for a file directory rather than the file group chooser.  This allows a command shell to run this script for the 'List files in directory' command (with bbs.curdir_code as the first argument).
  528. rswindell
    Sat Mar 10 2018 01:40 pm PST

    Modified Files:
    exec/load/cnfdefs.js 1.4 1.5 diff
    exec/load/cnflib.js 1.12 1.13 diff

    Log Message:
    Added file.cnf support (Nightfox, you could use this for your filearea-lb
    module).
    Also fixed a couple of field names (to match the Sync-JS model) in the
    msgs.cnf representation (e.g. op_ars -> operator_ars).
  529. nightfox
    Sat Mar 10 2018 12:23 pm PST

    Modified Files:
    exec/filearea-lb.js 1.1 1.2 diff

    Log Message:
    Added a V command to the file directory list to allow viewing a file.  This is done by reading ctrl/file.cnf (based on the read_file_config function in src/sbbs3/scfglib2.c), matching the filename extension in the list, and if found, it runs the file view command using bbs.exec().
    
    If possible, it would be useful to add the ability for sysops to move and delete files from this file lister (as in the stock file lister), but I'm not sure how feasable that would be right now.
  530. rswindell
    Sat Mar 10 2018 12:14 pm PST

    Modified Files:
    exec/load/binkp.js 1.76 1.77 diff

    Log Message:
    Allow the default CRAM challenge length (16 bytes) to be overridden
    (e.g. for experimental purposes) via binkit.ini:
    cram_challenge_length = <length in bytes>
  531. rswindell
    Sat Mar 10 2018 12:13 pm PST

    Modified Files:
    exec/binkit.js 1.55 1.56 diff

    Log Message:
    Allow the default CRAM challenge length (16 bytes) to be overridden
    (e.g. for experimental purposes) via binkit.ini:
    cram_challenge_length = <length in bytes>
  532. deuce
    Sat Mar 10 2018 02:16 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.202 1.203 diff

    Log Message:
    Have do_CryptFlush() return a bool.
    Also some whitespace cleanup.
  533. deuce
    Sat Mar 10 2018 02:04 am PST

    Modified Files:
    src/sbbs3/ssl.c 1.37 1.38 diff

    Log Message:
    Lower CRYPT_ERROR_INTERNAL to NOTICE.  Not sure the sysop can do anything
    about these.
  534. deuce
    Sat Mar 10 2018 01:50 am PST

    Modified Files:
    src/conio/x_cio.c 1.48 1.49 diff

    Log Message:
    Don't start the mouse thread until after video init is successful.
    Prevents x11 mouse thread from running when ciolib falls back past it
    (ie: to curses mode)
  535. deuce
    Sat Mar 10 2018 01:20 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.651 1.652 diff

    Log Message:
    Mail server is guilty too.
  536. deuce
    Sat Mar 10 2018 01:17 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.201 1.202 diff

    Log Message:
    Not every crypt error is due to flushing data!
  537. deuce
    Sat Mar 10 2018 12:50 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.650 1.651 diff

    Log Message:
    Re-fix warnings, but be sane about it this time.
  538. deuce
    Sat Mar 10 2018 12:09 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.649 1.650 diff
    src/sbbs3/main.cpp 1.683 1.684 diff

    Log Message:
    Fix indentation.
  539. deuce
    Sat Mar 10 2018 12:00 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.648 1.649 diff
    src/sbbs3/main.cpp 1.682 1.683 diff

    Log Message:
    Open cryptlib.key read-only (also, be cooler)
  540. deuce
    Fri Mar 09 2018 11:32 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.36 1.37 diff

    Log Message:
    Make CRYPT_ERROR_NOTAVAIL LOG_INFO level.
  541. deuce
    Fri Mar 09 2018 11:27 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.647 1.648 diff

    Log Message:
    Oh yeah, that's WAY cooler.
  542. deuce
    Fri Mar 09 2018 11:17 pm PST

    Modified Files:
    src/sbbs3/smbutil.c 1.123 1.124 diff

    Log Message:
    Fix last Clang warning.
  543. deuce
    Fri Mar 09 2018 11:15 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.646 1.647 diff

    Log Message:
    Fix unaligned pointer access warnings from Clang.
  544. deuce
    Fri Mar 09 2018 11:02 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.459 1.460 diff
    src/sbbs3/js_socket.c 1.200 1.201 diff
    src/sbbs3/mailsrvr.c 1.645 1.646 diff
    src/sbbs3/main.cpp 1.681 1.682 diff
    src/sbbs3/services.c 1.313 1.314 diff
    src/sbbs3/smbutil.c 1.122 1.123 diff
    src/sbbs3/websrvr.c 1.659 1.660 diff

    Log Message:
    "If you alloc() in a DLL, thou shalt free() in the same DLL"
    -- Albert Einstein
  545. deuce
    Fri Mar 09 2018 10:42 pm PST

    Modified Files:
    src/xpdev/xpprintf.c 1.60 1.61 diff

    Log Message:
    Call va_end() on errors as well.
  546. deuce
    Fri Mar 09 2018 10:34 pm PST

    Modified Files:
    src/sbbs3/services.c 1.312 1.313 diff

    Log Message:
    Add missing NULL check.
  547. deuce
    Fri Mar 09 2018 10:30 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.680 1.681 diff

    Log Message:
    Add "SSH" to all the cryptlib SSH logging.
  548. deuce
    Fri Mar 09 2018 10:20 pm PST

    Modified Files:
    src/sbbs3/writemsg.cpp 1.121 1.122 diff

    Log Message:
    And another of the same warnings.
  549. rswindell
    Fri Mar 09 2018 10:20 pm PST

    Modified Files:
    src/sbbs3/useredit.cpp 1.49 1.50 diff

    Log Message:
    Address clang warning: comparison of unsigned expression < 0 is always false
    getstr() does not return < 0, ever (it returns 0 on abort).
    Added more abort-checks after calls to getstr().
  550. deuce
    Fri Mar 09 2018 10:19 pm PST

    Modified Files:
    src/sbbs3/writemsg.cpp 1.120 1.121 diff

    Log Message:
    Fix warning.
  551. deuce
    Fri Mar 09 2018 10:17 pm PST

    Modified Files:
    src/sbbs3/un_rep.cpp 1.62 1.63 diff

    Log Message:
    Fix warning.
  552. deuce
    Fri Mar 09 2018 10:16 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.679 1.680 diff

    Log Message:
    Fix warnings.
  553. deuce
    Fri Mar 09 2018 10:12 pm PST

    Modified Files:
    src/sbbs3/js_global.c 1.372 1.373 diff

    Log Message:
    Fix warnings.
  554. deuce
    Fri Mar 09 2018 10:11 pm PST

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.83 1.84 diff

    Log Message:
    Fix warnings.
  555. rswindell
    Fri Mar 09 2018 10:08 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.678 1.679 diff
    src/sbbs3/js_system.c 1.169 1.170 diff

    Log Message:
    Fix more memory leaks (in error conditions) discovered by clang scan-build.
  556. rswindell
    Fri Mar 09 2018 10:05 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.35 1.36 diff

    Log Message:
    Fix get_ssl_cert() initialization of the error string pointer.
  557. rswindell
    Fri Mar 09 2018 09:13 pm PST

    Modified Files:
    src/sbbs3/userdat.c 1.186 1.187 diff

    Log Message:
    Fix some suspicious typos found via clang warnings.
  558. deuce
    Fri Mar 09 2018 08:49 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.644 1.645 diff

    Log Message:
    Remove unused variable.
  559. deuce
    Fri Mar 09 2018 08:49 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.677 1.678 diff

    Log Message:
    Use new cryptlib log stuff for SSH.
  560. deuce
    Fri Mar 09 2018 08:47 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.34 1.35 diff

    Log Message:
    CRYPT_ENVELOPE_RESOURCE is debug-level as well.
  561. rswindell
    Fri Mar 09 2018 08:34 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.458 1.459 diff

    Log Message:
    Elminated the redundnat "XXX Server listening" log messages
    (the multisock stuff already logs this for each interface and port).
  562. rswindell
    Fri Mar 09 2018 08:29 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.676 1.677 diff

    Log Message:
    Elminated the redundnat "XXX Server listening" log messages
    (the multisock stuff already logs this for each interface and port).
  563. rswindell
    Fri Mar 09 2018 08:20 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.33 1.34 diff

    Log Message:
    #include xpprintf.h to resolve msvc warning:
    ssl.c(210): warning C4013: 'asprintf' undefined; assuming extern returning int
  564. rswindell
    Fri Mar 09 2018 08:04 pm PST

    Modified Files:
    src/xpdev/xpprintf.c 1.59 1.60 diff
    src/xpdev/xpprintf.h 1.15 1.16 diff

    Log Message:
    Constify the 'format' argument of asprintf() and vasprintf() to be
    compatible with the glibc/etc. declarations and use.
  565. deuce
    Fri Mar 09 2018 07:53 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.199 1.200 diff
    src/sbbs3/mailsrvr.c 1.643 1.644 diff
    src/sbbs3/services.c 1.311 1.312 diff
    src/sbbs3/ssl.c 1.32 1.33 diff
    src/sbbs3/websrvr.c 1.658 1.659 diff

    Log Message:
    Massive TLS logging overhaul... next up, SSH...
  566. nightfox
    Fri Mar 09 2018 07:20 pm PST

    Modified Files:
    xtrn/DDAreaChoosers/DDFileAreaChooser.js 1.10 1.11 diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js 1.11 1.12 diff
    xtrn/DDAreaChoosers/readme.txt 1.1 1.2 diff
    xtrn/DDAreaChoosers/revision_history.txt 1.1 1.2 diff

    Log Message:
    Version 1.16: Bug fix for off-by-one issue when there is a file group with no directories or a message group with no sub-boards
  567. rswindell
    Fri Mar 09 2018 07:20 pm PST

    Modified Files:
    src/sbbs3/scfg/scfgxfr2.c 1.53 1.54 diff
    src/sbbs3/scfg/scfgxtrn.c 1.57 1.58 diff

    Log Message:
    Resolve memory leaks found by clang scan-build (mostly, or all, in error
    conditions) - e.g. if a malloc or realloc failed, then some other allocated
    memory would be leaked.
  568. rswindell
    Fri Mar 09 2018 07:19 pm PST

    Modified Files:
    src/sbbs3/bat_xfer.cpp 1.37 1.38 diff
    src/sbbs3/getmail.c 1.15 1.16 diff
    src/sbbs3/js_bbs.cpp 1.162 1.163 diff
    src/sbbs3/js_global.c 1.371 1.372 diff
    src/sbbs3/js_msgbase.c 1.218 1.219 diff
    src/sbbs3/js_system.c 1.168 1.169 diff
    src/sbbs3/sbbs.h 1.473 1.474 diff
    src/sbbs3/sbbsecho.c 3.71 3.72 diff

    Log Message:
    Resolve memory leaks found by clang scan-build (mostly, or all, in error
    conditions) - e.g. if a malloc or realloc failed, then some other allocated
    memory would be leaked.
  569. rswindell
    Fri Mar 09 2018 06:19 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.675 1.676 diff

    Log Message:
    Resolve clang scan-build warning about JS write_raw() method potentially
    calling putcom() with a len value of 0 (which triggers an auto-string-length
    grab via strlen() which should be 0 - but.. meh).
  570. deuce
    Fri Mar 09 2018 06:04 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.457 1.458 diff

    Log Message:
    Don't socket recv() errors for TLS sessions.
  571. deuce
    Fri Mar 09 2018 05:57 pm PST

    Modified Files:
    src/sbbs3/websrvr.c 1.657 1.658 diff

    Log Message:
    Resolve (?) clang crash on FreeBSD-CURRENT (!)
  572. deuce
    Fri Mar 09 2018 05:53 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.456 1.457 diff
    src/sbbs3/js_socket.c 1.198 1.199 diff
    src/sbbs3/mailsrvr.c 1.642 1.643 diff
    src/sbbs3/services.c 1.310 1.311 diff
    src/sbbs3/ssl.c 1.31 1.32 diff
    src/sbbs3/ssl.h 1.12 1.13 diff
    src/sbbs3/websrvr.c 1.656 1.657 diff

    Log Message:
    More betterer crypt logging...
    Things return allocated pointers with errors in them now.
    FTP server updated, the rest to follow "soon".
  573. rswindell
    Fri Mar 09 2018 05:10 pm PST

    Modified Files:
    exec/load/binkp.js 1.75 1.76 diff

    Log Message:
    Inlcude more more version details in the log output (so I can stop having
    to ask sysops after they've already pasted log output into a help request).
    Also, include the sbbs version in the BinkP "VER" message excahanged with
    the BinkP peer.
  574. rswindell
    Fri Mar 09 2018 05:10 pm PST

    Modified Files:
    exec/binkit.js 1.54 1.55 diff

    Log Message:
    Inlcude more more version details in the log output (so I can stop having
    to ask sysops after they've already pasted log output into a help request).
    Also, include the sbbs version in the BinkP "VER" message excahanged with
    the BinkP peer.
  575. rswindell
    Fri Mar 09 2018 04:01 pm PST

    Modified Files:
    src/sbbs3/sbbs_ini.c 1.162 1.163 diff

    Log Message:
    Fix some potential NULL dereferences in sbbs_write_ini() (if 'bbs' arg was
    passsed as NULL) found by scan-build.
  576. rswindell
    Fri Mar 09 2018 03:54 pm PST

    Modified Files:
    src/sbbs3/scfg/scfgmsg.c 1.53 1.54 diff

    Log Message:
    Initialize some variables to quiet scan-build.
  577. rswindell
    Fri Mar 09 2018 03:41 pm PST

    Modified Files:
    src/sbbs3/userdat.c 1.185 1.186 diff

    Log Message:
    Don't use the node value if it's garbage (unset by getnodedat).
    Thanks scan-build!
  578. deuce
    Fri Mar 09 2018 02:02 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.455 1.456 diff

    Log Message:
    Use crypt_ll() in the FTP server.
  579. deuce
    Fri Mar 09 2018 01:50 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.30 1.31 diff
    src/sbbs3/ssl.h 1.11 1.12 diff

    Log Message:
    Add crypt_ll(int) function that returns "the" appropriate log level for
    a cryptlib error code.
  580. deuce
    Fri Mar 09 2018 01:42 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.454 1.455 diff
    src/sbbs3/ssl.c 1.29 1.30 diff
    src/sbbs3/ssl.h 1.10 1.11 diff

    Log Message:
    First pass at updating the cryptlib log messages... step one, the FTP server.
  581. deuce
    Fri Mar 09 2018 12:51 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.28 1.29 diff
    src/sbbs3/ssl.h 1.9 1.10 diff

    Log Message:
    These functions take a CRYPT_HANDLE, not just a CRYPT_SESSION.
  582. deuce
    Fri Mar 09 2018 12:28 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.27 1.28 diff
    src/sbbs3/ssl.h 1.8 1.9 diff

    Log Message:
    Export get_crypt_error_string()
  583. deuce
    Fri Mar 09 2018 12:25 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.26 1.27 diff

    Log Message:
    Copy error descriptions from cryptlib.h into get_error_string() so we should
    always get a string in cryptlib errors.  Places that don't get an error
    string should now since it should always be useful.
  584. deuce
    Fri Mar 09 2018 12:04 pm PST

    Modified Files:
    src/sbbs3/js_global.c 1.370 1.371 diff

    Log Message:
    sp = p, not 0.
    (fix last commit)
  585. deuce
    Fri Mar 09 2018 12:03 pm PST

    Modified Files:
    src/sbbs3/js_global.c 1.369 1.370 diff

    Log Message:
    Fix spectacularly bad bug in the cksum_calc() global method.
    Thanks scan-build!
  586. deuce
    Fri Mar 09 2018 11:48 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.197 1.198 diff

    Log Message:
    When close() is called on an external socket (for example, from a service),
    call shutdown(sock, SHUT_RDWR) to do the TCP close, but leave the socket
    descriptor valid for the caller to clean up.
  587. deuce
    Fri Mar 09 2018 10:25 am PST

    Modified Files:
    src/sbbs3/js_socket.c 1.196 1.197 diff

    Log Message:
    Fix build error.
  588. deuce
    Fri Mar 09 2018 12:56 am PST

    Modified Files:
    src/smblib/base64.c 1.28 1.29 diff

    Log Message:
    Use the same comparison order so as not to confuse port scan-build.
  589. deuce
    Thu Mar 08 2018 11:46 pm PST

    Modified Files:
    src/xpdev/link_list.c 1.60 1.61 diff

    Log Message:
    Allow passing LAST_NODE to listRemoveNodes() for people who don't know that
    listRemoveNode() exists.
  590. deuce
    Thu Mar 08 2018 11:03 pm PST

    Modified Files:
    src/xpdev/xpevent.c 1.15 1.16 diff

    Log Message:
    And the final unused assignment... care of... SCAN-BUILD! \o/
  591. deuce
    Thu Mar 08 2018 11:02 pm PST

    Modified Files:
    src/syncterm/term.c 1.336 1.337 diff

    Log Message:
    Remove more unneeded assigmnents.
    Thanks scan-build!
  592. deuce
    Thu Mar 08 2018 10:59 pm PST

    Modified Files:
    src/syncterm/syncterm.c 1.217 1.218 diff

    Log Message:
    Remove more unused assignments.
    Thanks scan-build!
  593. deuce
    Thu Mar 08 2018 10:57 pm PST

    Modified Files:
    src/conio/bitmap_con.c 1.135 1.136 diff

    Log Message:
    Removed unused variable that got zeroed extra hard.
    Thanks scan-build!
  594. deuce
    Thu Mar 08 2018 10:55 pm PST

    Modified Files:
    src/conio/cterm.c 1.239 1.240 diff

    Log Message:
    Fix various useless assignments.
    Thanks scan-build!
  595. rswindell
    Thu Mar 08 2018 10:55 pm PST

    Modified Files:
    CVSROOT/loginfo 1.31 1.32 diff

    Log Message:
    Send commit message to synchro.net instead of vert.synchro.net, work-around
    for vert's IRCd not accepting new clients lately.
  596. deuce
    Thu Mar 08 2018 10:53 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.158 1.159 diff

    Log Message:
    Remove bad second check.
  597. deuce
    Thu Mar 08 2018 10:52 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.157 1.158 diff

    Log Message:
    The idea was to NULL check *before* passing to iniGetSectionList().
    Derp.
    Thanks DigitalMan!
  598. deuce
    Thu Mar 08 2018 10:48 pm PST

    Modified Files:
    src/conio/curs_cio.c 1.39 1.40 diff

    Log Message:
    Fix setvideoflags() in curses.  Did nothing.
    Thanks scan-build!
  599. rswindell
    Thu Mar 08 2018 10:47 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.641 1.642 diff

    Log Message:
    Remove "(ftn_addr)" portion of "To name", if it exists, in SMTP-submitted
    FidoNet netmail messages.
    Fix problem reported by Rastus and Nelgin.
  600. deuce
    Thu Mar 08 2018 10:45 pm PST

    Modified Files:
    src/syncterm/syncterm.c 1.216 1.217 diff

    Log Message:
    We don't need to call getenv("HOME") twice in a row to be extra super-sure
    the value is there.
    Thanks scan-build!
  601. deuce
    Thu Mar 08 2018 10:44 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.156 1.157 diff

    Log Message:
    More paranoia.  Still hard to hit unless you hate yourself.
    Thanks scan-build!
  602. deuce
    Thu Mar 08 2018 10:35 pm PST

    Modified Files:
    src/xpdev/ini_file.c 1.155 1.156 diff

    Log Message:
    Protect against NULL dereference
    Found by scan-build.
  603. deuce
    Thu Mar 08 2018 10:28 pm PST

    Modified Files:
    src/conio/ciolib.c 1.170 1.171 diff

    Log Message:
    Fix impossible to hit bug.
    Found by scan-build.
  604. deuce
    Thu Mar 08 2018 10:20 pm PST

    Modified Files:
    src/conio/cterm.c 1.238 1.239 diff

    Log Message:
    Fix use of uninitialized value when more than 16 bits of colour channel
    information are specified in an xterm rgb: color definition.
    Found by scan-build.
  605. deuce
    Thu Mar 08 2018 10:13 pm PST

    Modified Files:
    src/conio/cterm.c 1.237 1.238 diff

    Log Message:
    Fix potential NULL dereference on illegal strings commands.
    Found by scan-build.
  606. deuce
    Thu Mar 08 2018 10:11 pm PST

    Modified Files:
    src/xpdev/str_list.c 1.48 1.49 diff

    Log Message:
    Fix bug in last commit.
  607. deuce
    Thu Mar 08 2018 10:05 pm PST

    Modified Files:
    src/xpdev/str_list.c 1.47 1.48 diff

    Log Message:
    Fix a pair of unlikely memory leaks on realloc() failure found by scan-build.
  608. deuce
    Thu Mar 08 2018 10:01 pm PST

    Modified Files:
    src/syncterm/fonts.c 1.28 1.29 diff

    Log Message:
    Fix memory leak when quitting (meh)
    Found by scan-build.
  609. deuce
    Thu Mar 08 2018 09:50 pm PST

    Modified Files:
    src/xpdev/xpbeep.c 1.96 1.97 diff

    Log Message:
    Fix memory leak found by scan-build.
  610. deuce
    Thu Mar 08 2018 09:34 pm PST

    Modified Files:
    src/conio/cterm.c 1.236 1.237 diff

    Log Message:
    "fix" "issue" found by scan-build.
    Not impressed yet.  :-)
  611. rswindell
    Thu Mar 08 2018 08:54 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.640 1.641 diff

    Log Message:
    Log the message number when failing to increment delivery attempt counter.
  612. rswindell
    Thu Mar 08 2018 08:53 pm PST

    Modified Files:
    src/smblib/smblib.c 1.175 1.176 diff

    Log Message:
    A couple of the smb last_error strings had "index" and "header"
    conflated. Added " file" as well.
  613. rswindell
    Thu Mar 08 2018 07:55 pm PST

    Modified Files:
    src/sbbs3/jsexec.c 1.197 1.198 diff

    Log Message:
    Output the name of the module that set the exit_code.
  614. rswindell
    Thu Mar 08 2018 07:54 pm PST

    Modified Files:
    src/sbbs3/smbutil.c 1.121 1.122 diff

    Log Message:
    Output a status line when a messages is imported/added to a msgbase.
  615. deuce
    Thu Mar 08 2018 07:18 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.195 1.196 diff

    Log Message:
    Fix that ole last commit.
  616. rswindell
    Thu Mar 08 2018 07:11 pm PST

    Modified Files:
    src/build/Common.gmake 1.106 1.107 diff

    Log Message:
    Define _GNU_SOURCE when targeting linux. This resolves a lot of warnings
    about undeclared functions (vasprintf and pthread_setname_np) when building
    sbbs3.
  617. rswindell
    Thu Mar 08 2018 06:40 pm PST

    Modified Files:
    src/xpdev/link_list.c 1.59 1.60 diff

    Log Message:
    Use the function pthread_mutex_initializer_np() in place of the macro
    (PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP) - when we defined _GNU_SOURCE,
    assigning that macro value to list->mutex triggers a GCC compiler error.
  618. rswindell
    Thu Mar 08 2018 06:23 pm PST

    Modified Files:
    src/xpdev/gen_defs.h 1.75 1.76 diff

    Log Message:
    Use the "long" printf specifier for file offset (off_t) when __LP64__
    is defined - resolves gcc warning in ftpsrvr.c.
  619. deuce
    Thu Mar 08 2018 05:34 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.194 1.195 diff

    Log Message:
    Actually implement the timeout specified in Socket.recv().
    This has apparently never been implemented for non-TLS sockets, but it
    is used by some.
  620. deuce
    Thu Mar 08 2018 05:02 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.453 1.454 diff

    Log Message:
    Fix up load access with MLSx
    Call FULLPATH() on local directories after changing
    Add cdir to MLSD in the bbs: mount
    Return full path in MLST
  621. deuce
    Thu Mar 08 2018 03:52 pm PST

    Modified Files:
    src/sbbs3/jsexec.c 1.196 1.197 diff

    Log Message:
    Interrupt syscalls on break_handler() signals.
  622. rswindell
    Thu Mar 08 2018 03:33 pm PST

    Modified Files:
    src/xpdev/xpprintf.c 1.58 1.59 diff

    Log Message:
    Don't redefine _GNU_SOURCE if it's already defined.
  623. deuce
    Thu Mar 08 2018 03:25 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.452 1.453 diff

    Log Message:
    Map date uploaded to the created fact.
  624. deuce
    Thu Mar 08 2018 02:05 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.451 1.452 diff

    Log Message:
    Add the unique fact to things that can have aliases in ftpalias.cfg
    (dirs and files).  Include the unique fact in aliases as well.  Clients can
    now tell that aliases are the same entry.
    
    For MLST <dir>, always return the full path of the dir instead of the
    specified or relative path.
    
    Likely some other minor fixes as well.
  625. deuce
    Thu Mar 08 2018 11:09 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.639 1.640 diff

    Log Message:
    We don't need any of this cleanup on TLS negotiation failure... in fact,
    free() the mailproc causes a double-free crash.
  626. deuce
    Thu Mar 08 2018 02:34 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.450 1.451 diff

    Log Message:
    Fix format of modify fact.
  627. deuce
    Thu Mar 08 2018 12:37 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.449 1.450 diff

    Log Message:
    Add support for ftpalias.cfg to parsepath().  Directory aliases now work
    like symlinks... note that they aren't shown as symlinks in the directory
    output, so it may be a bit of a surprise when relative paths are relative
    to the target rather than the alias.
  628. rswindell
    Thu Mar 08 2018 12:19 am PST

    Modified Files:
    src/sbbs3/data_ovl.cpp 1.22 1.23 diff

    Log Message:
    Don't call the Progress callbacks when online != ON_REMOTE (e.g. running
    tasks in timed events).
  629. rswindell
    Thu Mar 08 2018 12:17 am PST

    Modified Files:
    src/sbbs3/pack_qwk.cpp 1.77 1.78 diff

    Log Message:
    Check the sbbs_t.online element rather than the cfg.node_num to filter
    excessive log output from packing-QWK events.
  630. rswindell
    Thu Mar 08 2018 12:05 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.448 1.449 diff

    Log Message:
    You need xpprintf.h for the vasprintf() prototype on Windows.
  631. deuce
    Wed Mar 07 2018 03:34 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.447 1.448 diff

    Log Message:
    Return an empty LIST or NLST listing if parsepath() fails.
  632. deuce
    Wed Mar 07 2018 02:39 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.674 1.675 diff

    Log Message:
    Don't count non-client sockets since they don't call the close callback.
  633. rswindell
    Wed Mar 07 2018 02:30 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.673 1.674 diff

    Log Message:
    Fix socket-counter bug introduced in rev 1.615: after accept()ing a connection,
    the startup->socket_open() callback wasn't being called.
    I'm not sure if this is correct with the *nix Spy socket stuff however.
  634. deuce
    Wed Mar 07 2018 02:22 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.446 1.447 diff

    Log Message:
    Skip errored path components and return a root error... LIST really needs
    to handle this somehow (but currently doesn't).
    Also, remove some debug output.
  635. deuce
    Wed Mar 07 2018 02:00 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.445 1.446 diff

    Log Message:
    Fix OPTS MLST support for local files
    Add the '..' parent directory to libs and dirs
    Fly the TVFS flag now that relative dirs are working
  636. deuce
    Wed Mar 07 2018 01:44 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.444 1.445 diff

    Log Message:
    Fix relative paths by rewriting parsepath() from scratch.
    LIST should likely check the return value now...
  637. deuce
    Wed Mar 07 2018 01:06 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.443 1.444 diff

    Log Message:
    Add support for UNIX.ownername to MLSx commands.
    Add support for OPTS MLST command.
    Fix MLST FEAT response.
  638. deuce
    Wed Mar 07 2018 03:04 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.442 1.443 diff

    Log Message:
    Initial MLST/MLSD support.  Relative paths are terrible, but they're terrible
    in the other stuff too.  The local mounts may not be at 100% either, but
    the appear to work.
  639. deuce
    Tue Mar 06 2018 11:50 pm PST

    Modified Files:
    src/sbbs3/websrvr.c 1.655 1.656 diff

    Log Message:
    Fix bug introduced in 1.649 for non-TLS sessions.  That fix was only supposed
    to be for TLS sessions.
  640. rswindell
    Tue Mar 06 2018 11:49 pm PST

    Modified Files:
    exec/load/binkp.js 1.74 1.75 diff

    Log Message:
    Added some helpful log messages when starting/finishing the transfer of
    files (sending or receiving).
  641. rswindell
    Tue Mar 06 2018 11:49 pm PST

    Modified Files:
    exec/binkit.js 1.53 1.54 diff

    Log Message:
    Added some helpful log messages when starting/finishing the transfer of
    files (sending or receiving).
  642. deuce
    Tue Mar 06 2018 11:47 pm PST

    Modified Files:
    exec/load/binkp.js 1.73 1.74 diff

    Log Message:
    Work around issue with Internet Rex 2.29 Win32 (binkp/1.1)
    Does not support CRAM-MD5 challenges longer than 16 bytes (32 hex chars)
  643. deuce
    Tue Mar 06 2018 11:20 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.638 1.639 diff

    Log Message:
    Add missing break after session fails to be set active.
  644. rswindell
    Tue Mar 06 2018 09:09 pm PST

    Modified Files:
    exec/binkit.js 1.52 1.53 diff

    Log Message:
    Send M_ERR instead of M_OK when a link's password doesn't match.
    I'm probably doing something wrong here, since I didn't write this code
    (particularly if there are multiple advertised addresses in the session
    which we have configured links for) - but this should at least give Al
    something to test.
  645. rswindell
    Tue Mar 06 2018 09:04 pm PST

    Modified Files:
    exec/load/binkp.js 1.72 1.73 diff

    Log Message:
    Send M_ERR instead of M_OK when a link's password doesn't match.
    I'm probably doing something wrong here, since I didn't write this code
    (particularly if there are multiple advertised addresses in the session
    which we have configured links for) - but this should at least give Al
    something to test.
  646. rswindell
    Tue Mar 06 2018 07:20 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.637 1.638 diff

    Log Message:
    Treat *all* types of SMTP AUTH failures as "bad logins" for the sake of
    throttling, temp-banning, and filtering.
  647. rswindell
    Tue Mar 06 2018 06:48 pm PST

    Modified Files:
    src/sbbs3/scfgsave.c 1.74 1.75 diff

    Log Message:
    The same custom data_dir as parent of auto-generated transfer path logic needed
    here in write_file_cfg() where the directories are created.
  648. deuce
    Tue Mar 06 2018 06:44 pm PST

    Modified Files:
    src/xpdev/dirwrap.c 1.99 1.100 diff

    Log Message:
    Fix last commit.
  649. deuce
    Tue Mar 06 2018 06:40 pm PST

    Modified Files:
    src/xpdev/dirwrap.c 1.98 1.99 diff

    Log Message:
    isfullpath() should not return true for "\0:" or "$:"... the first char
    must be a letter if the second char is a colon.
  650. rswindell
    Tue Mar 06 2018 05:12 pm PST

    Modified Files:
    src/sbbs3/scfg/scfgxfr2.c 1.52 1.53 diff

    Log Message:
    Use the custom data dir (if one was specified) in the displayed
    auto-generated file transfer path (no transfer path specified), in
    square brackets.
  651. rswindell
    Tue Mar 06 2018 04:57 pm PST

    Modified Files:
    src/sbbs3/load_cfg.c 1.72 1.73 diff

    Log Message:
    Change for Nelgin:
    If the sysop does not specify a file transfer path for a directory, but
    did specify a custom data directory, use the custom data directory as the
    parent of the auto-generated sub-directory to use for the file storage
    path. If this breaks existing configs (are you files are offline?), sorry.
  652. rswindell
    Tue Mar 06 2018 03:08 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.636 1.637 diff

    Log Message:
    Beautify the log output and make the agent/server names more consistent
    (e.g. "SUBMISSIONS Server" becomes "SMTPS Submission Agent", etc.).
    Removed the redundent "<protocol> Server listening" log lines.
  653. rswindell
    Tue Mar 06 2018 03:05 pm PST

    Modified Files:
    src/xpdev/multisock.c 1.33 1.34 diff

    Log Message:
    Update the log messages to include the protocol names/descriptions.
  654. deuce
    Tue Mar 06 2018 01:46 pm PST

    Modified Files:
    src/sbbs3/js_msg_area.c 1.68 1.69 diff

    Log Message:
    Enforce ABNF from RFC5536 for newsgroup property since it's stricter than
    the one in RFC3977.  Technically, you could have those groups, you just
    couldn't have any netnews articles in them.  :-)
  655. deuce
    Tue Mar 06 2018 01:31 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.635 1.636 diff

    Log Message:
    Downgrade message that will be passed to bounce() on failure to LOG_INFO.
    If there's a problem, bounce() will re-log them as LOG_WARNING later.
  656. deuce
    Tue Mar 06 2018 01:22 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.634 1.635 diff

    Log Message:
    Split out the mx fallback/TLS negotiation/etc stuff into a separate function
    and fix all the things.
    
    Hopefully this allows fallback to plaintext after a TLS failure now.
  657. rswindell
    Tue Mar 06 2018 01:21 pm PST

    Modified Files:
    exec/load/fido.js 1.30 1.31 diff

    Log Message:
    Fix flo_outbound() for point nodes (to match the behavior in the heading's
    comment block and the BSO/FLO standard).
    
    Hoping AL@TRMB will test this for us. :-)
  658. rswindell
    Tue Mar 06 2018 12:53 pm PST

    Modified Files:
    exec/binkit.js 1.51 1.52 diff

    Log Message:
    Added some temporary debug log output (with WARNING log level) to help
    resolve AL@TRMB's problem with error:
    /sbbs/fido/outbound.015/00000001.pnt/0004006a.bsy failed.
  659. deuce
    Tue Mar 06 2018 11:47 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.633 1.634 diff

    Log Message:
    Actually log the error string in the place it's most likely to be available...
    setting the session active.
  660. deuce
    Tue Mar 06 2018 11:19 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.632 1.633 diff

    Log Message:
    Allocate an extra byte for the '-'/' ' between the response and the option.
  661. deuce
    Tue Mar 06 2018 10:33 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.631 1.632 diff

    Log Message:
    Actually check the return value of sendmail_open_socket()
  662. rswindell
    Tue Mar 06 2018 01:13 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.630 1.631 diff

    Log Message:
    Update all the POP3 loglines to include the IP address or the authenticated
    user name (once authenticated).
    Lower the log level of the POP3S "Unable to set session active" messages,
    apparently these are normal occurence with drive-by bots and not error.log
    worthy.
    Fixed the !Cryptlib error in sock_recvbyte log output (sock, not socket).
  663. deuce
    Tue Mar 06 2018 01:06 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.629 1.630 diff

    Log Message:
    We need to actually recreate the socket before re-using it after a TLS
    failure... do that.
  664. deuce
    Tue Mar 06 2018 12:32 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.628 1.629 diff

    Log Message:
    Fix retry-after-TLS error, and make log messages more useful.
  665. rswindell
    Tue Mar 06 2018 12:28 am PST

    Modified Files:
    exec/gopherservice.js 1.16 1.17 diff

    Log Message:
    Log a message rather than try to open an invalid sub when requested by the
    client.
  666. deuce
    Tue Mar 06 2018 12:09 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.627 1.628 diff

    Log Message:
    Don't force TLS 1.0 for forwarded STARTTLS delivery.  Cox may suck, but
    not everyone is that inept.
  667. rswindell
    Tue Mar 06 2018 12:05 am PST

    Modified Files:
    src/sbbs3/websrvr.c 1.654 1.655 diff

    Log Message:
    Lower the log level in the "JavaScript FAILED to compile rewrite" log
    entry - if there's an actual compile error, it should already be logged
    via the exception/error-reporter callback. This should eliminate a lot of
    the dokuwiki-related error chatter in my error.log.
  668. rswindell
    Mon Mar 05 2018 11:33 pm PST

    Modified Files:
    src/sbbs3/main.cpp 1.672 1.673 diff

    Log Message:
    A little more detail in the "Packing completed" log line.
  669. rswindell
    Mon Mar 05 2018 11:33 pm PST

    Modified Files:
    src/sbbs3/pack_qwk.cpp 1.76 1.77 diff

    Log Message:
    Clean-up the log output when packing QWK packets from the event thread.
  670. deuce
    Mon Mar 05 2018 11:10 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.193 1.194 diff

    Log Message:
    Some needless paranoia.
  671. deuce
    Mon Mar 05 2018 11:09 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.192 1.193 diff

    Log Message:
    Don't close external sockets... ever.
  672. rswindell
    Mon Mar 05 2018 08:59 pm PST

    Modified Files:
    exec/load/portdefs.js 1.5 1.6 diff

    Log Message:
    Added the "submissions" (SMTPS submission) port definition.
  673. rswindell
    Mon Mar 05 2018 08:18 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.626 1.627 diff

    Log Message:
    Add the protocol ("POP3" or "SMTP") and socket descriptor to all the
    "Enable to" (TLS-related) error messages. This might help a little to
    understand why these errors are happening and allow us to consider
    lowering the log level(s) of commonly-occuring cases from LOG_ERR.
  674. deuce
    Mon Mar 05 2018 07:18 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.625 1.626 diff

    Log Message:
    Add support for other WITH clauses.  We still need to add RFC8314 Section 4.3
    support though.
  675. deuce
    Mon Mar 05 2018 07:04 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.624 1.625 diff

    Log Message:
    Add support for RFC3848 ESMTPA with clause.
    ESMTPS and ESMTPSA coming soon!
  676. deuce
    Mon Mar 05 2018 05:24 pm PST

    Modified Files:
    src/sbbs3/js_msg_area.c 1.67 1.68 diff

    Log Message:
    Replace all illegal newsgroup name characters (per RFC3977) with '_' in
    newsgroup property.
    
    Note that any exascii is also illegal, but I don't feel like doing the
    UTF-8 conversion thing today.  Also, you can manually stick in illegal
    characters if you like... but then it's a feature, not a bug.
  677. rswindell
    Mon Mar 05 2018 04:34 pm PST

    Modified Files:
    exec/binkit.js 1.50 1.51 diff
    exec/avatars.js 1.33 1.34 diff
    exec/sbbslist.js 1.36 1.37 diff

    Log Message:
    Change the cnfdefs.js to use the configuration (.cnf) record field
    names from the Sync-JS object model (jsobjs.html) rather than from the
    C/C++ source code (sbbsdefs.js). I got buy-in from mcmlxxix to make this
    change, but any existing scripts which use the old names will need to be
    changed or its likely that the .cnf record changes aren't going to be
    made as intended (attn: CoA sysops).
  678. rswindell
    Mon Mar 05 2018 04:34 pm PST

    Modified Files:
    exec/load/cnfdefs.js 1.3 1.4 diff

    Log Message:
    Change the cnfdefs.js to use the configuration (.cnf) record field
    names from the Sync-JS object model (jsobjs.html) rather than from the
    C/C++ source code (sbbsdefs.js). I got buy-in from mcmlxxix to make this
    change, but any existing scripts which use the old names will need to be
    changed or its likely that the .cnf record changes aren't going to be
    made as intended (attn: CoA sysops).
  679. rswindell
    Mon Mar 05 2018 04:26 pm PST

    Modified Files:
    exec/load/cnflib.js 1.11 1.12 diff

    Log Message:
    When writing a configuration string record (to a .cnf file), if the 
    struct field is not defined, write a zero-len string instead of 'undefined'.
  680. deuce
    Mon Mar 05 2018 04:08 pm PST

    Modified Files:
    src/sbbs3/services.c 1.309 1.310 diff

    Log Message:
    Don't call get_ssl_cert() until the services thread is up.
    Should fix possible issue with certificate being owned by root when
    _THREAD_SUID_BROKEN is true (ie: Linux).
  681. deuce
    Mon Mar 05 2018 03:29 pm PST

    Modified Files:
    exec/load/acmev2.js 1.23 1.24 diff

    Log Message:
    Don't mislabel Location headers as Link headers.
  682. rswindell
    Mon Mar 05 2018 01:50 pm PST

    Modified Files:
    src/xpdev/multisock.c 1.32 1.33 diff

    Log Message:
    Log the address of each interface socket being closed in addition to the
    port number. This resolves the confusion that arises from multiple
    identical "closing x Server socket on port n" lines in the log output.
  683. rswindell
    Mon Mar 05 2018 01:32 pm PST

    Modified Files:
    src/sbbs3/text_defaults.c 1.40 1.41 diff

    Log Message:
    When displaying posts and email summary (to/from/subj), handle 5-digit
    (for subs and "all mail") and 4-digit message numbers. Subs with >9999 msgs
    are not unheard of and its easy to accumulate that much mail in the mail base
    these days. Just eliminated the ':' from the format line(s) to make room.
  684. rswindell
    Mon Mar 05 2018 01:29 pm PST

    Modified Files:
    ctrl/text.dat 1.80 1.81 diff

    Log Message:
    When displaying posts and email summary (to/from/subj), handle 5-digit
    (for subs and "all mail") and 4-digit message numbers. Subs with >9999 msgs
    are not unheard of and its easy to accumulate that much mail in the mail base
    these days. Just eliminated the ':' from the format line(s) to make room.
  685. rswindell
    Mon Mar 05 2018 11:59 am PST

    Modified Files:
    src/xpdev/semfile.c 1.5 1.6 diff

    Log Message:
    Removed copyright year.
  686. deuce
    Mon Mar 05 2018 11:46 am PST

    Modified Files:
    src/sbbs3/services.c 1.308 1.309 diff

    Log Message:
    Remove waits in the services_thread() main loop.
    
    These waits could cause "bad" traffic (blocked, max client exceeded, etc)
    to prevent/delay accept()ing "good" traffic on other services.
  687. rswindell
    Mon Mar 05 2018 10:54 am PST

    Removed Files:
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-6x8.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-7x12.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-8x12.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-8x13.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-8x14.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-8x8.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 437-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 737-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 737-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 775-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 850-10x19.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 850-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 850-8x13.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 850-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 852-10x19.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 852-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 852-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 855-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 857-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 860-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 861-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 862-10x19.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 863-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 865-10x19.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 865-12x23.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 865-8x13.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 865-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 866-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/1.1 NONE 869-9x16.png diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-Arabic-16x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-Arabic-HalfWidth-8x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-Graphics-16x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-Graphics-HalfWidth-8x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-International-16x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE ATASCII-International-HalfWidth-8x16.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE BStrict-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE BStruct-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE MicroKnight-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE MoSoul-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE PotNoodle-8x11.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-16x14.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-7x14.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-7x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-8x14.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE RIP-8x8.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE StrokeFont.zip 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE Topaz-8x11.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/fonts/NONE TopazPlus-8x11.png 1.1 diff

    Log Message:
    Removing the web/root/ftelnet directory
    Ree (the author) said this old version should be removed from CVS.
  688. rswindell
    Mon Mar 05 2018 10:50 am PST

    Removed Files:
    web/root/ftelnet/ftelnet-resources/NONE ConnectOver.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE ConnectUp.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE SaveFilesDown.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE SaveFilesOver.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE SaveFilesUp.png 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE connectansi.txt 1.1 diff
    web/root/ftelnet/ftelnet-resources/NONE connectrip.txt 1.1 diff

    Log Message:
    Removing the web/root/ftelnet directory
    Ree (the author) said this old version should be removed from CVS.
  689. deuce
    Mon Mar 05 2018 10:47 am PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.441 1.442 diff

    Log Message:
    Don't write errors to the data socket when resp is false either.
  690. rswindell
    Mon Mar 05 2018 10:46 am PST

    Removed Files:
    web/root/ftelnet/NONE ClientVars.js 1.2 diff
    web/root/ftelnet/NONE fTelnet.swf 1.2 diff
    web/root/ftelnet/NONE playerProductInstall.swf 1.1 diff
    web/root/ftelnet/NONE swfobject.js 1.1 diff

    Log Message:
    Removing the web/root/ftelnet directory
    Ree (the author) said this old version should be removed from CVS.
  691. ree
    Mon Mar 05 2018 09:06 am PST

    Modified Files:
    web/templates/nightshade/ftelnet.inc 1.2 1.3 diff
    web/templates/nightshade/ftelnet_external.inc 1.3 1.4 diff

    Log Message:
    Support the latest version of fTelnet
  692. ree
    Mon Mar 05 2018 09:02 am PST

    Modified Files:
    web/templates/default/ftelnet.inc 1.2 1.3 diff
    web/templates/default/ftelnet_external.inc 1.3 1.4 diff

    Log Message:
    Support the latest version of fTelnet
  693. ree
    Mon Mar 05 2018 08:58 am PST

    Modified Files:
    web/root/members/externals.ssjs 1.6 1.7 diff

    Log Message:
    Support the latest version of fTelnet
  694. ree
    Mon Mar 05 2018 08:54 am PST

    Modified Files:
    web/root/ftelnet.ssjs 1.4 1.5 diff
    web/root/index.ssjs 1.34 1.35 diff

    Log Message:
    Support the latest version of fTelnet
  695. ree
    Mon Mar 05 2018 08:46 am PST

    Modified Files:
    exec/websocketservice.js 1.8 1.9 diff

    Log Message:
    Support the latest version of fTelnet
  696. ree
    Mon Mar 05 2018 08:42 am PST

    Modified Files:
    exec/load/ftelnethelper.js 1.5 1.6 diff

    Log Message:
    Support the latest version of fTelnet
  697. deuce
    Sun Mar 04 2018 10:33 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.440 1.441 diff

    Log Message:
    Add a comment regarding the unimplemented STAT command
  698. deuce
    Sun Mar 04 2018 10:03 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.439 1.440 diff

    Log Message:
    CCC doesn't have a registered FEAT code.
  699. deuce
    Sun Mar 04 2018 09:55 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.438 1.439 diff

    Log Message:
    Add AUTH, PBSZ, PROT, and CCC to HELP.  Also, add CCC to FEAT
  700. rswindell
    Sun Mar 04 2018 09:35 pm PST

    Modified Files:
    src/sbbs3/ctrl/MailCfgDlgUnit.cpp 1.33 1.34 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.dfm 1.35 1.36 diff

    Log Message:
    Fix the TLSPOP3checkbox control of the TLSPOP3Edit box.
    Increase the verbosity of the "Log" checkbox label.
  701. deuce
    Sun Mar 04 2018 09:02 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.25 1.26 diff

    Log Message:
    Add comment.
  702. deuce
    Sun Mar 04 2018 09:01 pm PST

    Modified Files:
    src/sbbs3/ssl.c 1.24 1.25 diff

    Log Message:
    Work around MSVC error which assumes ssl_context is used without being
    initialized (it's not).
  703. rswindell
    Sun Mar 04 2018 07:26 pm PST

    Modified Files:
    src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm 1.30 1.31 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.dfm 1.34 1.35 diff

    Log Message:
    Fix-up tab orders.
  704. deuce
    Sun Mar 04 2018 07:14 pm PST

    Modified Files:
    src/sbbs3/gtkuseredit/events.c 1.17 1.18 diff

    Log Message:
    Remove more debug info.
  705. deuce
    Sun Mar 04 2018 07:05 pm PST

    Modified Files:
    src/sbbs3/gtkuseredit/gtkuseredit.c 1.15 1.16 diff

    Log Message:
    Remove debug output.
  706. deuce
    Sun Mar 04 2018 06:53 pm PST

    Modified Files:
    src/sbbs3/ftpsrvr.c 1.437 1.438 diff
    src/sbbs3/main.cpp 1.671 1.672 diff

    Log Message:
    Add FTPS support.
    
    I wasn't expecting to do this, since SFTP is often viewed as "better", but
    SFTP doesn't have a specification, the implementations don't follow the
    specification drafts that are out there, and the whole sharing a port between
    file transfer and terminal server thing is irritating.
    
    This has only been tested with lftp, but it seems to work.
  707. rswindell
    Sun Mar 04 2018 06:12 pm PST

    Modified Files:
    src/sbbs3/ctrl/MailCfgDlgUnit.cpp 1.32 1.33 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.h 1.20 1.21 diff
    src/sbbs3/ctrl/MailCfgDlgUnit.dfm 1.33 1.34 diff

    Log Message:
    Added controls to enable/configure the new SMTP/TLS and POP3/TLS features
    created so graciously by Deuce, or as I like to call him: Mr. Crypto.
  708. rswindell
    Sun Mar 04 2018 04:38 pm PST

    Modified Files:
    src/sbbs3/mail.cpp 1.31 1.32 diff

    Log Message:
    delmail() re-writes the mail.sid file. Since I've seen some recent
    mail.sid corruption approximately around midnight (when delmail()) is
    called as part of the "DAILY:" mail maintenance, I'm suspicious of this
    function and while I haven't found any bugs, I did find (and now fixed)
    lack of error checking in calls to smb_fsetlength() and smb_fwrite().
  709. rswindell
    Sun Mar 04 2018 04:35 pm PST

    Modified Files:
    src/smblib/smblib.c 1.174 1.175 diff

    Log Message:
    smb_addmsghdr() will now confirm the index file length against the
    status.total_msgs value: if they don't match, don't add header & index
    to the message base, it's apparently corrupted and we're only going to
    make things worse as smb_putmsgidx() will fail (after we've stored the hdr)
    with an "invalid index offset" error.
  710. rswindell
    Sun Mar 04 2018 02:59 pm PST

    Modified Files:
    src/smblib/smblib.c 1.173 1.174 diff

    Log Message:
    Fix potential bug:
    If caller doesn't zero-initialize smb_t, then the 'lock' member could've
    been non-zero (garbage) and some functions would then not lock the SMB
    header, used for protecting against corruption from multiple process or thread
    modification of the same base.
  711. rswindell
    Sun Mar 04 2018 02:04 pm PST

    Modified Files:
    ctrl/sbbs.ini 1.74 1.75 diff

    Log Message:
    Use the new TLS-related settings.
  712. rswindell
    Sun Mar 04 2018 01:20 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.h 1.82 1.83 diff
    src/sbbs3/mailsrvr.c 1.623 1.624 diff
    src/sbbs3/sbbs_ini.c 1.161 1.162 diff

    Log Message:
    Use easier-to-understand .ini keys and options in the [mail] section
    for new TLS-related settings:
    SubmissionsPort -> TLSSubmissionPort
    POP3SPort -> TLSPOP3Port
    USE_TLS_SUBMISSIONS_PORT -> TLS_SUBMISSION
    USE_POP3S_PORT -> TLS_POP3
    There was actuall a typo in the "USE_POP3S_PORT" string anyway. <shrug>
  713. rswindell
    Sun Mar 04 2018 01:06 pm PST

    Modified Files:
    src/sbbs3/smbutil.c 1.120 1.121 diff

    Log Message:
    Re-lock the msg base in packmsgs() when re-opening (to set status header),
    so that the smb_unlock() in main() doesn't fail and display the harmless
    error:
    Error -207 (smb_unlock 2 'No such file or directory' removing mail.lock)
    unlocking mail
  714. deuce
    Sun Mar 04 2018 11:38 am PST

    Modified Files:
    3rdp/build/cl-algorithms.patch 1.1 1.2 diff

    Log Message:
    Enable USE_SSH_EXTENDED which will allow support for sftp in the future.
  715. deuce
    Sun Mar 04 2018 12:32 am PST

    Modified Files:
    ctrl/sbbs.ini 1.73 1.74 diff

    Log Message:
    Wiki says SMTP listens on port 587 by default.  Make that happen.
  716. deuce
    Sun Mar 04 2018 12:18 am PST

    Modified Files:
    ctrl/sbbs.ini 1.72 1.73 diff

    Log Message:
    Add new values/options.
  717. deuce
    Sun Mar 04 2018 12:15 am PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.622 1.623 diff
    src/sbbs3/mailsrvr.h 1.81 1.82 diff
    src/sbbs3/sbbs_ini.c 1.160 1.161 diff

    Log Message:
    Add support for mail TLS ports.  This adds two new keys to sbbs.ini Mail
    section:
    
    POP3SPort=995
    SubmissionsPort=465
    
    And two new mail options:
    USE_SUBMISSIONS_PORT
    USE_POP3SS_PORT
    
    These are the last of the two option bits for the mail server.
  718. deuce
    Sat Mar 03 2018 11:22 pm PST

    Modified Files:
    src/xpdev/sockwrap.h 1.53 1.54 diff

    Log Message:
    Add pop3s and submissions ports
  719. deuce
    Sat Mar 03 2018 11:11 pm PST

    Modified Files:
    src/sbbs3/mailsrvr.c 1.621 1.622 diff
    src/sbbs3/mailsrvr.h 1.80 1.81 diff
    src/sbbs3/mime.c 1.9 1.10 diff
    src/sbbs3/mime.h 1.4 1.5 diff

    Log Message:
    Mail server support for Opportunistic TLS.
    
    Support STARTTLS in SMTP and STLS in POP3.  This includes the sendmail
    thread.  Clients can now be configured to use STARTTLS with Synchronet
    mail services, and Synchronet will attempt to deliver securely when
    possible (though it will fall back to plain text delivery when necessary.)
    
    This touches a *lot* of mail server stuff, so some instability is not
    unlikely.
    
    Of course, RFC8314 (Jan, 2018) officially recommends implicit TLS on the TLS
    ports now, so support for that should be next.
  720. rswindell
    Sat Mar 03 2018 09:50 pm PST

    Modified Files:
    exec/load/fidocfg.js 1.30 1.31 diff

    Log Message:
    Simplify the binkit.js boolean option parsing by just using the JS File
    iniGetValue() boolean parsing (by passing a default value of 'false').
  721. rswindell
    Sat Mar 03 2018 09:17 pm PST

    Modified Files:
    exec/load/fidocfg.js 1.29 1.30 diff

    Log Message:
    Fixed typo in previous commit:
    line 359: ReferenceError: typeoof is not defined
  722. rswindell
    Sat Mar 03 2018 08:07 pm PST

    Modified Files:
    src/smblib/smblib.c 1.172 1.173 diff

    Log Message:
    Include hex values of invalid base/header IDs in the error message.
  723. rswindell
    Sat Mar 03 2018 04:40 pm PST

    Modified Files:
    exec/load/fidocfg.js 1.28 1.29 diff

    Log Message:
    Attempt to resolve reported error:
    TypeError: this.node[sec].poll.toUpperCase is not a function
  724. rswindell
    Fri Mar 02 2018 09:10 pm PST

    Modified Files:
    src/sbbs3/chksmb.c 1.60 1.61 diff

    Log Message:
    Print all the details of a corrupted hash record.
  725. deuce
    Fri Mar 02 2018 06:05 pm PST

    Modified Files:
    exec/ircd.js 1.171 1.172 diff

    Log Message:
    Quick initial testing hack... if we accept a connection on ports 994 or 6697,
    it's TLS (SSL).
    
    This will get replaced with actualy config things once we ascertain that
    it works properly and stuff.
  726. deuce
    Fri Mar 02 2018 06:02 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.191 1.192 diff
    src/sbbs3/js_socket.h 1.4 1.5 diff
    src/sbbs3/load_cfg.c 1.71 1.72 diff
    src/sbbs3/scfgdefs.h 1.43 1.44 diff
    src/sbbs3/services.c 1.307 1.308 diff
    src/sbbs3/ssl.c 1.23 1.24 diff
    src/sbbs3/websrvr.c 1.653 1.654 diff

    Log Message:
    Store the certificate context in scfg_t.  This allows static services to be
    TLS servers without all of them needing to separately load the ssl certificate.
    
    It's destroyed in free_scfg(), and the config *must* be prepped both to
    destroy the certificate and to load it.  This is because the "no cert"
    value is -1, not 0, so the prepped flag is all we really have to indicate
    if it's zero because it's a valid certificate or zero because no certificate
    has been loaded.
  727. deuce
    Fri Mar 02 2018 05:26 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.190 1.191 diff

    Log Message:
    Add ssl_server boolean property.
  728. rswindell
    Fri Mar 02 2018 12:03 pm PST

    Modified Files:
    exec/binkit.js 1.49 1.50 diff

    Log Message:
    Allow the Sysop name (ZYZ value) to be over-ridden via binkit.ini.
  729. rswindell
    Fri Mar 02 2018 12:02 pm PST

    Modified Files:
    exec/load/fidocfg.js 1.27 1.28 diff

    Log Message:
    Support a "sysop" value in the global section of binkit.ini, to over-ride
    the ZYZ BinkP value (e.g. with the sysop's real name instead of alias).
  730. rswindell
    Fri Mar 02 2018 11:21 am PST

    Modified Files:
    exec/binkit.js 1.48 1.49 diff

    Log Message:
    Fix bug cause install() to run for every poll. JS, you're far too liberal
    in your accepted syntax.
  731. rswindell
    Thu Mar 01 2018 11:36 pm PST

    Modified Files:
    src/sbbs3/ctrl/ServicesCfgDlgUnit.dfm 1.11 1.12 diff

    Log Message:
    Tool-tip help/hint for Services config: "Insert key to add new values".
  732. deuce
    Thu Mar 01 2018 10:47 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.30 1.31 diff

    Log Message:
    If there is an error in at_least_a_third(), always return false so a new
    certificate is generated.
  733. deuce
    Thu Mar 01 2018 10:45 pm PST

    Modified Files:
    exec/binkit.js 1.47 1.48 diff

    Log Message:
    Process flow files in the order reccomended by FTS-5005.
  734. rswindell
    Thu Mar 01 2018 10:15 pm PST

    Modified Files:
    exec/binkit.js 1.46 1.47 diff

    Log Message:
    Changed/added some log lines for a little easier debugging.
    Added an "install" command: "jsexec binkit install"
  735. rswindell
    Thu Mar 01 2018 08:30 pm PST

    Modified Files:
    src/sbbs3/rechocfg.c 3.28 3.29 diff

    Log Message:
    Bugfix: wasn't saving the OutgoingSemaphore key back to sbbsecho.ini when
    saving changes.
  736. deuce
    Thu Mar 01 2018 06:17 pm PST

    Modified Files:
    exec/load/binkp.js 1.71 1.72 diff

    Log Message:
    For outgoing connections, if there is a password, and the remote accepts it,
    mark the session as secure.  Works around Radius/4.010/21.01.2005,13:56(Final-Release)/Win32
    not sending the reccomended M_OK argument.
  737. rswindell
    Thu Mar 01 2018 04:31 pm PST

    Modified Files:
    src/sbbs3/ctrl/MainFormUnit.cpp 1.196 1.197 diff
    src/sbbs3/ctrl/MainFormUnit.h 1.86 1.87 diff

    Log Message:
    Update the log-level controls when re-reading .ini files. Since the change on
    Nov-28-2017 (don't save .ini files with every change of log-levels), it was
    quite easy for the visible log level controls and the actual log level (in the
    startup structures) to get out-of-sync.
    
    I'm pondering saving the selected log-level when recycling or something else,
    but for now at least the visible controls match the real log level.
  738. deuce
    Thu Mar 01 2018 03:38 pm PST

    Modified Files:
    ctrl/sbbsecho.ini 1.1 1.2 diff

    Log Message:
    Lower-case command names for case-sensitive systems.
  739. deuce
    Thu Mar 01 2018 03:05 pm PST

    Modified Files:
    exec/load/binkp.js 1.70 1.71 diff

    Log Message:
    Set sentempty if we send an eob while senteob is true.
    May fix infinite M_EOB ping-pong on some v1.1 connections.
  740. rswindell
    Thu Mar 01 2018 03:04 pm PST

    Modified Files:
    exec/load/fido_syscfg.js 1.12 1.13 diff

    Log Message:
    Fix usage of backslash() in previous commit.
  741. rswindell
    Thu Mar 01 2018 01:38 pm PST

    Modified Files:
    exec/load/fido_syscfg.js 1.11 1.12 diff

    Log Message:
    Bugfix: when pasing sbbsecho.ini, insure inbound and secure-inbound
    paths end in a path separator since the calling scripts (e.g. binkit.js)
    assume they do. This apparently is not a problem if you're still using
    SBBSecho v2/sbbsecho.cfg however.
  742. deuce
    Thu Mar 01 2018 11:09 am PST

    Modified Files:
    src/sbbs3/ssl.c 1.22 1.23 diff

    Log Message:
    Open the certificate keyset in readonly mode when we're not going to write.
  743. deuce
    Thu Mar 01 2018 11:09 am PST

    Modified Files:
    src/sbbs3/websrvr.c 1.652 1.653 diff

    Log Message:
    Down't lower the recv timeout until after the session is established.
  744. rswindell
    Wed Feb 28 2018 03:40 pm PST

    Added Files:
    xtrn/sbl/DEPRECATED.TXT NONE 1.1 diff

    Log Message:
    Added note about this retired/deprecated project (SBJ). In summary,
    use sbbslist.js instead.
  745. deuce
    Wed Feb 28 2018 02:58 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.189 1.190 diff

    Log Message:
    Fix crash in socket_select() if it's passed in an invalid socket.
  746. deuce
    Wed Feb 28 2018 12:48 pm PST

    Modified Files:
    exec/certtool.js 1.1 1.2 diff

    Log Message:
    Don't delete csr.cert, ask the user to after importing.
    This allows using --import again later if something goes wrong.
  747. deuce
    Wed Feb 28 2018 11:26 am PST

    Added Files:
    exec/certtool.js NONE 1.1 diff

    Log Message:
    Since ACMEv2 endpoint has been delayed, create a small too to generate CSRs
    and import certificate chains.
    
    This supports two commands and one option:
    --csr
    	Supports multiple --domain example.com options (defaults to system.inet_addr)
    	Generates a csr on stdout.
    	jsexec certtool --domain example.com --domain www.example.com --csr > csr.pem
    
    --import <file>
    	Imports a certificate chain.  A certificate chain is two or more
    	PEM certificates in a file... ie:
    	-----BEGIN CERTIFICATE-----
            MIIFNzCCBB+gAwIBAgISA/+MFKRHU5G75Qe5a0tI9p2rMA0GCSqGSIb3DQEBCwUA
            -----END CERTIFICATE-----
            -----BEGIN CERTIFICATE-----
            MIIEkjCCA3qgAwIBAgIQCgFBQgAAAVOFc2oLheynCDANBgkqhkiG9w0BAQsFADA/
            -----END CERTIFICATE-----
            If the entire chain isn't present, it will be imported, but the TLS
    	server won't validate properly.
    
    This should be usable with Let's Encrypt stuff today.
  748. deuce
    Tue Feb 27 2018 11:28 pm PST

    Modified Files:
    src/syncterm/syncterm.c 1.215 1.216 diff

    Log Message:
    Add support for -v command to output the version.
  749. deuce
    Tue Feb 27 2018 11:20 pm PST

    Modified Files:
    src/syncterm/GNUmakefile 1.73 1.74 diff

    Log Message:
    Don't use SMBLIB_LDFLAGS or SMBLIB_LIBS either.
  750. deuce
    Tue Feb 27 2018 10:43 pm PST

    Modified Files:
    src/syncterm/targets.mk 1.6 1.7 diff

    Log Message:
    SyncTERM does not depend on smblib.
  751. deuce
    Tue Feb 27 2018 10:30 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.29 1.30 diff

    Log Message:
    Add new --tos argument to print the Terms of Service URL.
  752. deuce
    Tue Feb 27 2018 10:21 pm PST

    Modified Files:
    CVSROOT/modules 1.49 1.50 diff

    Log Message:
    Add Common.make
  753. deuce
    Tue Feb 27 2018 10:20 pm PST

    Modified Files:
    src/conio/GNUmakefile 1.36 1.37 diff

    Log Message:
    Revert last commit.
  754. deuce
    Tue Feb 27 2018 10:18 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.28 1.29 diff

    Log Message:
    Add new TOSAgreed ini setting, only tell the remote ToS was agreed to if
    it's true.  Log an error with the URL if it's not true and account creation
    fails.
  755. deuce
    Tue Feb 27 2018 10:14 pm PST

    Modified Files:
    exec/load/acmev2.js 1.22 1.23 diff

    Log Message:
    Add debug logging... note all RPC calls, and log Link and Location headers.
    All of this as LOG_DEBUG.
  756. rswindell
    Tue Feb 27 2018 09:55 pm PST

    Modified Files:
    src/conio/GNUmakefile 1.35 1.36 diff

    Log Message:
    Fix lingering compile issue when smblib isn't actually built as a lib
    (e.g. when downloading syncterm-src.tgz)
  757. rswindell
    Tue Feb 27 2018 07:39 pm PST

    Modified Files:
    install/GNUmakefile 1.72 1.73 diff

    Log Message:
    Set MKFLAGS to MAKEFLAGS= (the magic bit), per Deuce.
    A second fix for the recursive make issue in src/sbbs3/targets.mk
    (build of scfg, uedit, and umonitor).
  758. rswindell
    Tue Feb 27 2018 07:37 pm PST

    Modified Files:
    src/sbbs3/targets.mk 1.44 1.45 diff

    Log Message:
    Remove unnecessary $(MAKEFLAGS) - passed via environment already, for
    recursive make of scfg, uedit, and umonitor.
  759. rswindell
    Tue Feb 27 2018 07:16 pm PST

    Modified Files:
    install/GNUmakefile 1.71 1.72 diff

    Log Message:
    Removed scfg, uedit, and umonitor from all/binaries target since a make
    in src/sbbs3 now builds these sub-projects too.
  760. deuce
    Tue Feb 27 2018 11:18 am PST

    Modified Files:
    exec/letsyncrypt.js 1.27 1.28 diff

    Log Message:
    Do an incremental backoff on retries up to just over a minute.
  761. deuce
    Tue Feb 27 2018 10:52 am PST

    Modified Files:
    exec/letsyncrypt.js 1.26 1.27 diff

    Log Message:
    The official integration guide recommends renewing certificates "when they
    have a third of their total lifetime left".  Do that.
  762. deuce
    Tue Feb 27 2018 02:19 am PST

    Modified Files:
    exec/letsyncrypt.js 1.25 1.26 diff

    Log Message:
    Make key type/size variables... to be configurable in the future.
  763. deuce
    Tue Feb 27 2018 02:08 am PST

    Modified Files:
    exec/load/acmev2.js 1.21 1.22 diff

    Log Message:
    Support ECDSA
  764. deuce
    Tue Feb 27 2018 01:38 am PST

    Modified Files:
    src/sbbs3/js_cryptcon.c 1.18 1.19 diff

    Log Message:
    Fix support for ECDSA keys.
  765. deuce
    Tue Feb 27 2018 12:03 am PST

    Modified Files:
    src/sbbs3/prntfile.cpp 1.25 1.26 diff

    Log Message:
    Revert commit during update breakage.
  766. deuce
    Tue Feb 27 2018 12:00 am PST

    Modified Files:
    src/sbbs3/js_cryptcon.c 1.17 1.18 diff
    src/sbbs3/prntfile.cpp 1.24 1.25 diff

    Log Message:
    Add support for ECDSA keys.
    Also, free() temp variables for RSA keys.
  767. deuce
    Mon Feb 26 2018 09:28 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.24 1.25 diff

    Log Message:
    Path host and dir_path to the constructor rather than setting them afterward.
    Fixes bug where the key ID would be taken from the staging server.
  768. deuce
    Mon Feb 26 2018 09:27 pm PST

    Modified Files:
    exec/load/acmev2.js 1.20 1.21 diff

    Log Message:
    Allow passing the directory path as dir_path to the constructor.
  769. deuce
    Mon Feb 26 2018 07:47 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.23 1.24 diff

    Log Message:
    Reorg, cleanup, fix, whatever.
  770. deuce
    Mon Feb 26 2018 07:19 pm PST

    Modified Files:
    exec/lbshell.js 1.119 1.120 diff

    Log Message:
    Truncate the list in Xtrnsec as well as Xtrnsecs.
    Should "fix" bug reported on AlcaBBS (by not allowing access to the last
    few doors).
  771. deuce
    Mon Feb 26 2018 06:55 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.22 1.23 diff

    Log Message:
    "Clean up"
    
    Basically, prepare to split the script into various functions and stuff...
    that var list is silly.
  772. rswindell
    Mon Feb 26 2018 06:29 pm PST

    Modified Files:
    src/sbbs3/prntfile.cpp 1.23 1.24 diff

    Log Message:
    printfile() and printtail() now use fexistcase() to get the proper case
    of the passed filei, fixing a long-standing issue with a couple of menu
    commands (e.g. "MAININFO") in the WWIV (and possibly other) command shells.
    Thank Nelgin. Are we keeping count yet?
  773. deuce
    Mon Feb 26 2018 04:08 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.21 1.22 diff

    Log Message:
    Override User-Agent
  774. deuce
    Mon Feb 26 2018 04:07 pm PST

    Modified Files:
    exec/load/acmev2.js 1.19 1.20 diff

    Log Message:
    Allow overriding user agent
  775. deuce
    Mon Feb 26 2018 04:06 pm PST

    Modified Files:
    exec/load/http.js 1.38 1.39 diff

    Log Message:
    thus -> this
  776. deuce
    Mon Feb 26 2018 04:04 pm PST

    Modified Files:
    exec/load/http.js 1.37 1.38 diff

    Log Message:
    Simple support for overriding User-Agent string.
  777. deuce
    Mon Feb 26 2018 03:57 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.20 1.21 diff

    Log Message:
    Add support for the --revoke option.
  778. deuce
    Mon Feb 26 2018 03:56 pm PST

    Modified Files:
    exec/load/acmev2.js 1.18 1.19 diff

    Log Message:
    Add certificate revocation support.
  779. echicken
    Mon Feb 26 2018 02:34 pm PST

    Modified Files:
    exec/load/tree.js 1.29 1.30 diff
    exec/load/scrollbar.js 1.13 1.14 diff

    Log Message:
    Expose Tree __properties__.offset via getter.
    Use Tree offset when calculating scrollbar position.
  780. deuce
    Mon Feb 26 2018 02:07 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.19 1.20 diff

    Log Message:
    Add support for the --new-key argument which generates a new account key.
  781. deuce
    Mon Feb 26 2018 02:04 pm PST

    Modified Files:
    exec/load/acmev2.js 1.17 1.18 diff

    Log Message:
    Add support for changing keys via the change_key(key) method.
  782. deuce
    Mon Feb 26 2018 01:24 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.18 1.19 diff

    Log Message:
    Add a delay between deletion attempts.
  783. deuce
    Mon Feb 26 2018 12:31 pm PST

    Modified Files:
    exec/load/acmev2.js 1.16 1.17 diff

    Log Message:
    More debug logging
  784. mcmlxxix
    Mon Feb 26 2018 11:49 am PST

    Modified Files:
    exec/load/tree.js 1.28 1.29 diff

    Log Message:
    remove spammy debug logging
  785. deuce
    Mon Feb 26 2018 11:42 am PST

    Modified Files:
    exec/letsyncrypt.js 1.17 1.18 diff

    Log Message:
    Don't do extra work to be less secure... always use a new RSA certificate
    with a CSR.
  786. mcmlxxix
    Mon Feb 26 2018 11:30 am PST

    Modified Files:
    exec/load/tree.js 1.27 1.28 diff

    Log Message:
    scroll menu content down only when selection reaches top of visible frame
  787. deuce
    Mon Feb 26 2018 11:23 am PST

    Modified Files:
    exec/fschat.js 1.4 1.5 diff
    exec/ircbot.js 1.33 1.34 diff
    exec/showsixel.js 1.4 1.5 diff
    exec/websocketservice.js 1.7 1.8 diff

    Log Message:
    Revert changes I made... hopefully.
  788. deuce
    Mon Feb 26 2018 11:18 am PST

    Modified Files:
    exec/letsyncrypt.js 1.16 1.17 diff

    Log Message:
    Store keys using the host, support a new Host global config parameter, do
    an update of the Host has changed. Delete Staging value since it's not
    used anymore.
  789. echicken
    Mon Feb 26 2018 08:54 am PST

    Modified Files:
    xtrn/ansiview/readme.txt 1.5 1.6 diff

    Log Message:
    Document the top_level, pause, speed settings.
  790. deuce
    Sun Feb 25 2018 11:58 pm PST

    Modified Files:
    exec/load/acmev2.js 1.15 1.16 diff

    Log Message:
    Lint lint lint...
  791. deuce
    Sun Feb 25 2018 11:53 pm PST

    Modified Files:
    exec/load/acmev2.js 1.14 1.15 diff

    Log Message:
    Use the correct Content-Type: application/jose+json for POST.
  792. deuce
    Sun Feb 25 2018 11:52 pm PST

    Modified Files:
    exec/load/http.js 1.36 1.37 diff

    Log Message:
    Allow specifying the content-type in a Post().
  793. deuce
    Sun Feb 25 2018 11:50 pm PST

    Modified Files:
    exec/load/http.js 1.35 1.36 diff

    Log Message:
    SyncJSLint found a big in extra_headers handling.  Fix that and everything
    else it found.
  794. deuce
    Sun Feb 25 2018 11:43 pm PST

    Modified Files:
    exec/load/http.js 1.34 1.35 diff

    Log Message:
    prototypify HTTP object.  No need for everyone to have their own private
    copies of all the methods.
  795. deuce
    Sun Feb 25 2018 11:38 pm PST

    Modified Files:
    exec/fschat.js 1.3 1.4 diff
    exec/ircbot.js 1.32 1.33 diff
    exec/showsixel.js 1.3 1.4 diff
    exec/syncjslint.js 1.30 1.31 diff
    exec/websocketservice.js 1.6 1.7 diff

    Log Message:
    Add require(), CryptKeyset, and CryptCert to syncjslint.
  796. deuce
    Sun Feb 25 2018 11:33 pm PST

    Modified Files:
    exec/load/acmev2.js 1.13 1.14 diff

    Log Message:
    Move FULL_JWT_METHODS[] definition to just before it's used.
  797. deuce
    Sun Feb 25 2018 11:24 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.15 1.16 diff

    Log Message:
    Add a --force option to force a renewal.
  798. deuce
    Sun Feb 25 2018 11:21 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.14 1.15 diff

    Log Message:
    Remove asn1_len since it's in the ACMEv2 prototype now and use it from there.
    Give the certchain a different name from the private key so we can safely delete
    it without losing the private key too.
    Don't hold the keyset open while waiting for a CSR to be renewed.
  799. deuce
    Sun Feb 25 2018 11:08 pm PST

    Modified Files:
    exec/load/acmev2.js 1.12 1.13 diff

    Log Message:
    We need the whole cert chain for SSL... and they made up a new format for
    ACME.  Convert it to PKCS#7 before importing.
  800. deuce
    Sun Feb 25 2018 11:05 pm PST

    Modified Files:
    src/sbbs3/js_cryptcert.c 1.7 1.8 diff

    Log Message:
    export is a reserved word.
  801. rswindell
    Sun Feb 25 2018 09:22 pm PST

    Modified Files:
    src/xpdev/link_list.c 1.58 1.59 diff

    Log Message:
    Allow link_list.c to built without str_list support.
  802. echicken
    Sun Feb 25 2018 08:22 pm PST

    Modified Files:
    xtrn/ansiview/ansiview.js 1.23 1.24 diff

    Log Message:
    Let File.iniGetObject figure out the truthiness for us.
    Do it in one line, because some people would use two lines instead.
  803. echicken
    Sun Feb 25 2018 07:52 pm PST

    Modified Files:
    xtrn/ansiview/ansiview.js 1.22 1.23 diff

    Log Message:
    Clobber DM's change.
    Allow pause 'enabbled' by default when pause=true/yes/on/1 in root of
    settings.ini.
    Use 'top_level' setting from root of settings.ini, if present, in place
    of 'Gallery Menu' text.
    Removed my handle from the top of the screen, good buddy. Other people
    have stuck their fingers in this thing.
  804. rswindell
    Sun Feb 25 2018 07:43 pm PST

    Modified Files:
    xtrn/ansiview/ansiview.js 1.21 1.22 diff

    Log Message:
    Allow pause enabbled by default when 'pause=true' in the global/root
    section of settings.ini.
  805. nightfox
    Sun Feb 25 2018 05:09 pm PST

    Added Files:
    text/avatars/DIGDIST.startrek.bin NONE 1.1 diff

    Log Message:
    A collection of Star Trek avatars.  Digital Man created the Starfleet logo (it was in his Miscellaneous Doodles collection).  I created the other avatars.  Hopefully these look okay to others..  I'm still developing my artistic abilities.  Darnit Jim, I'm a software developer, not an artist.
  806. rswindell
    Sun Feb 25 2018 03:10 pm PST

    Modified Files:
    src/sbbs3/umonitor/umonitor.c 1.82 1.83 diff

    Log Message:
    Added sysop chat availability toggle to the System Toggle menu:
    creates/deletes the file: ctrl/sysavail.chat
  807. rswindell
    Sun Feb 25 2018 03:01 pm PST

    Modified Files:
    src/sbbs3/chat.cpp 1.74 1.75 diff
    src/sbbs3/sbbs.h 1.472 1.473 diff
    src/sbbs3/userdat.c 1.184 1.185 diff
    src/sbbs3/userdat.h 1.66 1.67 diff

    Log Message:
    Move sysop_available() and set_sysop_availability() from chat.cpp to userdat.c
    so they can be more easily used by external utils (e.g. umonitor).
  808. rswindell
    Sun Feb 25 2018 01:27 pm PST

    Modified Files:
    exec/lbshell.js 1.118 1.119 diff

    Log Message:
    One extra bbs.online check in the xtrn program loop to help avoid odd JS errors
    when a user is disconnected while in a door,e.g.
    lbshell.js line 505: TypeError: xtrn_area.sec_list[sec] is undefined
  809. deuce
    Sat Feb 24 2018 11:55 pm PST

    Modified Files:
    exec/load/tickit/nodelist_handler.js 1.4 1.5 diff

    Log Message:
    !
  810. deuce
    Sat Feb 24 2018 11:54 pm PST

    Modified Files:
    exec/load/tickit/nodelist_handler.js 1.3 1.4 diff

    Log Message:
    looks like it silently fails if the destination directory isn't present.
  811. deuce
    Sat Feb 24 2018 11:31 pm PST

    Modified Files:
    exec/load/acmev2.js 1.11 1.12 diff

    Log Message:
    SyncJSLint
  812. deuce
    Sat Feb 24 2018 11:31 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.13 1.14 diff

    Log Message:
    SyncJSLint
  813. deuce
    Sat Feb 24 2018 11:11 pm PST

    Modified Files:
    src/syncterm/objects.mk 1.22 1.23 diff

    Log Message:
    Add md5 and base64.o to objects.
  814. echicken
    Sat Feb 24 2018 10:19 pm PST

    Modified Files:
    exec/avatar_chooser.js 1.24 1.25 diff

    Log Message:
    "I don't want an avatar"
    Will add an (empty) avatar for the user and disable it.
    Appears for users who have no avatar configured.
  815. rswindell
    Sat Feb 24 2018 10:00 pm PST

    Modified Files:
    exec/load/sbbslist_html.js 1.7 1.8 diff

    Log Message:
    HTML-entity-encode the sysops' email address(es). This will hide the
    addresses from dumb web-scrapers, but not smart ones.
  816. rswindell
    Sat Feb 24 2018 06:57 pm PST

    Modified Files:
    exec/avatar_chooser.js 1.23 1.24 diff

    Log Message:
    Fix error when there's no avatar data value:
    avatar_chooser.js line 76: TypeError: bin is null
  817. rswindell
    Sat Feb 24 2018 06:54 pm PST

    Modified Files:
    exec/logon.js 1.31 1.32 diff

    Log Message:
    If there's an avatar section, with no data, but it's disabled, don't prompt
    the user to create/select an avatar.
  818. deuce
    Sat Feb 24 2018 02:24 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.12 1.13 diff

    Log Message:
    Abort updates earlier, no need to read the system password if the update
    isn't going to happen.
    
    Also, add more errors, especially when a certificate is installed, but the
    state data can't be updated.  That (very unlikely - some would say impossible)
    situation will result in a new cert being requested every time the script is
    ran (ideally every day), and likely running into throttling issues.
  819. rswindell
    Sat Feb 24 2018 02:08 pm PST

    Modified Files:
    CVSROOT/modules 1.48 1.49 diff

    Log Message:
    Revert previous commit. Apparently adding smblib/Common.make is not the 
    solution since we're not actually building it as a library but rather
    cherry picking specific files and this just introduces more problems since
    don't have all the required files in this massive alias.
  820. deuce
    Sat Feb 24 2018 02:04 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.11 1.12 diff

    Log Message:
    *Actually* don't do authorizations that are already completed.
  821. rswindell
    Sat Feb 24 2018 01:58 pm PST

    Modified Files:
    src/sbbs3/js_cryptcert.c 1.6 1.7 diff

    Log Message:
    Resolve compile warnings from msvc2013.
  822. rswindell
    Sat Feb 24 2018 01:56 pm PST

    Modified Files:
    src/sbbs3/sbbs.vcxproj 1.11 1.12 diff

    Log Message:
    Added new source files: js_cryptcert.c and js_cryptkeyset.c.
  823. rswindell
    Sat Feb 24 2018 01:49 pm PST

    Modified Files:
    CVSROOT/modules 1.47 1.48 diff

    Log Message:
    Added smblib/Common.make to syncterm alias (was causing build error:
    "base64.h: No such file or directory"). Boy, it should be simpler to
    just include smblib/*.
  824. deuce
    Sat Feb 24 2018 01:10 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.10 1.11 diff

    Log Message:
    If LetSyncrypt can't create $WEBROOT/.well-known/acme-challenge/, throw
    an error.
    
    If LetSyncrypt does create it, add a webctrl.ini file that removes access
    restrictions so that the file can be validated.
  825. deuce
    Sat Feb 24 2018 01:02 pm PST

    Modified Files:
    src/sbbs3/websrvr.c 1.651 1.652 diff

    Log Message:
    Allow overriding AccessRequirements to a zero-length string.
    This allows disabling authentication after a higher level specifies an
    AccessRequirements value, eliminating the last reason to keep access.ars
    around.
  826. deuce
    Sat Feb 24 2018 01:55 am PST

    Modified Files:
    exec/letsyncrypt.js 1.9 1.10 diff

    Log Message:
    Don't re-do authorizations that are already completed.
  827. deuce
    Sat Feb 24 2018 01:47 am PST

    Modified Files:
    exec/letsyncrypt.js 1.8 1.9 diff

    Log Message:
    Renew certificates when they have less than 30 days remaining, rather than
    when they're 30 days old.
  828. deuce
    Sat Feb 24 2018 01:36 am PST

    Modified Files:
    exec/letsyncrypt.js 1.7 1.8 diff

    Log Message:
    If the current RSA key in ssl.cert is too small (< 2048 bits), delete
    ssl.cert and generate a new key.
    
    The defl-signed certificates are 1536 bits, so cannot be reused for Let's
    Encrypt.
  829. deuce
    Sat Feb 24 2018 12:52 am PST

    Modified Files:
    exec/letsyncrypt.js 1.6 1.7 diff

    Log Message:
    Remove ToDone comments.
  830. deuce
    Sat Feb 24 2018 12:36 am PST

    Modified Files:
    exec/letsyncrypt.js 1.5 1.6 diff

    Log Message:
    Add support for multiple domains.
    
    Modify ctrl/letsyncrypt.ini and in the Domains section, add the web root
    for each domain in the format:
    example.com=/sbbs/web/root
    
    If the list of domains changes, a new certificate will be generated next
    time letsyncrypt runs.
    
    You DO NOT need to specify the domains if you only need to support the single
    host system.inet_addr.
  831. deuce
    Sat Feb 24 2018 12:20 am PST

    Modified Files:
    exec/load/acmev2.js 1.10 1.11 diff

    Log Message:
    When polling auth, throw an error if it becomes invalid.
  832. deuce
    Fri Feb 23 2018 11:09 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.4 1.5 diff

    Log Message:
    csrenc was just for debugging... remove.
  833. deuce
    Fri Feb 23 2018 11:08 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.3 1.4 diff

    Log Message:
    Initial multiple domain stuff.
  834. deuce
    Fri Feb 23 2018 11:05 pm PST

    Modified Files:
    src/sbbs3/js_cryptcert.c 1.5 1.6 diff

    Log Message:
    Add new add_extension() function which maps to cryptAddCertExtension().
    Also, allow signing unrecognized attributes.
    
    These changes allow getting a Let's Encrypt certificate covering multiple
    domain names.
  835. deuce
    Fri Feb 23 2018 11:04 pm PST

    Modified Files:
    3rdp/build/GNUmakefile 1.39 1.40 diff
    3rdp/build/cl-allow-duplicate-ext.patch NONE 1.1 diff

    Added Files:
    	cl-allow-duplicate-ext.patch 
    Log Message:
    Remove check in cryptAddCertAttribute() which disallows adding DER blobs
    when the extension is natively supported by Cryptlib.  This is to work
    around the apparent impossiblity of adding multiple DNSName entries to the
    Subject Alt Name field.
    
    Sorry DigitalMan, you'll have to compile the Win32 libraries again.  :-)
  836. deuce
    Fri Feb 23 2018 07:08 pm PST

    Modified Files:
    exec/load/acmev2.js 1.9 1.10 diff

    Log Message:
    Add debug logging before throwing errors... not sure if log() can take
    large multi-line strings though.
  837. deuce
    Fri Feb 23 2018 07:01 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.2 1.3 diff

    Log Message:
    Fulfill all http-01 challenges rather than just picking one of them.
  838. deuce
    Fri Feb 23 2018 05:14 pm PST

    Modified Files:
    src/sbbs3/js_cryptcert.c 1.4 1.5 diff

    Log Message:
    Deal with having more properties than a tinyid can hold by exposing the
    attribute_get/set[_string|_time]? interface.  This is way easier than a
    bunch of tiny getter/setter functions, and most of these certificate
    extensions aren't actually going to be used anyway.
    
    Also, surface the attribte cursor constants for more advanced certificate
    parsing/creation.
  839. rswindell
    Fri Feb 23 2018 04:41 pm PST
    src/smblib Makefile 1.7 NONE
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv7654
    
    Removed Files:
    	Makefile 
    Log Message:
    We don't support Borland builds of this project any longer. Haven't for a long
    time.
  840. rswindell
    Fri Feb 23 2018 04:34 pm PST
    src/sbbs3 Makefile 1.87 NONE
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6842
    
    Removed Files:
    	Makefile 
    Log Message:
    We don't support Borland builds of this project any longer. Haven't for a long
    time.
  841. rswindell
    Fri Feb 23 2018 04:08 pm PST

    Modified Files:
    src/sbbs3/targets.mk 1.43 1.44 diff

    Log Message:
    Added recursive make targets for scfg, uedit, and umonitor - built with
    the default/all target.
    So a single "make" command in src/sbbs3 should build these nested targets
    as well.
    Caveat: "make clean" does not clean these sub-make targets.
  842. deuce
    Fri Feb 23 2018 03:55 pm PST

    Modified Files:
    exec/letsyncrypt.js 1.1 1.2 diff

    Log Message:
    Only update the certificate if it's older than 30 days.  It's now safe to
    run this as a daily event.
  843. rswindell
    Fri Feb 23 2018 03:51 pm PST

    Modified Files:
    src/sbbs3/uedit/uedit.c 1.55 1.56 diff

    Log Message:
    Address code error caught by GCC warning:
    uedit.c:1475:5: warning: this 'if' clause does not guard...
         if(uifc.changes)
  844. deuce
    Fri Feb 23 2018 03:46 pm PST

    Modified Files:
    src/sbbs3/js_cryptcert.c 1.3 1.4 diff

    Log Message:
    Fix Date certificate property handling.  It's read/written as a string,
    but it's parsed as a number.  Use the JS Date type for the values.
  845. deuce
    Fri Feb 23 2018 03:08 pm PST

    Added Files:
    exec/letsyncrypt.js NONE 1.1 diff

    Log Message:
    LetSyncrypt.js -- an AJAXv2 client for Let's Encrypt.
    
    This script will request and install a certificate, then recycle your web
    server.  This is barely sufficient, but a lot more needs to be done...
    1) Tracking certificate expiration, and only placing a new order when
       appropriate.
    2) Handling failure better.
    3) Handle changes in the system password (like anyone ever does THAT).
    4) Clean up stale authorizations.
    
    Also, some enhanced features would be nice:
    1) Adding a bunch of SANs, so virtual hosts Just Work
    2) Key aging and updating
    3) More control of certificate contents... I can't find a list of what
       Let's Encrypt supports in CSRs.
  846. deuce
    Fri Feb 23 2018 02:58 pm PST

    Modified Files:
    exec/load/letsyncrypt.js 1.8 1.9 diff

    Log Message:
    More cleanup.
  847. deuce
    Fri Feb 23 2018 02:39 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.188 1.189 diff

    Log Message:
    recv()ing zero bytes always succeeds.
  848. deuce
    Fri Feb 23 2018 02:18 pm PST

    Modified Files:
    exec/load/letsyncrypt.js 1.7 1.8 diff

    Log Message:
    Change "Based on" to "Inspired by"... we've gone off the rails here.
  849. deuce
    Fri Feb 23 2018 02:16 pm PST

    Modified Files:
    exec/load/http.js 1.33 1.34 diff
    exec/load/letsyncrypt.js 1.6 1.7 diff

    Log Message:
    Move stuff from letsyncrypt.js to http.js
    
    Parsing the response code and headers is an HTTP thing, not an ACME thing.
  850. deuce
    Fri Feb 23 2018 02:07 pm PST

    Modified Files:
    exec/load/letsyncrypt.js 1.5 1.6 diff

    Log Message:
    Clean up, check response, etc.  This is Good to Go now.
  851. deuce
    Fri Feb 23 2018 02:06 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.187 1.188 diff

    Log Message:
    Fix derp.
  852. deuce
    Fri Feb 23 2018 02:05 pm PST

    Modified Files:
    src/sbbs3/js_socket.c 1.186 1.187 diff

    Log Message:
    Don't lot a warning when a TLS session completes normally.
  853. rswindell
    Fri Feb 23 2018 10:57 am PST

    Modified Files:
    src/sbbs3/js_bbs.cpp 1.161