Hello All!
http://download.binkd.org
http://sites.google.com/site/vasilyevmax/fido
2020/04/30 21:30:12 git
Makefile,1.1,1.2
[DOS] fix making directory tree for DOS build
2020/04/29 09:03:10 1.1a-104 git
ftnnode.c,2.51,2.52 ftnq.c,2.44,2.45 protocol.c,2.237,2.238
Silence warnings: remove superfluous nullity checks
struct `FTN_NODE` defined in `btypes.h` contains
the member `pwd`, which is a character array.
Several places in the code, this array was checked
for nullity; however, this was always done in a place
where the validity of the referring `FTN_NODE` struct
pointer had already been established, and as `pwd` is
an array (and not a generic pointer) it can never be
NULL. These superflous checks caused warnings when
compiling under `clang`.
This change removes those checks to silence these warnings.
Additionally, at those call sites often the code called
`strcmp` to compare `p->pwd` against some other string,
invariably inside of a conditional. Modify the
conditionals to always explicity compare the value
returned from `strcmp` against e.g. 0.
Signed-off-by: Dan Cross <
cross@fat-dragon.org>
* Originally in RU.BINKD
* Crossposted in BINKD
WBR, Max. piwamoto!»¿ßѼ-¡ÑΓ
--- ߬πτáε »« FleetStreet'π :-(((
* Origin: Personal Reality (2:5057/77)