Hello g00r00!

I just noticed that a ZIP file with a FILE_ID.DIZ in it hadn't used the DIZ for the description, which I though was a bit odd.

Upon strace inspection, it appears that Mystic is looking for file_id.diz but not FILE_ID.DIZ when importing (e.g. when choosing (E)dit --> (I)mport DIZ from a file listing). Perhaps it should check for both?

Best regards
Björn

--- Mystic BBS v1.12 A47 2021/08/05 (Linux/64)
* Origin: Star Collision BBS, Uppsala, Sweden (2:201/137)

Hello again, g00r00!

On 06 Aug 2021, Björn Wiberg said the following...

I just noticed that a ZIP file with a FILE_ID.DIZ in it hadn't used the DIZ for the description, which I though was a bit odd.

Upon strace inspection, it appears that Mystic is looking for
file_id.diz but not FILE_ID.DIZ when importing (e.g. when choosing
(E)dit --> (I)mport DIZ from a file listing). Perhaps it should check for both?

I also noticed that after trying to (I)mport the FILE_ID.DIZ, there's a leftover in the temp directory:

bbs@glimmer:~/mystic$ find temp1/ -exec ls -l '{}' \;
total 0
-rw-rw-rw- 1 bbs bbs 486 aug 5 19:59 temp1/._FILE_ID.DIZ

bbs@glimmer:~/mystic$ file temp1/._FILE_ID.DIZ
temp1/._FILE_ID.DIZ: AppleDouble encoded Macintosh file

...which might be due to the fact that the archive appears to have been created on a Mac? Each file appears to come with a "companion" file, e.g.:

467 Defl:N 208 56% 2021-08-05 19:59 bfa9b96f FILE_ID.DIZ
486 Defl:N 354 27% 2021-08-05 19:59 41668813 __MACOSX/._FILE_ID.DIZ

But I don't get that file if I manually try to unpack the file with unzip, so perhaps the (I)mport DIZ function does something extra which results in that file being extracted, too...

The ZIP file in question can (temporarily) be downloaded from here if you would like to take a peek at it:
https://scbbs.nsupdate.info/files/ARTPACK1.ZIP

Thanks in advance!

Best regards
Björn

--- Mystic BBS v1.12 A47 2021/08/05 (Linux/64)
* Origin: Star Collision BBS, Uppsala, Sweden (2:201/137)

Upon strace inspection, it appears that Mystic is looking for
file_id.diz but not FILE_ID.DIZ when importing (e.g. when choosing
(E)dit --> (I)mport DIZ from a file listing). Perhaps it should check
for both?

Thats not quite how it works. It does not look for FILE_ID.DIZ - what it does changes based on the file and whether or not Mystic can internally handle the archive format (ie ZIP, LZH/LHA, RAR).

It opens the file and does an archive listing to find the .diz or .ans file and then attempts to extract the file name that it finds.

If it cannot find a file by internally looking at its archive data then
Mystic will try to extract "file_id.*" and then search for an .ans file and finally a .diz file. None of it is upper case.

This allows it to handle all types of file variations in case sensitive systems such as "file_id.diz, FILE_ID.DIZ, File_ID.Diz and so on.

... Youth is glorious, but it isn't a career

--- Mystic BBS v1.12 A47 2021/07/31 (Windows/64)
* Origin: Sector 7 * Mystic WHQ (1:129/215)

467 Defl:N 208 56% 2021-08-05 19:59 bfa9b96f FILE_ID.DIZ
486 Defl:N 354 27% 2021-08-05 19:59 41668813 __MACOSX/._FILE_ID.DIZ

Thanks I have done some updates to the import stuff although I am a bit confused how that ._FILE_ID.DIZ could ever be extracted unless Mystic called to extract it directly.

I am putting a new build up now so we're on the same page again with recent changes. Let me know if you still have this happening, Mass email, etc.

Also I fixed the index bug in the file listings so run mutil -run packfilebases after you upgrade to make sure your indexes are properly generated and after that everything should be ok.

... Reward for a job well done: More work

--- Mystic BBS v1.12 A47 2021/07/31 (Windows/64)
* Origin: Sector 7 * Mystic WHQ (1:129/215)

Hello g00r00!

On 07 Aug 2021, g00r00 said the following...

Thats not quite how it works. It does not look for FILE_ID.DIZ - what
it does changes based on the file and whether or not Mystic can internally handle the archive format (ie ZIP, LZH/LHA, RAR).

OK!

The logic of this explains the stat calls and ENOENTs I saw with strace...

This allows it to handle all types of file variations in case sensitive systems
such as "file_id.diz, FILE_ID.DIZ, File_ID.Diz and so on.

Sounds nice!

However for this ZIP file it didn't appear to work, for some reason...
Please feel free to check if it works better for you?

https://scbbs.nsupdate.info/files/ARTPACK1.ZIP

Thanks in advance! :)

Best regards
Björn

--- Mystic BBS v1.12 A47 2021/08/05 (Linux/64)
* Origin: Star Collision BBS, Uppsala, Sweden (2:201/137)

Hello g00r00!

Thank you for your reply!

Thanks I have done some updates to the import stuff although I am a bit confused how that ._FILE_ID.DIZ could ever be extracted unless Mystic called to
extract it directly.

Yes, really strange...

I am putting a new build up now so we're on the same page again with recent changes. Let me know if you still have this happening, Mass email, etc.

The mass e-mail works fine now!

However the (I)mport DIZ still doesn't work with ARTPACK1.ZIP, it appears not to find the DIZ and so does not update the description.

Also I fixed the index bug in the file listings so run mutil -run packfilebases
after you upgrade to make sure your indexes are properly generated and after that everything should be ok.

Thanks a lot! Yes, the duplicate file entries problem seems to be gone now! Well done! :)

Best regards
Björn

--- Mystic BBS v1.12 A47 2021/08/07 (Linux/64)
* Origin: Star Collision BBS, Uppsala, Sweden (2:201/137)

However for this ZIP file it didn't appear to work, for some reason... Please feel free to check if it works better for you?

I did test it before I released but only on the Windows side, my bad.

The next update that I will put up today will have the fix for that.

... 24 hours in a day and 24 beers in a case. Hmmmm...
--- Mystic BBS v1.12 A47 2021/08/07 (Windows/64)
* Origin: Sector 7 * Mystic WHQ (1:129/215)

Hello g00r00!

On 08 Aug 2021, g00r00 said the following...

I did test it before I released but only on the Windows side, my bad.
The next update that I will put up today will have the fix for that.

Thanks a lot! It is much appreciated! :)

Best regards
Björn

--- Mystic BBS v1.12 A47 2021/08/07 (Linux/64)
* Origin: Star Collision BBS, Uppsala, Sweden (2:201/137)

Hello g00r00!

On 08 Aug 2021, Björn Wiberg said the following...

I did test it before I released but only on the Windows side, my bad. The next update that I will put up today will have the fix for that.

Thanks a lot! It is much appreciated! :)

I can confirm that this is now working fine here, too!
It imported the FILE_ID.DIZ without a hitch.

Thanks a lot!

Best regards
Björn

--- Mystic BBS v1.12 A47 2021/08/08 (Linux/64)
* Origin: Star Collision BBS, Uppsala, Sweden (2:201/137)