Re: SlyVote
By: Digital Man to Nightfox on Tue Aug 08 2017 11:56 am

I'll play with tuning that in a couple of days. The first thing I notice is the reference to msgbase.total_msgs in your loop. It would be an improvement in speed to cache this property in a local variable as every time you read that property, the underlying code in the MsgBase class goes and reads the status of the message base:

var total_msgs = msgbase.total_msgs;
for (var i = 0; !subBoardHasPolls && (i < total_msgs); ++i)

I tried this enhancement on Vert and it made only a slight improvement in performance, so that's not the main issue. It could be a problem in the get_msg_index method. I'll look into it.

Hi DM - I know this is an old message I'm replying to - we were discussing speed-related issues when I was initially working on SlyVote. I was curious if you had ever found anything that might help the speed issues we had noticed?
Not too long ago, I had made an update to dd_lightbar_menu.js so that rather than having to add/copy all the menu items into the menu object, you can replace a couple functions (for the menu to get the number of items and to retreive an item for display & it return code), so a menu can basically access another source of items. I originally did that for my message reader, but I then updated SlyVote to do that, as I think that might provide a bit of a speed improvement.

Nightfox

---
■ Synchronet ■ Digital Distortion: digitaldistortionbbs.com

Re: SlyVote
By: Nightfox to Digital Man on Tue May 19 2020 02:07 pm

Re: SlyVote
By: Digital Man to Nightfox on Tue Aug 08 2017 11:56 am

I'll play with tuning that in a couple of days. The first thing I notice is the reference to msgbase.total_msgs in your loop. It would be an improvement in speed to cache this property in a local variable as every time you read that property, the underlying code in the MsgBase class goes and reads the status of the message base:

var total_msgs = msgbase.total_msgs;
for (var i = 0; !subBoardHasPolls && (i < total_msgs); ++i)

I tried this enhancement on Vert and it made only a slight improvement in performance, so that's not the main issue. It could be a problem in the get_msg_index method. I'll look into it.

Hi DM - I know this is an old message I'm replying to - we were discussing speed-related issues when I was initially working on SlyVote. I was curious if you had ever found anything that might help the speed issues we had noticed?

I added the MsgBase.get_index() method about a year ago for use in msglist.js which enhanced the performance considerable. Have you tried using that?

digital man

This Is Spinal Tap quote #5:
Nigel Tufnel: Authorities said... best leave it... unsolved.
Norco, CA WX: 68.5°F, 44.0% humidity, 9 mph NNE wind, 0.00 inches rain/24hrs

Re: SlyVote
By: Digital Man to Nightfox on Tue May 19 2020 03:00 pm

I added the MsgBase.get_index() method about a year ago for use in msglist.js which enhanced the performance considerable. Have you tried using that?

Yes, SlyVote uses get_index if it's available.

Nightfox

---
■ Synchronet ■ Digital Distortion: digitaldistortionbbs.com

Re: SlyVote
By: Nightfox to Digital Man on Tue May 19 2020 05:00 pm

Re: SlyVote
By: Digital Man to Nightfox on Tue May 19 2020 03:00 pm

I added the MsgBase.get_index() method about a year ago for use in msglist.js which enhanced the performance considerable. Have you tried using that?

Yes, SlyVote uses get_index if it's available.

I don't recall if I tried SlyVote since you made that change. Since my Synchronet files are on a samba share (over a gigabit LAN), that tends to highlight I/O-bound processes very well.

digital man

This Is Spinal Tap quote #4:
David St. Hubbins: He died in a bizarre gardening accident...
Norco, CA WX: 64.2°F, 53.0% humidity, 7 mph E wind, 0.00 inches rain/24hrs