https://gitlab.synchro.net/main/sbbs/-/commit/0f7716c038d4a6f37947f888
Modified Files:
src/sbbs3/zmodem.c
Log Message:
Strip/ignore high (parity) bit in ZPAD, ZDLE, and hex headers
The previous committed fix/issue raised some additional concerns about this "parity" bit:
Something I didn't notice before from the ZMODEM spec:
"The hex header receiving routine ignores parity."
And looking at lrzsz's zm.c, I see it goes even further and ignores the "parity" bit on the ZPAD and ZDLE bytes proceeding the frame encoding byte as well as in the frame encoding byte itself (so ZHEX, 'B' 0x22 and 0xC2 should be treated as equivalent).
I find it strange that some ZMODEM implementations (e.g. chuck's zshhdr()) would send the terminating LF with the even-parity bit set, but not set the even-parity flag for any of the frame content bytes. And then, expect that the parity flag may be set on incoming hex headers. I suppose it makes sense for 7-E-1 connections, but then the transmitted terminating LF would have had its parity flag set automatically (would not need to be set manually in the code). Add to the mysteries of ZMODEM that will likely never be solved.