• Update letsyncrypt.js

    From Michael J. Ryan to GitLab note in main/sbbs on Monday, January 25, 2021 02:43:23
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/84#note_1328

    @rswindell This seems to address the issue(s) I was having regarding trying to run letsencrypt and it adding in an invalid domain for the system/host.
  • From Deuce to GitLab note in main/sbbs on Monday, January 25, 2021 09:26:44
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/84#note_1329

    Possibly this should just switch both to use system.host_name instead of inet_addr. The idea that the system does not know it's own domain name seems highly flawed.
  • From Michael J. Ryan to GitLab note in main/sbbs on Monday, January 25, 2021 09:43:31
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/84#note_1331

    @Deuce I tried that... and it still used the same host as inet_addr not the Hostname specified in sbbs.ini. (at least when run via jsexec, not sure if a timed event would have the same issue).

    I have roughneckbbs.com on a separate server from synchronet... but synchronet is handling mx for the domain. The changes in this pr allowed it to be configured and work as such.
  • From Deuce to GitLab note in main/sbbs on Monday, January 25, 2021 10:57:57
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/84#note_1333

    Right, the point is though that separate configuration shouldn't be required. The system should be able to use the web Hostname and be correct (see #207 for details). Currently that's not supported, but it should be simple to write a JS script or add more JS objects to get that information. You shouldn't need to configure the same thing (ie: web server public hostname) in multiple places (sbbs.ini and letsyncrypt.ini).

    As more and more things generate URLs for the web server, this issue will just get worse.
  • From Deuce to GitLab note in main/sbbs on Monday, January 25, 2021 14:16:38